7469 Commits

Author SHA1 Message Date
Stephan Bergmann
8a8ea11e5e bool improvements
Change-Id: I4e428e5d7093dbc8a1e7fd47ec49998ce143e5ac
2014-01-29 11:08:32 +01:00
Stephan Bergmann
ead1525417 bool improvements
Change-Id: If35c939adede6a912dee14714a7ceeab84ac977e
2014-01-28 20:24:39 +01:00
Jan Holesovsky
cb64711136 Don't use OSL_LOG_PREFIX when throwing exceptions in non-debug builds.
Using OSL_LOG_PREFIX in the exceptions is not a good idea; it blows the size
of the string literals tremendously - full build path for every line that uses
that, including the line.

Let's not remove it for good, but hide it for non-debug builds
(OSL_DEBUG_LEVEL == 0) so that anybody who would like to use this during
debugging could still do (but I doubt it has any value for anybody).

Change-Id: Icc8db95ae0862671a206e681f92c60cdf51ffc32
2014-01-27 23:21:43 +01:00
Caolán McNamara
d1c2f9849e coverity#707688 Uninitialized scalar field
Change-Id: If45153679e199eb749b8c877fc8593304ac35100
2014-01-27 17:03:06 +00:00
Caolán McNamara
6a3c12f303 coverity#707687 Uninitialized scalar field
Change-Id: I955a302418c56b6f34f89ff04b1e27c4d1b2722e
2014-01-27 17:03:05 +00:00
Norbert Thiebaud
5de65dc2d6 coverity#440706 : Explicit null dereferenced
Change-Id: I9c078ba5cb413bdb1c790adc327796a85d870974
2014-01-27 03:24:18 -06:00
Andrzej Hunt
3d2fefd800 fdo#72804 Add firebird.msg to install.
This provides saner error messages for malformed
or invalid sql.

Change-Id: I86664db1f1446128bb73e6749f8c00f8313dd414
2014-01-27 06:46:30 +00:00
Norbert Thiebaud
92864323e7 coverity#4407301 Dereference after null check
Change-Id: I3cbb28a65dc75ac641cac88148e36ec3a819ffc4
2014-01-25 03:10:53 -06:00
Norbert Thiebaud
3de5e97e43 coverity#440730 Dereference after null check
Change-Id: Iab8f02e3bb1e03c0ee7efdd0b47d8329d786578d
2014-01-25 03:10:53 -06:00
Timothy Pearson
3ab5dc7dad Fix FTBFS when TDE integration is enabled
Change-Id: Ia44e15044879fbbc169f7097a6f5f14346a0cf39
Reviewed-on: https://gerrit.libreoffice.org/7626
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-24 16:07:12 +00:00
Caolán McNamara
61360536d7 coverity#440728 Explicit null dereferenced
Change-Id: I76b8d6eb59d2558a7ff8a1b1573f24e41a03b8b6
2014-01-23 20:35:32 +00:00
Caolán McNamara
89f7da7ac1 coverity#1158204 Unintentional integer overflow
Change-Id: I8e10fb52803dbd81e5490940a9a7e529beebc803
2014-01-23 20:35:32 +00:00
Caolán McNamara
09c749cc57 coverity#440711 Explicit null dereferenced
Change-Id: I794ac29dc81b1d42b959135277284de1f8c33ccf
2014-01-23 17:01:04 +00:00
Noel Grandin
d803483f6a convert more SvStream::operator<< calls
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.

Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:39 +00:00
Stephan Bergmann
5cb459c207 bool improvements
Change-Id: I989302c6774c4dd01dff3f682bd4b681fc9141df
2014-01-22 11:39:19 +01:00
Stephan Bergmann
a3f32769fc Fix bogus mass-conversion equalsAsciiL -> startsWith
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.

Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-21 15:54:52 +01:00
Takeshi Abe
12ca5ec6f4 Drop unused #include
Change-Id: I06d3b5dde967a424df1ad20ab2c02878c7d0fbb9
2014-01-17 10:29:01 +09:00
Noel Grandin
c648d08720 convert SvStream::operator<< overloads to more explicit methods
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
Stephan Bergmann
cc7ffa07f1 Be explicit when using bool as integral value
Change-Id: I782942e25107ce996f3f31c3f53123c118d81838
2014-01-14 18:11:10 +01:00
Stephan Bergmann
ab6e083f7d bool improvements
Change-Id: Ibe8e80169b222e425df7016a0012591793546adf
2014-01-14 18:11:10 +01:00
Caolán McNamara
09dc581359 drop unnecessary tools/string.hxx includes
Change-Id: I2439ed19b554381f80e882aacbac05167622df92
2014-01-13 13:54:51 +00:00
Noel Grandin
b69864f3f8 re-write SvStream operator<< to non-overloaded methods
This is the actual re-write.

Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
  (*this) << 1;

Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-10 13:26:24 +00:00
Stephan Bergmann
46cf9aed39 SAL_WARN_UNUSED css::uno::Type
Change-Id: I3b165e2a4414fd3d6c3cede5eb39beffa9fe7576
2014-01-08 11:48:04 +01:00
Noel Grandin
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
Lionel Elie Mamane
01329972d8 fdo#37167 create statement before execute/wasNull/getBoolean
This populates "object" member variable.

The "createStatement" calls were removed in:

 commit b9392a36645d8632b97ad79240f483b3a1683b61
 Author: Ivo Hinkelmann <ihi@openoffice.org>
 Date:   Thu Apr 23 10:42:05 2009 +0000

    CWS-TOOLING: integrate CWS dbaperf1

This was most probably in error since the call is not removed from the
other modified member functions in this commit and/or failed to
aaccount for the scenario of no parameter (and thus no setXXX call
before execute).

Change-Id: Ic0e7b7b64ea496791f32c1416aa7d4416f909616
2014-01-06 17:11:00 +01:00
Tor Lillqvist
51145fa544 WaE: C4701: potentially uninitialized local variable 'aErr' used
Change-Id: I420a103fc62091319ec2d466c037d7c6631dde5d
2014-01-03 12:32:52 +02:00
Andrzej Hunt
2b24eec3d4 fdo#70664 Allow reading firebird Blob as InputStream.
Change-Id: Ie0cb93a902961b3f37daf435828263478c9d2997
2014-01-01 19:10:17 +00:00
Andrzej Hunt
cb4b290bcf fdo#70664 Implement Blob writing (firebird-sdbc).
Change-Id: Ia95c6e1a0ede2103aae25610baeb3c7a9642113a
2014-01-01 19:10:17 +00:00
Caolán McNamara
e2591cdeeb drop STRING_MAXLEN uses from connectivity
Change-Id: I12a999c2c6bdd119c2e3e544bbbdabb0b0ce2ba2
2013-12-30 00:21:08 +00:00
Zolnai Tamás
d1c74734c8 Transex3: NO_LOCALIZE_EXPORT
In the past, NO_LOCALIZE_EXPORT macro must be used to
skip uneeded parsing of src files which has no localizable content.
It is unsued by now and it is more effective to handle
this files on gmake level:
gb_SrsTarget_add_nonlocalizable_files
gb_SrsTarget_add_nonlocalizable_templates

Plus remove some empty src file.

Change-Id: I8fc9b2db0b5fd7a3379d3c5be970c4fc691f4c53
2013-12-27 07:14:57 +01:00
Marcos Paulo de Souza
692c724f5e fdo#60698: Merge odbcbase into odbc
We odbcbase is just used inside odbc library, so merge them.

Change-Id: I4f4b34873b570ddcf1065c49e5310a1e73092fd6
2013-12-24 09:12:16 +00:00
Julien Nabet
151887a955 Fix other typos
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-22 18:51:41 +01:00
Lionel Elie Mamane
a5ce8c77a0 fdo#72916 correct rounding of time part of DateTime
Change-Id: I135478755f9e5a844119129b470fef8de2cd0409
2013-12-21 16:49:50 +01:00
Tor Lillqvist
be053c9a80 Spelling correction: s/retrive/retrieve/
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Caolán McNamara
bea15d037b CID#736937 Not restoring ostream format
Change-Id: I07b1d90258647453e498b574bc38c78872041c2d
2013-12-19 11:31:10 +00:00
Caolán McNamara
f5ef6b39fb nIndex can only be -1 or < sSystemPath.getLength()
from

sal_Int32 nIndex = sSystemPath.lastIndexOf('.');

so

OUString sConnPartURL = sSystemPath.copy( 0, ::std::max< sal_Int32 >( nIndex, sSystemPath.getLength() )

is equivalent to

OUString sConnPartURL = sSystemPath.copy( 0, sSystemPath.getLength() )

which is

OUString sConnPartURL = sSystemPath;

so drop sConnPartURL and replace with sSystemPath

Change-Id: I3fc8e88a4b3e474c3dccd08cf356e4663503ae02
2013-12-18 12:37:09 +00:00
Caolán McNamara
365baa17fa STROAGE->STORAGE
Change-Id: I2c83c87d15f5fdc766a8464a8389e22120eabc52
2013-12-18 12:08:45 +00:00
Lionel Elie Mamane
edbbc471bc HSQLDB: correct syntax of change password from MySQL to HSQLDB
Change-Id: Iacf60c456912f2e38c7a082e48c45164e79c1097
2013-12-17 12:16:24 +01:00
Lionel Elie Mamane
9203ae338f HSQLDB: quote usernames
Change-Id: I8384920bc55dafb2cc6581fe82f38d4e2659cc3d
2013-12-17 12:16:23 +01:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
Noel Grandin
2ac31b06ae Unnecessary use of OUString constructor inside OUStringBuffer constructor
Convert code like:
    OUStringBuffer sVal(OUString("0x"));
to:
    OUStringBuffer sVal("0x");

Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-17 11:49:05 +02:00
Noel Grandin
8548abbac5 Remove unnecessary use of OUString constructor in OUStringBuffer::append calls
Convert code like
  aStrBuffer.append(OUString(" AS "));
to
  aStrBuffer.append(" AS ");

Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
2013-12-17 11:49:04 +02:00
Noel Grandin
909b27df48 remove unnecessary double calls to OUString constructor
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
2013-12-17 11:49:04 +02:00
Noel Grandin
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
Julien Nabet
c302a773d4 cppcheck: fix statements that begin with string constant
Change-Id: I42427beeae06f607e60aeeb7142714fd1f5d740d
2013-12-17 07:31:29 +01:00
Stephan Bergmann
b1d65c9f15 Allow setting environment value directly in .component files
...for internal loader="com.sun.star.loader.SharedLibrary" components, instead
of exported component_getImplementationEnvironmen (or implicit
CPPU_CURRENT_LANGUAGE_BINDING_NAME).  Adapted a few .component files as proof-
of-concept, more to follow.

Change-Id: I82332e0a48e6fc1da245990bb72265fe6e58447e
2013-12-16 21:43:12 +01:00
Stephan Bergmann
a83b2af9ab Clean-up uno/lbnames.h
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-16 21:43:12 +01:00
Julien Nabet
0d0e40bd21 Let's apply the same for these
Change-Id: Icd0f4ecee7d3d633f7a41e479729688829b4cf9d
2013-12-14 13:16:31 +01:00
Lionel Elie Mamane
0b46c06171 odbc DBMetaData: NULL pattern equivalent to "%", not "%foo"
Change-Id: Ief475a1bf6e65b4786e8ee9c025b204f143a30e0
2013-12-14 06:00:49 +01:00