11329 Commits

Author SHA1 Message Date
Caolán McNamara
7950797f27 coverity#706468 Uncaught exception
and

coverity#706469 Uncaught exception

Change-Id: Ia67d777b09ac7f72a94a9019765266854775c53f
2014-07-01 16:43:06 +01:00
Caolán McNamara
968f633b24 coverity#706382 Uncaught exception
and

coverity#706377
coverity#706378
coverity#706382

Change-Id: I17f672e31867b1be77c16a8a6e121a8f67df7c90
2014-07-01 16:43:05 +01:00
Stephan Bergmann
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Caolán McNamara
5ace3f3b4f clang scan-build: various warnings
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
Julien Nabet
501ebd0f7c Resolves fdo#43277 Send Legacy Report "E-Mail as ..."=>error message
Change-Id: Iaaadd4fd3015214c007a86d1a83f837aa0d2bdb6
2014-06-30 23:27:34 +02:00
Julien Nabet
a0233e6e03 Typo: habe->have
Change-Id: Ic76a399fc4073fcb713bb566f3fbee2077e20e52
2014-06-29 13:15:52 +02:00
Julien Nabet
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
Noel Grandin
533c6cb6ba fixes for up-casting to Reference<XInterface>
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"

Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-25 17:10:43 +02:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
Luc Castermans
f910280b87 Translated German comments - correction
Conflicts:
	dbaccess/source/ui/dlg/advancedsettings.hxx

Change-Id: If1bbd9ce099f1e8e70149277b412db54f28cb0de
Reviewed-on: https://gerrit.libreoffice.org/9802
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-24 09:11:46 +00:00
Luc Castermans
3d768a2158 Translated German comments
Change-Id: I1a40351aec666c94707ad2dd625f3ab8606242d1
2014-06-24 10:10:23 +01:00
David Tardon
012003e468 fdo#80422 check only one radio button in a group
Change-Id: Ibf1ed3d33d8b2c7da4eee26943da0c09647f4bff
2014-06-24 09:51:26 +02:00
Joren De Cuyper
171efcb7ac fdo#76203 - use consistent titlecase for UI title labels
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9
Reviewed-on: https://gerrit.libreoffice.org/9858
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23 09:01:25 +00:00
Julien Nabet
ef242d3ac8 Typo rong->wrong
Change-Id: I9665d0bd8eccfb16a53eeb733954cdc59af8ccdd
2014-06-22 23:35:48 +02:00
Kohei Yoshida
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
Stephan Bergmann
ae2cccdd2c Missing null check (triggered e.g. by CppunitTest_dbaccess_dialog_save)
Change-Id: I2f78ca59bfebbcffd9a6d0309c49179457bd9172
2014-06-18 14:43:09 +02:00
Stephan Bergmann
32694db4bf rtl::Reference fits just fine here
Change-Id: I14cdcab307f1d2edcebb9fd4aa3009daa32bc7d1
2014-06-18 11:26:34 +02:00
Caolán McNamara
e43c672597 coverity#1223092 Uninitialized scalar field
Change-Id: Ibfbc85562d30c541eada430759a0bda9305d9850
2014-06-17 10:57:57 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Lionel Elie Mamane
db7042cdba janitorial: update function name in SAL_INFO output
Change-Id: Ie01599c8f3ae465998113dd8bfd2a33b27d0a39d
2014-06-16 21:58:05 +02:00
Lionel Elie Mamane
21f2efbe5f dbaccess::ORowSet: separate impl_rebuild_throw
Used by two different callers that wanted different things.
Also, freeResources now always positions on BeforeFirst.
It is only called with _bComplete==false by execute()-related code.

Change-Id: I3e34f77ce37c239d8d3d6a8cd7514b125b049de6
2014-06-16 21:58:05 +02:00
Lionel Elie Mamane
767e15343f clean up fdo#79427 fix: force BeforeFirst only at execute(), not updateRow()
Change-Id: Iaa881d055923702acbb96862d187af41a6ded730
2014-06-16 21:58:05 +02:00
Caolán McNamara
564b8d8ed5 coverity#983629 Uncaught exception
Change-Id: Ie3f8a0a04c136a5ed68486aa5e31284556805510
2014-06-16 16:59:08 +01:00
Lionel Elie Mamane
44cd9a17ca fdo#79427 after execute() a ResultSet is expected to be BeforeFirst
Change-Id: I38091d1ee2161d6e32da3a0bde60e3fc008aa83d
Reviewed-on: https://gerrit.libreoffice.org/9794
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-16 06:47:33 +00:00
Stephan Bergmann
529e7619c5 loplugin:staticcall
Change-Id: I78895f3524086e1d00d9e8eafd52e505f786320b
2014-06-13 17:54:25 +02:00
Stephan Bergmann
85e6eb78c7 Fix memory leak
Change-Id: Idc75fd0735452ffdf6a21e3597cd3fe74f651581
2014-06-13 17:42:57 +02:00
Caolán McNamara
111cec826b coverity#982455 Dereference after null check
Change-Id: If4ad2fe763bffdb64119f7f2a5797aae588fbbf8
2014-06-12 10:24:20 +01:00
Stephan Bergmann
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
Stephan Bergmann
a92e973b6d Change SfxTabPage::Reset param from ref to pointer
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)

Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-11 10:39:03 +02:00
Stephan Bergmann
4dbeadb9c1 Change SfxTabPage::FillItemSet param from ref to pointer
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)

Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10 17:25:23 +02:00
Caolán McNamara
0dc13e9c06 tweak things to allow switching between small and large toolbar icons
Change-Id: Ife4da4c6f4acc3b3f9fde18cdfc09635cf9b6776
2014-06-10 13:23:35 +01:00
sk94
bf6a770dfe DLG_INDEXDESIGN conversion to .ui
Change-Id: I84d6531a73e6e726359bd20664b6299ad8a390ee
Reviewed-on: https://gerrit.libreoffice.org/9699
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-06-10 12:23:22 +00:00
Luc Castermans
5da12788c9 Translated German comments dbaccess/source/ui clean now
Change-Id: Ida2d2dbe95f290e2f32ed2259b8f9bdb27cbf2f9
Reviewed-on: https://gerrit.libreoffice.org/9689
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-06-09 08:46:11 +00:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Lionel Elie Mamane
ade17fc916 fdo#79786 implement getFormOperations for data grid (table view)
Change-Id: I704057b25ca11633ba62fbb834bd2e6095f348f3
Reviewed-on: https://gerrit.libreoffice.org/9685
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-09 06:41:43 +00:00
Caolán McNamara
32c37a7ae0 coverity#1103693 Missing break in switch, assuming its intentional
Change-Id: Ie61305f367e2a07a61599433bd83e1ea13bffd71
2014-06-05 13:35:54 +01:00
Caolán McNamara
8d1063ce1e coverity#705147 Missing break in switch, assuming its intentional
Change-Id: I9041f18eb4aae73b795245c589b28a3d02d8397e
2014-06-05 13:35:51 +01:00
Caolán McNamara
65f1fcce56 coverity#705146 Missing break in switch, assuming its intentional
Change-Id: I09a2cacc3aa18796c06a1f1cc9315b3628865621
2014-06-05 13:35:51 +01:00
Noel Grandin
ea41de0ba5 dbaccess: remove SAL_THROW macro
Change-Id: I01e43d6171dc2381ff8c151d5716e9ffede24822
2014-06-05 08:17:49 +02:00
Thomas Arnhold
13b2519800 update_pch: add a bunch of pch files
connectivity: 3m52s ->  2m47s
 cppcanvas:      28s ->    13s
 cppuhelper:     20s ->    14s
 dbaccess:     2m38s ->  2m01s
 hwpfilter:      16s ->    13s
 sot:            21s ->    16s

Change-Id: I49286bfe6be73dd1b861be632b95e17a99e82f8a
2014-06-04 21:18:40 +02:00
Caolán McNamara
d18dc5dd22 coverity#1000657 Missing break in switch
Change-Id: I03acdc2769e893fc7ecb2885302951852804867b
2014-06-04 12:34:16 +01:00
Stephan Bergmann
3e336d69e3 loplugin:literaltoboolconversion
Change-Id: Ie871fa9378bbb34eacd3205f9485a6f89f833674
2014-06-04 10:47:02 +02:00
Caolán McNamara
3e66a5b5c6 fix index dialog regression
thanks to sk94 for noticing this when trying to
convert this to .ui

Change-Id: If7130d53acb7c194cf0a9a4301f3573789888b86
2014-06-04 09:18:41 +01:00
Stephan Bergmann
369d95931f DeInitVCL at end of tests
This required some changes to the framework:

* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
  once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
  the exisiting unobootstrapprotector).  CppunitTests that need VCL now need to
  declare gb_CppunitTest_use_vcl.

* For things to work properly, the UNO component context needs to be disposed
  from within DeInitVCL (cf. Desktop's Application::DeInit called from
  DeInitVCL).  The easiest solution was to introduce an
  Application::setDeInitHook (where the hook is called from DeInitVCL)
  specifically for vclbootstrapprotector to call.

* PythonTests don't (yet) call DeInitVCL; they still hook into
  BootstrapFixture's original test_init functionality (to call InitVCL), and do
  not make use of the vclbootstrapprotector.

Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04 08:55:12 +02:00
Thomas Arnhold
70c8b4567f WaE: warning C4101: 'e' : unreferenced local variable
Change-Id: Ib5aa5f401eabedfdaebea1dea8f48f284dbccdd5
2014-06-04 08:30:27 +02:00
Caolán McNamara
229abf40ac coverity#1219794 Uncaught exception
Change-Id: Icc9e5faf9ef15840c359b7766112278094d52dea
2014-06-03 20:10:17 +01:00
Caolán McNamara
0301abbbc3 coverity#1219801 Uncaught exception
Change-Id: I372c1891e41510c24daf256d00f3ca98e8a374a9
2014-06-03 20:10:17 +01:00
Lionel Elie Mamane
8eb341ac9e fdo#73352 don't crash if clearWarnings throws an SQLException
Change-Id: If67bda43589834e4c922056145bc60884728cb8a
Reviewed-on: https://gerrit.libreoffice.org/9591
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-31 03:56:12 +00:00
Caolán McNamara
48a697ef1c coverity#706394 Uncaught exception
and hopefully a bunch more of those in dbaccess

Change-Id: I5aefcfe56a697f9e6b18dfe167fdd8a4f54ab6e0
2014-05-30 15:54:56 +01:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29 09:01:40 +02:00