mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
9263b101c39172cbcf04189c515bca80cb15f3aa
Commit Graph

10633 Commits

Author SHA1 Message Date
Stephan Bergmann
107c2c7c7b Remove #ifdef TIMELOG'ed SAL_INFOs 
...the code doesn't make much sense that way.

Change-Id: I506e37b44924701255431f6d20d4610f7f52287d
 2013-11-06 20:55:58 +01:00
Noel Grandin
296329a926 convert xub_StrLen to sal_Int32 
convert for loops using xub_StrLen to use sal_Int32

Change-Id: I5f635ca078966fefe938dbc7e8dea7c8d0d0b554
 2013-11-06 08:51:22 +02:00
Lionel Elie Mamane
730c6bfce5 fill in nNumPrecRadix 
Wrongfully removed by commit 808052a139
Date: Tue Jun 20 02:21:13 2006 +0000
which only wanted to make the code warning-free...

But also disallow radix 1 (which does not make much sense)

Change-Id: Id8e313301fa6d5e9643d76865a62cc933999a63e
 2013-11-05 19:14:24 +01:00
Noel Grandin
3d65dfa3c9 convert xub_StrLen to sal_Int32 
Converts code that calls comphelper::string::getTokenCount() to
use sal_Int32 to store the return value.

Change-Id: I439605a39d29b1309649e30f3ff40dfa412efcde
 2013-11-05 13:18:14 +02:00
Thomas Arnhold
fed3c2bf20 dbaccess: cleanup 
* remove an external guard
* fix some include guards

Change-Id: I4e5b5fc5c50acfd81321377e7956e33c838edeba
 2013-11-05 09:28:54 +01:00
Thomas Arnhold
bfbe8c0b5b fixincludeguards.sh: dbaccess 
Change-Id: Iadd4326d58a5df5761a0ed5ce7fd5fb01fb87d11
 2013-11-05 09:28:52 +01:00
Noel Grandin
5285beeaa4 remove redundant calls to OUString constructor in if expression 
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
 2013-11-04 10:11:08 +02:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Noel Grandin
7a06928bcf convert code to use OUString::endsWith 
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
 2013-10-23 08:29:15 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Caolán McNamara
ef23018f6f missing header 
Change-Id: I84aebf0e107add76dfb293b3a34a30705fd0b3a6
 2013-10-22 13:53:55 +01:00
Michael Stahl
dd28837249 vcl: mark more Image constructors as "explicit" 
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
 2013-10-22 14:42:17 +02:00
Caolán McNamara
91e181ea58 remove uses of COMPARE_* 
Change-Id: Icdc36b4b24d2f399f481065df3200feb98025135
 2013-10-21 14:26:32 +01:00
Caolán McNamara
45e366eadb drop unnecessary tools/string includes 
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
 2013-10-20 19:00:36 +01:00
Marcos Paulo de Souza
3d3293144b fdo#54938: Adapt svtools and comphelper module ... 
to  use cppu::supportsService and other pieces.

Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-17 14:43:28 +02:00
Lionel Elie Mamane
d9eac2ceb8 make sure value passed to updateBoolean is treated as a boolean 
Change-Id: I69549fd8ab95cf92ccb06fd9aed1b9dba2935d7d
 2013-10-16 18:45:21 +02:00
Lionel Elie Mamane
1883d4f10f when reading a bool from a database, treat is as a bool 
This in particular allows recognition of strings "true" and "false".

Change-Id: I590a5357206e4fb0b92b78b8ee4655e445e6f152
 2013-10-16 18:45:19 +02:00
Jan Holesovsky
66013a154b [API CHANGE]: PreView -> Preview, including .uno:PrintPagePreView. 
Will be .uno:PrintPagePreview going forward.

Change-Id: Ie5a35467917a54a60dab9eaacf0690c9df27e6f6
 2013-10-16 16:57:22 +02:00
Stephan Bergmann
7a3381c2a8 CID#1000838 Fix overrides' exception specifications 
Includes also fixes for
CID#1000839
CID#1000840
CID#1000841

Change-Id: I4c7d0bbaec59357af722353bdf947f5629dde1b0
 2013-10-16 10:04:44 +02:00
Tor Lillqvist
6954aad4e5 Reduce copypasta: Introduce SAL_NEWLINE_STRING and use it 
Contains the platform-dependent on-disk line separator ("\r\n" for Windows,
"\n" otherwise, and yes, I assume an ASCII-based world).

Use it instead of static constant char array fields, with ifdeffed
initialisations, in various classes here and there.

Change-Id: Ibea1f2cc1acfb8cc067c3892a41f73bf44f2c78a
 2013-10-13 13:49:24 +03:00
Tor Lillqvist
8b73652822 Test _WIN32 instead of UNX as it is Win32 that's different here 
Change-Id: I05e93ef13523a4729c46c9dbf36657d7288c62e6
 2013-10-12 18:29:51 +03:00
Caolán McNamara
44fa08ed89 CID#1103679 calm coverity re invalid iterators 
Change-Id: Iad07aa59c6016752ec9467945d737380d214c3c0
 2013-10-11 08:51:26 +01:00
Caolán McNamara
541bb85933 CID#1103666 check for NULL 
Change-Id: Idb8cf3c80422d38c271dc2cc8176ff231cf64025
 2013-10-10 17:06:01 +01:00
Stephan Bergmann
f58ee783ee Improve ErrorCodeIOException messages 
...and clean up some includes.

Change-Id: Ia5843cd38f967722d7173a6c87fba26064e3ffd6
 2013-10-09 21:02:11 +02:00
Thomas Arnhold
c20f23a660 html export: 4.0 needs type attribute for style tag 
Change-Id: Iaa076f639a4da564945385ee616d346c4f0d0889
 2013-10-07 11:53:33 +02:00
Thomas Arnhold
646950f96d html export: use only HTML 4.0 for export 
Change-Id: I36d8ddf7b8b38e27686c6cc51ef2a676394f97fb
 2013-10-07 11:53:33 +02:00
Jesús Corrius
050248fea5 Initial fix for fdo#69915 
Change-Id: Id673eb7a55aefb35ff8ab612f926bfd115129ab4
 2013-10-04 10:02:35 +02:00
Tor Lillqvist
e036d4b706 Spell "indices" correctly 
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
 2013-10-02 21:57:42 +03:00
Lionel Elie Mamane
a102d822c9 janitorial: more const, comments 
Change-Id: I5366840ab67fdf89575e890a0d97602b8e78f71a
 2013-10-02 19:02:33 +02:00
Stephan Bergmann
e67308c306 -Werror,-Wunused-variable 
Change-Id: I9379b66c8ad5bffeebd60a2d38fe466b6856e613
 2013-10-02 18:40:15 +02:00
Stephan Bergmann
7f3d893634 -Werror,-Wunused-variable 
Change-Id: I1f3b4c25176db53fc3b827e9514ff497a33f419c
 2013-10-02 18:40:14 +02:00
Stephan Bergmann
82902dd38b -Werror,-Wunused-variable 
Change-Id: I62dbc62446dbdcb25c7a221d88f59862333e5a4d
 2013-10-02 18:40:14 +02:00
Stephan Bergmann
34063e35f7 -Werror,-Wunused-variable 
Change-Id: I805b898faaae631d047ec82e7139c6d6ccaea3b1
 2013-10-02 18:40:14 +02:00
Stephan Bergmann
0ff379fa1c -Werror,-Wunused-variable 
Change-Id: I0d587538c3bee7ad71acb2272c7f85f5f7454158
 2013-10-02 18:40:14 +02:00
Stephan Bergmann
075d472a9d Use std::auto_ptr::reset where applicable 
(avoids warnings about std::auto_ptr ctor being deprecated)

Change-Id: I39d2d155c0bc62ca77a30c02428ea39102213f42
 2013-10-02 16:49:49 +02:00
Caolán McNamara
f7f4216702 remove some UniString::GetBuffer 
Change-Id: I808026a6f593b0251ee107d27e7ca12d55b2d0a0
 2013-10-02 11:43:04 +01:00
Noel Grandin
b47e4dbc08 convert more of dbaccess from String to OUString 
seemed to have missed this the first time around

Change-Id: I8b7b78c95c576b178e3e181c7589da81e5189ee3
 2013-10-01 10:08:44 +02:00
Noel Grandin
d11ed5a57e convert dbaccess module from String to OUString 
Change-Id: I110c925f8d955dfd841cdd1092c13df4d8205393
 2013-10-01 10:08:43 +02:00
Andras Timar
7f436c1fd3 typo fixes in comments 
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
 2013-09-26 11:47:45 +02:00
Caolán McNamara
8e30689680 drop worthless _VECTOR_/_MAP_ header guards 
Change-Id: I54be19847b8fb609f0b08a528cc06dbae9f579d5
 2013-09-25 19:24:24 +02:00
Caolán McNamara
98de5b40c8 Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii 
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
 2013-09-25 19:24:23 +02:00
Noel Grandin
ffc782c23c remove dead definitions 
Change-Id: I69d2df6cb0a7f994339972a23a913938307e5791
 2013-09-19 10:14:15 +02:00
Andrzej J.R. Hunt
7a6fd503b1 Remove sal_char* from dbexception and some cleanup. 
Change-Id: I81909e4542bd5e8d1f8ae182c3c17f9bbea9745d
Reviewed-on: https://gerrit.libreoffice.org/5881
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-09-12 17:33:02 +00:00
Andrzej J.R. Hunt
4216518982 Update implementations of ColumnLocate::findColumn to throw on invalid column. 
Change-Id: I7a9354ecd35a70a005c6c50e38d27de9b33332bd
Reviewed-on: https://gerrit.libreoffice.org/5922
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-09-12 17:26:12 +00:00
Caolán McNamara
1c4f72748d CID#736168 help coverity out a bit 
coverity thinks theres an overrun here, I think its wrong, but its
needlessly complicated code, simplify

Change-Id: I9db4886b4e60d49c25de514081953cb380d4146f
 2013-09-12 13:09:05 +01:00
Thomas Arnhold
fa1b2554d5 use replaceFirst 
Change-Id: Ia20eec6e868579ed31e478514b7f2722a0972094
Reviewed-on: https://gerrit.libreoffice.org/5828
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-09-05 16:49:33 +00:00
Julien Nabet
fd636fe722 Remove unused writeDBLoaderInfo 
See http://nabble.documentfoundation.org/About-writeDBLoaderInfo-function-in-dbloader-cxx-dbaccess-module-td4072511.html

Change-Id: I11b8ff569eaaa8ddcaf105e45ef4ee189e71c183
 2013-09-02 22:50:17 +02:00
Caolán McNamara
ed0f0fa730 XubString->OUString 
Change-Id: I5424a148c7173409e6e56f9483fcc769696707bc
 2013-09-02 12:22:34 +01:00