Commit Graph

5970 Commits

Author SHA1 Message Date
Caolán McNamara
98a61a2ae1 Resolves: fdo#68275 Grayscale TIFF is imported as white
this reverts 6c719c1585 "n#615223 local nbyte1
should have been class-level nByte1" which was to fix the use seen
in valgrind og the uninitialized nByte1

So additionally remove the use of the uninit nByte1 entirely

Change-Id: I5b3f4fa00d74e545f207a11a5e90935f14a23a8e
2013-08-22 15:08:05 +01:00
Julien Nabet
af14ad6c20 cppcheck: fix redundant assignments
Change-Id: Ib0c2f0c2b67f40ce75469b434a67c62187aca93d
2013-08-22 07:14:58 +02:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Michael Meeks
1c7af455ab Re-work 8bit characters in source code, or remove them.
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-08-20 19:30:59 +00:00
Stephan Bergmann
2d2337eb74 Improve some debug output
Change-Id: I1008822ba8592ea43f87805bf00adbfdaf4f02fc
2013-08-20 17:58:44 +02:00
Stephan Bergmann
9793d38752 Use standard idiom
Change-Id: I77b2732e04435ee93044b65c4925de43cc20187f
2013-08-19 08:55:57 +02:00
Tor Lillqvist
058a3d1c46 Further work on the "Mac-like app structure" option
Lots of stuff still either ended up in the wrong place, or was looked up from
the wrong place, or both. Fix most cases.

Change-Id: I06ebbce207c219f3cd82b4387dd9b3fdb83420d4
2013-08-18 21:11:16 +03:00
Julien Nabet
3b51ba24be cppcheck: fix duplicateBranch
Git history shows it was like this since first commit (2009-12-15)
Moreover I noticed these lines:
    220     if ( mpCGM->pElement->nAspectSourceFlags & ASF_FILLCOLOR )
    221         nFillColor = mpCGM->pElement->pFillBundle->GetColor();
    222     else
    223         nFillColor = mpCGM->pElement->aFillBundle.GetColor();
even if nFillColor can have another value in case below
    249         case FIS_GEOPATTERN :
    250         {
    251             if ( mpCGM->pElement->eTransparency == T_ON )
    252                 nFillColor = mpCGM->pElement->nAuxiliaryColor;
    253             eFS = drawing::FillStyle_NONE;
    254         }
this change is still safe since it's just a simplification.

Change-Id: Icf41dbeee6405780483649e0968dd30e8a533882
2013-08-15 19:53:11 +02:00
Caolán McNamara
6b20520517 Resolves: fdo#33983 use 'Slides' instead of 'Pages' for impress pdf export
Change-Id: Id380514f8f74783a0a0baf61cc9358f2b1bcbc47
2013-08-15 17:34:45 +01:00
Tomaž Vajngerl
ef947839c9 fdo#59524 Enable encryption for docx, pptx and standard OOXML formats
Change-Id: Id00fde15188be3fb7209d8f14f2f2f07ebd211b0
2013-08-15 17:18:20 +02:00
Tomaž Vajngerl
3423db6f81 fdo#59524 Encryption for MS Office 2007 Spreadsheet documents
This enables saving of MS 2007 spreadsheet documents with a password.
The encryption used is the same as used in Office 2007 (however
different than in Office 2010 and 2013 which use "agile" encryption).

Change-Id: I3539e811d95b6f9178246ab269d13bb385a48bd2
2013-08-14 00:01:51 +02:00
Takeshi Abe
e2e15148fc Mark as const/static
Change-Id: I54a7daee7345e7c0c5c3f866d5c365722b567eff
2013-08-04 00:54:12 +09:00
Caolán McNamara
8bcbc765a2 convert xslt filter dialog to .ui
Change-Id: I02bb629af1f4811f382469b8e2aaaba272f07034
2013-07-30 20:57:30 +01:00
Caolán McNamara
cd79c46b46 drop unused help ids & fix mnemonic widgets
Change-Id: I80c21126e2728ffa18c87a98e500cc941d462de1
2013-07-30 15:47:40 +01:00
abdulmajeed ahmed
9ed24d6625 Convert xml filter tabpage transformation to .ui
Change-Id: Ice69f7d036d414c82f6c313a8dc025f736b97e68
Reviewed-on: https://gerrit.libreoffice.org/5201
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-30 14:47:21 +00:00
Stephan Bergmann
36efa8c6a8 Related rhbz#98977: Handle multiple LibXSLTTransformer::terminate calls
Trying to reproduce rhbz#98977, temporarily changing TRANSFORMATION_TIMEOUT_SEC
(filter/source/xsltfilter/XSLTFilter.cxx) to zero, loading a dummy "Microsoft
Excel 2003 XML (.xml)" file shows a "General input/output error" msg box and
"Cancel" leads to a crash due to duplicate calls to m_tcontrol->terminate() from
both XSLTFilter::importer and XSLTFilter::endDocument (both
filter/source/xsltfilter/XSLTFilter.cxx).

Change-Id: Ia103d944f3e1f14ca2cf5552ca3a48348132d38e
2013-07-30 11:49:18 +02:00
Stephan Bergmann
a95d1eff07 Remove effectively unused INetURLObject OString overloads
Change-Id: Icbbe27b229d5454d27be646e00e8b362a77359b3
2013-07-29 08:26:29 +02:00
Caolán McNamara
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
Michael Meeks
03993b47c5 targetted clean of redundant header piece from 62badf3828
Change-Id: Ic1240114d667fb7797afae4847427cc889f3cb48
2013-07-26 14:18:52 +01:00
Julien Nabet
c9d037c3e8 fdo#46037: no more comphelper/configurationhelper.hxx in filter
Change-Id: I8b839dcf1f1a6247800f0bf054b2872b1acf800a
Reviewed-on: https://gerrit.libreoffice.org/5082
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-24 20:19:25 +00:00
Caolán McNamara
b5cd1de309 set mnemonic widgets and a few other little tweaks
Change-Id: Ic0ae45085ca933e41591f932524f4ddef4de5714
2013-07-24 14:12:34 +01:00
abdulmajeed ahmed
af2d2b864a Convert Xml-Filter-TabPage-General to .ui
Change-Id: Ia2ce0ce28b8a078b99651b38bdd3cbeaea3d8772
Reviewed-on: https://gerrit.libreoffice.org/5029
Tested-by: abdulmajeed ahmed <aalabdulrazzaq@kacst.edu.sa>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-24 13:12:06 +00:00
Caolán McNamara
951e35d5b9 add test-case for CVE-2013-2577
Change-Id: I69f42b8ea53b68495cb4666a93ece47f6679582e
2013-07-24 09:37:45 +01:00
Julien Nabet
cb99d82385 fdo#66274: Saving document as RTF result in text 'Use Rich Text Format Format'
Change-Id: Id617816c8530b7536238b5aa4a471c57a2a0b82e
Reviewed-on: https://gerrit.libreoffice.org/4999
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-22 17:39:26 +00:00
Mark Wielaard
cae861f0b3 Fix memory leak with osl_getCurrentSecurity ().
The result of osl_getCurrentSecurity () should always be deleted again
with osl_freeSecurityHandle ().

Change-Id: If0991937fcb24207d1f78166f61c4be22d423629
Reviewed-on: https://gerrit.libreoffice.org/4947
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-07-17 10:57:21 +00:00
Palenik Mihály
9c0a390489 fdo#63133: Write tools/tempfile.hxx out
I deleted TempFile class and changed it to utl::TempFile class
-which in unotools/tempfile.hxx- in the followings: Storage,
StgTmpStrm, SwXMailMerge classes; and RenderAsEMF function.
I modified header in precompiled_sw.hxx.

Change-Id: I3dae5333dc42538e1b905f6a6bbc85534c591dc1
Reviewed-on: https://gerrit.libreoffice.org/4938
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-07-16 18:40:45 +00:00
Michael Stahl
fd3c5d3a06 filter: need more boost_headers
Change-Id: Id927d5494bed8d4d8fa27f38dfcde14b95081cc1
2013-07-15 18:18:29 +02:00
Mark Wielaard
81a608e930 Fix memory leak in SvxMSDffManager::CheckForConvertToSOObj.
Use boost::scoped_ptr for temporary SvMemoryStream.

Change-Id: I6235d7868bd20963aa5fdda32b1dd3b82cf0b182
Reviewed-on: https://gerrit.libreoffice.org/4760
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-11 08:21:57 +00:00
Mark Wielaard
4cf80bd8b2 Fix memory leak in SvxMSDffManager::ImportShape.
When a new DffPropertyReader is created and assigned to pSecPropSet
make sure the old one is deleted first.

Change-Id: Idd14fdf4e3a03a625a10a89dde71ad66cbdba792
Reviewed-on: https://gerrit.libreoffice.org/4761
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2013-07-09 10:16:12 +00:00
Frédéric Wang
fb2edd686c fdo#66645 XHTML export: ignore incorrect style on math objects
Change-Id: Ied09a189184380aa3eba30261c7517f6bccf6d09
Reviewed-on: https://gerrit.libreoffice.org/4751
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2013-07-09 09:03:16 +00:00
Stephan Bergmann
b63524d269 error: comparison between pointer and integer (Clang trunk towards 3.4)
...the check in itga.cxx was useless anyway, as new[] does not return null.

Change-Id: I4de5a46e14a83ab134d0a098a62748e909dc9c00
2013-07-08 17:32:25 +02:00
Stephan Bergmann
9e31cf2ae6 -Werror,-Wdeprecated-register (Clang trunk towards 3.4)
...in files generated by gperf; an alternative could be to use -isystem instead
of -I in gb_Library_use_custom_headers.

Change-Id: I316684ab5342977655a5642903b13e127adaf95c
2013-07-08 17:32:25 +02:00
Caolán McNamara
0c68a3867f convert pdf signing page to .ui format
Change-Id: I037036e410a6f9d7da7bc34721c105e81470d5d9
2013-07-08 14:54:07 +01:00
Caolán McNamara
28d6687131 convert pdf options dialog to .ui format
Change-Id: I7c186ea77bbadd20ac881dcb0aa2cf7db525dc1e
2013-07-08 13:10:03 +01:00
Caolán McNamara
aa93c3c9a0 convert pdf export general page to .ui
Change-Id: I94d86f9807e67bd4f352321fde1c83913b5a4fed
2013-07-08 10:40:42 +01:00
Caolán McNamara
1e467c8b38 convert pdf view page to .ui format
Change-Id: I738dd72f66658f60025152c9c3db765dbcb981ac
2013-07-04 10:23:03 +01:00
Michael Stahl
fb3778b2a2 ... fix more -Werror=address (wrong TempFile ctor called)
Change-Id: I19b2195a5e524f8c485f904989f1c604fca9612f
2013-07-02 14:01:19 +02:00
Michael Stahl
23326c4827 filter: fix more -Werror=address (wrong TempFile ctor called)
Change-Id: I2242b12b75dfbd1ae6fdb4283c065168ac9df4d2
2013-07-02 13:34:28 +02:00
Frédéric Wang
1ef63d0842 fdo#66278 - MathML export: distinguish inline/display equations.
Change-Id: Ia764c2fd64ab772342ce86f67ee290ab38dc4a83
Reviewed-on: https://gerrit.libreoffice.org/4607
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-07-01 13:41:35 +00:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
Michael Stahl
8a7ede404c SVGWriter: fix build with C++98 compilers
Change-Id: Idae0823767291081ed51a478583273daaa0cd1c3
2013-06-29 22:39:20 +02:00
SJacobi
9911631895 SVGWriter can now be initialized properly. Removing some strange code peaces.
Change-Id: Ia3011d002c4028008b207505352384f6bb72ce10
Reviewed-on: https://gerrit.libreoffice.org/4619
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-06-29 20:02:45 +00:00
Thomas Arnhold
955ebe83a8 String to OUString and cleanup
Change-Id: Idc18c1a6a64edea3399c8747ec0f096a2f964b68
2013-06-29 16:23:24 +02:00
Thomas Arnhold
318f2b64cc remove some createFromAscii usage
there are a lot more of them:

git grep 'createFromAscii[^)]*"'

Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-29 16:23:23 +02:00
Caolán McNamara
937abc32bf stray debugging
Change-Id: Ie9408fecfdb9216a6a80d92a2c215ebf25997e9f
2013-06-28 13:46:18 +01:00
Thomas Arnhold
5cb2e3104b remove toolkit/unohlp.hxx hack
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913
Reviewed-on: https://gerrit.libreoffice.org/4601
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 11:49:28 +00:00
Caolán McNamara
396ab1eba7 convert pdf security page to .ui
Change-Id: Ie785f4b112b8992707f886720d92bd34d0823f39
2013-06-28 11:50:15 +01:00
Caolán McNamara
31fc0b7442 always call setDeferredProperties for dialog get/set title
Change-Id: I57f9cc8fbdb9d2a304c346e03893fa55d6a61bd5
2013-06-28 11:50:15 +01:00
Khaled Hosny
feaebe7f93 Always embed 14 standard Postscript fonts in PDF
Ealier version of PDF standard allowed for not embedding the so called
standard PostScript fonts in the PDF files and all PDF readers had to
include them or a "suitable substitute". This behaviour had many issues
and is deprecated for 10 years now. The current version of PDF spec
says:

  Beginning with PDF 1.5, the special treatment given to the standard 14
  fonts is deprecated. Conforming writers should represent all fonts
  using a complete font descriptor. For backwards capability, conforming
  readers shall still provide the special treatment identified for the
  standard 14 fonts.

This commits removes support for not embedding these fonts, and the, now
redundant, option to embed them.

This has the side effect of elimanating the cause of fdo#66108 and
fdo#41547.

Change-Id: I4f1fc4137a2de7baeef9e504f2e4f84fbec0a491
Reviewed-on: https://gerrit.libreoffice.org/4495
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-06-27 19:03:31 +00:00
Caolán McNamara
62aec37627 use standard row spacing
Change-Id: Icbdc1399d4abd9222c1b1fced68c1e3012b05020
2013-06-27 16:49:35 +01:00