mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

2306 Commits

Author SHA1 Message Date
Alexandre Vicenzi
f9369d33a4 fdo#54938 Convert to cppu::supportsService 
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10
Reviewed-on: https://gerrit.libreoffice.org/7649
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
 2014-02-03 14:35:46 +00:00
Michael Stahl
45befb3685 "stati" considered both pretentious and incorrect Latin 
As one knows, the Latin plural of the noun status is statūs.

Change-Id: I6b19c57aa2aedcc1337736becc93d8802fe03f2e
 2014-01-30 14:04:29 +01:00
Alexandre Vicenzi
25d089e09d fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter. 
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab
Reviewed-on: https://gerrit.libreoffice.org/7731
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-30 10:48:40 +00:00
Matúš Kukan
19e16083c6 Introduce com.sun.star.ui.theModuleUIConfigurationManagerSupplier singleton. 
Change-Id: I7b503e5d49865c9ff287bf72eaff1995ce871790
 2014-01-30 10:48:25 +01:00
Stephan Bergmann
6d993bc5b4 bool improvements 
Change-Id: I78099f87510355a43ba9b01ca9d545d44ce11a50
 2014-01-28 20:26:28 +01:00
Matúš Kukan
ba8413d262 Introduce com.sun.star.frame.theUICommandDescription singleton. 
Change-Id: Ic88cca3722d555ba48d7da8c176556fa1ff90650
 2014-01-28 18:52:22 +01:00
Caolán McNamara
d31a216b1f coverity#705814 Dereference before null check 
Change-Id: Ib5eb5a7058098f7222b1597e60ddc84786403805
 2014-01-28 14:30:42 +00:00
Stephan Bergmann
e3133ae237 Let C++ inline functions return bool instead of sal_Bool 
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).

Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
 2014-01-23 18:43:53 +01:00
Stephan Bergmann
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=) 
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
 2014-01-22 15:00:54 +01:00
Arnaud Versini
5a73cceee5 FORMS : Remove usage of DBG_CTOR and DBG_DTOR. 
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 16:26:50 +00:00
Stephan Bergmann
602c87b425 Window::PreNotify should return bool 
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
 2014-01-18 00:37:49 +01:00
Stephan Bergmann
04683f1488 Window::Notify should return bool 
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
 2014-01-17 16:42:29 +01:00
Caolán McNamara
854188e3b1 remove last xub_StrLen in forms 
Change-Id: If6c711cf9c317411c72260b4029521782f8a282c
 2014-01-15 15:36:23 +00:00
Stephan Bergmann
459c8131ac bool improvements 
Change-Id: Iba5bf2d2207f80098cb43ff8ce290eef741d21c9
 2014-01-14 21:28:07 +01:00
Stephan Bergmann
d7a360eb99 Lock SolarMutex in RichtTextEngine::Create 
...as always, the question is where exactly to place the mutex guard, but
without it querying for XServiceInfo of a freshly instantiated
"stardiv.one.form.component.Edit" (i.e., OFormattedFieldWrapper) would lead to
failing

> DbgTestSolarMutex () at include/tools/debug.hxx:295
> OutputDevice::ImplGetGraphics (this=0x2b81dc11e680) at vcl/source/gdi/outdev.cxx:560
> OutputDevice::DrawRect (this=0x2b81dc11e680, rRect=Rectangle = {...}) at vcl/source/gdi/outdev.cxx:1649
> OutputDevice::ImplDrawColorWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:778
> OutputDevice::ImplDrawWallpaper (this=0x2b81dc11e680, nX=0, nY=0, nWidth=1, nHeight=1, rWallpaper=...) at vcl/source/gdi/outdev6.cxx:1083
> OutputDevice::Erase (this=0x2b81dc11e680) at vcl/source/gdi/outdev6.cxx:1144
> VirtualDevice::ImplInitVirDev (this=0x2b81dc11e680, pOutDev=0x28dc0a0, nDX=1, nDY=1, nBitCount=0, pData=0x0) at vcl/source/gdi/virdev.cxx:114
> VirtualDevice::VirtualDevice (this=0x2b81dc11e680, nBitCount=0) at vcl/source/gdi/virdev.cxx:136
> ImpEditEngine::SetRefDevice (this=0x2b81dc045f10, pRef=0x0) at editeng/source/editeng/impedit2.cxx:195
> ImpEditEngine::ImpEditEngine (this=0x2b81dc045f10, pEE=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/impedit2.cxx:156
> EditEngine::EditEngine (this=0x2b81dc0c8a00, pItemPool=0x2b81dc0a0960) at editeng/source/editeng/editeng.cxx:104
> frm::RichTextEngine::RichTextEngine (this=0x2b81dc0c8a00, _pPool=0x2b81dc0a0960) at forms/source/richtext/richtextengine.cxx:103
> frm::RichTextEngine::Create () at forms/source/richtext/richtextengine.cxx:52
> frm::ORichTextModel::ORichTextModel (this=0x2b81d866ff30, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/richtext/richtextmodel.cxx:66
> frm::ORichTextModel::Create (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/richtext/richtextmodel.cxx:243
> cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171
> cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a6a0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203
> cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a638, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432
> non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433
> cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.RichTextControl", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979
> non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987
> frm::OControlModel::OControlModel (this=0x2b81d8679408, _rxContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSetDelegator=0 '\000') at forms/source/component/FormComponent.cxx:593
> frm::OBoundControlModel::OBoundControlModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, _rUnoControlModelTypeName="com.sun.star.form.component.RichTextControl", _rDefault="com.sun.star.form.control.TextField", _bCommitable=1 '\001', _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/FormComponent.cxx:1273
> frm::OEditBaseModel::OEditBaseModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8, rUnoControlModelName="com.sun.star.form.component.RichTextControl", rDefault="com.sun.star.form.control.TextField", _bSupportExternalBinding=1 '\001', _bSupportsValidation=1 '\001') at forms/source/component/EditBase.cxx:57
> frm::OEditModel::OEditModel (this=0x2b81d8679408, _rxFactory=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at forms/source/component/Edit.cxx:296
> frm::OEditModel_CreateInstance (_rxFactory=uno::Reference to (cppuhelper::ServiceManager *) 0x2b813a25a260) at forms/source/component/Edit.cxx:280
> cppu::OSingleFactoryHelper::createInstanceEveryTime (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:171
> cppu::OSingleFactoryHelper::createInstanceWithContext (this=0x2b819d66a5c0, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:203
> cppu::OFactoryComponentHelper::createInstanceWithContext (this=0x2b819d66a558, xContext=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/factory.cxx:432
> non-virtual thunk to cppu::OFactoryComponentHelper::createInstanceWithContext(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/factory.cxx:433
> cppuhelper::ServiceManager::createInstanceWithContext (this=0x2b813a25a208, aServiceSpecifier="com.sun.star.form.component.TextField", Context=uno::Reference to (cppu::ComponentContext *) 0x2b813a244dd8) at cppuhelper/source/servicemanager.cxx:979
> non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) () at cppuhelper/source/servicemanager.cxx:987
> frm::OFormattedFieldWrapper::ensureAggregate (this=0x2b81d8879818) at forms/source/component/FormattedFieldWrapper.cxx:342
> frm::OFormattedFieldWrapper::queryAggregation (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.cxx:164
> cppu::OWeakAggObject::queryInterface (this=0x2b81d8879818, rType=invalid uno::Type) at cppuhelper/source/weak.cxx:281
> frm::OFormattedFieldWrapper::queryInterface (this=0x2b81d8879818, _rType=invalid uno::Type) at forms/source/component/FormattedFieldWrapper.hxx:68
> com::sun:⭐:uno::BaseReference::iquery (pInterface=0x2b81d8879818, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:43
> com::sun:⭐:uno::Reference<com::sun:⭐:lang::XServiceInfo>::iquery (pInterface=0x2b81d8879818) at include/com/sun/star/uno/Reference.hxx:58
> com::sun:⭐:uno::Reference<com::sun:⭐:lang::XServiceInfo>::Reference (this=0x2b81d8663a98, rRef=...) at include/com/sun/star/uno/Reference.hxx:158

Change-Id: I16ebbb2caf4f0fe943c9e43bddde03b5a2627e35
 2014-01-08 14:09:15 +01:00
Stephan Bergmann
175f650998 This can be private 
Change-Id: Ida54a46580fb3d1ec49ea5daeb55c0235d2bf85a
 2014-01-08 14:06:01 +01:00
Julien Nabet
151887a955 Fix other typos 
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
 2013-12-22 18:51:41 +01:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp 
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
 2013-12-17 17:32:58 +01:00
Stephan Bergmann
a83b2af9ab Clean-up uno/lbnames.h 
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
 2013-12-16 21:43:12 +01:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code 
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
 2013-12-12 11:10:10 +01:00
Stephan Bergmann
a62c2a5fa5 Don't hold css::uno::Type instances by pointer 
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
 2013-12-12 08:26:40 +01:00
Stephan Bergmann
123e2c3e93 Revert "Don't hold css::uno::Type instances by pointer" 
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now:
Ach, old GCC doesn't like plain string literals to initialize members
of OUString type...

Change-Id: I50563a00406259bb5d41831e2a2796762450d097
 2013-12-11 15:38:30 +01:00
Stephan Bergmann
90f91088d2 Don't hold css::uno::Type instances by pointer 
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
 2013-12-11 15:16:51 +01:00
Stephan Bergmann
b0926378ac Clean up includes of comphelper/stl_types.hxx 
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
 2013-12-06 17:56:11 +01:00
Stephan Bergmann
e9c62a2d9c Get rid of unnecessary comphelper::UStringEqual 
Change-Id: Ia8718e49f21ccec239b2769eafa6bef90e0e9e40
 2013-12-06 14:28:36 +01:00
Stephan Bergmann
07ab0d43b5 Get rid of DECLARE_STL_VECTOR 
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
 2013-12-06 08:04:23 +01:00
Stephan Bergmann
4a8175ebeb Get rid of DECLARE_STL_USTRINGACCESS_MAP 
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
 2013-12-06 08:04:22 +01:00
Michael Stahl
6aefcb6a6f forms: avoid deadlock when setting FontControlModel properties 
Deadlock found in forms_unoapi on Windows, with
OGridControlModel::setFastPropertyValue_NoBroadcast() calling event
handler that tries to lock SolarMutex.

FontControlModel::setFastPropertyValue_NoBroadcast() and its callers in
3 other classes must not send events via firePropertyChange()
because they are called by OPropertySetHelper::setFastPropertyValues()
with its Mutex locked.

It is possible (though sadly quite convoluted) to delay the sending of
the events by calling setDependentFastPropertyValue() instead.

Change-Id: I0c767cfec01fe1bcaeb1236287b5faf81a2e7441
 2013-11-27 17:20:31 +01:00
Michael Stahl
e521a803c9 FontControlModel::convertFastPropertyValue: fix bad cast of Kerning 
Casting sal_Bool to integer lets the comparison always fail.

Change-Id: I33cf9e9b6a65f81166870bdfe32e9a97101501df
 2013-11-27 17:14:23 +01:00
Julien Nabet
ea6f3c09cf outter -> outer (also when "outter" is inside another word) 
Change-Id: I0290d57f1c27a82a34a7dba56d88d51ec6d0bd9e
 2013-11-23 22:40:38 +01:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Julien Nabet
4ea65db333 cppcheck: Array index is used before limits check 
Change-Id: I30154dd9504b70dc3212af3ac1d88dfc9a9d8396
 2013-11-16 10:52:45 +01:00
Stephan Bergmann
ab5d1fbfb4 SAL_WARN_UNUSED com::sun:⭐:uno::Any 
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
 2013-11-14 21:02:40 +01:00
Stephan Bergmann
ba3783467c -Werror,-Wunused-member-function 
Change-Id: Ia04390e5a3d4c5833c24add581985a9491af0443
 2013-11-14 10:15:05 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Michael Stahl
d6809a9ac5 i18npool, forms: remove warnings_guard_unicode*.h 
These horrible headers use "#pragma GCC system_header" and thereby
prevent generated Makefile dependencies, which is what broke incremental
builds after the ICU upgrade today.

Change-Id: Ife983b3c4de86968da8a0187a1acb1bbb2b5c81f
 2013-11-14 00:04:16 +01:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00
Noel Grandin
ef90021abe convert OUString !compareToAscii to equalsAscii 
Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
 2013-11-11 12:58:12 +02:00
Noel Grandin
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii 
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
 2013-11-11 12:58:12 +02:00
Noel Grandin
373f352ef2 remove unnecessary use of OUString constructor in FORMS module 
Change-Id: Ibbf477e99ba0c07a9138497496442b0f9296f5c3
 2013-11-11 11:21:22 +02:00
Thomas Arnhold
bdf7b2715e fixincludeguards.sh: forms 
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
 2013-11-05 09:28:53 +01:00
Samuel Mehrbrodt
a71a562a99 fdo 70998: Termchange: Graphics->Image 
Change-Id: If451dfb24567157c86bca9a4a8564eb8de231a38
Reviewed-on: https://gerrit.libreoffice.org/6524
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-11-04 07:49:45 -06:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Marcos Paulo de Souza
da5449da0c fdo#54938: More uses of cppu::supportsService 
Change-Id: Id6bed78d92eba52283a17ab3ca66e751c225e48d
Reviewed-on: https://gerrit.libreoffice.org/6423
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-25 08:07:04 +00:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Caolán McNamara
45e366eadb drop unnecessary tools/string includes 
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
 2013-10-20 19:00:36 +01:00
Lionel Elie Mamane
080e9c2987 bogus WaE: 'bValue' may be used uninitialized in this function 
Change-Id: Ifde0f9370d093f447edac4899c5bbc7940da5a8c
 2013-10-17 16:00:55 +02:00
Tor Lillqvist
2337bb6b40 WaE: unknown warning group '-Wmaybe-uninitialized' 
Seriously, would it be so awful to initialise the value even if strictly
speaking it is unnecessary? Hopefully avoiding that is not an attempt at
manual micro-optmisation? (Or did the initialisation actually cause some
warning?)

Besides, Clang is not just "the MacOS X compiler". I use Clang on Linux,
too. It is great. Our Clang plug-in (which can be easily used only on Linux)
is very useful.

Change-Id: I379afed707d96745ee29979bd79467309adf0147
 2013-10-17 08:34:01 +03:00