mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

2650 Commits

Author SHA1 Message Date
Noel Grandin
7938279a0d /include/connectivity/dbtools.hxx: sal_Bool->bool 
Change-Id: Ie1e1952e3d39d53756583482826dfc3b65b5f9e0
 2014-04-04 13:44:18 +02:00
Caolán McNamara
a7b6623b1f coverity#707864 Uninitialized scalar field 
Change-Id: Ieb42d64ead25d9e06175a7664d8659e0907d28f1
 2014-04-04 12:14:21 +01:00
Caolán McNamara
627b0c682a coverity#707862 Uninitialized scalar field 
Change-Id: I0d94414f4645d3f5da6242bbfefcee449572d2c0
 2014-04-04 12:14:21 +01:00
Julien Nabet
786b31696b Typo: corect->correct 
Change-Id: I31267af8aae35d647b8c4b0a0c5f926ad4779919
 2014-04-03 21:15:54 +02:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Michaël Lefèvre
c03c9da8c2 fdo#43157 : clean up OSL_POSTCOND 
Conflicts:
	include/sal/log-areas.dox

Change-Id: I770b8b9fb82f873ccb88dc26ac05206f703ddf33
Reviewed-on: https://gerrit.libreoffice.org/8805
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-04-03 11:23:49 +00:00
Noel Grandin
a718b02f8e vcl: sal_Bool->bool and cleanup 
- remove unused PFilterDlgCall typedef
- remove bool parameter from PFilterCall typedef - it was always being

  called with false, and nothing was reading it

Change-Id: Ic56127e7d55254a7b9b65849a21cb286f52344d1
 2014-04-03 09:17:55 +02:00
Stephan Bergmann
6478730e12 Forgotten TODO 
Change-Id: I4fb1c155c533445856639498e73c728933bb3dd7
 2014-04-01 19:42:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Noel Grandin
3194d22a24 connectivity: sal_Bool->bool and fix method name 
Convert method name
  getBoleanComparisonPredicate
to
  getBooleanComparisonPredicate

Change-Id: I00c726b1fecd8352dc49f2af98c3ae3c799ef424
 2014-04-01 07:38:08 +02:00
Thomas Arnhold
cc3a302fcb typo: unfortunally -> unfortunately 2014-03-29 19:16:20 +01:00
Michael Stahl
1258b576ae tools: support 64-bit file positions in SvStream 
Bump stream positions to 64 bits on:

SvLockBytes::SetSize()
SvStream::SeekPos()
SvStream::SetSize()
SvStream::SetStreamSize()
SvStream::Seek()
SvStream::SeekRel()
SvStream::Tell()
SvStream::remainingSize()
SvStream::nActPos
SvStream::nBufFilePos

Change-Id: I0521fd60d31d1a33e5634cbf51dd42edc46ad919
TODO: adapt callers of Seek()/SeekRel()/Tell()/remainingSize()
 2014-03-29 02:03:07 +01:00
Michael Stahl
19bbfc0b39 tools: allow 64-bit positions on SvLockBytes 
Bump stream positions to 64 bits on:

SvLockBytes::ReadAt()
SvLockBytes::WriteAt()
SvAsyncLockBytes::m_nSize
SvOpenLockBytes::Seek()
SvOpenLockBytes::Tell()
SvOutputStreamOpenLockBytes::m_nPosition
OInputStreamHelper::m_nActPos

Change-Id: Ica3b674e0ab23a756260a51475e97a5396ecdddb
 2014-03-29 02:03:07 +01:00
Stephan Bergmann
1f90d06bbb Remove remaining DBG_CTOR etc. remnants from forms 
Change-Id: I1616d7e77071caa78ffd8c7d7857f50f3afa1bb7
 2014-03-28 15:32:45 +01:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Noel Grandin
b1de52241c svtools: sal_Bool->bool 
Change-Id: Iaa489318f25107e91fc8133523fbd9d724493314
 2014-03-24 08:12:08 +02:00
Noel Grandin
86a32589e9 Find places where OUString and OString are passed by value. 
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
 2014-03-18 08:32:26 +02:00
Stephan Bergmann
22684273d5 forward*PropertyValue functions need not be SAL_CALL 
...and _bSuccess parameter is unused

Change-Id: Iee5e1d5c2d4272f342b2867bfe76f8c87dcd69d4
 2014-03-13 14:00:03 +01:00
Caolán McNamara
39831d90d9 coverity#704232 Logically dead code 
these conditions are already handled in the switch above

Change-Id: I1a2bfe4cc536f2d1292fd39b86afc53ac5463308
 2014-03-11 13:53:25 +00:00
Stephan Bergmann
2598a15ed2 forms: simplify deprecated XTypeProvider.getImplementationId 
...and remove thus unused unotools/idhelper.hxx

Change-Id: I63affbcb0494ef91bc010b9dd5512d4cc718d7a2
 2014-03-10 17:39:55 +01:00
Stephan Bergmann
191a50828c simplify 
Change-Id: Icd2dff124ca331935412e2653c57943b92deeea4
 2014-03-05 17:57:11 +01:00
Alexander Wilms
bed18b128f Remove visual noise from forms 
Conflicts:
	forms/source/component/DatabaseForm.cxx

Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 14:54:56 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Julien Nabet
f1a73892b3 Typo: apropriate -> appropriate 
Change-Id: I05e23039dc3ae0b6595c87fe550f4228ad93d5d6
 2014-02-25 22:04:17 +01:00
Stephan Bergmann
76b114f849 implicitboolconversion: warn about implicit conversion of call args to bool 
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.

Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.

(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)

Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
 2014-02-24 17:25:05 +01:00
Stephan Bergmann
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState 
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
 2014-02-24 12:27:32 +01:00
Stephan Bergmann
146c7c5c89 toolkit: sal_Bool -> bool 
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
 2014-02-24 11:13:42 +01:00
Stephan Bergmann
b7259532d8 Remove unnecessary bool2any 
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
 2014-02-24 08:08:00 +01:00
Stephan Bergmann
ad73967e99 Remove unnecessary extractInterface 
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
 2014-02-24 08:08:00 +01:00
Caolán McNamara
2a83910e72 coverity#704644 Dereference after null check 
Change-Id: I9b2aad39c54497b5b53a86cf11a754f89c012d0e
 2014-02-23 14:22:43 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Caolán McNamara
841ea0ace7 coverity#441137 Dereference after null check 
Change-Id: I877abe904885f28560cf43ee70001ac97fadbe04
 2014-02-23 03:28:22 +00:00
Caolán McNamara
ca7c3debbd coverity#738652 Uninitialized scalar field 
Change-Id: Ie191910d49ee9f622bc407a768e79671698d2ac3
 2014-02-21 12:40:27 +00:00
Caolán McNamara
466e8bd416 coverity#738654 Uninitialized scalar field 
Change-Id: I92909b606e06f3d86fc3b66aef1ac52e5d706967
 2014-02-21 12:40:27 +00:00
Caolán McNamara
09f93567e9 coverity#738656 Uninitialized scalar field 
Change-Id: I49e3f47e318ae342738dd1de90673e2aee2bb62b
 2014-02-21 12:40:26 +00:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool 
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
 2014-02-21 12:53:51 +01:00
Noel Grandin
b7180bd14f editeng: sal_Bool->bool 
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
 2014-02-21 12:19:24 +02:00
Noel Grandin
7e06ccad8f editeng: sal_Bool->bool 
Change-Id: I36cb765d87ddef1fba3447a3ea90e5285cbcd678
 2014-02-21 12:19:23 +02:00
Takeshi Abe
5f17e5eaad Replace deprecated std::auto_ptr with boost::scoped_ptr 
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
 2014-02-21 14:35:52 +09:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx 
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-20 16:22:17 +00:00
Stephan Bergmann
12f1faf7bf svl: sal_Bool -> bool 
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
 2014-02-20 08:17:00 +01:00
Takeshi Abe
d548b250db Drop unnecessary #include 
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
 2014-02-18 13:24:11 +09:00
Stephan Bergmann
05f742d28b comphelper: sal_Bool -> bool 
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
 2014-02-17 17:55:19 +01:00
Stephan Bergmann
faced6b5f7 ucbhelper: sal_Bool -> bool 
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
 2014-02-17 17:55:18 +01:00
Caolán McNamara
7426c9d869 coverity#737157 Uncaught exception 
Change-Id: I062dbdf7c29489111f7ba6dc37a191d835fa7824
 2014-02-13 14:56:21 +00:00
Caolán McNamara
2d72cfb502 coverity#737151 Uncaught exception 
Change-Id: I133012cf88020e38eb0fc0932979347b996943fe
 2014-02-13 14:56:20 +00:00
Caolán McNamara
beb0a165ec coverity#737149 Uncaught exception 
Change-Id: I34b31a3574e5a21a506c49b4f69f3b8c8fbdcdbd
 2014-02-13 14:56:20 +00:00
Noel Grandin
2882060775 cid#705175 missing break in switch 
Change-Id: I4565f3eab411a706eddc665b5b35f3b940b4a52c
 2014-02-12 08:59:05 +02:00
Noel Grandin
a3395aab4a cid#705174 missing break in switch 
Change-Id: Id3563f949a210ea4af59a96bbbbbb615368b06c2
 2014-02-12 08:59:05 +02:00
Andras Timar
ac6e8ac7e4 typo fixes in comments 
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
 2014-02-06 23:22:30 +01:00