mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

3705 Commits

Author SHA1 Message Date
Stephan Bergmann
5a10e33f4d Improve exception messages (for debugging) 
Change-Id: Id2e00e0b0363c58c88585dd15f34156e57a7aaac
 2013-11-01 09:00:17 +01:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Thomas Arnhold
1beabca95b remove local css namespace definitions 
As we have it globally in sal/types.h those are not necessary.

Change-Id: I18bba2c763c4680c4fa7fde4c5158953b5cfad82
 2013-10-28 15:16:17 +01:00
Michael Stahl
dd28837249 vcl: mark more Image constructors as "explicit" 
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
 2013-10-22 14:42:17 +02:00
Caolán McNamara
45e366eadb drop unnecessary tools/string includes 
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
 2013-10-20 19:00:36 +01:00
Tor Lillqvist
5c046a31e1 WaE: unused parameter 'SystemType' 
Change-Id: I52717d85269dd1802b942ba19f5710b9e469faf1
 2013-10-12 20:34:54 +03:00
Tor Lillqvist
87708fd311 Simplify 
Change-Id: Ic2afa7e60da57c5b516a043f717dea21a3cf0d55
 2013-10-12 19:17:21 +03:00
Caolán McNamara
fd4d263d2d CID#738544 unitialized member 
Change-Id: I4f2342776467594f3512af624a653a9b827a0afe
 2013-10-09 16:59:45 +01:00
Jan Holesovsky
ad7b757a25 'ist' -> 'is' here and there. 
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
 2013-10-04 20:27:30 +02:00
Tor Lillqvist
6925df8b39 WaE: unused variable 
Change-Id: I73aabeff7d28ef3526d18188c6fab2e0bc2529d7
 2013-10-02 20:04:10 +03:00
Stephan Bergmann
ed2cd062eb -Werror,-Wunused-variable 
Change-Id: I703d08f4c1080e5c5afaab9652ea2c18b4f365f1
 2013-10-02 17:48:35 +02:00
Stephan Bergmann
a1c126c264 -Werror,-Wunused-variable 
Change-Id: I548eec1fdcc862b76361c56724667f2d9f6e0950
 2013-10-02 17:35:11 +02:00
Stephan Bergmann
bdc0e87a15 -Werror,-Wunused-const-variable 
Change-Id: Iac6d103afb5d6ed3f59e589ec174f6aad253a0aa
 2013-10-02 16:49:31 +02:00
Stephan Bergmann
eb103fa411 -Werror,-Wunused-const-variable 
Change-Id: Id416a7bcb3ac3ea5354f6f7b5ec3daa1dc742f8d
 2013-10-02 16:49:31 +02:00
Stephan Bergmann
2ad1494c6b -Werror,-Wunused-const-variable 
Change-Id: I52bd479bd40031acc2742b93ab77420f26070b59
 2013-10-02 16:49:31 +02:00
Stephan Bergmann
062855b4ae -Werror,-Wunused-const-variable 
Change-Id: I93796237cb953445e42fde5822ad51bc3edcce10
 2013-10-02 16:49:31 +02:00
Andras Timar
7f436c1fd3 typo fixes in comments 
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
 2013-09-26 11:47:45 +02:00
Jesús Corrius
7d491bec40 Everytimes -> Every time 
Change-Id: Ib84cee7dbb493387760ce68c25ec442bf0a4a121
 2013-09-26 10:37:00 +02:00
Jesús Corrius
6a3cf741d1 Otherwhise -> Otherwise 
Change-Id: Iaec23e1d240f675a04b52cd251c4cb2a1242bb44
 2013-09-26 10:21:12 +02:00
Jesús Corrius
a1bc57563f Some spellchecker love in the comments 
Change-Id: I88dee4ae25ac57a78b72fa020b76e0d9b7709b31
 2013-09-26 10:02:26 +02:00
Caolán McNamara
98de5b40c8 Related: fdo#38838 remove UniString::EqualsIgnoreCaseAscii 
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
 2013-09-25 19:24:23 +02:00
Kohei Yoshida
05dd2fb998 Disable all features that rely on orcus. 
Change-Id: I6dcf91491497cd9d3662adaeceb73b4b544a56c9
 2013-09-18 22:37:58 -04:00
Caolán McNamara
0cd21c2bed drop intermediate Strings 
Change-Id: I7f730d4f5329525eda9f78514dcaa3788149d077
 2013-09-17 10:11:08 +01:00
Noel Grandin
e8ecf30ea6 convert FRAMEWORK module from String to OUString 
Change-Id: Iafa6b5f213d37093e7e46065c9264c7bb7fae377
 2013-09-17 09:05:49 +02:00
Julien Nabet
c4f5b1745c Replace char[] by OUStringBuffer/OUString 
Change-Id: I233d067b3fcb93c80ab3c458b19b4f60680fe84b
 2013-09-14 01:23:15 +02:00
Thomas Arnhold
3e55e00662 String to OUString 
This removes nearly all ToLowerAscii() calls.

Conflicts:
	linguistic/source/convdic.cxx
	linguistic/source/convdiclist.cxx
	linguistic/source/dlistimp.cxx
	sc/source/filter/html/htmlexp.cxx

Change-Id: Iddcaacfb7383e1df3d2f13751a3c788eba953fdd
Reviewed-on: https://gerrit.libreoffice.org/5895
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2013-09-13 11:30:48 +00:00
Tor Lillqvist
7323bc3405 WaE: warning C4100: 'aEvent' : unreferenced formal parameter 
I thought SAL_WARN_IF etc worked in such a way that any variables used
in the condition would be "used" from the compiler's point of view,
even in an optimising build case where SAL_DETAIL_ENABLE_LOG_WARN is
false and SAL_WARN_IF should optimise away?

Change-Id: I728e1eeb8559e1299abf403afceb0e2748d08857
 2013-09-09 22:25:50 +03:00
Stephan Bergmann
f500b2d7d9 Remove dead code 
...merged in via d02f75a8c36705924ddd6a5921fe3012fafce812 "Resolves: #i121420#
merge sidebar feature," but apparently already unused in the original AOO
commit.

Change-Id: I12e4ff05769d95a847881934eab6da722bb1950e
 2013-09-09 14:16:52 +02:00
Tor Lillqvist
c31d3ed99c One more case of explicit OUString construction needed for return statement 
Change-Id: I577aa609179cdb83124b004ff9ef5aa2123e1e5b
 2013-09-09 01:52:09 +03:00
Tor Lillqvist
2f750d86cf Try to keep older(?) gcc versions happy 
Change-Id: Id563e644356a9265ded66cf08a711078c804ac84
 2013-09-09 01:42:07 +03:00
Tor Lillqvist
a3474bab69 Try to make the Gentoo tinderbox happy with explicit OUString() values 
Change-Id: If73a84a09ad54072e1251ed2db8aacc307ff32d2
 2013-09-09 01:23:18 +03:00
Tor Lillqvist
2b3e225853 Bin some uses of the stupid DECLARE_ASCII macro 
Change-Id: I076eef8069e848ec3cf9c69f1b489ad44586324e
 2013-09-09 00:58:15 +03:00
Tor Lillqvist
1817936b28 Bin unused remains of framework's own "debug framework" 
Change-Id: I71937debf674ff11173d7d8fa5aa43dc12234ce6
 2013-09-09 00:29:23 +03:00
Tor Lillqvist
895885652e Fix non-debug build 
Change-Id: I5446c7fec62c1a934b1ffb21fefa1279b932ca09
 2013-09-09 00:13:01 +03:00
Tor Lillqvist
5bb0c9d790 Use SAL_INFO instead of framework's own "event logging" 
That "event logging" consisted of two macros, both used in a single place.

Change-Id: I8faffd9756399f1902e52aa41968b71a964a4324
 2013-09-08 23:51:41 +03:00
Tor Lillqvist
04c3f9d185 Use SAL_INFO instead of framework's own WRITE_LOGFILE 
Change-Id: Ieb1a45ca75c7a475d02535cd176396a0aeb68510
 2013-09-08 23:51:41 +03:00
Tor Lillqvist
9a8e2d09bc Use SAL_WARN_IF instead of framework's home-grown LOG_ASSERT(2) 
Also remove declarations for debug function that don't exist (have been
removed (misguidedly?) as unused perhaps).

Change-Id: I0bc3320c52b3d50dc851a07fdc30b593cc4856b1
 2013-09-08 23:51:41 +03:00
Tor Lillqvist
b022cfb6ca Get rid of some pointless SAL_INFO calls 
Change-Id: I451cacc550972a6a61e3e325936ce950bbf87475
 2013-09-08 23:51:41 +03:00
Tor Lillqvist
6aa0698828 Use SAL_INFO instead of framework's own LOG_WARNING 
Change-Id: Ief44fceaf03d2567f4aacd9ff74d361436e5e05b
 2013-09-08 23:51:41 +03:00
Tor Lillqvist
c5ab14cbaf Use SAL_INFO instead of framework's own LOG_EXCEPTION 
Change-Id: If1976d235f82267a85598d5d59d8ed332a39c792
 2013-09-08 23:51:40 +03:00
Michael Stahl
791a8b96f7 Revert "fdo#68552: Don't (attempt to) do run-time expansion of build-time parameters" 
This reverts commit ac4e19f9085dbd0103c7336a5318aa1e55b3e3e0.

Unfortunately does not work if BUILDDIR is different from SRCDIR.
 2013-09-05 18:17:00 +02:00
Tor Lillqvist
ac4e19f908 fdo#68552: Don't (attempt to) do run-time expansion of build-time parameters 
The $(share_subdir_name) things in the filter fragment .xcu files didn't
actually work it seems. But anyway, it's a bit silly to do expansion at
run-time of $(foo) things known at build-time anyway. Thanks to sberg for
pointing this out.

So just use the normal configury .in mechanism for these. Simpler.

Change-Id: I14b3e5cc5169b34df8a1d7ff07cc28452c67bcc8
 2013-09-05 13:34:25 +03:00
Eike Rathke
3945267d67 was convertIsoStringToLanguage(), use convertToLanguageTypeWithFallback() 
Change-Id: Ic08b09824cffdc9b633ba13ec3050cc109f671cd
 2013-09-03 20:35:42 +02:00
Philipp Riemer
3c48673ff7 Delete wrong comment 
This indicates that there should follow the private methods in this class.
However, the visibility constraint "private" was never in this code since it
was added in 2009. So I delete it.

See:
$> git log -u -- framework/source/uiconfiguration/imagemanagerimpl.hxx
ca00697e3dae9a03573d11281fc8d9a4ee391d3d (Sep 8th 2009)

Change-Id: Iac82b79d8cf6cc0c796a5ee97be25d2d24f4fa48
 2013-09-02 22:09:04 +02:00
Philipp Riemer
bf42b6f9f5 fdo#62475 - remove visual noise 
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
 2013-08-31 22:41:10 +02:00
Julien Nabet
6a419ad8f2 Bin intermediate iterator 
Change-Id: I49e6cd7bc6e4db95163d0b0b8c81bb4330ead081
 2013-08-27 06:57:44 +02:00
Julien Nabet
932dbfd2d1 Bin intermediate iterator + rename parameter function 
Change-Id: Ic1055af502918ee754673a6e3ad704c55ef09a36
 2013-08-27 06:32:16 +02:00
Julien Nabet
a2791f9745 Bin intermediate iterator again 
Change-Id: I6c3410e4043f6a10474f955434e8c855f60ecc80
 2013-08-27 06:30:54 +02:00
Julien Nabet
6ef19375b2 Bin intermediate iterator 
Change-Id: I6401adb29fc3fe4c8b7d420fc9bc325827ec4f21
 2013-08-27 06:29:40 +02:00
Julien Nabet
c6040d9bd4 Bin intermediate iterator + rename parameter function 
(see example of http://www.cplusplus.com/reference/vector/vector/erase/)

Change-Id: I8c0ee334abd91ea99b80a43581a04cbbf9a91fa3
 2013-08-27 06:11:07 +02:00