Stephan Bergmann
e50ef195bc
New loplugin:stringconcat
...
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Stephan Bergmann
3818cc5329
simplify
...
Change-Id: I1f44dd938bd0033ad4a5b6af4d24d1ba3e76d852
2014-07-01 12:26:51 +02:00
Stephan Bergmann
732b8be76f
Fix osl_setEnvironment args
...
Change-Id: I243ecb42d7ba2ce58f4c1a0bf97ad74de947d8bd
2014-07-01 12:25:36 +02:00
Caolán McNamara
5ace3f3b4f
clang scan-build: various warnings
...
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
Stephan Bergmann
b97c5480e9
Unused declaration
...
(which loplugin:unreffun did not catch, as it was referenced by a
friend declaration in vendorbase.hxx)
Change-Id: I8a1afd4699b56425b580c1e63557342ee7ec1cb2
2014-06-27 22:16:35 +02:00
Stephan Bergmann
e4b7da8da8
Dead declarations
...
Change-Id: I43e388df118b9e08ab8c05cad31871ef0af35164
2014-06-27 08:59:59 +02:00
Noel Grandin
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Noel Grandin
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Noel Grandin
0e507ae031
various: remove SAL_THROW macro
...
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
Caolán McNamara
15befeb90c
coverity#705191 Missing break in switch
...
Change-Id: I3e6b081711a45e6e0d77c6288ad26214b95b3dc7
2014-05-26 10:18:23 +01:00
Michael Stahl
831c8e02ca
jvmfwk: generalize (and fix) the do_msvcr71_magic to Oracle JRE 7
...
With just the Oracle JRE installed, it is not possible to load the
"jvm.dll" directly, because the required MSVC runtime DLL is not
found (unless some other software happens to install it system-wide),
as described in http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7184978
There was a hack "do_msvcr71_magic" to manually load the runtime that
is bundled with Oracle JRE 6 and this generalizes that to work with the
MSVCR100.DLL that is bundled with Oracle JRE 7 as well.
An additional adaption of the virtual addresses in the file is done,
and it's a mystery whether it even worked before without that.
This issue was not user-visible before because LO releases 3.5 - 4.2
bundle the MSVCR100.DLL themselves.
Change-Id: If61565df80ff8a68472a76000ab5b10d6c78e11c
2014-05-23 00:19:31 +02:00
Thomas Arnhold
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
Stephan Bergmann
eae3f52f94
New --disable-runtime-optimizations
...
...to better serve the needs of tools like -fsanitize=address
Change-Id: Ic2f2b981b2f5c1bc95ff91bc7a8d21fbb695dc8d
2014-05-08 14:22:00 +02:00
Stephan Bergmann
f5ed2f4e92
Resolves: rhbz#1092589 Thoroughly check whether JRE is still present
...
...not only on Mac OS X. Was able to reproduce this on Fedora 20 where current
JRE was /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.5.x86_64 but for whatever reason
there was also a left-behind /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.0.x86_64 tree
(containing just a handful of sub-dirs, but no real content) that was still
recorded in my ~/.config/libreoffice/4/user/config/javasettings_Linux_X86_64.xml
Change-Id: Ie477c5a506a430f6c29525f6c558dbc18bbf1c48
2014-05-08 13:10:46 +02:00
Stephan Bergmann
5a8b1b16de
Remove unused jfw_setJRELocations
...
Change-Id: If71cc5052f7ddfbc2d69ba01aa0cd3be2a4def8e
2014-05-08 12:58:01 +02:00
Pedro Giffuni
19c4d8d2fb
Many spelling fixes: directories h* - p*.
...
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.
(cherry picked from commit 11a1ff6144521aeabb0c6db25c89a2ac31bedee0)
Conflicts:
external/libxmlsec/xmlsec1-customkeymanage.patch
hwpfilter/source/hwpeq.cxx
icc/README
icu/createmak.pl
idl/source/objects/object.cxx
idlc/inc/idlc/errorhandler.hxx
include/jvmfwk/framework.h
include/oox/helper/propertyset.hxx
instsetoo_native/inc_ure/windows/msi_templates/_Validat.idt
javainstaller2/src/JavaSetup/org/openoffice/setup/Controller/PrologueCtrl.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Installer/LinuxInstaller.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Installer/SolarisInstaller.java
javainstaller2/src/JavaSetup/org/openoffice/setup/InstallerHelper/LinuxHelper.java
javainstaller2/src/JavaSetup/org/openoffice/setup/SetupData/ProductDescription.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Util/Controller.java
javainstaller2/src/JavaSetup/org/openoffice/setup/Util/ExecuteProcess.java
javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java
javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java
jurt/com/sun/star/comp/servicemanager/ServiceManager.java
jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
jvmfwk/source/elements.cxx
jvmfwk/source/elements.hxx
l10ntools/inc/wtranode.hxx
l10ntools/inc/wtratree.hxx
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/Convert.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/ConverterException.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/FileMaker.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/GSIWriter.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/GSIandSDFMerger.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFWriter.java
l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFWriter.java
l10ntools/scripts/localize.pl
l10ntools/scripts/localize_old.pl
l10ntools/source/cfgmerge.cxx
l10ntools/source/export.cxx
l10ntools/source/filter/merge/FCFGMerge.java
l10ntools/source/filter/merge/Merger.java
l10ntools/source/filter/utils/Cache.java
l10ntools/source/filter/utils/ConfigHelper.java
l10ntools/source/filter/utils/FileHelper.java
l10ntools/source/filter/utils/XMLHelper.java
l10ntools/source/merge.cxx
l10ntools/source/tagtest.cxx
l10ntools/source/xmlparse.cxx
l10ntools/source/xrmmerge.cxx
libtextcat/libtextcat-2.2.patch
libxml2/libxml2-long-path.patch
linguistic/inc/linguistic/misc.hxx
linguistic/source/lngsvcmgr.cxx
migrationanalysis/src/driver_docs/allstrings.ulf
migrationanalysis/src/driver_docs/sources/AnalysisDriver.bas
migrationanalysis/src/driver_docs/sources/CommonMigrationAnalyser.bas
migrationanalysis/src/driver_docs/sources/word/MigrationAnalyser.cls
migrationanalysis/src/msokill/msokill.cpp
migrationanalysis/src/wizard/Wizard.frm
odk/examples/DevelopersGuide/Accessibility/EventHandler.java
odk/examples/DevelopersGuide/Accessibility/EventListenerProxy.java
odk/examples/DevelopersGuide/Accessibility/GraphicalDisplay.java
odk/examples/DevelopersGuide/Forms/DataAwareness.java
odk/examples/DevelopersGuide/Forms/KeyGenerator.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/DocumentView.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/FunctionHelper.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/Interceptor.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/NativeView.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java
odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/ViewContainer.java
odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java
odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/FilterOptions.java
odk/examples/cpp/complextoolbarcontrols/Makefile
odk/setsdkenv_windows.template
offapi/com/sun/star/accessibility/AccessibleEventId.idl
offapi/com/sun/star/accessibility/AccessibleEventObject.idl
offapi/com/sun/star/accessibility/AccessibleRelationType.idl
offapi/com/sun/star/accessibility/XAccessible.idl
offapi/com/sun/star/accessibility/XAccessibleRelationSet.idl
offapi/com/sun/star/accessibility/XAccessibleStateSet.idl
offapi/com/sun/star/animations/Event.idl
offapi/com/sun/star/animations/XAnimationNode.idl
offapi/com/sun/star/awt/AccessibleListBoxList.idl
offapi/com/sun/star/awt/XLayoutFlow.idl
offapi/com/sun/star/awt/XMessageBoxFactory.idl
offapi/com/sun/star/awt/XPopupMenu.idl
offapi/com/sun/star/awt/grid/XGridColumn.idl
offapi/com/sun/star/chart/ChartAxis.idl
offapi/com/sun/star/chart2/data/TabularDataProviderArguments.idl
offapi/com/sun/star/chart2/data/XDatabaseDataProvider.idl
offapi/com/sun/star/configuration/AdministrationProvider.idl
offapi/com/sun/star/configuration/ConfigurationRegistry.idl
offapi/com/sun/star/configuration/backend/XBackendChangesNotifier.idl
offapi/com/sun/star/datatransfer/XDataFormatTranslator.idl
offapi/com/sun/star/datatransfer/clipboard/RenderingCapabilities.idl
offapi/com/sun/star/deployment/InvalidRemovedParameterException.idl
offapi/com/sun/star/document/DocumentInfo.idl
offapi/com/sun/star/document/EmptyUndoStackException.idl
offapi/com/sun/star/document/EventObject.idl
offapi/com/sun/star/document/ExtendedTypeDetection.idl
offapi/com/sun/star/document/ExtendedTypeDetectionFactory.idl
offapi/com/sun/star/document/FilterFactory.idl
offapi/com/sun/star/document/MediaDescriptor.idl
offapi/com/sun/star/document/NoSuchFilterRequest.idl
offapi/com/sun/star/document/OfficeDocument.idl
offapi/com/sun/star/document/TypeDetection.idl
offapi/com/sun/star/document/UndoContextNotClosedException.idl
offapi/com/sun/star/document/XExtendedFilterDetection.idl
offapi/com/sun/star/document/XFilter.idl
offapi/com/sun/star/document/XInteractionFilterSelect.idl
offapi/com/sun/star/document/XTypeDetection.idl
offapi/com/sun/star/drawing/Hatch.idl
offapi/com/sun/star/drawing/XDrawPages.idl
offapi/com/sun/star/drawing/XShapeBinder.idl
offapi/com/sun/star/drawing/framework/XConfigurationControllerRequestQueue.idl
offapi/com/sun/star/drawing/framework/XRelocatableResource.idl
offapi/com/sun/star/embed/ElementModes.idl
offapi/com/sun/star/embed/EntryInitModes.idl
offapi/com/sun/star/embed/Storage.idl
offapi/com/sun/star/embed/StorageFactory.idl
offapi/com/sun/star/embed/StorageStream.idl
offapi/com/sun/star/embed/XCommonEmbedPersist.idl
offapi/com/sun/star/embed/XEmbedObjectClipboardCreator.idl
offapi/com/sun/star/embed/XEmbeddedClient.idl
offapi/com/sun/star/embed/XInplaceClient.idl
offapi/com/sun/star/embed/XInplaceObject.idl
offapi/com/sun/star/embed/XInsertObjectDialog.idl
offapi/com/sun/star/embed/XPersistanceHolder.idl
offapi/com/sun/star/embed/XStorage.idl
offapi/com/sun/star/embed/XTransactionBroadcaster.idl
offapi/com/sun/star/embed/XTransactionListener.idl
offapi/com/sun/star/form/FormComponents.idl
offapi/com/sun/star/form/XSubmitListener.idl
offapi/com/sun/star/form/binding/BindableDataAwareControlModel.idl
offapi/com/sun/star/form/binding/BindableDatabaseListBox.idl
offapi/com/sun/star/form/component/DatabaseComboBox.idl
offapi/com/sun/star/form/component/DatabaseFormattedField.idl
offapi/com/sun/star/form/component/DatabasePatternField.idl
offapi/com/sun/star/form/component/DatabaseTextField.idl
offapi/com/sun/star/form/component/GridControl.idl
offapi/com/sun/star/frame/Components.idl
offapi/com/sun/star/frame/ContentHandler.idl
offapi/com/sun/star/frame/ContentHandlerFactory.idl
offapi/com/sun/star/frame/Desktop.idl
offapi/com/sun/star/frame/DispatchDescriptor.idl
offapi/com/sun/star/frame/DispatchProvider.idl
offapi/com/sun/star/frame/DispatchRecorder.idl
offapi/com/sun/star/frame/Frame.idl
offapi/com/sun/star/frame/FrameActionEvent.idl
offapi/com/sun/star/frame/FrameLoaderFactory.idl
offapi/com/sun/star/frame/ProtocolHandler.idl
offapi/com/sun/star/frame/XControlNotificationListener.idl
offapi/com/sun/star/frame/XDesktop.idl
offapi/com/sun/star/frame/XDispatchRecorderSupplier.idl
offapi/com/sun/star/frame/XDocumentTemplates.idl
offapi/com/sun/star/frame/XFrame.idl
offapi/com/sun/star/frame/XFrameLoader.idl
offapi/com/sun/star/frame/XInterceptorInfo.idl
offapi/com/sun/star/frame/XRecordableDispatch.idl
offapi/com/sun/star/frame/XStatusbarController.idl
offapi/com/sun/star/frame/XStorable2.idl
offapi/com/sun/star/frame/XSynchronousDispatch.idl
offapi/com/sun/star/frame/XTerminateListener2.idl
offapi/com/sun/star/graphic/GraphicObject.idl
offapi/com/sun/star/graphic/XGraphicObject.idl
offapi/com/sun/star/inspection/XNumericControl.idl
offapi/com/sun/star/inspection/XObjectInspectorModel.idl
offapi/com/sun/star/inspection/XPropertyHandler.idl
offapi/com/sun/star/installation/XProtocolHandlerCheck.idl
offapi/com/sun/star/installation/protocols.idl
offapi/com/sun/star/linguistic2/SpellFailure.idl
offapi/com/sun/star/linguistic2/XLinguServiceManager.idl
offapi/com/sun/star/mail/XMailServer.idl
offapi/com/sun/star/mozilla/XPluginInstance.idl
offapi/com/sun/star/mozilla/XPluginInstanceSyncPeer.idl
offapi/com/sun/star/packages/zip/ZipIOException.idl
offapi/com/sun/star/presentation/OutlineView.idl
offapi/com/sun/star/presentation/XPresentation2.idl
offapi/com/sun/star/presentation/XSlideShow.idl
offapi/com/sun/star/presentation/XSlideShowController.idl
offapi/com/sun/star/report/XFunction.idl
offapi/com/sun/star/report/XFunctionsSupplier.idl
offapi/com/sun/star/report/XReportComponent.idl
offapi/com/sun/star/report/XReportDefinition.idl
offapi/com/sun/star/report/meta/XFunctionManager.idl
offapi/com/sun/star/resource/XStringResourcePersistence.idl
offapi/com/sun/star/resource/XStringResourceWithLocation.idl
offapi/com/sun/star/resource/XStringResourceWithStorage.idl
offapi/com/sun/star/sdb/DataSettings.idl
offapi/com/sun/star/sdb/ErrorCondition.idl
offapi/com/sun/star/sdb/SQLContext.idl
offapi/com/sun/star/sdb/Table.idl
offapi/com/sun/star/sdb/XRowSetApproveListener.idl
offapi/com/sun/star/sdb/application/XDatabaseDocumentUI.idl
offapi/com/sun/star/sdb/tools/XConnectionTools.idl
offapi/com/sun/star/sdbc/DataType.idl
offapi/com/sun/star/sdbc/XDatabaseMetaData.idl
offapi/com/sun/star/sdbcx/Descriptor.idl
offapi/com/sun/star/security/DocumentSignatureInformation.idl
offapi/com/sun/star/sheet/AccessibleSpreadsheetDocumentView.idl
offapi/com/sun/star/sheet/AccessibleSpreadsheetPageView.idl
offapi/com/sun/star/sheet/DatabaseRange.idl
offapi/com/sun/star/smarttags/XSmartTagAction.idl
offapi/com/sun/star/table/AccessibleTableView.idl
offapi/com/sun/star/table/CellProperties.idl
offapi/com/sun/star/table/CellRangeListSource.idl
offapi/com/sun/star/table/CellValueBinding.idl
offapi/com/sun/star/table/XMergeableCellRange.idl
offapi/com/sun/star/task/DocumentPasswordRequest.idl
offapi/com/sun/star/task/JobExecutor.idl
offapi/com/sun/star/task/MasterPasswordRequest.idl
offapi/com/sun/star/task/PasswordRequest.idl
offapi/com/sun/star/task/XJob.idl
offapi/com/sun/star/text/AccessiblePageView.idl
offapi/com/sun/star/text/AccessibleTextDocumentView.idl
offapi/com/sun/star/text/LineNumberingProperties.idl
offapi/com/sun/star/text/NumberingRules.idl
offapi/com/sun/star/text/XRelativeTextContentRemove.idl
offapi/com/sun/star/text/textfield/Database.idl
offapi/com/sun/star/text/textfield/SetExpression.idl
offapi/com/sun/star/text/textfield/docinfo/Description.idl
offapi/com/sun/star/text/textfield/docinfo/Info0.idl
offapi/com/sun/star/text/textfield/docinfo/Info1.idl
offapi/com/sun/star/text/textfield/docinfo/Info2.idl
offapi/com/sun/star/text/textfield/docinfo/Info3.idl
offapi/com/sun/star/text/textfield/docinfo/Keywords.idl
offapi/com/sun/star/text/textfield/docinfo/Revision.idl
offapi/com/sun/star/text/textfield/docinfo/Subject.idl
offapi/com/sun/star/text/textfield/docinfo/Title.idl
offapi/com/sun/star/ucb/CommandFailedException.idl
offapi/com/sun/star/ucb/Content.idl
offapi/com/sun/star/ucb/ContentAction.idl
offapi/com/sun/star/ucb/FetchError.idl
offapi/com/sun/star/ucb/FetchResult.idl
offapi/com/sun/star/ucb/HierarchyDataSource.idl
offapi/com/sun/star/ucb/InteractiveFileIOException.idl
offapi/com/sun/star/ucb/SearchRecursion.idl
offapi/com/sun/star/ucb/UniversalContentBroker.idl
offapi/com/sun/star/ucb/XAnyCompare.idl
offapi/com/sun/star/ucb/XCachedContentResultSetFactory.idl
offapi/com/sun/star/ucb/XCachedDynamicResultSetFactory.idl
offapi/com/sun/star/ucb/XContentIdentifierMapping.idl
offapi/com/sun/star/ui/UIElementType.idl
offapi/com/sun/star/ui/dialogs/FilePicker.idl
offapi/com/sun/star/ui/dialogs/FolderPicker.idl
offapi/com/sun/star/util/PathSubstitution.idl
offapi/com/sun/star/util/XChangesNotifier.idl
offapi/com/sun/star/util/XCloseBroadcaster.idl
offapi/com/sun/star/util/XCloseListener.idl
offapi/com/sun/star/util/XCloseable.idl
offapi/com/sun/star/util/XStringSubstitution.idl
offapi/com/sun/star/util/XTextSearch.idl
offapi/com/sun/star/util/XURLTransformer.idl
offapi/com/sun/star/xforms/XModel.idl
offapi/com/sun/star/xml/sax/XFastAttributeList.idl
offapi/com/sun/star/xml/sax/XFastParser.idl
officecfg/registry/data/org/openoffice/Office/Labels.xcu
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
officecfg/registry/schema/org/openoffice/Office/Common.xcs
officecfg/registry/schema/org/openoffice/Office/Embedding.xcs
officecfg/registry/schema/org/openoffice/Office/ExtensionDependencies.xcs
officecfg/registry/schema/org/openoffice/Office/ExtensionManager.xcs
officecfg/registry/schema/org/openoffice/Office/Histories.xcs
officecfg/registry/schema/org/openoffice/Office/OptionsDialog.xcs
officecfg/registry/schema/org/openoffice/Office/Paths.xcs
officecfg/registry/schema/org/openoffice/Office/PresenterScreen.xcs
officecfg/registry/schema/org/openoffice/Office/TabBrowse.xcs
officecfg/registry/schema/org/openoffice/Office/UI.xcs
officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
officecfg/registry/schema/org/openoffice/Office/UI/WindowState.xcs
officecfg/registry/schema/org/openoffice/Office/WebWizard.xcs
officecfg/registry/schema/org/openoffice/Office/Writer.xcs
officecfg/registry/schema/org/openoffice/Setup.xcs
officecfg/registry/schema/org/openoffice/TypeDetection/Types.xcs
oox/source/xls/sheetdatabuffer.cxx
package/source/xstor/xstorage.cxx
padmin/source/padialog.src
postprocess/signing/signing.pl
pyuno/source/module/pyuno_module.cxx
Change-Id: I60c7b6d661ff803b5e9214ac7fefb32772ef19a7
2014-04-30 17:11:30 +01:00
Takeshi Abe
1a5457a11c
Avoid possible memory leaks in case of exceptions
...
Change-Id: I4b2b439615db0ff4598f405d1e339eebbff7ae91
2014-04-21 22:29:09 +09:00
Andras Timar
c79a5f87b1
remove executable bit
...
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-04-17 15:11:14 +02:00
Thomas Arnhold
fa1f7d27c1
typo: attribut -> attribute
2014-04-14 12:32:59 +02:00
Stephan Bergmann
5180805c3f
Clean up function declarations
...
Change-Id: I0ad09f02d1d09d6ce45bc204c8cd8d26ef663ddb
2014-04-09 10:42:38 +02:00
Stephan Bergmann
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Noel Grandin
86a32589e9
Find places where OUString and OString are passed by value.
...
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
Alexander Wilms
132d7941e0
Remove visual noise from jvmfwk
...
Change-Id: Ie9ad9478532b395bd6a2bddd54bbe0d10b1b5eb2
Reviewed-on: https://gerrit.libreoffice.org/8277
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:11:54 -06:00
Stephan Bergmann
0274246d08
Support OpenJDK "-internal" version suffix
...
...as e.g. produced by java-1.8.0-openjdk.fc20
(Sorting Rel_INTERNAL < Rel_EA is somewhat arbitrary.)
Change-Id: I25449ec4da63243fc1044aae366f8fa6c5ef1eb5
2014-02-18 16:41:22 +01:00
Stephan Bergmann
f2529fc744
jvmfwk: sal_Bool -> bool
...
Change-Id: I35f302006cb9ef6e98a041dea811818b98c0e876
2014-02-18 12:17:37 +01:00
Stephan Bergmann
237d2c923b
Don't set JAVA_HOME on Mac OS X
...
...for one, it doesn't appear necessary there ("needed for awt"), and for
another setting it according to Oracle's JRE 7 would prevent a subsequent
visit to the Advanced preferences pane from listing Apple's JRE 6, as launching
that java and reading its system properties would be fooled by the JAVA_HOME and
report the Oracle system properties instead.
Change-Id: I02d82de6113b44b3cae3fb55cd83177fe852d769
2014-02-12 08:12:53 +01:00
Stephan Bergmann
ba826a22c6
Simplify string handling
...
Change-Id: I1b79bfd7e7e92fc8f4937e6b9ae9ec9468839ea6
2014-02-12 08:07:48 +01:00
Stephan Bergmann
6c697a99c9
Related fdo#74597: Java on Mac doesn't use javaldx/library path fiddling
...
...so no need to return non-empty SunInfo::getLibraryPaths (for the Oracle JRE,
cf. how this had always returned an empty set for the Apple JRE in
otherjre.cxx).
This fixes the bug that selecting the Oracle JRE in the Advanced options pane
didn't stick, because jfw_areEqualJavaInfo was called on a JavaInfo read back
from XML where nRequirements had been cleared (in CNodeJavaInfo::loadFromNode)
and a JavaInfo where non-empty SunInfo::getLibraryPaths ->
VendorBase::needsRestart() == true -> nRequirements == JFW_REQUIRE_NEEDRESTART,
so always returned false.
(There's multiple errors here. It is questionable whether jfw_areEqualJavaInfo
should take nRequirements into account, at least when used from
SvxJavaOptionsPage. And VendorBase::getLibraryPaths appears to be only used to
compute VendorBase::needsRestart, ignoring the actual path data. But leave that
for future clean-up.)
Change-Id: I5f004434b1cb7e909a153c43c474a2317f24b0c1
2014-02-11 14:21:07 +01:00
Stephan Bergmann
471cbb0522
bool improvements
...
Change-Id: I418611622b4b47ed5a4fa2ab99afb25371b186f6
2014-01-28 20:26:26 +01:00
Stephan Bergmann
65191cda81
bool improvements
...
Change-Id: I757e19313576d2c3d13af1cb720f182f0de91613
2014-01-27 10:47:32 +01:00
Caolán McNamara
def94cc40e
coverity#705670 Resource leak
...
Change-Id: Ib89a580127d91e9d7a23b998df3cd100246bf289
2014-01-24 15:09:41 +00:00
Stephan Bergmann
e3133ae237
Let C++ inline functions return bool instead of sal_Bool
...
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
2014-01-23 18:43:53 +01:00
Stephan Bergmann
e7f7b1d09c
bool improvements
...
Change-Id: Ic4572480d48e341c8fa611a3283efc351f530eb5
2014-01-21 13:24:30 +01:00
Noel Grandin
08fe82e59c
Remove unnecessary use of OUString constructor in + expressions
...
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
Noel Grandin
73342dbb82
remove unnecessary RTL_CONSTASCII_STRINGPARAM
...
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.
Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-22 08:07:19 +02:00
Noel Grandin
e52779d2f8
remove unnecessary use of OUString constructor
...
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
Noel Grandin
e2451bd729
Convert indexOf->startsWith and lastIndexOf->endsWith
...
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
Michael Meeks
72b954df59
Avoid using gconftool. Atk provides a11y not Java on Unix.
...
cf. comment in framework header. Should have no impact on real
run-time Java a11y, which would be enabled later as-needed; only
on JRE selection. For extreme corner-cases, where your auto-selected
JRE has no a11y support either select another JRE in the UI or:
$ export JFW_PLUGIN_FORCE_ACCESSIBILITY=1
to override.
Change-Id: I59a6428e5a11664b75c29580cad76eb9500db45a
2013-10-30 11:09:55 +00:00
Michael Stahl
bf0e30f9cd
jvmfwk: remove Package_*solver
...
Change-Id: I5784f3c060680c366053334db8a879250bfdbbbe
2013-10-28 20:17:26 +01:00
Michael Stahl
8df17a3409
gbuild: set Package default target to INSTDIR
...
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28 20:17:26 +01:00
Michael Stahl
176782e303
jvmfwk: rewrite odd conditional
...
Change-Id: I69f8e44b0845ac2d6db5a32298de1b561be61f2c
2013-10-28 20:17:25 +01:00
Stephan Bergmann
658e88c59d
Improve debug output (and some clean up)
...
Change-Id: Ibce90b4eeab679d526f0e0b1e9a8ab3b14255622
2013-10-28 16:09:06 +01:00
Markus Mohrhard
4badcfda55
Revert "Related: #i119525# List only JREs whose jvm library can be loaded"
...
This reverts commit 37ca14359b8c4027f1d9f9569ddfa2740cd2731e.
This breaks the loading of the jvm.dll on Windows if the msvcr*.dll is
not in the system path.
2013-10-14 06:10:15 +02:00
Tor Lillqvist
01e1a2465e
URE folder path fixes for the HAVE_FEATURE_MACOSX_MACLIKE_APP_STRUCTURE case
...
Change-Id: I5019cce2172db7b3ac74e25f5ea9dc62e9fd03f8
2013-10-05 21:10:42 +03:00
Tor Lillqvist
4c63fd10a5
Try to fix cross-compilation
...
Add more FOO_FOR_BUILD variables and some gb_Foo_for_build functions.
Get rid of gb_INSTROOT and gb_DEVINSTALLROOT, just use INSTROOT.
Change-Id: Iee531b02d14fae41edb68ad589a5dec829a60255
2013-09-23 00:54:43 +03:00
Stephan Bergmann
a041f518af
Still copy jvmfwk support files to solver
...
...instead of only to instdir, as happened after
2e47462d076364725875e770a91a7bb6bbbec2c1 "jvmfwk: install also into instdir," so
that CppunitTests (which still run against solver) can use jvmfwk. This will
become moot when solver is eventually dropped.
Change-Id: Ic2cdbf32e20a79f8cc6ac2088e4bc47dcd6f5cc5
2013-09-16 11:39:24 +02:00
Stephan Bergmann
5397b49f4d
Towards a working instdir for Mac OS X
...
Introduced gb_INSTROOT, which is the same as $(INSTDIR) except for Mac OS X,
where it is $(INSTDIR)/LibreOffice.app/Contents. Most stuff ends up there (so
most occurrences of $(INSTDIR) have been replaced with $(gb_INSTROOT)), but SDK-
related stuff goes to $(INSTDIR)/$(gb_Package_SDKDIRNAME). (And
GeneratedPackage needed to be made more flexible, to allow for packages that go
into either of those two places.)
For Android and iOS, gb_INSTROOT probably still needs to be set.
The most obvious missing thing yet to make instdir work for Mac OS X is the
instdir/*/LibreOffice.app/Contents/ure/ vs.
instdir/*/LibreOffice.app/Contents/ure-link/ split.
Change-Id: I4478edd27b14c92c96d92d5169bdca3ec50d78f5
2013-09-11 00:50:54 +02:00
Matúš Kukan
2e47462d07
jvmfwk: install also into instdir
...
Change-Id: I4004361a85af4e6aed9dd0951d1154a2d99f97e7
2013-09-09 22:09:00 +02:00
Stephan Bergmann
644c33a857
fdo#67313: Use "lo" suffix for private URE libs
...
...(like is done for most of LO's non-URE libs already) to reduce likelihood of
name clashes, esp. on Windows where URE libs are found via PATH.
This introduces PRIVATELIBS_URE, and removes now-unused UNOLIBS_URE.
Change-Id: Ib95dd45f18de140a54e62d632dbf2239f83c232e
2013-08-27 14:03:36 +02:00
Luboš Luňák
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
