mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

998 Commits

Author SHA1 Message Date
Caolán McNamara
356263dcdb coverity#982468 Unchecked dynamic_cast 
Change-Id: Ie98fa4199ebfa96495bdb7fa4582b09926fac8f1
 2014-03-25 17:03:49 +00:00
Vort
53cbca6ee1 fdo#44710 PDF Import: Correction of position of rotated text 
Change-Id: Ie53b25a6cec88c07a317c50bd0965282fac64ff0
Reviewed-on: https://gerrit.libreoffice.org/8725
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-03-23 11:42:39 +00:00
Noel Grandin
86a32589e9 Find places where OUString and OString are passed by value. 
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
 2014-03-18 08:32:26 +02:00
Stephan Bergmann
54b4add666 Remove unused HelpCloseListener 
Change-Id: I9040a1262b31f8d0f19594b6efcf12b2c38be7be
 2014-03-12 16:24:43 +01:00
Vort
7963d2b0f6 fdo#40513 PDF Import: Hack: Replace incorrect values of font's ascent property 
Change-Id: Ib7bd6e15fff5213b5d935c6f03f2c65ea3f6ca50
Reviewed-on: https://gerrit.libreoffice.org/8416
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-03-03 09:20:24 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
e6bd9d718d Remove visual noise from sdext 
Change-Id: I792249b9e92db9af4daee0bd835e04044d29bca5
Reviewed-on: https://gerrit.libreoffice.org/8308
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 08:19:03 -06:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Caolán McNamara
0ac8d57b0c coverity#983817 Uncaught exception 
Change-Id: I91883489d9557c5e3779c6b16bf377c1b95e49da
 2014-02-23 03:28:23 +00:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx 
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-20 16:22:17 +00:00
Vort
7f8e774119 fdo#75195 PDF import: Revert commit 128adf7e5c06fff378c8d72b44ec4be1e462984f 
Change-Id: Icb03088809e57a388317f98046f9de3197772a41
Reviewed-on: https://gerrit.libreoffice.org/8126
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-20 14:03:34 +00:00
Noel Grandin
97a185d8b9 cid#983380 Dereference before null check 
Change-Id: I9504738a5291b85362a80e630d9e413825fa6572
 2014-02-20 09:31:11 +02:00
Vort
988b695bcc fdo#37246 PDF Import: Color to string conversion fix 
Change-Id: I5ec9f0246f6c2d1b12a389906d04133b2f5a6f9f
Reviewed-on: https://gerrit.libreoffice.org/8106
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-18 20:19:17 +00:00
Vort
9616b786ad fdo#45003 PDF import: Implementing linejoin and linecap properties 
Change-Id: I4b09cd7b970d5aca4500ae333edef0e4c2f618b9
Reviewed-on: https://gerrit.libreoffice.org/8009
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-12 10:48:51 +00:00
Julien Nabet
4415f6b7b1 cppcheck: duplicateExpression 
See http://nabble.documentfoundation.org/Cppcheck-Same-expression-on-both-sides-of-in-PresenterPaneBorderManager-cxx-sdext-td4094873.html

Change-Id: I7dbb8d0254ca77127250d6ca02de7b945ef8051e
 2014-02-08 09:09:02 +01:00
Vort
9db3b5585c fdo#35143 PDF import: Reimplementation of whitespace detection function 
Change-Id: I5b230aaebf72b70bbb7e206414a5ac0e01f01f86
Reviewed-on: https://gerrit.libreoffice.org/7564
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-04 15:13:15 +00:00
Alexandre Vicenzi
32b8c5c4a9 fdo#54938 Convert basctl, mysqlc, sdext, svgio, writerp. to cppu::supportsSer. 
Change-Id: I60128dbb5bf83f25eea847fe655d7126c9077414
Reviewed-on: https://gerrit.libreoffice.org/7756
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
 2014-02-02 18:53:03 +00:00
Stephan Bergmann
e7d1a81ee3 bool improvements 
Change-Id: I969de97522ae2e3f8693e82a500a73e28451ef77
 2014-01-28 20:26:22 +01:00
Stephan Bergmann
a3f32769fc Fix bogus mass-conversion equalsAsciiL -> startsWith 
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.

Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
 2014-01-21 15:54:52 +01:00
Stephan Bergmann
7cc255c9df Use proper bool operations 
Change-Id: If9d439faba5a02b50152dfa1090b9eb1afa0fc18
 2014-01-10 17:11:48 +01:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Jelle van der Waa
6e06bd6cb5 fdo#72598 Remove SunStudio cruft from code base 
Change-Id: I8dfbbb36cca3cf71c8d347b248dd206c447db6d2
Reviewed-on: https://gerrit.libreoffice.org/7136
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2013-12-18 15:53:50 +00:00
Stephan Bergmann
8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp 
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
 2013-12-17 17:32:58 +01:00
Jelle van der Waa
417c85bf58 fdo#72598 Remove SunStudio cruft from code base 
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc
Reviewed-on: https://gerrit.libreoffice.org/7104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2013-12-17 11:57:04 +00:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Noel Grandin
2ac31b06ae Unnecessary use of OUString constructor inside OUStringBuffer constructor 
Convert code like:
    OUStringBuffer sVal(OUString("0x"));
to:
    OUStringBuffer sVal("0x");

Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
 2013-12-17 11:49:05 +02:00
Noel Grandin
8548abbac5 Remove unnecessary use of OUString constructor in OUStringBuffer::append calls 
Convert code like
  aStrBuffer.append(OUString(" AS "));
to
  aStrBuffer.append(" AS ");

Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
 2013-12-17 11:49:04 +02:00
Noel Grandin
08fe82e59c Remove unnecessary use of OUString constructor in + expressions 
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
 2013-12-17 11:49:03 +02:00
Michael Stahl
de45a49273 sdext: clean up some pointless #ifdefs 
Change-Id: Ic23c0ccc45d7a98b3581feab43fc4c8c8aef9013
 2013-12-05 13:00:26 +01:00
Takeshi Abe
3b2f956ba6 Drop duplicate #include 
Change-Id: Ife8ebbb5e46704c5d2ff46cc345b4ed926e7dc12
 2013-12-02 01:02:06 +09:00
Thorsten Behrens
05d2994c13 Further XCanvas != XBitmapCanvas cleanup. 
It seems I missed a few places in
21ec9beae29b19b8ec6f0a16fd0e708e4f210208, getting that straight
now hopefully.

Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
 2013-11-29 18:26:48 +01:00
Thorsten Behrens
1b10205c2c Fix fdo#71527 no unguarded ptr dereference here. 
This is the real problem - mxPane can be validly NULL.

Change-Id: Ie8d055db9bfb68cb9031fa970518343f5aec6619
 2013-11-29 18:26:28 +01:00
Thorsten Behrens
b807b2d929 Revert "Resolves: fdo#71527 don't crash in presenter console" 
This reverts commit bae01385c895a100b5371879889e606927cff877.

Change-Id: Id149bae0904fd6c2120209d69490d0b257ac3f64
 2013-11-29 18:26:17 +01:00
Noel Grandin
6eac9deadd remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsL 
Convert code like this:
    if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aStr == "rem")
which compiles down to the same code.

Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
 2013-11-21 13:29:29 +02:00
Noel Grandin
d454834895 Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls" 
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.

I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
 2013-11-20 16:38:28 +02:00
Noel Grandin
acebbee971 remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls 
Convert code like:
    if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aByteStr.startsWith("rem"))

Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
 2013-11-20 13:56:08 +02:00
Caolán McNamara
bdc7cf264a cppcheck: Variable is reassigned a value before the old one has been used 
Change-Id: Ifc16473c426bca2235e84b0d71291756074712bb
 2013-11-20 09:32:17 +00:00
Caolán McNamara
bae01385c8 Resolves: fdo#71527 don't crash in presenter console 
but we're now dropping slides in there for some reason so
this is just a don't crash band-aid and not the fix
for the deeper problem

Change-Id: I2f70471d03979ffb86b6289e7a432f4505c1b556
 2013-11-20 09:21:44 +00:00
Noel Grandin
3af99e4d59 convert equalsAsciiL calls to startsWith calls 
Convert code like:
    aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
    aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.

Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
 2013-11-20 10:07:31 +02:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Michael Stahl
7379d2cf98 GCC diagnostic push / pop requires HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE 
Change-Id: I0765649b94b370caf92a29a8ff2224e335196612
 2013-11-14 16:03:20 +01:00
Stephan Bergmann
e537c807fb -Werror,-Wunused-member-function 
SimpleView had been unused since its inception in
b561e658ebed8cfcfd18dc90bd25de9134341fb3 "INTEGRATION: CWS presenterview."

Change-Id: Ieb3af55c4cfebd24fe229c847f38ca108ae3401e
 2013-11-14 10:15:05 +01:00
Stephan Bergmann
b83774a7c5 -Werror,-Wunused-member-function 
Change-Id: Ie8f3502c735cf38e21f2f55f27d384dbe3d8d5ef
 2013-11-14 10:15:00 +01:00
Stephan Bergmann
44322852b8 -Werror,-Wunused-member-function 
Change-Id: I745ceb72423b120ef42437778e3a5fe05bd7b42b
 2013-11-14 10:15:00 +01:00
Stephan Bergmann
198a35a1a8 -Werror,-Wunused-member-function 
Change-Id: I17160893b759f4dee1871e8f6d6525d327cf8cd6
 2013-11-14 10:14:59 +01:00
Stephan Bergmann
b20d87f466 -Werror,-Wunused-member-function 
...the whole ChooserDialogHandler class is unused since before
bdc71b3e4112b5c83a6aec61403981fcdd156138 "remove non-compiled code" removed its
sole, #if'ed out use.

Change-Id: If94db1c98074132952dd204864a478e1e12d455d
 2013-11-14 10:14:57 +01:00
Stephan Bergmann
e0cbd673c2 -Werror,-Wunused-exception-parameter 
Change-Id: Ibcda8d872ad89a363f71bc4d5aa92b6bae2d2608
 2013-11-14 10:14:57 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Michael Stahl
acf93bbc97 remove more pragma instances of GCC system_header 
Use "#pragma GCC diagnostic ignored" instead which does not prevent
generation of dependencies.

Change-Id: Ic9034f20ef71c1ee6e5363b73c831142c2813d20
 2013-11-14 00:04:16 +01:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00