which means that icons suddenly reappeared in the menus when the gtk
theme had disabled them
ref e8f8f24c8415898c787bbfb629247ed62e73a2b9
Change-Id: Ia9aef5ca39bda2ddf6d7c4ebc2bddc01d470d09b
...seen CppunitTest_dbaccess_dialog_save fail with
> abort
> __assert_rtn
> ImplDbgTestSolarMutex at vcl/source/app/dbggui.cxx:1678
> DbgFunc at tools/source/debug/debug.cxx:1123
> DbgTestSolarMutex at debug.hxx:286
> OutputDevice::ImplGetGraphics at vcl/source/gdi/outdev.cxx:525
> OutputDevice::GetFontCharMap at vcl/source/gdi/outdev3.cxx:7740
> OutputDevice::HasGlyphs at vcl/source/gdi/outdev3.cxx:7810
> Window::ImplCheckUIFont at vcl/source/window/window.cxx:447
> Window::ImplUpdateGlobalSettings at vcl/source/window/window.cxx:471
> Application::MergeSystemSettings at vcl/source/app/svapp.cxx:495
> SvtMiscOptions_Impl::SetIconTheme at svtools/source/config/miscopt.cxx:592
> SvtMiscOptions_Impl::SetIconThemeAutomatically at svtools/source/config/miscopt.cxx:934
> SvtMiscOptions_Impl::Load at svtools/source/config/miscopt.cxx:514
> SvtMiscOptions_Impl at svtools/source/config/miscopt.cxx:299
> SvtMiscOptions_Impl at svtools/source/config/miscopt.cxx:425
> SvtMiscOptions at svtools/source/config/miscopt.cxx:753
> SvtMiscOptions at svtools/source/config/miscopt.cxx:756
> connectivity::DriversConfigImpl::Load at connectivity/source/commontools/DriversConfig.cxx:106
> connectivity::DriversConfigImpl::getInstalledDrivers at DriversConfig.hxx:53
> connectivity::DriversConfig::getURLs at connectivity/source/commontools/DriversConfig.cxx:243
> ODsnTypeCollection at dbaccess/source/core/misc/dsntypes.cxx:60
> ODsnTypeCollection at dbaccess/source/core/misc/dsntypes.cxx:71
> DatasourceURLListener at dbaccess/source/filter/xml/xmlfilter.cxx:183
> DatasourceURLListener at dbaccess/source/filter/xml/xmlfilter.cxx:183
> dbaxml::ODBFilter::implImport at dbaccess/source/filter/xml/xmlfilter.cxx:451
> dbaxml::ODBFilter::filter at dbaccess/source/filter/xml/xmlfilter.cxx:404
> non-virtual thunk to dbaxml::ODBFilter::filterat dbaccess/source/filter/xml/xmlfilter.cxx:415
> dbaccess::ODatabaseDocument::impl_import_nolck_throw at dbaccess/source/core/dataaccess/databasedocument.cxx:520
> dbaccess::ODatabaseDocument::load at dbaccess/source/core/dataaccess/databasedocument.cxx:585
> non-virtual thunk to dbaccess::ODatabaseDocument::loadat dbaccess/source/core/dataaccess/databasedocument.cxx:602
> dbaxml::DBContentLoader::load at dbaccess/source/filter/xml/dbloader2.cxx:484
> non-virtual thunk to dbaxml::DBContentLoader::loadat dbaccess/source/filter/xml/dbloader2.cxx:553
> framework::LoadEnv::impl_loadContent at framework/source/loadenv/loadenv.cxx:1177
> framework::LoadEnv::startLoading at framework/source/loadenv/loadenv.cxx:401
> framework::LoadEnv::loadComponentFromURL at framework/source/loadenv/loadenv.cxx:172
> framework::Desktop::loadComponentFromURL at framework/source/services/desktop.cxx:603
> non-virtual thunk to framework::Desktop::loadComponentFromURLat framework/source/services/desktop.cxx:604
> unotest::MacrosTest::loadFromDesktop at unotest/source/cpp/macros_test.cxx:43
> DialogSaveTest::test at dbaccess/qa/extras/dialog-save.cxx:73
> CppUnit::TestCaller<DialogSaveTest>::runTest at TestCaller.h:166
> CppUnit::TestCaseMethodFunctor::operatorat TestCase.cpp:32
> (anonymous namespace)::Prot::protect at unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:88
> CppUnit::ProtectorChain::ProtectFunctor::operatorat ProtectorChain.cpp:20
> (anonymous namespace)::Prot::protect at unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:64
> CppUnit::ProtectorChain::ProtectFunctor::operatorat ProtectorChain.cpp:20
> CppUnit::DefaultProtector::protect at DefaultProtector.cpp:15
> CppUnit::ProtectorChain::ProtectFunctor::operatorat ProtectorChain.cpp:20
> CppUnit::ProtectorChain::protect at ProtectorChain.cpp:77
> CppUnit::TestResult::protect at TestResult.cpp:181
> CppUnit::TestCase::run at TestCase.cpp:91
> CppUnit::TestComposite::doRunChildTests at TestComposite.cpp:64
> CppUnit::TestComposite::run at TestComposite.cpp:23
> CppUnit::TestComposite::doRunChildTests at TestComposite.cpp:64
> CppUnit::TestComposite::run at TestComposite.cpp:23
> CppUnit::TestRunner::WrappingSuite::run at TestRunner.cpp:47
> CppUnit::TestResult::runTest at TestResult.cpp:148
> CppUnit::TestRunner::run at TestRunner.cpp:96
> (anonymous namespace)::ProtectedFixtureFunctor::run at sal/cppunittester/cppunittester.cxx:150
> sal_main at sal/cppunittester/cppunittester.cxx:242
> main at sal/cppunittester/cppunittester.cxx:166
Change-Id: I217499b41027449df634945c4b260aafdfc4bff4
The hard-coded icon themes have been replaced by a dynamic list
which is filled by scanning the config directory
Conflicts:
include/vcl/settings.hxx
vcl/source/app/settings.cxx
vcl/source/window/window.cxx
Change-Id: Ie3680ffe27d06e375acf22753e036cb6ddabc4ed
Reviewed-on: https://gerrit.libreoffice.org/7935
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.
Conflicts:
sc/source/ui/dbgui/pvlaydlg.cxx
Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This reverts commit 277922e7a0a4ae8076c10936c4b12df6dcc5ddac.
...since 73e3aafa990168aa532fa7b81fc4de8f455b10e1 was reverted and
sw_htmlexport test fails.
Change-Id: I32a390a3058e43bc3314b678e27c74036b90f200
This reverts commit 700883b34ebcdb77f398b4423f358bdf4648a853.
...since 73e3aafa990168aa532fa7b81fc4de8f455b10e1 was reverted and
sw_htmlexport test fails.
Change-Id: Ia83705279e792a0c2375619b6a209e46a319fea7
Convert the template based read_lenPrefixed methods to regular
methods.
Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
git grep found nowhere in the codebase that this define is being
set.
Change-Id: I63e18e8f47b5e58ff96b075ddb4bc9a36e1dc80e
Reviewed-on: https://gerrit.libreoffice.org/8002
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
