Noel Grandin
a4dc5ea2f7
svtools: sal_Bool->bool
...
Change-Id: I288a5c8b86d21a1b91f464aaf162aed9aca35a42
2014-03-24 08:12:10 +02:00
Noel Grandin
b41badb803
svtools: sal_Bool->bool
...
Change-Id: I37352e90a5304e75ce0c8ae922a167b1e70625e8
2014-03-24 08:12:10 +02:00
Noel Grandin
f7074d8de5
svtools: sal_Bool->bool
...
Change-Id: I2044e6c1f15579b6051fad5d36fcfa8795f88953
2014-03-24 08:12:10 +02:00
Noel Grandin
7a679ee19c
svtools: sal_Bool->bool
...
Change-Id: I35c9c1514c67860e61b6e2457ab4548d04a4d159
2014-03-24 08:12:10 +02:00
Noel Grandin
554e54429c
svtools: sal_Bool->bool
...
Change-Id: Ic9b4838c4d1b4d2d2ea4665811dd396bdbec31b7
2014-03-24 08:12:09 +02:00
Noel Grandin
9604eb8758
svtools: sal_Bool->bool
...
Change-Id: I8f171f7f61ea06a79183e9bf9b15b8c35c98cc9b
2014-03-24 08:12:09 +02:00
Noel Grandin
f661ac03e0
svtools: sal_Bool->bool
...
Change-Id: I22d8869551f46d2a0607f670f937853f394b6acf
2014-03-24 08:12:09 +02:00
Noel Grandin
b1de52241c
svtools: sal_Bool->bool
...
Change-Id: Iaa489318f25107e91fc8133523fbd9d724493314
2014-03-24 08:12:08 +02:00
Noel Grandin
1a1fe47731
svtools: sal_Bool->bool
...
Change-Id: I0c2e9314d85860831b29db76c89c8776c1b071b9
2014-03-24 08:12:08 +02:00
Noel Grandin
cafdef8109
svtools: sal_Bool->bool
...
Change-Id: I56072620f9ea28833e1590a7fff7d71ed11fc34c
2014-03-24 08:12:08 +02:00
Noel Grandin
9f12e4a351
svtools: sal_Bool->bool
...
Change-Id: Ic765d1a28960dbeca9501852b5e84cfdfe6ac47e
2014-03-24 08:12:07 +02:00
Noel Grandin
83d807ba78
svtools: sal_Bool->bool and remove virtual
...
remove virtual from AcceleratorExecute::execute because nothing
seems to override it.
Change-Id: Idac00ce421f2a46921347b976b7658aac9097ee2
2014-03-24 08:12:07 +02:00
Caolán McNamara
f5179bcbac
just give the enclosing frame the required helpid
...
Change-Id: Ifb0209eaea4f738ac5b5826f924552465cccc272
2014-03-21 15:15:15 +00:00
Caolán McNamara
d1a8a119f2
coverity#708279 Uninitialized pointer field
...
Change-Id: I65b245c3f262f2ad2665e7d0c3c246104e36eacd
2014-03-19 15:37:59 +00:00
Caolán McNamara
60211f44fd
coverity#708277 Uninitialized pointer field
...
Change-Id: I9877ef518b68afada1abaf47ebb167fcaf7bda16
2014-03-19 15:37:59 +00:00
Noel Grandin
96710f8e46
convert OUString::match to OUString::endsWith
...
Convert code like:
rTxt.match( "---", rTxt.getLength()-3 )
to:
rTxt.endsWith( "---" )
Change-Id: Iada74c5e714f7234f25b326526843a36255d5599
2014-03-19 08:55:21 +02:00
Kohei Yoshida
402fffa1b4
Add dash-dot and dash-dot-dot line styles.
...
We need these for Excel interop.
Change-Id: I91450c1d205f28636edfb4392aa6ae5091b1d7b7
2014-03-19 00:28:16 -04:00
Matteo Casalin
78a4b4247b
SwapIn/SwapOut can return bool + sal_Bool to bool
...
Change-Id: Ia5477d6bb83af38435b9ac44359fe2f46b00807c
2014-03-16 09:51:13 +01:00
Caolán McNamara
19efab6828
coverity#982471 Dereference after null check
...
Change-Id: I00c47ffa1f03e1c6e921efbc41ef01252c1c64b7
2014-03-15 20:55:49 +00:00
Stephan Bergmann
e1d99bc0d5
ToolbarMenu does not implement XStatusListener
...
Change-Id: Ia0195e794ac5e23905035738f0ab7e658c3bb92b
2014-03-14 17:57:25 +01:00
Stephan Bergmann
98666e8625
No need for a virtual OPropertyContainer::getTypes
...
(and rename to getBaseTypes for clarity)
Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
Caolán McNamara
20e43b9f88
-Werror=reorder
...
Change-Id: I763b2c21f0ba62cf9343582a5a41e0dc0b744b50
2014-03-13 14:31:22 +00:00
Caolán McNamara
9a76d79dc4
coverity#708296 Uninitialized pointer field
...
Change-Id: I05b10b0b9812a79ea8c55e5af3bcde83f24e12cf
2014-03-13 14:03:28 +00:00
Caolán McNamara
514fcf4238
coverity#708287 Uninitialized pointer field
...
Change-Id: Ie1e605caaaa6a2fc7756a285298c1f49962ad2b6
2014-03-13 14:03:28 +00:00
Caolán McNamara
184b9f7da7
coverity#708280 Uninitialized pointer field
...
Change-Id: I92b3e6ec80a951bd8a0133a348de7240ec15a89e
2014-03-13 14:03:27 +00:00
Noel Grandin
41776e53c5
svtools,svx: prefer passing OUString and OString by reference
...
Change-Id: Iceb2cbcda9d8ddb4ee00db9365c751e0e5d8b3a6
2014-03-13 13:13:38 +02:00
Stephan Bergmann
62fae8bda8
svtools: simplify deprecated XTypeProvider.getImplementationId
...
Change-Id: I2534ad4a720dd5d13324ac6fb19b8676ae50ff4e
2014-03-10 17:39:58 +01:00
Caolán McNamara
6f57b77c35
callcatcher: update unused code
...
Change-Id: I0d7f204473bd5fcddf2342850a16194fdb385c13
2014-03-10 11:36:23 +00:00
Caolán McNamara
dc4746a25b
coverity#708299 Uninitialized scalar field
...
Change-Id: I15b3c6d8a2af7be1fd8cada39c58ed706271f307
2014-03-09 21:20:11 +00:00
Matteo Casalin
dcc977b339
switch: ungroup two case which perform different operations
...
Change-Id: I099501a596ebeb2820192d08de80eae342191bb7
2014-03-08 10:13:25 +01:00
Stephan Bergmann
b901f7699d
x->getSomething(x->getImplementationId()) doesn't make any sense
...
...the point of the aIdentifier parameter to css.lang.XUnoTunnel.getSomething is
so that caller and callee can verify they know each other and the value passed
back (pointer in local address space, in this case) will actually make sense for
the caller.
Change-Id: Id79c419307992b30ea6ef7997b74a015631ad21c
2014-03-07 19:46:26 +01:00
Caolán McNamara
a3f0803059
coverity#704317 Logically dead code
...
Change-Id: I680efdff5be6a9f699b8954c11eddc027f972a76
2014-03-07 16:26:43 +00:00
Caolán McNamara
11abf53b9d
coverity#708336 Uninitialized scalar field
...
Change-Id: I9ccd8e1cf6fd06d7a6b7af57803f1e96e26b9963
2014-03-06 16:35:46 +00:00
Caolán McNamara
553554d0c8
coverity#982472 Dereference after null check
...
Change-Id: Ie797775184260fe5b5024d85be4244a56aee274a
2014-03-06 16:35:45 +00:00
Caolán McNamara
c71de82e9a
callcatcher: update unused code
...
Change-Id: Ibecd2458fb50ea6e9aff4e0c8ed76f9bfa25b8f4
2014-03-06 11:26:37 +00:00
Caolán McNamara
4516e30053
crash indexing -1
...
Change-Id: Ia339bed9bad3b43ec1e4ea813646cab81cf3a619
2014-03-05 20:41:07 +00:00
Eike Rathke
160d289564
cast to the higher capacity type instead
...
Change-Id: I515f315c93dd19016dfdabdf9524606214f84891
2014-03-05 16:21:25 +01:00
Tor Lillqvist
9d4c3a2a21
WaE: comparison of integers of different signs
...
Change-Id: I936e7bdaf3a4236775add4982005b465f229eb78
2014-03-05 16:25:43 +02:00
Eike Rathke
68ec95b3f8
made ListBox handle more than 64k elements, fdo#61520 related
...
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.
Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
Olivier Hallot
935e91c55f
Add window title and frame into placeedit.ui
...
Change-Id: Ibc45598b719c0898af19e6266799f84cc66d2db1
Reviewed-on: https://gerrit.libreoffice.org/8453
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05 05:00:07 -06:00
Noel Grandin
f68e276c79
remove unused code in svtools/SvtAccessibilityOptions
...
SvtAccessibilityOptions::GetColorValueSetColumnCount() const
SvtAccessibilityOptions::GetEdgeBlending() const
SvtAccessibilityOptions::GetListBoxMaximumLineCount() const
SvtAccessibilityOptions::GetPreviewUsesCheckeredBackground() const
SvtAccessibilityOptions::SetColorValueSetColumnCount(short)
SvtAccessibilityOptions::SetEdgeBlending(short)
SvtAccessibilityOptions::SetListBoxMaximumLineCount(short)
SvtAccessibilityOptions::SetPreviewUsesCheckeredBackground(unsigned char)
Change-Id: I1efe1da923a7c26030655ca8baa299325f416478
2014-03-05 09:17:48 +02:00
Noel Grandin
8f4aaed855
debug only code SvtIconChoiceCtrl::SetEntryTextMode
...
Change-Id: I840294fd8ae03ecfef614fea7c6f3a552596446e
2014-03-05 09:17:48 +02:00
Jan Holesovsky
be4f7ea3f6
OLE preview: Limit the GDI metafile size to 100000 actions.
...
Excel can copy huge metafiles to the clipboard, with over 3 million of
actions, which are 1) unusable, and 2) crash LibreOffice because of their
size.
So let's just limit the size of metafiles to be under 100000 actions,
otherwise use the 'OLE' bitmap.
Change-Id: I6a50471e6fe6ab9417592c011bf78cad6247236b
2014-03-04 23:05:11 +01:00
Stephan Bergmann
b2371492df
Use cstdlib std::abs instead of stdlib.h abs
...
...because the latter lacks the abs(long) overload in some popular environments,
cf. <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60401 > "stdlib.h does not
provide abs(long) overload."
Similarly, stdlib.h lacks the abs(float), abs(double), abs(long double)
overloads compared to cmath there, whose use was apparently intended in
sw/qa/extras/ooxmlexport/ooxmlsdrexport.cxx. Rewrote that to use
CPPUNIT_ASSERT_DOUBLES_EQUAL instead, which revealed that the comparisons need
rather large deltas of .1 resp. .2 (which the original code hid with an
implicit conversion to integral type, thus using an effective delta of 1).
Discovered with -Wabsolute-value ("absolute value function 'abs' given an
argument of type 'long' but has parameter of type 'int' which may cause
truncation of value") recently introduced on Clang trunk towards 3.5.
Change-Id: I4c41575ffdccb2944498b662bd3a53fd510cb0c0
2014-03-03 18:36:55 +01:00
Arnaud Versini
0feaf45541
SVTOOLS : Remove usage of DBG_CTOR and DBG_DTOR.
...
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: I83e39d69deaf2aa1c5ca455c92d070a2d33def3f
Reviewed-on: https://gerrit.libreoffice.org/8421
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03 09:19:11 -06:00
Caolán McNamara
2aa4b7e1f0
coverity#984421 Unused pointer value
...
Change-Id: Id44c9c3da6624db63e1f0f95dcaeddcc8b5402d5
Reviewed-on: https://gerrit.libreoffice.org/8426
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-02 15:20:05 -06:00
Stephan Bergmann
51e937c270
loplugin:literaltoboolconversion
...
Change-Id: If5949c6123e2816d0e7d9fd93d3e24dfecba1a56
2014-02-28 11:17:52 +01:00
Chris Sherlock
381f8a5673
sal_Bool -> bool in mostly vcl module
...
Conflicts:
include/vcl/settings.hxx
svtools/source/table/tablecontrol_impl.cxx
sw/source/core/frmedt/fecopy.cxx
vcl/inc/canvasbitmap.hxx
vcl/inc/headless/svpframe.hxx
vcl/inc/unx/salframe.h
vcl/inc/win/salframe.h
vcl/inc/win/salprn.h
vcl/inc/win/salvd.h
vcl/osx/DragSource.cxx
vcl/osx/DragSource.hxx
vcl/osx/DropTarget.cxx
vcl/osx/DropTarget.hxx
vcl/osx/OSXTransferable.cxx
vcl/osx/OSXTransferable.hxx
vcl/osx/clipboard.cxx
vcl/osx/clipboard.hxx
vcl/osx/salprn.cxx
vcl/qa/cppunit/canvasbitmaptest.cxx
vcl/source/components/fontident.cxx
vcl/source/control/edit.cxx
vcl/source/control/spinfld.cxx
vcl/source/gdi/gdimtf.cxx
vcl/source/gdi/virdev.cxx
vcl/source/helper/canvasbitmap.cxx
vcl/source/window/dockwin.cxx
vcl/unx/generic/dtrans/X11_selection.hxx
vcl/unx/kde/UnxFilePicker.cxx
vcl/unx/kde/UnxFilePicker.hxx
vcl/unx/kde4/KDE4FilePicker.cxx
vcl/unx/kde4/KDE4FilePicker.hxx
vcl/unx/kde4/KDESalFrame.hxx
Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
Noel Grandin
64977e5c2b
remove unused code FontSizeBox::GetValue(unsigned short, FieldUnit)
...
Change-Id: I63df5364d69bf60e7a5ee2b5854b41ce27f10894
2014-02-28 08:32:04 +02:00
Armin Le Grand
af63727b9f
Resolves: #i15508# Added support for BMP file type
...
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4)
Conflicts:
filter/source/msfilter/escherex.cxx
include/vcl/gfxlink.hxx
svx/source/xml/xmlgrhlp.cxx
sw/source/ui/docvw/romenu.cxx
vcl/source/filter/graphicfilter.cxx
Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27 19:30:40 +00:00