This was only available in experimental mode previously. Also note that
export of Writer TextFrames are handled separately, there DML export is
still off by default.
Change-Id: Ie8eaa1670610d92a363a8558b68064e7d7de2cdd
There was code that was inserted by commit id
'8c178a50334109b34ef456ca6aa51cd3d98699ae' that added logic to
also export 'rPr' in the 'pPr' node.
The 'rPr' represents the paragraph marker formatting.
However - simply copying the last run's formatting and assuming
it is the same for the paragraph marker should not be used.
Also refer to 'aafffe6d1c3734fb2acef4b2bb1385c1e2f49043' for
details on test-case disable.
Change-Id: I6004e4c706abfeb5f51d86d11d3ebf46256a68c5
Reviewed-on: https://gerrit.libreoffice.org/7121
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
The property is called w:themeColor and it belongs to the w:color tag
inside run properties.
On import, the themeColor prop is stored in the character interop
grab bag together with the val prop.
On export, the current color of a text run is compared with the
stored val prop to know if the color has been changed during the
document edition. If it hasn't changed, the themeColor property
must be written to the document; if it has, it must not be written to
avoid overwriting the new color.
Also added a unit test for this property.
Change-Id: Icc95ee023aecc741adcba23d23206aadd6c30e1f
Description: Docx containing floating table with formula was giving
"General input/output error" while opening in LibreOffice. Reason being within xLoader->filter() it was calling
EmbeddedObjectContainer::RemoveEmbeddedObject() with bClose value as sal_True(default value in function declaration)
and hence it was removing embedded object from container and also it was closing it.Fix includes passing this bClose
value as sal_false (which means remove object from container but don't close it.)
verified code changes for various floating table docx and normal docx containing tables and formulas.
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/7009
Change-Id: I9c2d3f8c4099f9f753b2a1b027f9072cd4effeb5
1] Libreoffice gets crashed while saving.
2] This caused:
"testCrashWhileSave.docx" file crashes on save
Tested on Libreoffice 4.2
Implementation:
1] It crashes when we are trying to access cell number 2 from
cells vector which contains only single cell. So put check
for cell number which we are accessing and Number of cells
in single row.
2] As we are exporting Header and footer in between when we are
exporting document.xml. In this case we are facing issue in
table export for header and footer. Because flags for table
is getting shared in both export.
So we are switching between flags in between exporting
"document.xml" and Header & footer
export.
After fix:
1] No crash on save for "testCrashWhileSave.docx" and
opens successfully on MS Office 2010
Added Unit test case in export.
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/6676
Change-Id: Iefbf565f7b512d76ac68e9353e225edca425ef06
Problem Description: While saving the file LO shows the error
"This file could not be save".
The root cause was memory leak.
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/6850
Change-Id: Iacc185780c14760056a7d690eb113d4dde1de034
1. Glosary folder is imported as Intrograb and exported.
2. Added unit test case
Reviewed on:
https://gerrit.libreoffice.org/6825
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
writerfilter/source/filter/ImportFilter.cxx
Change-Id: Ifd51a75a65e030d44d30e02cd7ab51fb088186b3
We store the values of themeFontLang tag to the document grab bag so
we can save it back to the document on export time.
Added unit tests to check that the attribute is properly set back and
also that the theme fonts are correctly applied to the text.
Change-Id: Ia54c513796ba38a571396ca7b72dfd28463c15fd
Explicitly ended paragraph when the column break appears in a run
(which is not the first run in the paragraph), as Writer adds a
column break only for new paragraph. Also the created paragraph
must have the same para properties as the earlier one. Hence avoided
pushing new para properties if paragraph is split to adjust a col break.
Added UT for the same.
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/6953
Change-Id: If7d503b7a4bfab31f40ceb0119876e5909252b2f
Expecting that the shapes are on the drawpage in the same order as they
are in the file and providing zorder info at the same time doesn't work.
Either using names is required or the simpler way is not providing
zorder info. Fixed earlier bugdocs not to provide zorder info, so when
zorder will be handled, these tests will still work.
Change-Id: I771b0574eba489322998c84a60d5acb94fd09189
Description: There was a problem for some documents, during export Invalid sectPr were getting added.
The root cause was faulty calculation of PageDesc value.
This was the reason for increasing number of pages in RT doc.
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Change-Id: I0700c735545614730d26be187d9047fd20ebf134
Reviewed-on: https://gerrit.libreoffice.org/6813
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Description:
If in original doc for table if "allow row to break across pages" is checked then during export
it used to write <w:cantSplit w:val="false"/> in trPr which was causing problem that all the cell
data was getting displayed on same page.
Change-Id: I5a20976ca91099de191eb1e2a7290b96dcdc6777
The problem was that after handling the mce elements
(AlternativeContent, Choice, Fallback) we still invoked the lcl version
of these methods and this resulted in duplicated properties in the
dmapper, finally resulting in incorrect position of the textbox.
Change-Id: Ib581162cba703fc1e2e44c1a9e63358891d6f78c
Word wants this, so it's added by the exporter to the document, but on
import we should ignore it.
Change-Id: Idcb669ba624bf462a50a85eb4aacf397afb6efe6
The unit test checks three cases:
* attributes in run properties
* attributes in default run properties
* attributes in style definitions
Change-Id: Ie3224f41bd29e8b258dbd6823b7c9549e1ef5b1e
Commit 840a8573c8cebe67ddd3c9fe106c7dbd789bb334 (Fix fdo#70220
Superscript not imported from pptx., 2013-10-07) made it possible to set
CharEscapementHeight even if moBaseline is not set, but this causes
problems in the docx importer + not necessary, according to the bugdoc;
so just don't do that.
Change-Id: Ib95ac449bd8fdf6376261ddc86108f0d23f2200e
This is similar to commit d5c934d150cb6cea5f96cbbee4fb5e8312bf027e
(n#792778 DOCX import: parse group shapes in oox only, 2012-12-14),
except that was for the VML importer.
The only difference is that in case of drawingML,
OOXMLFastContextHandlerShape::lcl_createFastChildContext() is only
called for the children of the group shape, not for the element itself,
so compare against the start token, not the current element.
Change-Id: Iddeabb20bbd5f0153e2fc4e6df463830126fdd37
This means in case we hit an mc:AlternateContent element, we will read
the mc:Choice branch of it, in case wps is the required feature, not the
mc:Fallback one, which contains the information in VML format (after a
lossy conversion).
Change-Id: I476156bd1a39927dda903d14540155d1e62a211e
The problem was that the shapes produced by the drawingML import had
types like ooxml-triangle, and EnhancedCustomShapeTypeNames::Get() only
handles VML/binary MSO shapes (e.g. isosceles-triangle). Add an OOXML
mode, and in that case use msfilter::util::GETVMLShapeType() instead,
and only fall back to EnhancedCustomShapeTypeNames::Get() if necessary.
Change-Id: Ic93ba4719133dd3e96c17d2562642a03e559fefa
This way a 2>/dev/null output still gives a csv, even if there were
various other warnings in the meantime.
Change-Id: I6ed3de4058c829e856286c7d484d6ed436c362a4
I.e. previously only absolutely positioned textboxes were handled, with
this, centered textboxes are fine as well. Given that the drawingml
picture import code already supported this, refactor common code to a
common method.
Change-Id: I56e0dbfa0ffc7e27a70a0e8fb8477681389a51cf
Since commit 23b67c536537c91020cf5a45ab5cb36d7316ed89 (DOCX import: fix
import of font size in table styles, 2013-03-04) we simply ignored all
table style run props, that indeed fixed testTableStylerPrSz, but broke
cases when otherwise reasonable run properties were specified in table
styles.
Fix this by only ignoring run props of table styles if the default para
style should have priority.
Change-Id: Ic10f635f4b8688af252214d5d38216b4d5c8fa8e
If a table row is marked as tblHeader, then the firstRow section of the
table style should be applied, even if that row is in fact not the first
row.
Change-Id: I10605f404160e72c620e9204503203fea1c6d6d8
"caps and no smallcaps" means style::CaseMap::UPPERCASE, not
style::CaseMap::NONE. Different XML elements in DOCX, single UNO
property.
Change-Id: I8cbc719f2c307d5d2cbd4af93ea61e35b640ad1d
