The problem was that in ShapeBase::convertAndInsert(), the rectangle
calculated for a line was zero, that's why it wasn't imported. Fix this
by overriding the get*Rectangle() methods in LineShape, instead of doing
so with implConvertAndInsert().
Change-Id: Ie4bb2f7964b438cb56e4f5ee7a4ebe9f8f8eb734
I don't know what's wrong with it or why the problem shows only for
me on openSUSE12.2, but it's been broken for several days now
and there's not much point in keeping it that way given that it
didn't work from the beginning.
Change-Id: I608bc01e4ee914629db1aa75ce8463044fe20ca6
This was about importing RTF tables where different rows had different
number of cells. In the meantime, a better implementation was added for
DOCX, just using that for RTF fixes the import of this bugdoc.
Also fixes a crasher while loading ooo43817-1.rtf.
Change-Id: I0970275272eca7f33a442bd6acc97a4f8d9dabeb
The problem was that \sbknone (being a section property) triggered
creating a section, but the document doesn't have multiple sections.
Make sure we don't send section properties as long as no \sect control
words present.
The RTF spec says control words are case sensitive, and page 252 of the
v1.9.1 spec defines \mlimloc, but earlier page 118 and 125 also defines
\mlimLoc, so let's accept both.
Like the minimal filter tests, these tests are invoked from a single
cppunit method since commit 0a30cb22a1, so
some info about exactly what file failed is necessary. If we are at it,
also print the (re)loading time as well.
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).
Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.
I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.
I dropped the optional interfaces
XStatusIndicatorFactory
XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.
I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.
Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
UseOnPage got changed in commit
fa0f42bafb, but SvxPageUsage got
unchanged. Given that right now other applications don't support first
page headers / footers, leave SvxPageUsage unchanged and provide
conversion methods between the two types.
Previously textframes inside groupshapes were tried to be imported as
TextFrames, but then their addition to a GroupShape failed, so the text
simply ended up as a normal paragraph. Fix this by importing members of
groupshapes as drawinglayer objects, just like how the WW8 import does.
Also fix two testcases, which implicitely tested that the groupshape VML
element is ignored on import.
Change-Id: I1a9fba8a5fd532203a825e55b1d5996277ea12fa
For this test document, the first paragraph is part of a textbox, when I
reduced the original bugdoc, I forgot about this.
Change-Id: Ia8d8aa5992d717a55c4115e4eb6d29f37e365df0
Regression from d4069372484f18b242a42a1996767f57b031fff6
Change-Id: I28e095819e0c2f1a4b110741ace366329937f863
Reported-by: Michael Stahl <mstahl@redhat.com>
In general, DOCX tables provide a grid for the table, then use spans in
case different number of cells are used in different rows. In this case,
the cell width is ignored, as the wished width can be counted from the
grid and span values.
However, it's also valid to simply provide more cells then the amount
defined by the grid, and in this case the cell width should decide the
final width of the cells. This commit adds support for this later case.
Change-Id: I0dd6c1f0c06f81c2afa00489b7ad1f33ff300a7c
Additionally:
1) Make sure cell margins are zero when they are not defined.
2) Handle cellx values in case of a negative left margin.
Change-Id: I9b8fb700b6459e622396c98e4344aba79f62c96e
This is still not complete, but having the replacement graphic only is
far better than having nothing.
Change-Id: I141a3de1a449f4261c7086e10f2c141b3f6cdb10
