1680 Commits

Author SHA1 Message Date
Noel Grandin
e5dd09caaf coverity#708893 unused pointer value
Change-Id: Ib029e08f7dc29330b1a0b5d93c1c0a356dbd59dd
2014-02-07 12:14:33 +02:00
Noel Grandin
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
Chris Sherlock
570e5d70f3 fdo#74425 Remove deprecated static function ResMgr::GetLang()
ResMgr::GetLang() has been deprecated for a long time now. It is used
by only one function,
SubstitutePathVariables::SetPredefinedPathVariables() in the framework
module. I have therefore removed it from ResMgr and placed it as a
function in framework/source/services/substitutepathvars.cxx where it
is actually used.

Change-Id: I5f0d8f701aa45f8653020affeff6339f8fc9bc0e
Reviewed-on: https://gerrit.libreoffice.org/7791
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-04 14:43:57 +00:00
Stephan Bergmann
a61f3161a4 At least warn when DBG_TESTSOLARMUTEX has not been set up
Change-Id: I5ae5318685ffe45bd9616d06eea21a93585715f2
2014-02-03 16:05:09 +01:00
Norbert Thiebaud
84f313ba4a coverity#100870 : Uninitialized scalar field
Change-Id: Ica1af6017aedf94ad4daa92352691675bf6378fd
2014-01-29 23:36:52 -06:00
Stephan Bergmann
b4c2496f44 bool improvements
Change-Id: Ia3fd76aa70564cbc683d0d66cc39aa368bea29d9
2014-01-28 20:26:17 +01:00
Noel Grandin
16a2e90335 remove SvStream::operator<< methods
.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:47 +00:00
Arnaud Versini
de2d5d9abb TOOLS : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Id75ca6991af0bf75e979c7bc2da452f323f389ea
Reviewed-on: https://gerrit.libreoffice.org/7531
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 16:09:25 +00:00
Stephan Bergmann
fb96dc3c8f bool improvements
Change-Id: I5237197595b1b892e7720de13fc835b64470505e
2014-01-21 13:24:31 +01:00
Tor Lillqvist
38b4030703 Avoid warnings: unused parameter
Change-Id: I92fd33e020772eac735f133f467207da9635e9b4
2014-01-16 23:22:44 +02:00
Bjoern Michaelsen
43bfe1ecb8 always build an empty DbgUnhandledException, to allow debug=t builds without --enable-dbgutils 2014-01-16 21:45:17 +01:00
Stephan Bergmann
4210bba0b3 Missing adaption to WriteSvPersistBase
...introduced in c648d0872058941ed18499a8bf1993037d9b5532 "convert
SvStream::operator<< overloads to more explicit methods."

Change-Id: I8343cd3d1e92ccd3ca3fc6292ebd1114ada444e1
2014-01-16 18:13:02 +01:00
Noel Grandin
c648d08720 convert SvStream::operator<< overloads to more explicit methods
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
Stephan Bergmann
1a3e7b7d59 Use bool
Change-Id: I1cb9aa1a06fde24d0b7c7ec0ad56994598ee1d4b
2014-01-10 17:11:50 +01:00
Stephan Bergmann
dda2d87181 Massage odd TODO code some more
Change-Id: I0e4fab72a6384eab41eeb1357eaf88be876a6b52
2014-01-10 17:11:50 +01:00
Stephan Bergmann
dfe74865e0 Use bool
Change-Id: I643f7d13b95c6bb89ee00be706e384338ed8b79a
2014-01-10 17:11:50 +01:00
Stephan Bergmann
78162f005a Use bool
Change-Id: I1317aebafaae3c80a2016d23f93411a610fa349d
2014-01-10 17:11:50 +01:00
Stephan Bergmann
3abb11b346 Use bool
Change-Id: I7b48d8b9e162f9e4447bfcfcc0bbd1158bd35f5b
2014-01-10 17:11:49 +01:00
Stephan Bergmann
6eeee04bad WildCard::ImpMatch should return bool
Change-Id: Ib851cbe072bca0d594440cc28164e112d0fe37cb
2014-01-10 17:11:49 +01:00
Noel Grandin
b69864f3f8 re-write SvStream operator<< to non-overloaded methods
This is the actual re-write.

Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
  (*this) << 1;

Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-10 13:26:24 +00:00
Noel Grandin
de84529b55 Clang plugin to re-write SvStream operator<< to non-overloaded methods
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteUInt32.
Note that the rewriter is not perfect, and hand-tweaking the output
is necessary.

Change-Id: I0291c8192ca74d6334ed3cf8cb713212b2f0c67d
Reviewed-on: https://gerrit.libreoffice.org/7307
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-10 13:26:15 +00:00
Noel Grandin
2ac31b06ae Unnecessary use of OUString constructor inside OUStringBuffer constructor
Convert code like:
    OUStringBuffer sVal(OUString("0x"));
to:
    OUStringBuffer sVal("0x");

Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
2013-12-17 11:49:05 +02:00
Noel Grandin
80612512fe remove unnecessary casts
It is no longer necessary to cast to sal_Unicode when calling
OUStringBuffer::append

Change-Id: Iab3d1e12eef472cfe11f1d0d1969ca404091dd7d
2013-12-12 13:15:25 +02:00
Stephan Bergmann
a39d07e134 Unwind occurrences of deprecated sal_sChar, sal_uChar
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
2013-11-27 12:52:32 +01:00
Adam Co
8d7cb7773d Moved 'DateTimeToOString' from 'filter' package to 'tools' package
After the move now other classes can convert DateTime to OString also

Reviewed on:
	https://gerrit.libreoffice.org/6816

Change-Id: I0ceb9a5cc26103a6cb36d7765a717770ec3fbe7d
2013-11-26 14:02:02 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
Caolán McNamara
4bc5287636 xub_StrLen->sal_Int32
Change-Id: Ia52a898fa0a6b47eb7f78b03ef8c8648ddf72e28
2013-11-13 13:50:37 +00:00
Matúš Kukan
f116128500 implement very simple SvScriptStream to read from process
It inherits from SvStream, so it could be used easily.
Basically, it's just a simple wrapper around
osl_executeProcess_WithRedirectedIO() and osl_readFile().

Change-Id: Ifa225c87d2c9be7e71ea113b0832a4fe83ec65b3
2013-11-13 10:33:18 +01:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
Noel Grandin
8396cce9b5 clean up places accessing the NULL at the of an OUString
There were only a couple of real bugs fixed, but we're a little
bit safer now.
This also fixes the assert and the comment in OUString::operator[]
about this.

Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
2013-10-23 13:12:55 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
Caolán McNamara
b37e2dd071 Resolves: fdo#38838 remove UniString
hammer silver nails into coffin and bury in concrete

Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-22 12:50:48 +01:00
Caolán McNamara
5d98890708 move ResId::toString
Change-Id: I287a92de9ae30255990595263c3302d753fdbccf
2013-10-22 09:14:19 +01:00
Caolán McNamara
b2e954e300 Related: fdo#38838 remove UniString::UniString(const ResId&)
Change-Id: Id881fe3f9c7c89a7bcc1a5d8f653e18494ffa913
2013-10-22 09:14:19 +01:00
Caolán McNamara
cfda947d7c Related: fdo#38838 remove UniString::Copy
Change-Id: I566e3ade54962bbc6ace9b757f79c1b8ed9ffd00
2013-10-21 19:29:17 +01:00
Caolán McNamara
6e03e292e5 Related: fdo#38838 remove a pile of ctors
Change-Id: I5d19eadc3dc24b0aeeb61c677f440eef83af78c2
2013-10-21 14:26:33 +01:00
Caolán McNamara
d486b2b324 Related: fdo#38838 remove/privatize String::Append
Change-Id: I5ae90b02e7ae5ddd19495fd0847b7e9dfc4419e8
2013-10-21 11:25:00 +01:00
Caolán McNamara
48bb54aa7e Related: fdo#38838 remove String::Insert
Change-Id: I37e35b5a16d37b1fccc6aa47f5027ff406c67d98
2013-10-21 09:17:32 +01:00
Caolán McNamara
9e6917c21e Related: fdo#38838 remove String::ToInt32
Change-Id: I6f90e9a06acaa5af88cd011015938dba2059ee0e
2013-10-21 09:17:32 +01:00
Caolán McNamara
3714051f14 Related: fdo#38838 remove String::[G|S]etChar
Change-Id: I64711aa3e6580eff7c64a92243e3161ef2d7cb9e
2013-10-21 09:17:31 +01:00
Caolán McNamara
60ff30a2ab drop DBGCHECKSTRING
Change-Id: I0c60becfd3a61cffb46c76e6f1488528c59b46e9
2013-10-21 09:17:31 +01:00
Caolán McNamara
9be876cd06 Related: fdo#38838 remove non OUString ::Append
Change-Id: I084ce5c4833964018849617632a1308dc74adda3
2013-10-21 09:17:31 +01:00
Caolán McNamara
8bb4b18127 Related: fdo#38838 remove String::Equals
Change-Id: Ib85907c9e274ba4e4f4c9394f3d4ecf0c9374603
2013-10-20 19:00:36 +01:00
Caolán McNamara
b0fd64b2fa Related: fdo#38838 remove the unused String::Insert
Change-Id: I39f4c68b76d8816fc91e4dc39bf2305142d1fb93
2013-10-20 19:00:36 +01:00
Caolán McNamara
35373db029 Related: fdo#38838 remove String::Assign(const sal_Unicode*)
Change-Id: I0dfa34732acfd20e71fa3876466552338332610b
2013-10-20 12:03:50 +01:00
Caolán McNamara
a6cdf1b2f6 Related: fdo#38838 remove String::Search
Change-Id: I92a50bc5f7b0cddcf2066cdac50439a3d5f1708b
2013-10-19 19:16:30 +01:00
Caolán McNamara
f2bdfdb295 Related: fdo#38838 remove String::Replace
Change-Id: Ia6602809a65db0a7dcfef80cc474aab67d520980
2013-10-19 14:24:40 +01:00
Caolán McNamara
fdf85819c3 Related: fdo#38838 remove String::Match
Change-Id: I9db663dbcb432cbfe380e1272d6daaed3e6f4221
2013-10-18 16:27:43 +01:00
Caolán McNamara
13f383ac91 Related: fdo#38838 remove String::GetToken
Change-Id: Ic5307816dd3f0c74f10eb8a15910a1674713bf9c
2013-10-18 11:11:49 +01:00
Thomas Arnhold
c65eb7e569 Related: fdo#38838 remove String::SearchAndReplace
Change-Id: I1cc52d0be360b05e722a18b3ca5d08b2b0b0842d
2013-10-17 15:22:20 +02:00