156 Commits

Author SHA1 Message Date
Stephan Bergmann
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
Julien Nabet
f8cd68bad6 cppcheck: Redundant checking of STL container
Change-Id: I83a8671e90431bbc4f41392f062d37c452b018ff
2014-06-21 14:26:58 +02:00
Noel Grandin
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
Noel Grandin
cc25f70ef1 compareTo -> equals
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate

Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04 11:52:34 +02:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
Stephan Bergmann
80ce877249 Clean up function declarations
Change-Id: I18125ac6c58c89f76c3a6cfb3a7ee77b1059aeb1
2014-04-08 10:22:01 +02:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
Andrzej Hunt
d69346b170 Make parameters const too.
(Following on from loplugin:passstringbyref)

Change-Id: I9100f51aa7420b237c84de7d36d2374ac6612d00
2014-03-18 19:49:59 +00:00
Andrzej Hunt
887ab6d083 loplugin:passstringbyref
Change-Id: Ic88d78418fb9380dece316544e0afb4d8660f8e6
2014-03-18 18:37:33 +00:00
Tor Lillqvist
c15913b273 Spelling fix: suported
Change-Id: I3b67edd5ba4541a65cb0916abea6db1362c32afd
2014-03-12 15:56:04 +02:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
a450e0eea2 unodevtools: sal_Bool -> bool
Change-Id: Ie62a7d184f4982a5164c183f6e38d534b94df1bd
2014-02-17 17:55:18 +01:00
Stephan Bergmann
07d3807e99 codemaker: sal_Bool -> bool
Change-Id: I2cacac2aa7e48b3b9d8d060137d5c6d6f1d06b3f
2014-02-17 17:55:17 +01:00
Noel Grandin
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
Thomas Arnhold
d0c12f0aa2 fixincludeguards.sh: uno*
Change-Id: I8fb3c25cd583b688104a0ee8620696e7b2958ab5
2013-11-05 09:28:51 +01:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
Stephan Bergmann
a80fb45fe4 Revert "WIP: add cppumaker -U to directly read from .idl files"
This reverts commit c4113906d7f15f8aa0eb385a4caf474b3505ede1, which is not
necessary after all with recent "Hook SourceProvider into unoidl::loadProvider."
2013-09-16 13:29:49 +02:00
Stephan Bergmann
c4113906d7 WIP: add cppumaker -U to directly read from .idl files
Change-Id: I420847515b6b691ae81a249a8820cf9a3d132372
2013-09-12 17:45:12 +02:00
Michael Stahl
3cb10e9220 unodevtools: drop support for skeletonmaker --java4 parameter
Minimum requirement has been Java 1.5 for years now.

Change-Id: Id512507db1fc12c92d8f7662505eda6866da2fc6
2013-08-26 16:20:50 +02:00
Michael Stahl
975e230f08 unodevtools: why does the C++ generating code check java5 flag?
Change-Id: I598698948a3543f1c020cc4a4b8db8799eb314a5
2013-08-26 16:20:50 +02:00
Eike Rathke
0f80c06463 added FIXME-BCP47 comment
Change-Id: I77416a9e275dc204b3b82807d27b5276ad4f497f
2013-07-11 19:15:52 +02:00
Eike Rathke
7d0f6f671e added FIXME-BCP47 comment
Change-Id: I202c53a094ac7ddcbd1fa0d2367058aba56820ed
2013-07-11 19:15:52 +02:00
Jelle van der Waa
84f1f1d149 fdo#43460 include,registry,svtools,svx,unodevtools: use isEmpty()
Change-Id: I6e35b91092239275694eec3666b076f7ff7e54f6
Reviewed-on: https://gerrit.libreoffice.org/4335
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-18 17:33:46 +00:00
Stephan Bergmann
a1dff2901e Support for annotations in the new UNOIDL format
...used for now to transport @deprecated information.

Also, improve Idx-String (formerly Idx-Name, but also used for UTF-8 annotations
now) format, using the 0x80000000 for the indirection rather than the base case.
(And the README erroneously used "Offset of" Idx-String all over the place.)

Change-Id: I7003b1558ab536a11a9af308f9b16a7ef8840792
2013-05-16 16:12:45 +02:00
Michael Meeks
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
Stephan Bergmann
bab43b23d5 Allow for (relative) pathname args for codemakers again
Change-Id: I503d88b7d6fc44ef70d5071fddcec465e3fba856
2013-04-24 12:42:01 +02:00
Stephan Bergmann
048e591819 Further codemaker, unodevtools clean-up
...getting rid of now dangling references to module registry.

Change-Id: Iccad7ff5dc0e79bf91b7b7dae03b73f16adeb121
2013-04-16 17:38:44 +02:00
Stephan Bergmann
30a7c6ba6b WIP: Experimental new binary type.rdb format
Make uno-skeletonmaker work on top of unoidl/ instead of registry/.

These changes have only been tested so far rather lightly.  Basic
uno-skeletonmaker still works, but more thorough testing of the various input
flags is needed.

Change-Id: Id7f3aee863a10f8c649325db2d6f34a4057f70ff
2013-04-16 13:52:29 +02:00
Stephan Bergmann
8937fac216 uno-skeletonmaker does not bootstrap UNO
...so mentioning env:INIFILENAME and env:UNO_TYPES is misleading.

Change-Id: Ia91ad691c58d226bc445b3355dffb82ba7ddbef5
2013-04-11 16:11:19 +02:00
Stephan Bergmann
7b3bef772d No need to have uno-skeletonmaker depend on udkapi
...just for RuntimeException, which can be replaced with CannotDumpException.

Change-Id: I258f5fe534d589b33e988f7e585168c1bc6990f8
2013-04-11 16:11:19 +02:00
Stephan Bergmann
eb4786e88a Remove dead code
Change-Id: I090b0b1b10fdfe9d5955fe0137214d8907c3aa0c
2013-04-11 14:45:16 +02:00
Stephan Bergmann
fc02ae8f82 [API CHANGE] WIP: Experimental new binary type.rdb format
Make javamaker work on top of unoidl/ instead of registry/.

API CHANGE: javamaker no longer supports the -B switch, as that is meaningless
with the new format.  When reading from an old-format .rdb file, /UCR is hard-
coded as the prefix now.

Change-Id: I8cca39f8ebacd0476934f7bd493d206928d063a9
2013-04-11 09:29:44 +02:00
Stephan Bergmann
02a8e8acd1 [API CHANGE] WIP: Experimental new binary type.rdb format
Make cppumaker work on top of unoidl/ instead of registry/, as a first step to
change all the various codemakers.

* API CHANGE: cppumaker no longer supports the -B switch, as that is meaningless
  with the new format.  When reading from an old-format .rdb file, /UCR is
  hard-coded as the prefix now.

* TODO: The new format does not yet support deprecation annotations, so the
  generated .hdl/.hpp files lack any SAL_DEPRECATED_INTERNALs for now.

* codemaker/typemanager.hxx is extended with access to unoidl/ functionality, so
  the various codemakers can use registry/ and unoidl/ in parallel for now.
  The access to registry/ functionality will be removed.  (Added small throwaway
  helper functions u2b/b2u to easily map between OString and OUString at the
  remaining seams for now.)

* Includes a selective revert of ba044b1e9613ed30906a9a540b7da8392923e4e3
  "remove needless forward rtl::OUString declarations" in those parts of
  codemaker, unodevtools, unoidl that were covered by this local
  work-in-progress patch; I would otherwise have hard a hard time re-applying
  it.

* The generated .hdl/.hpp files are mostly unchanged, except for a few minor
  things:

** Any SAL_DEPRECATED_INTERNALs are missing (see above).

** In comprehensive getCppuType definitions, some members were erroneously
   classified as TypeCalss_UNKNOWN.

** In comprehensive getCppuType definitions, some unnecessary calls like

     ::cppu::UnoType< ::sal_Int32 >::get();

   can be removed.

** For typedef sequence<X>, the .hdl file need not include X.hdl, but only needs
   to forward-declare it.

** Unnecessary includes for optional bases of interfaces can be removed.

** Some numbering of local variable names (sMethodName1, ...) has changed.

Change-Id: Icad98f248ac15177337f1b4ab709a755a8af6238
2013-04-09 09:44:33 +02:00
Golnaz Irannejad
92c6a38175 Fixed 4 spelling errors in the comments.
Change-Id: Ic48f52d7ea4f6a4964f627e3051c96c46ffc2f76
Reviewed-on: https://gerrit.libreoffice.org/3164
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-07 21:28:01 +00:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann
bb1f0c667f Clean up codemaker/typemanager.hxx
Change-Id: I650efd6780070410eaf34993dd41ed1b8ada7c9a
2013-03-27 09:36:54 +01:00
Chr. Rossmanith
4b2890453b Removed RTL_CONSTASCII_STRINGPARAM in unodevtools
Change-Id: I41ea9fe6fcac6cba0e12cd570b9971998717f401
2013-03-12 21:02:26 +01:00
Kenneth Beck
21e1e859a7 fdo#60724 change spelling error REMOVEABLE -> REMOVABLE
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments.
All other instances of the misspelling have remained the same.
Example: AF_REMOVEABLE

Change-Id: I391f4101bbc3e06689318235a37d616065bc1686
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-06 10:39:30 +01:00
Thomas Arnhold
919e277466 loplugin: unused variables and commented code
Change-Id: I01f1f1d112767b576d7cfc6e25fe95385de2c0cf
2013-03-03 11:48:02 +01:00
Julien Nabet
2ce2fafa1b Some cppcheck cleaning
Change-Id: Idb380dbb7470dbdb371778ba0c486392cc55380e
2013-02-12 14:48:04 +01:00
Thorsten Behrens
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
Miklos Vajna
26364f4fd3 deduplicate OString std::basic_ostream operators
I wanted to add one, based on OUString one, and Stephan on IRC agreed
it's a good idea. Then it turned out we already had it in sal unit
tests, sdext and unodevtools as well. Get rid of all these, and have a
single implementation in string.hxx, so it can be used everywhere.

Change-Id: Ibb820f20a138d055fd87036253c627fb862a31fe
2012-11-10 10:49:31 +01:00
Arnaud Versini
9d314ab71e Replace usage of rtl/memory.h in unodevtools with equivalent from string.h
Change-Id: Id13d0be47071345508ea1ddd3a8c4b8e656fcfe8
2012-08-04 17:47:00 +02:00
Michael Meeks
ec54c0c45f re-base on ALv2 code. 2012-07-03 13:10:11 +01:00
Andras Timar
54e9a28390 typo: paramters, paramaters -> parameters
Change-Id: If58683331c50f2a95204e8e2dea11edbef3ccb63
2012-06-19 16:44:08 +02:00
Michael Stahl
9af0eb7e99 skeletonmaker: add back \" in string literal
Seems accidentally removed in ea489b3570efe7d9a53da91ba66fa1563d40ffbb.

Change-Id: I7c4be5c41033ca8d4f66557efb30d17f8527b4a8
2012-06-07 15:17:41 +02:00
Tor Lillqvist
2faadd0b4e Update also the help message
Change-Id: I3b84d1905d13c9418985d1ebe5feac13a0025efe
2012-06-06 19:00:03 +03:00
Tor Lillqvist
d28f2135f1 Nobody uses this tool, but still, update the license blurb it outputs
Change-Id: Id9d767c2738d8052f2716086fb40a1b01c68d76e
2012-06-06 18:55:56 +03:00
Norbert Thiebaud
ea489b3570 targeted string re-work
Change-Id: Ia2115e70df8f64eb0dade6beb33ee64c358af767
2012-06-02 17:57:16 -05:00
David Ostrovsky
a57b634799 gbuild conversion: unodevtools module 2012-04-14 06:58:00 -05:00