401 Commits

Author SHA1 Message Date
Caolán McNamara
7a8815875f all the filterText impls are now no-ops, so remove
Change-Id: I6e67756bb89235198c8d2705833d18ee9fb77fb1
2014-03-20 14:40:32 +00:00
Caolán McNamara
ed61716320 Resolves: #i49980# Autosense fax4cups devices and configure automatically
If there is a "Dial" ppd key then it's a fax device. If the Dial is set to
"Manually" then ignore that it's a fax device and don't prompt for a fax
number.

If we have a fax number, then set the jobname to the number given that
"printing will result in sending the fax to the number contained in the job
name"

Remove the weird and wonderful non-macosx-unix-only, non-pdf-print-backend,
text "scraping" of phone numbers out of the print out in the @@#PHONE@@ format.

Allow the phone entry dialog to accept multiple fax numbers separated by ;

Change-Id: Ie1d84b68584e82df15ceda5f32c7c75086b035c8
Related: rhbz#159153, #i49981#, #i49920#
2014-03-20 14:40:32 +00:00
Caolán McNamara
872de52958 IsQuickJob is never read and FAX# is never written
Change-Id: Id8f852df49b951fa6f5558e7e45018f07a9b104f
2014-03-20 14:40:32 +00:00
Caolán McNamara
1e539dbf0f Resolves: fdo#50855 Nimbus Sans L missing styles
Change-Id: Ie8cdcf4ad0ffe52024fd5cfe33073abfc6aadca8
2014-03-12 16:03:46 +00:00
Takeshi Abe
59b428189d Avoid possible resource leaks by boost::scoped_array
Change-Id: I3a9131d75690e18caec4c328934735a9ca19e7ca
2014-03-11 09:30:49 +09:00
Takeshi Abe
e0e2f4c988 Avoid possible resource leaks with boost::scoped_ptr
Change-Id: I835bec5c43b7b4a8638d5032b720661fc2f1397f
2014-03-07 16:35:09 +09:00
Caolán McNamara
2f41b934e5 coverity#708896 Unused pointer value
Change-Id: Id2a4e43c1f32d997ee2656ef2e55a1951ce60f9d
2014-03-06 16:35:53 +00:00
Caolán McNamara
a61d15e0c4 coverity#708897 Unused pointer value
Change-Id: Iab37796be5c9d6fef3e68e9ec9b6828c643b822d
2014-03-06 16:35:53 +00:00
Caolán McNamara
f3770d0d04 coverity#708898 Unused pointer value
Change-Id: I3190fa5c49de84319bf08f286c1511d2b23e4922
2014-03-06 16:35:53 +00:00
Caolán McNamara
827d9168ee coverity#708899 Unused pointer value
Change-Id: I7b8c2a01a59f939805d09612968d8f90acf1849a
2014-03-06 16:35:52 +00:00
Caolán McNamara
7e5fdb00f9 coverity#708900 Unused pointer value
Change-Id: I2b644bf795bcfe2978aac25696cf362d7505c9a5
2014-03-06 16:35:52 +00:00
Caolán McNamara
8770c1de8d coverity#708901 Unused pointer value
Change-Id: Ie12718b9de452ccd5b8031694d6e70792b438d89
2014-03-06 16:35:52 +00:00
Caolán McNamara
a163062793 coverity#708902 Unused pointer value
Change-Id: Ia8e140da22d67013a1485445a6359aa001a14826
2014-03-06 16:35:52 +00:00
Caolán McNamara
be9c3a83b2 coverity#708903 Unused pointer value
Change-Id: I86bf2361e06bc9beac20b76894b247c46c265b1a
2014-03-06 16:35:51 +00:00
Takeshi Abe
8e65dd0897 Add mode lines
Change-Id: Iae71a0779839015b7c853f93703fe263f84a591a
2014-03-04 17:15:23 +09:00
Stephan Bergmann
b2371492df Use cstdlib std::abs instead of stdlib.h abs
...because the latter lacks the abs(long) overload in some popular environments,
cf. <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60401> "stdlib.h does not
provide abs(long) overload."

Similarly, stdlib.h lacks the abs(float), abs(double), abs(long double)
overloads compared to cmath there, whose use was apparently intended in
sw/qa/extras/ooxmlexport/ooxmlsdrexport.cxx.  Rewrote that to use
CPPUNIT_ASSERT_DOUBLES_EQUAL instead, which revealed that the comparisons need
rather large deltas of .1 resp. .2 (which the original code hid with an
implicit conversion to integral type, thus using an effective delta of 1).

Discovered with -Wabsolute-value ("absolute value function 'abs' given an
argument of type 'long' but has parameter of type 'int' which may cause
truncation of value") recently introduced on Clang trunk towards 3.5.

Change-Id: I4c41575ffdccb2944498b662bd3a53fd510cb0c0
2014-03-03 18:36:55 +01:00
Chris Sherlock
d12324d136 Rename GetGraphics to AcquireGraphics
Currently there are a number of classes that have a function called
GetGraphics(). It returns a SalGraphics instance if one is available
for the sole use of the caller. Some variants keep a pool of available
SalGraphics and return one not currently in use by anyone, creating
extra ones on demand, sometimes up to a set limit and returning NULL
on reaching that limit of simultaneously in use SalGraphics.

This is confusing. What is really happening from the perspective of the calling
is that is that we are attempting to *acquire* ownership of a SalGraphics
instance.

Therefore, rename GetGraphics to AcquireGraphics() which returns a handle to a
SalGraphics if we can acquire a free graphics instance, and NULL if we cannot,
which makes it cleared that ReleaseGraphics should be called on the result
of AcquireGraphics.

The classes that were changed to include the new acquire function are:

* SalFrame
* SalVirtualDevice
* SalInfoPrinter
* PspSalInfoPrinter
* X11SalFrame
* X11SalVirtualDevice
* GtkSalFrame
* KDESalFrame
* TDESalFrame
* WinSalFrame
* WinSalInfoPrinter
* WinSalVirtualDevice
* SvpSalFrame
* SvpSalVirtualDevice
* AquaSalFrame
* AquaSalInfoPrinter
* AquaSalVirtualDevice

Change-Id: Ic39c08a4bcaf665ae08ba2808cd03b0e80790c46
Reviewed-on: https://gerrit.libreoffice.org/8070
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 10:59:19 -06:00
Chris Sherlock
381f8a5673 sal_Bool -> bool in mostly vcl module
Conflicts:
	include/vcl/settings.hxx
	svtools/source/table/tablecontrol_impl.cxx
	sw/source/core/frmedt/fecopy.cxx
	vcl/inc/canvasbitmap.hxx
	vcl/inc/headless/svpframe.hxx
	vcl/inc/unx/salframe.h
	vcl/inc/win/salframe.h
	vcl/inc/win/salprn.h
	vcl/inc/win/salvd.h
	vcl/osx/DragSource.cxx
	vcl/osx/DragSource.hxx
	vcl/osx/DropTarget.cxx
	vcl/osx/DropTarget.hxx
	vcl/osx/OSXTransferable.cxx
	vcl/osx/OSXTransferable.hxx
	vcl/osx/clipboard.cxx
	vcl/osx/clipboard.hxx
	vcl/osx/salprn.cxx
	vcl/qa/cppunit/canvasbitmaptest.cxx
	vcl/source/components/fontident.cxx
	vcl/source/control/edit.cxx
	vcl/source/control/spinfld.cxx
	vcl/source/gdi/gdimtf.cxx
	vcl/source/gdi/virdev.cxx
	vcl/source/helper/canvasbitmap.cxx
	vcl/source/window/dockwin.cxx
	vcl/unx/generic/dtrans/X11_selection.hxx
	vcl/unx/kde/UnxFilePicker.cxx
	vcl/unx/kde/UnxFilePicker.hxx
	vcl/unx/kde4/KDE4FilePicker.cxx
	vcl/unx/kde4/KDE4FilePicker.hxx
	vcl/unx/kde4/KDESalFrame.hxx

Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0
Reviewed-on: https://gerrit.libreoffice.org/8219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28 03:19:47 -06:00
Caolán McNamara
581ffdd286 coverity#1187675 Dereference null return value
Change-Id: I313772d7382c303990f7333990e340803678be79
2014-02-27 12:58:44 +00:00
Caolán McNamara
3a1671b351 coverity#1187674 Dereference null return value
Change-Id: I4fdf0e324463285d086c1503214e2aee0c0537e8
2014-02-27 12:58:44 +00:00
Alexander Wilms
d9f0af83b7 Remove visual noise from vcl
Conflicts:
	vcl/source/app/settings.cxx
	vcl/source/window/dockmgr.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/floatwin.cxx
	vcl/source/window/toolbox2.cxx

Change-Id: Ie67681549a76e77064b09d4b5bf80fe4c6010341
Reviewed-on: https://gerrit.libreoffice.org/8339
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 04:56:16 -06:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
fe7a4bccfd Adapt vcl to various loplugin warnings on Mac OS X
Change-Id: I4553ce218fbcf2ac681b284c71e7d558a451511c
2014-02-21 23:47:23 +01:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Stephan Bergmann
973b47a336 unotools: sal_Bool -> bool
Change-Id: I8051c0756e0474a5b4f748e0aa15a9922e82ea97
2014-02-19 12:47:07 +01:00
Michael Stahl
cdb405f4e4 vcl: CUPS printing: notify user if spooling failed
CUPS does not accept jobs for a printer that has been stopped; pop up
an error message in this case instead of silently ignoring failure.

Change-Id: I1bc9120c9c9f438e350c964ed7ef29924a72ce78
2014-02-18 22:57:25 +01:00
Michael Stahl
c76cd71fe9 fdo#41524: CUPS printing: use "collate" option when PDF is available
Assume that the CUPS printer is able to handle collating by itself,
don't send multiple print jobs (except if user clicks on "Create single
print jobs for collated output" of course...).

To enable collating with PDF based printers, add the "collate" option;
legacy PS based printers still get the weird stuff read from the PPD
(not sure what the risks of changing that are).

Change-Id: Ia12dc69f9083bba94f2ed633ecbd153aac7e40ab
2014-02-18 22:56:51 +01:00
Caolán McNamara
0d3082dbf2 callcatcher: update unused code
Change-Id: Iaaad9302ef8edb47fa95ce8ca608b6f36449521b
2014-02-12 13:03:50 +00:00
Khaled Hosny
9140d27954 Minor
Change-Id: Ic2182ffc76d63b966fc381dadb59af344dda945e
2014-02-05 01:31:36 +02:00
Khaled Hosny
e3a41d57e4 Set HarfBuzz buffer flags for text boundaries
If the run is the start and/or end of the whole text string being laid
out, set corresponding HarfBuzz buffer flags as it will help HarfBuzz
e.g. place a stray combining at the beginning of a paragraph on a dotted
circle.

Change-Id: I05c9fa46b251a2ce4e716da33fb6edda680d2dd1
2014-02-05 01:31:36 +02:00
Stephan Bergmann
c1d37365c4 bool improvements
Change-Id: Iede12ed1e35581cf48d64b898f22949d0c1aa6de
2014-01-28 20:26:19 +01:00
Caolán McNamara
afb90e554c coverity#738921 Uninitialized pointer field
Change-Id: I607a8d75b9ee60015a382ee4111c5ca8bac6a1f8
2014-01-24 15:05:00 +00:00
Caolán McNamara
5b0395948e coverity#735339 Unchecked return value from library
Change-Id: Ia6567cb6f779669c738469ba68b7ad675e99d71a
2014-01-24 15:05:00 +00:00
Stephan Bergmann
b184636e1c bool improvements
Change-Id: I714caa8dc3d34fd56e6a11f57db6723dcb7e6705
2014-01-21 18:24:02 +01:00
Khaled Hosny
718329232e This is an int, not float
Change-Id: Ie3fbda69c5747f4ca42d84c272356ba9f435194e
2014-01-18 01:20:10 +02:00
Khaled Hosny
ee8a36a967 Simplify
Change-Id: Id018e985110b024ff107f4221501ece2cf27f5d3
2014-01-18 01:11:09 +02:00
Khaled Hosny
e41b8ca514 Minor
Change-Id: Iefaa98350c8d6116aa07d4d91be29104a930b8db
2014-01-18 01:11:09 +02:00
Khaled Hosny
1615b7f1d0 Do proper script itemization with HarfBuzz
This implements http://www.unicode.org/reports/tr24/ by using ICU’s
implementation of it, but since the code in question is private API, I
simply copied the two self-contained files.

This commit is best viewed with --ignore-space-change.

Change-Id: I38c385d4fb6f8a2edc804d48f0aa14df9f0a8b3b
2014-01-18 01:11:09 +02:00
Stephan Bergmann
5169abbac9 bool improvements
Change-Id: I7ec4f5b2e691ec03e9e2c5ca3a004f1e04efbc27
2014-01-17 18:45:14 +01:00
Chris Sherlock
7d432a9e67 Remove defines now that fontconfig baseline has been updated
Change-Id: Ia97ab24e60785be36f475f6bf275a0ae336e9408
Reviewed-on: https://gerrit.libreoffice.org/7461
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-16 15:39:09 +00:00
Stephan Bergmann
e632321483 endSpool return value is effectively success flag, not job ID
Change-Id: I5b96eeff80ca29f0f8f24ee6da7a2ca76cbb05ce
2014-01-10 08:30:30 +01:00
Herbert Dürr
a16aacd647 Resolves: #i123840# add and use the sal_GlyphId type
Using the central definition adds consistency and cleans up many ad hoc
declarations. The type sal_GlyphId will become a class in the future so
that its bitfield operations etc. can then be isolated into nice methods.

(cherry picked from commit c0a84ad10964fb7a65b6239cbe1cef8698b5d17b)

Conflicts:
	vcl/aqua/source/gdi/salatslayout.cxx
	vcl/aqua/source/gdi/salgdi.cxx
	vcl/generic/glyphs/gcach_ftyp.cxx
	vcl/generic/print/genpspgraphics.cxx
	vcl/generic/print/glyphset.cxx
	vcl/generic/print/glyphset.hxx
	vcl/headless/svptext.cxx
	vcl/inc/generic/genpspgraphics.h
	vcl/inc/generic/glyphcache.hxx
	vcl/inc/os2/salgdi.h
	vcl/inc/quartz/salgdi.h
	vcl/inc/salgdi.hxx
	vcl/inc/sallayout.hxx
	vcl/inc/unx/salgdi.h
	vcl/inc/vcl/fontmanager.hxx
	vcl/inc/win/salgdi.h
	vcl/os2/source/gdi/os2layout.cxx
	vcl/os2/source/gdi/salgdi3.cxx
	vcl/source/gdi/pdfwriter_impl.cxx
	vcl/source/gdi/sallayout.cxx
	vcl/source/glyphs/gcach_ftyp.hxx
	vcl/source/glyphs/gcach_layout.cxx
	vcl/source/glyphs/glyphcache.cxx
	vcl/source/glyphs/graphite_layout.cxx
	vcl/unx/generic/fontmanager/fontmanager.cxx
	vcl/unx/generic/gdi/gcach_xpeer.cxx
	vcl/unx/generic/gdi/gcach_xpeer.hxx
	vcl/unx/generic/gdi/salgdi3.cxx
	vcl/unx/generic/gdi/xrender_peer.hxx
	vcl/unx/headless/svpgdi.hxx
	vcl/unx/headless/svppspgraphics.cxx
	vcl/unx/headless/svppspgraphics.hxx
	vcl/win/source/gdi/salgdi3.cxx
	vcl/win/source/gdi/winlayout.cxx

Change-Id: Ic629131950360e2df4c15db30d6a5362193c6330
2014-01-06 14:32:30 +00:00
Michael Meeks
2c066ac3df fdo#73280 - always advance the iterator to avoid an infinite loop.
Change-Id: I62f2d8ec5d6d62f1dbe9657cfbbbc90c56cce812
2014-01-04 14:48:47 +00:00
Herbert Dürr
5033fa376f Resolves: #i123840# normalize SalGraphics point count argument types...
to sal_uInt32

The old mixture of sal_uInt32, ULONG, sal_uLong, sal_uIntPtr gets
consolidated. 4e9 points are more than enough for a SalGraphics.

(cherry picked from commit 03f5dce97331acc1a5e832f956d711a5dc0aac0e)

Conflicts:
	vcl/aqua/source/gdi/salgdi.cxx
	vcl/generic/print/genpspgraphics.cxx
	vcl/inc/os2/salgdi.h
	vcl/inc/quartz/salgdi.h
	vcl/inc/salgdi.hxx
	vcl/os2/source/gdi/salgdi.cxx
	vcl/os2/source/gdi/salgdi2.cxx
	vcl/source/gdi/salgdilayout.cxx
	vcl/unx/generic/gdi/salgdi.cxx
	vcl/unx/headless/svpgdi.hxx
	vcl/unx/headless/svppspgraphics.cxx
	vcl/unx/headless/svppspgraphics.hxx

Change-Id: Iddf806256c7e5403158635e3f5f0049e9382500f
2013-12-31 10:45:02 +00:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Jelle van der Waa
417c85bf58 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc
Reviewed-on: https://gerrit.libreoffice.org/7104
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-17 11:57:04 +00:00
Noel Grandin
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
Michael Meeks
8949d6f32a graphite2: get visibility right for static linkage on windows.
Change-Id: I79fa15d539bcb86610dd4def08536c33bd2a10c2
2013-12-13 13:20:10 +00:00
Tor Lillqvist
a0e8a1b691 fontmanager.hxx is private to vcl
Change-Id: Iec1d1539db0b44d2ddc420cf500585098d4793fc
2013-12-11 10:30:02 +02:00