mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356,287 Commits 1 Branch 0 Tags
Commit Graph

716 Commits

Author SHA1 Message Date
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Noel Grandin
adc20c3937 compareToAscii -> equalsAscii 
convert places using compareToAscii that should be using equalsAscii

Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
 2014-06-04 11:52:31 +02:00
Jens Carl
8e115c6008 fdo#68849: Add header guards to all include files 
added header guards for directories basebmp/, chart2/, cppuhelper/,
include/test/, io/test/, sax/test, shell/, writerfilter/, and xmlhelp/

Change-Id: I0e29a9b75c26d71f58aa98986b52f6d3b46015a6
Reviewed-on: https://gerrit.libreoffice.org/9615
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-02 08:46:30 +00:00
Jens Carl
626a428367 fdo#68849: Add header guards to all include files 
Added header guards to files in directories xml*/*

Change-Id: Ia5dfb9ab494bfbfae7537f2d54ff11331dc8c922
Reviewed-on: https://gerrit.libreoffice.org/9539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-05-29 09:02:51 -05:00
Thomas Arnhold
e6ff6f9a71 use namespace css instead of com::sun 
Change-Id: I47582b072bb939cf270a76e430a9f7908b5c1d93
 2014-05-27 14:00:28 +02:00
Thomas Arnhold
3930127dfb cppcheck: redundantAssignment 
Change-Id: I6fcece7f7a77060bfa3cd3d40db3fa4f253cf261
 2014-05-24 15:46:42 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Julien Nabet
036a660a86 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part11 
Change-Id: Ibe0a1006aba2b6cbd87c0bd6ca3acbf9ba7b0fbe
 2014-05-13 23:20:26 +02:00
Julien Nabet
fa51b55680 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part9 
Change-Id: I82ed4a4868cb22566706ca0f4b1321e0d45016cf
 2014-05-10 23:54:07 +02:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false" 
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
 2014-05-05 12:47:48 +02:00
Noel Grandin
abd8c2a0f6 xmlhelp: sal_Bool->bool 
Change-Id: I0aa1b7023b5100fb855a8a839e44036988d8bc2e
 2014-05-02 08:49:21 +02:00
Thomas Arnhold
8bb2ce61c0 fixincludeguards.sh: some smaller dirs 
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
 2014-04-19 11:10:13 +02:00
Stephan Bergmann
9d9f8151f3 Remove unused code 
Change-Id: Ia624a624271b1143c96cd189cc9e4dab4c5ae302
 2014-04-15 09:30:36 +02:00
Thomas Arnhold
0fb30c1e79 typo: misformed -> malformed 2014-04-14 12:32:21 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Norbert Thiebaud
03a6135292 de-macroize xmlhelp ContentProvider 
Change-Id: I806cd7a263dbe37581c8845b4089a76a7d591628
 2014-03-20 20:17:54 -05:00
Norbert Thiebaud
514a6de482 kill ucbhelper XTYPEPROVIDER_DECL macro 
Change-Id: I1daf6661dd7b5be396bec980da84feaab6e6b80f
 2014-03-20 19:33:47 -05:00
Norbert Thiebaud
27399c3433 de-macroize xmlhelp tvfactory 
Change-Id: Ie4b0e0923ade427f7ab637e8e76769a6dca957c5
 2014-03-20 18:03:00 -05:00
Norbert Thiebaud
db5407b6ac de-macroize xmlhelp TVBase 
Change-Id: I92e9bc4bbdf18273d26d666d98401cd83a9b1560
 2014-03-20 17:56:12 -05:00
Noel Grandin
86a32589e9 Find places where OUString and OString are passed by value. 
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
 2014-03-18 08:32:26 +02:00
Norbert Thiebaud
2ef98b947e kill XINTERFACE_IMPL_6 
Change-Id: I1445524d3c15a3dec881c1499910779b9d61b840
 2014-03-05 09:44:18 -06:00
Norbert Thiebaud
66f2c35fac de-macroize XINTERFACE_DECL 
Change-Id: Iaa1cf999189f6b62547c208eadc38150400ca0fe
Reviewed-on: https://gerrit.libreoffice.org/8454
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-03-05 09:29:24 -06:00
Marcos Paulo de Souza
4d6560f506 fdo#54938: Convert some places to use cppu::supportsService 
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
 2014-03-04 07:30:02 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
003342bfef Remove visual noise from xmlhelp 
Change-Id: Idd4d9d556d6644350d1a14b9f81f5fd0df8ee2d1
Reviewed-on: https://gerrit.libreoffice.org/8344
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 03:50:15 -06:00
Caolán McNamara
5c94648354 coverity#708696 Uninitialized scalar field 
Change-Id: If22c709ebab80d626d3d409fd6ba718781cff07d
 2014-02-21 12:40:36 +00:00
Noel Grandin
08fe82e59c Remove unnecessary use of OUString constructor in + expressions 
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
 2013-12-17 11:49:03 +02:00
Caolán McNamara
6b713bafe4 Related: fdo#72022 internal links busted 
regression since 58fa3d50aa43102cea8690fd6bf51fb80c007955

Change-Id: I499704d18872da6f2f01cf955a6496104c53dd3f
 2013-12-06 15:00:25 +00:00
Caolán McNamara
57b15f2dcd Resolves: fdo#72022 Integrated help ignored if installed 
regression since 58fa3d50aa43102cea8690fd6bf51fb80c007955

Change-Id: Ia20f28daace30181652bbbbec3f9845045db03b4
 2013-12-06 13:27:57 +00:00
Marcos Paulo de Souza
1c3d51fd68 fdo#60698: Merge tvhlp1 into ucpchelp1 
tvhlp1 just have 2 files, and this lib is used always with ucpchelp1. By
these reasons, we can merge these 2 libs.

Change-Id: I515f9c12893c986279ffac91b83879c467b091c7
Reviewed-on: https://gerrit.libreoffice.org/6820
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-12-02 05:15:36 -06:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Norbert Thiebaud
bd7f704ed4 xmlhelp: include <> for external includes 
Change-Id: I274968e015f1d0c3d06aa5040f53b72d14c45b9f
 2013-11-11 22:37:29 -06:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00
Noel Grandin
58fa3d50aa remove unnecessary use of OUString constructor in XMLHELP module 
Change-Id: I033bcf9cddc58f605fe8d65731f8b312410da7e5
 2013-11-07 13:22:56 +02:00
Noel Grandin
5285beeaa4 remove redundant calls to OUString constructor in if expression 
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
 2013-11-04 10:11:08 +02:00
Caolán McNamara
b7efab3a98 valgrind: on success aHDFData is out of scope 
and pData points to data belonging to it

Change-Id: I2a3c1f73e4cdcb07d21ef14cb410d351f39cdba8
 2013-10-24 16:33:14 +01:00
Caolán McNamara
d94f3a68f7 pEmpty is completely insane to use 
DbtToStringConverter protects against a NULL pointer, but not a
pointer to the too short data that pEmpty provides

Change-Id: I5d21e852ce0373eff7d3627e266b9cbc77f5dd09
 2013-10-24 16:33:14 +01:00
Thomas Arnhold
f852bda5ec clean up some include guards 
Conflicts:
	sw/source/ui/inc/content.hxx

Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6
Reviewed-on: https://gerrit.libreoffice.org/6388
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-10-23 10:28:07 +00:00
Marcos Paulo de Souza
ee5661ecd3 fdo#54938: Adapt supportsService implementations.. 
to cppu::supportsService

Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-22 10:28:10 +00:00
Thomas Arnhold
67aec43915 cleanup 
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
 2013-10-16 05:41:26 +02:00
Caolán McNamara
9af3b8b4ff CID#705780 seeing as this is irredeemably wrong remove it 
This is catastrophically wrong, just appear to be lucky that
this code path is never called, so remove it entirely rather
than mess around fixing it

Change-Id: I4a8a443ed20b7e11cd9cc69b3d66d28087f09db8
 2013-10-03 13:09:21 +01:00
Caolán McNamara
ebfa1e6c86 CID#707598 uninitialized scalar values 
Change-Id: Id3c6488cfda25ab809bf554216bf2e5161456be0
 2013-09-21 12:36:43 +01:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf() 
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
 2013-08-21 15:10:35 +02:00
Tor Lillqvist
058a3d1c46 Further work on the "Mac-like app structure" option 
Lots of stuff still either ended up in the wrong place, or was looked up from
the wrong place, or both. Fix most cases.

Change-Id: I06ebbce207c219f3cd82b4387dd9b3fdb83420d4
 2013-08-18 21:11:16 +03:00
Tor Lillqvist
c6a7300974 Use subfolder names from <config_folders.h> 
Change all instances of hardcoded "program", "share" etc subfolder names to
use those from <config_folders.h> instead. In normal builds, the end result
will not change.

Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
 2013-08-18 21:11:16 +03:00
Jelle van der Waa
87b5ac652d fdo#57950: Remove some chained appends in xmhelp 
Change-Id: I4680547aa1d12d3e8eab3c33e3158845848c2068
Reviewed-on: https://gerrit.libreoffice.org/5376
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
 2013-08-13 11:11:42 +00:00
Jelle van der Waa
2f66b0cb11 fdo#62475 removed pointless comments 
Change-Id: I4fa01553246fa023806b3fec8e6e756a1efa59f1
Reviewed-on: https://gerrit.libreoffice.org/5342
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2013-08-10 19:23:25 +00:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00