Andrea Gelmini
64a3124d92
Fix typos
...
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3
Reviewed-on: https://gerrit.libreoffice.org/41194
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2017-08-17 21:53:28 +02:00
Noel Grandin
2e8acde112
remove UL/L suffixes from integer constants on the RHS of expressions
...
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5
Reviewed-on: https://gerrit.libreoffice.org/41237
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-17 11:25:21 +02:00
Noel Grandin
ff1f6a5fc2
remove UL/L suffixes from integer constants in initialiser/call expressions
...
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300
Reviewed-on: https://gerrit.libreoffice.org/41214
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-17 08:14:31 +02:00
Noel Grandin
224b770fa7
remove UL/L suffixes from shift-by-constant expressions
...
Change-Id: Ia470f643e3eefeccc14183133603db260460bd53
Reviewed-on: https://gerrit.libreoffice.org/41212
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-17 08:14:03 +02:00
Noel Grandin
db17a874af
convert std::map::insert to std::map::emplace II
...
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331
Reviewed-on: https://gerrit.libreoffice.org/41019
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-11 13:51:29 +02:00
Noel Grandin
3dcf6dfcee
remove unnecessary use of 'this->'
...
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-02 13:45:36 +02:00
Noel Grandin
b32ead5dd2
loplugin:checkunusedparams more part1
...
seems I got one of the checks wrong, and was missing a bunch of stuff
Change-Id: I2c662fc4e735f8d6cbe56c6f82906a60a580331b
Reviewed-on: https://gerrit.libreoffice.org/40481
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-28 07:17:51 +02:00
Caolán McNamara
81047eaebc
make animation loop sal_uInt32 consistently
...
all this foo is ultimately animated gifs and the count there is
limited to unsigned 16bit
Change-Id: Ib6e6dde7355f3619bb7735743e686e6338a235ee
2017-07-27 13:32:53 +01:00
Noel Grandin
b9982b51f4
loplugin:constparams in slideshow
...
Change-Id: Ifa9fda35020d456338781879df9fba4c0ee535fd
Reviewed-on: https://gerrit.libreoffice.org/40469
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-27 09:38:38 +02:00
Noel Grandin
7de833a626
simplify calls OUString::copy in foo.copy(x, foo.getLength() - x)
...
Change-Id: I20318c77dcc3bc2a64336541ef5a3f412bfd9483
Reviewed-on: https://gerrit.libreoffice.org/39803
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-11 14:13:03 +02:00
Noel Grandin
868d8c8f0f
loplugin:unnecessaryparen handle parens inside call expr
...
stick to single-arg function calls, sometimes parens in multi-arg calls
might be there for clarity
Change-Id: Ib80190c571ce65b5d219a88056687042de749e74
Reviewed-on: https://gerrit.libreoffice.org/39676
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-07 10:45:05 +02:00
Noel Grandin
ab9b38a406
use more begin()/end() for Sequence
...
Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
2017-07-06 08:35:23 +02:00
Noel Grandin
4b2262ab5b
new loplugin unnecessaryparen
...
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-05 11:08:48 +02:00
Noel Grandin
e037381f85
loplugin:unusedfields in slideshow..svtools
...
Change-Id: I74d5a4b8cfc4b18267f99648a3112b163c91fd8c
Reviewed-on: https://gerrit.libreoffice.org/39474
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-03 16:03:34 +02:00
Jochen Nitschke
c4ddf6cd6d
C++11 remove std::unary_function bases from functors
...
std::unary_function is deprecated since C++11 and removed in C++17
90% done with regexp magic.
removed obsolete <functional> includes.
The std::unary_function base class was used in 3 places:
* chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole
is used in a std::not1 function helper who uses the members
return_type and argument_type.
- replace deprecated std::not1 with a lambda
* chart2/source/tools/ModifyListenerHelper.cxx:
lcl_weakReferenceToSame used the argument_type member in the
operator() parameter.
- inline the parameter type.
* xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement
used result_type and argument_type in operator().
- inline the types
Also fix compile error with gcc about finding std::for_each.
Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f
Reviewed-on: https://gerrit.libreoffice.org/39358
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2017-07-03 12:21:03 +02:00
Stephan Bergmann
58c0252f37
loplugin:casttovoid: slideshow
...
Change-Id: Iaa330dc5cedd31fb3f35e6ebdef62a99900f0ee0
2017-07-02 22:30:18 +02:00
Noel Grandin
2fb2d6efdb
loplugin:oncevar in scaddins..sot
...
Change-Id: I657a131374b9f1153135e00ed429889518b91427
Reviewed-on: https://gerrit.libreoffice.org/39258
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-26 14:00:59 +02:00
Andrea Gelmini
dbcc169d8c
Fix typos
...
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5
Reviewed-on: https://gerrit.libreoffice.org/39232
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-06-26 09:20:18 +02:00
Jochen Nitschke
a5dba7dbec
remove unused osl/mutex.hxx includes
...
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
2017-06-18 13:38:25 +02:00
Caolán McNamara
277395b626
make opengl transitions under X flicker free on enter/leave
...
Change-Id: I109637dc6b3d23c0beca21f3cf0c7ba918ecb4f8
Reviewed-on: https://gerrit.libreoffice.org/38749
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-06-13 22:06:04 +02:00
Jochen Nitschke
febbad7263
cleanup unused css/frame/* includes
...
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-12 13:05:38 +02:00
Caolán McNamara
756e090b7f
logging the simple message is sufficient
...
Change-Id: I84bced2b8dd92082f4777e00261ac87752278527
2017-06-11 13:40:34 +01:00
Caolán McNamara
595740608f
logging the simple message is sufficient
...
Change-Id: I04ad6cb063af53f79245f923c022f3f9cd3abebd
2017-06-10 16:18:06 +01:00
Noel Grandin
2ccde70d60
teach redundantcast plugin about functional casts
...
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-30 08:50:31 +02:00
Noel Grandin
ef513fd4b0
remove unnecessary use of OString::getStr
...
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-28 19:44:08 +02:00
Jochen Nitschke
8f999d656a
cleanup unused css/animations/ and css/presentation/ includes
...
Change-Id: Iafd106d431869d80f664bd540092bee4f10e14b5
Reviewed-on: https://gerrit.libreoffice.org/37862
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-21 21:05:05 +02:00
Stephan Bergmann
52ef15cbdb
Revert "Fix typos"
...
This reverts commit 26a67002fc
. "Iff" is not a
typo, see 2a65bf32ec
"Revert 'Typo: iff->if'".
2017-05-18 21:58:31 +02:00
Andrea Gelmini
26a67002fc
Fix typos
...
Only replaced "iff" with "if"
Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581
Reviewed-on: https://gerrit.libreoffice.org/37782
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Eike Rathke <erack@redhat.com >
2017-05-18 18:55:17 +02:00
Noel Grandin
389da66dfc
remove unused uno::Reference vars
...
found by temporarily marking Reference as SAL_WARN_UNUSED.
Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-12 09:56:01 +02:00
Chris Sherlock
97eb00c75e
revert OSL_ASSERT changes
...
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07 17:03:35 +10:00
Chris Sherlock
6ffc3cf9e5
tdf#43157: convert slideshow module away from OSL_ASSERT to assert
...
Change-Id: I6a067922bd701387172d94713ec05fc3313de19c
2017-05-07 11:16:44 +10:00
Noel Grandin
9348b322a5
clang-tidy readability-simplify-boolean-expr
...
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a
Reviewed-on: https://gerrit.libreoffice.org/36450
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-28 11:23:34 +02:00
Caolán McNamara
ea9a31e3f1
logging the simple message is sufficient
...
Change-Id: I50050001f080f668bded036372feeb271da4a7c6
2017-04-16 14:47:12 +01:00
Stephan Bergmann
e40f3cf330
Improved loplugin:redundantcast, static_cast on arithmetic types: slideshow
...
Change-Id: I5f2031068ef0ab8e777fddfa90e7a15836938b48
2017-04-06 18:31:23 +02:00
Noel Grandin
5d0e485e82
use actual UNO enums in reportdesign..svtools
...
Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203
Reviewed-on: https://gerrit.libreoffice.org/36043
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-03 09:40:19 +00:00
Miklos Vajna
a5a571307f
tdf#82580 tools: rename Rectangle to tools::Rectangle
...
Mostly generated using
make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"
Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.
Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
Tested-by: Jenkins <ci@libreoffice.org >
2017-03-31 06:27:11 +00:00
Andrea Gelmini
2eae33e82e
Fix typos
...
Change-Id: I5518e764fd8349c476e79bb888e93a1dab01ed1d
Reviewed-on: https://gerrit.libreoffice.org/35644
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-26 14:02:41 +00:00
Noel Grandin
53bfd644d2
convert UpdateFlags to scoped enum
...
Change-Id: I73121e85a927bae3f042a2bbc0283a28067b891f
Reviewed-on: https://gerrit.libreoffice.org/35553
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-23 10:29:17 +00:00
Caolán McNamara
01112d2a63
some OSL_FAIL to SAL_WARN
...
Change-Id: I5101e42b7a34cca9055fc805d9a392ba4f920a3d
2017-03-09 20:59:10 +00:00
Caolán McNamara
57b8a0c317
show the last gif frame when the animation ends
...
Change-Id: I240d0a46cff905edababbd13fe7e58c9e4d0f0db
2017-03-08 11:37:12 +00:00
Stephan Bergmann
823956aa8f
loplugin:loopvartoosmall
...
Change-Id: Ib8737f1690c738016fcdc1f365b744fcb567ce57
2017-03-08 10:57:07 +01:00
Stephan Bergmann
6cb9e6dad7
Remove redundant 'inline' keyword
...
...from function definitions occurring within class definitions. Done with
a rewriting Clang plugin (to be pushed later).
Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-03-03 20:55:50 +00:00
Noel Grandin
198c41c4fe
new loplugin unoany
...
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-28 10:17:47 +00:00
Stephan Bergmann
18339e9eb6
loplugin:subtlezeroinit: slideshow
...
Change-Id: I1280b51f42c21d15c76ea54a11c7a5a72930d566
2017-02-21 07:34:59 +01:00
Noel Grandin
2a89b42e7d
convert AttributeType to scoped enum
...
and drop unused CHAR_ROTATION enumerator
Change-Id: I9ca50aef41fa736c7f34c210844fb54f60f5bca8
2017-02-15 08:33:37 +02:00
Noel Grandin
0102b85e4e
convert DocTreeNode::NodeType to scoped enum
...
and drop unused enumerators
Change-Id: I0b9220cc2a70847ee43b63accec5bede3dbb99fa
2017-02-15 08:33:37 +02:00
Noel Grandin
602a07e110
drop CycleMode enum
...
since we only ever used the CYCLE_LOOP enumerator
Change-Id: I181be1e1bba7f72f64420ab22e119d2bffad2d37
2017-02-15 08:33:37 +02:00
Noel Grandin
dd803c6e25
convert ReverseMethod to scoped enum
...
and drop unused enumerators
REVERSEMETHOD_INVERT_SWEEP
REVERSEMETHOD_SUBTRACT_POLYGON
Change-Id: I11b52d4b32e5f766dfa3bcd69b9c636f4106b7b4
2017-02-15 08:33:37 +02:00
Tor Lillqvist
9d29d3dad4
BOOST_SPIRIT_SINGLE_GRAMMAR_INSTANCE has been defined forever in these files
...
Change-Id: I0afa1b404192f44540aa318e748452e0328fac6b
2017-02-14 21:21:29 +02:00
Stephan Bergmann
6dce9c6757
Add missing #includes
...
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849
"Remove dynamic exception
specifications".
Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00