389200 Commits

Author SHA1 Message Date
Caolán McNamara
591e0c10af crashtesting: moz397551-1.svg detect self-referencing 'use' loop
Change-Id: Ibc9001f02c89bcfdff396cd694d0de378c6d1863
2016-03-04 15:04:58 +00:00
Miklos Vajna
3cefd33eb5 CppunitTest_xmlsecurity_signing: add signature removal testcase
Fails with the previous commit reverted.

Change-Id: I050a03fa923980e46b31eff457d0b83f6c38ceaf
2016-03-04 16:01:34 +01:00
Miklos Vajna
c30bf0284c xmlsecurity OOXML export: handle keeping all signatures but one
The removal of the _xmlsignatures sub-storage in
DocumentSignatureHelper::OpenSignatureStream() serves 3 purposes:

1) Remove no longer needed signature streams
2) Truncate signatures relation stream
3) Truncate still needed signature streams

2) and 3) could be done using io::XTruncate as well, but if the whole
storage is removed to handle 1), then individual truncate() calls are
not necessary.

Change-Id: Id9ed9c87c94f340dc947124b28f085561798d361
2016-03-04 16:01:34 +01:00
Miklos Vajna
4351ff1f12 xmlsecurity: extract signature removal logic from DigitalSignaturesDialog
So that it'll be possible to call that code without an active dialog,
from a headless unit test.

Change-Id: I1728a666ff5d84b337efd7e2b7eb68469896257a
2016-03-04 16:01:34 +01:00
Stephan Bergmann
4225092a35 cid#1326861,1326862: Eq: Problems with implementation of equals()
Cloneable, odd additional equals overloads, odd hasCode implementation---all
smells like clueless cargo cult.  And I see no place where it would get used.

Change-Id: Icca89531ce9181fb47eacfb6fae704f4f45012a9
2016-03-04 15:51:04 +01:00
Stephan Bergmann
305453d2c7 This ScriptEntry ctor is always called with empty languagedepprops
Change-Id: Ia8ddfecf2f809e9f0132ba59812446973532476c
2016-03-04 15:37:15 +01:00
Stephan Bergmann
8a4e256d67 Scripting.location is unused
Change-Id: Ia534b5aa579a678f8b0273e6c8c12a6ad335c67a
2016-03-04 15:34:45 +01:00
Stephan Bergmann
90033c542b ScriptEntry fields can be final
Change-Id: I7616641584b7ea8192cf3724d8b7d5b88af39da6
2016-03-04 15:31:38 +01:00
Stephan Bergmann
8e4c33799f Turn forwarding among ScriptEntry ctors around, dropping one
Change-Id: If3c86c7e5c4acaf4a3e48194e24c3c73e4e99499
2016-03-04 15:30:46 +01:00
Stephan Bergmann
9b70fdf5ed Remove unusd ScriptEntry ctor
Change-Id: I7109877e789659b87cbc16e9c5da39dcc8249e09
2016-03-04 15:29:19 +01:00
Stephan Bergmann
05dba6868e Forwarding-only ctor, can be private
Change-Id: I9ed2aa9c2bf2e17705dc711560154a9596c8264a
2016-03-04 15:26:03 +01:00
Stephan Bergmann
04b5ae6221 This ScriptEntry ctor is only needed by ctor of derived class ScriptMetaData
Change-Id: If3e6aae326aa53825edca9d5dc207d185d288cce
2016-03-04 15:23:38 +01:00
Stephan Bergmann
2e96766428 Remove unused ScriptEntry.setLogicalName
Change-Id: Iad58e4227433b766bbdce92a53c95aed48320f88
2016-03-04 15:20:45 +01:00
Stephan Bergmann
cf6e5f5b6d Parcel.getByName apparently wants to return ScriptMetaData
Change-Id: I4a710384ec3a0d719f2ad1fbbe7b43b0be1fa1d9
2016-03-04 15:09:14 +01:00
Marco Cecchetti
0cb71c1017 tdf#98052 - polypolygons were not drawn on the alpha device
In OutputDevice::DrawPolyPolygon when b2dpolygon are used for drawing
the source polygon is not drawn on the alpha device.

Change-Id: I54f4e5a13469d9844866cea61b074420219b836d
Reviewed-on: https://gerrit.libreoffice.org/22892
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-04 13:26:20 +00:00
Stephan Bergmann
9dcd54014c cid#1327083 SWL: Sleep with lock held
It's unclear to me why the disposeOffice method was marked "synchronized" in the
first place with fbd72be142ed23b3b526c8d0c3e002f15ca7ec74 "INTEGRATION: CWS
qadev16: #114831#."  Maybe just some cluelessness?  Lets see whether we ever run
into any problems after removing it.

Change-Id: I1f262b6b4b4f4e8911754a6b3fa3d61f5df0aeae
2016-03-04 14:21:22 +01:00
Pranav Kant
e04284587a lok: Export only programmatic style names
First, it reverts b0111f494c1ee2d75ac4f1544c06c24d464cc416. It
was a bad idea to export UI names via LOK because the client
would need the programmatic ones anyways for UNO commands. We
cannot expect UNO commands to accept UI style names and work,
though that's another thing that they will work in most cases
because mostly UI names are equal to programmatic ones. Clients
are now supposed to have their own UI name <-> programmatic name
mapping, if they want style names to use for translations.

Secondly, it fixes a bug that was already there mixing programmatic
names with UI ones in an effort to put default writer styles on
the top of the list.

Change-Id: I307f987fe740b3c43b0e14ec4773edcb672a11df
Reviewed-on: https://gerrit.libreoffice.org/22810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-03-04 13:20:15 +00:00
Caolán McNamara
63af0c1481 add config namespace cause we use config: elements
Change-Id: I34d47e854999eb2e8fd118351ff3b3577a1083d7
2016-03-04 13:18:23 +00:00
Andras Timar
a775bfb99e Don't build ui-previewer in the App Store case
Change-Id: I25ca4b8672702095cc04723bc9c6bdf01a06382f
2016-03-04 13:34:50 +01:00
Andras Timar
d037081169 harden OS X code signing script (handle spaces in bundle name)
Change-Id: Icf9bdcd0bcd988d32477cf9ab7f8d917ff6a2275
2016-03-04 13:34:49 +01:00
Andras Timar
7bba75cf5b remove unopkg script from MacOSX folder of sandboxed app
Change-Id: Ib59953225480e6923e418b966cce289f07f863b5
(cherry picked from commit f16f8ee5c2a269339a36bf6af9b24b50b4328a37)
2016-03-04 13:34:49 +01:00
Andras Timar
32c8ba6492 Don't put symlink to MacOS folder of sandboxed app
Conflicts:
	ure/Package_install.mk

Change-Id: Ica4cfd3befa67aa1d03140ad2a766dfbb208ec0a
(cherry picked from commit d6785e162fa8cc4b03de76cd2d089d62ae45c068)
2016-03-04 13:34:48 +01:00
Andras Timar
3a663f7a45 Don't package unoinfo in case of Mac OS X like app structure
Change-Id: I517ed7ac43b0655c7e571e0b9fead32c4f2e7948
(cherry picked from commit ec51b41ba4831ce43a4f3ead47c72d2d6a884f61)
2016-03-04 13:34:48 +01:00
Andras Timar
ea1ca253d3 shell script in Contents/MacOS is not accepted
(cherry picked from commit c5d91c02192f4272ad2a200beffa059a7dc7a146)

Conflicts:
	scp2/source/ooo/file_ooo.scp

Change-Id: Ib047b763bfeff9dbf43db8fc11e6fd7f1fa179f8
2016-03-04 13:34:48 +01:00
Lionel Elie Mamane
606efa8fb4 pgsql-sdbc: put local code and constants in anonymous namespace
Change-Id: Iaccda39ddf651f6b2ef326c9b3903670c25bcdde
2016-03-04 13:16:43 +01:00
Lionel Elie Mamane
5cbb6631e6 pgsql-sdbc: factorise common code
Change-Id: Iea185bc216e92baee9f97157b8ac13a9a64f99b5
2016-03-04 13:16:42 +01:00
Lionel Elie Mamane
0b0c99edbb tdf#92538 pgsql-sdbc make a reasonable sorting of types
Change-Id: I74283234834b5057857620ed2466068e88628585
2016-03-04 13:16:41 +01:00
Lionel Elie Mamane
ac1468e2ef pgsql-sdbc: "text" dataype is *LONG*VARCHAR
Change-Id: Idd01299ef4592b43e573c3b0996d4822664c6bcf
2016-03-04 13:16:41 +01:00
Lionel Elie Mamane
a55f22ef4c fixup startsWith vs == in string comparisons
probably left-over from OUString transition

Change-Id: I29f8f34ad44828608aa16b0b0a0759e887e280af
2016-03-04 13:16:40 +01:00
Noel Grandin
4d0003df73 loplugin:unuseddefaultparam in cui
Change-Id: I83c35b7a71d0becb98e739f076f42ce58b9e1cd8
2016-03-04 14:01:19 +02:00
Noel Grandin
9b3b0b1ceb loplugin:unuseddefaultparam in filter
Change-Id: Ieaad3145c01dc4ea7b3e7eb7859db89ebd1d7fe1
2016-03-04 14:01:19 +02:00
Noel Grandin
1fd781e7cd loplugin:unuseddefaultparam in oox/reportdesign/sd
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
2016-03-04 14:01:19 +02:00
Tomáš Chvátal
a4c1704127 Fix python2 build of pyuno with older py2 versions
SyntaxError: ('invalid syntax', ('//usr/lib64/libreoffice/program//uno.py',
368, 77, "            return _ConstantGroup({c.Name.split('.')[-1]:
c.ConstantValue for c in td.Constants})\n"))

Change-Id: Ie87c21fbfd83fc4d6f918eb55128db235c2220a8
Reviewed-on: https://gerrit.libreoffice.org/22863
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-04 11:45:14 +00:00
Stephan Bergmann
d7c4c45bc8 Use existing "sal.osl" log area
Change-Id: I7d48c1543b0d3239c8e646ca0765421f933cfecc
2016-03-04 12:35:42 +01:00
Stephan Bergmann
c3ab4e1970 sal/test/testbootstrap.cxx is dead test code
...so no need to add dead log areas here (as questionably introduced with
f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove OSL_DEBUG_LEVEL > 1
conditionals")

Change-Id: Id0544a76f9c426bc06e327f0f2ec2d421da1fa50
2016-03-04 12:31:13 +01:00
Stephan Bergmann
56388a7ea9 Probably better to not disable this cache in all debug modes
(f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove OSL_DEBUG_LEVEL > 1
conditionals" had changed it from OSL_DEBUG_LEVEL > 1 to > 0)

Change-Id: I40714993fb55ec27b80d225cec28c64f2959ab73
2016-03-04 12:27:26 +01:00
Stephan Bergmann
72b724ad8e Spurious spaces
Change-Id: I60bb1e303f7a26b4324cccf2858258a375b53f34
2016-03-04 12:25:26 +01:00
Caolán McNamara
0b9ceae7da coverity#1326474 Resource leak on an exceptional path
Change-Id: I13047e59fc10ab169072f84c75ba88c569d16bd6
2016-03-04 11:24:27 +00:00
Caolán McNamara
1e83fab9b4 coverity#1326516 Resource leak on an exceptional path
Change-Id: I91cc5614fb0db76eabd46cbe7e39ae33227728b7
2016-03-04 11:24:27 +00:00
Caolán McNamara
b08e200c3d coverity#1326237 Dereference after null check
Change-Id: Iac84adff096c5b847b2a63ac57ddf5b2f5e34e11
2016-03-04 11:24:27 +00:00
Caolán McNamara
5adfcaaadc coverity#1326304 Explicit null dereferenced
Change-Id: I9eb58884e41d9669d2413f7b5b63bddf6a4b4320
2016-03-04 11:24:27 +00:00
Caolán McNamara
8a1c6cba0a coverity#1326460 Dereference null return value
Change-Id: I18a80d7695f081c6f274dd7de68bd4dee1054be4
2016-03-04 11:24:27 +00:00
Caolán McNamara
1ffa92cfe3 coverity#1326333 Unguarded write
Change-Id: I94026a7b66a0cac01a1e42d8eee0ec7b4d5fc513
2016-03-04 11:24:27 +00:00
Stephan Bergmann
d35eac83ab This is test code, OK to unconditionally print to stdout
...and where appropriate use CPPUNIT_ASSERT_EQUAL to have no need to always
print out certain values

Change-Id: Iad2ccb235b09852fffd3f010cf069c45b36e2d4b
2016-03-04 12:21:03 +01:00
Noel Grandin
46c67c4323 loplugin:unuseddefaultparam in tools
Change-Id: I027f4d53e3aa793bd61bf110899e464a9b6430ec
Reviewed-on: https://gerrit.libreoffice.org/22891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04 11:20:09 +00:00
Katarina Behrens
ff45bc3346 tdf#98083: Always save cell format
it was pretty bad idea not to save it for rich-formatted cells
(tdf#92296) as there is more to cell format than just a font

Change-Id: I0e5e7d7187c69519bb8f4de2b627e385fccd3d46
Reviewed-on: https://gerrit.libreoffice.org/22762
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-03-04 11:16:46 +00:00
Stephan Bergmann
066a81ee8d This is test code, OK to unconditionally print to stdout
Change-Id: I419aba8728b3a65fca69c82a4f950daaf4815187
2016-03-04 12:14:51 +01:00
Stephan Bergmann
443208dce7 Remove write-only g_nSocket* debug vars
Change-Id: Ie8a1d015242450094928863013030b4cb0bb1f4e
2016-03-04 12:07:15 +01:00
Stephan Bergmann
4b47853acc Clean up a SAL_WARN_IF
Change-Id: I8a945f3e83559f421aa1a0b4fbfcec1b25932ef7
2016-03-04 12:05:42 +01:00
Miklos Vajna
78a209b951 CppunitTest_xmlsecurity_signing: add signature append testcase
Fails with e.g. commit 963264a417ce807201f0021fc6000ce7d6cf0245
(xmlsecurity OOXML export: don't loose old signatures when adding a new
one, 2016-03-03) reverted.

Change-Id: Ia2b0f3d8914bca14075481f5ac8cd4c0033d26c1
2016-03-04 11:48:48 +01:00