The removal of the _xmlsignatures sub-storage in
DocumentSignatureHelper::OpenSignatureStream() serves 3 purposes:
1) Remove no longer needed signature streams
2) Truncate signatures relation stream
3) Truncate still needed signature streams
2) and 3) could be done using io::XTruncate as well, but if the whole
storage is removed to handle 1), then individual truncate() calls are
not necessary.
Change-Id: Id9ed9c87c94f340dc947124b28f085561798d361
Cloneable, odd additional equals overloads, odd hasCode implementation---all
smells like clueless cargo cult. And I see no place where it would get used.
Change-Id: Icca89531ce9181fb47eacfb6fae704f4f45012a9
In OutputDevice::DrawPolyPolygon when b2dpolygon are used for drawing
the source polygon is not drawn on the alpha device.
Change-Id: I54f4e5a13469d9844866cea61b074420219b836d
Reviewed-on: https://gerrit.libreoffice.org/22892
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
It's unclear to me why the disposeOffice method was marked "synchronized" in the
first place with fbd72be142ed23b3b526c8d0c3e002f15ca7ec74 "INTEGRATION: CWS
qadev16: #114831#." Maybe just some cluelessness? Lets see whether we ever run
into any problems after removing it.
Change-Id: I1f262b6b4b4f4e8911754a6b3fa3d61f5df0aeae
First, it reverts b0111f494c1ee2d75ac4f1544c06c24d464cc416. It
was a bad idea to export UI names via LOK because the client
would need the programmatic ones anyways for UNO commands. We
cannot expect UNO commands to accept UI style names and work,
though that's another thing that they will work in most cases
because mostly UI names are equal to programmatic ones. Clients
are now supposed to have their own UI name <-> programmatic name
mapping, if they want style names to use for translations.
Secondly, it fixes a bug that was already there mixing programmatic
names with UI ones in an effort to put default writer styles on
the top of the list.
Change-Id: I307f987fe740b3c43b0e14ec4773edcb672a11df
Reviewed-on: https://gerrit.libreoffice.org/22810
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
...so no need to add dead log areas here (as questionably introduced with
f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove OSL_DEBUG_LEVEL > 1
conditionals")
Change-Id: Id0544a76f9c426bc06e327f0f2ec2d421da1fa50
(f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove OSL_DEBUG_LEVEL > 1
conditionals" had changed it from OSL_DEBUG_LEVEL > 1 to > 0)
Change-Id: I40714993fb55ec27b80d225cec28c64f2959ab73
...and where appropriate use CPPUNIT_ASSERT_EQUAL to have no need to always
print out certain values
Change-Id: Iad2ccb235b09852fffd3f010cf069c45b36e2d4b
it was pretty bad idea not to save it for rich-formatted cells
(tdf#92296) as there is more to cell format than just a font
Change-Id: I0e5e7d7187c69519bb8f4de2b627e385fccd3d46
Reviewed-on: https://gerrit.libreoffice.org/22762
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Fails with e.g. commit 963264a417ce807201f0021fc6000ce7d6cf0245
(xmlsecurity OOXML export: don't loose old signatures when adding a new
one, 2016-03-03) reverted.
Change-Id: Ia2b0f3d8914bca14075481f5ac8cd4c0033d26c1