LOK_CALLBACK_PARTS_COUNT_CHANGED did not cover more complex scenarios, like
more pages deleted at the same time, etc.
Instead, we need to trigger the LOK_CALLBACK_DOCUMENT_SIZE_CHANGED, and the
client has to be smart enough to update the previews in a way that does not
consume too much resources - ie. it has to have a link between the part names
(which are unique) and the previews, and request only the missing ones.
Change-Id: I36ff5dc86f360e3c7bd2c55fae8aaa99e054b4eb
... unless the policy changes the default already.
This was the date of the classification is stored in the document, and
can be inserted as a field as well, but if the policy has an explicit
classification start date, we don't overwrite that.
Change-Id: I17974d73a415a2c8032df48aa7b7f4eebb7178ab
The feature for debugging seems unused so long that defining
ENABLE_DEBUG_DUMPASDOT breaks the build but no one complains.
So let's ditch it.
Change-Id: I0b472cd1acbcfd0c2550c3bd36661c91bc2e2986
Reviewed-on: https://gerrit.libreoffice.org/22608
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
genLang produces errors on the clang tinderbox, due to the way
it uses a singleton.
Removed genLang from Module in order to satisfy tinderbox, while
fixing the problem.
Change-Id: I03a6175de8340f1c0ad5953b32659106e10d75f5
Consistency is important. (I know that we are wildly inconsistent in
many things, even inside individual source files. Like the spacing of
the expression in an if statement. But putting an opening brace on a
separate line is something we do quite consistently.)
Change-Id: I7c50628653b94a4da0fc4dc8db8869a5f1a64527
the genLang project aims at replacing all l10ntools with more
modern versions, based on C++ and lex.
The current extract works basically as a standalone "find" over the
source tree. genLang can use that, but also a more efficient way, by
having translation-worthy files declared in the makefile stubs.
genLang itself is a C++ framework, where each file type is defined as
a class, making it easy to add new file types.
genLang can easily be adopted to transform the help files into e.g.
mediawiki format, and later merge a url back into the code.
The project was first developed (solely by the author) in a non
published branch of OO. This branch was never merged but deleted
and therefore never published.
The files have been adapted to the LO build system and setup.
The primary commit is just to raise awareness, that this is being
developed. The following commit, will update the source code to LO
standard. Before replacing the old modules a dedicated review will
be asked for.
Change-Id: I4504992474333c476c179903f822bfaf1441cca9
Reviewed-on: https://gerrit.libreoffice.org/22819
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
If position and size were loaded from the WindowStateData
structure there's no need to recompute the layout.
As an added benefit if the user previously resized/move the
dialog, the new one will open using the same geometry.
Change-Id: I306504080357f9be8f3e628ba13ca5dc2957dd52
Reviewed-on: https://gerrit.libreoffice.org/21850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
PageBackground is due to old constraints in exporters not completely
hindered when IsPageVisible() is already set for signalling that
all EditView-specific Page visualisations should be suppressed.
As long as these exporters are not adapted, use the setting of
SetPagePaintingAllowed() which consequently achieves this.
Change-Id: I2222a799533f763b54b2210a46c24aa8ae92d7a2
Reviewed-on: https://gerrit.libreoffice.org/22837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Project: help 3ceee913def605d1f2e4c42545b8b4a6d56a13aa
Minor tweaks to statistics help content
- Use “Choose” rather than “Menu” in menu paths for consistency
- Remove the UI-only convention of using an ellipsis
- Drop a linkless paragraph of “Refer to Wikipedia”, it’s useless
if it doesn’t have a link
- Now that we’re on Wikipedia links, refer to them more elegantly
and add a dot to end the paragraph
Change-Id: I6e3964b8926710cd57ee6750fddb039c2c846c34
when using native gtk3 menubars.
The issue is that MenuBarManager does not own its MenuBar.
And in this embedded menubar situation a new menubar is newed and passed to
m_pInplaceMenuBar but nothing destroys it.
Now with native gtk3 menubars this becomes obvious as the native menubar stays
behind, while in the non-native case the old menubar is replaced by
the new one so while it still leaks the menubar you don't see it.
Change-Id: Id732cb66664a71efc471d7bad35f4de890e1017e
So that when SvxPathTabPage sets a custom classification path (or resets
it back to the default), then no restart is needed, the toolbar will be
updated instantly.
ClassificationCategoriesController::statusChanged() was called already,
all that was necessary is to remove old entries, to trigger a re-read of
the policy.
Change-Id: I98edea19fedfb5c1197981085193f959c19647a1
Remove kde4/tde/open-url.sh and have LO just use xdg-open.
It's available on TDE builds as well as any recent KDE. We recently
did this just for gnome-open-url and have had no reported issues.
Change-Id: I4e1ee6caef368051af92023fa382b6fed9d9397e
Reviewed-on: https://gerrit.libreoffice.org/21173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
In a supreme twist of irony, people now assume that --without-x somehow
enables them to run LO in Wayland. Let's see if renaming it *again*
to --disable-gui is finally clear enough.
Change-Id: I5993ee63670f43fb90f32f375f8b0632478c8283
Project: help 4960c1ad663747257f1dc69a649f715a32a9e77e
add warning for case sensitivity and Excel interoperability
Change-Id: I79cc6d6c48225f8559339f65df99de838c2e7ae6
Caused by my commit f29c0b2b3e
"boost::shared_ptr->std::shared_ptr in slideshow"
where I foolishly converted
shared_from_this()
to
std::shared_ptr<Activity>((Activity*)this) )
all over the place, which is bad, I should have used
std::dynamic_pointer_cast<ViewEventHandler>(shared_from_this())
Ah, the joys of C++ memory management.
Change-Id: I9b538e78730c9107870f406cb8ba482d491dd568
