Thomas Arnhold
563c236710
cppcheck: Function parameter 'rStartPos' should be passed by reference
...
Change-Id: Ie453e1a95b54de07463b6f5052a23d6632400b8d
2014-05-22 12:50:52 +02:00
Thomas Arnhold
cf10dd612d
cppcheck: Function parameter 'rLineInfo' should be passed by reference
...
Change-Id: I5bd3f808a0ca61731c5ceb57100d1b30a3163e98
2014-05-22 12:50:51 +02:00
Thomas Arnhold
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
Julien Nabet
4c0ec2a1dd
Blind fix for red Tinderboxes, following
...
Change-Id: I590a682af7fc1879ae63cda3aea73063ba4c84f4
2014-05-10 06:57:15 +02:00
Jan Holesovsky
261b1ad80a
'!= false' is redundant, and confusing - kill it.
...
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-05-09 22:28:44 +02:00
Caolán McNamara
9f1e44e190
coverity#738576 Uninitialized pointer field
...
Change-Id: Id945cf9549b7f633f7deb1f237a2bf6536f221c1
2014-04-28 10:31:02 +01:00
Caolán McNamara
76f74ef908
coverity#738575 Uninitialized pointer field
...
Change-Id: Ib65f0e95ef2a837b6c5791d9e2dce5fe8025da33
2014-04-28 10:31:02 +01:00
Caolán McNamara
b3e332b4a7
coverity#738574 Uninitialized scalar field
...
Change-Id: Ia7cca6e2a2bc3240a32509697a999461491a2747
2014-04-28 10:31:02 +01:00
Caolán McNamara
766d5e4ec0
coverity#738573 Uninitialized scalar field
...
Change-Id: I8b112fa0095cc6ed15c9198a312a0b6fce3a8d28
2014-04-28 10:31:02 +01:00
Miklos Vajna
c2af50eb6d
fdo#77229 EMF+ rendering: improve EmfPlusSetClipPath's CombineModeExclude case
...
This is still not perfect, but at least we now don't do the opposite of
what was asked.
Change-Id: I5e144c5ec2987902e65b2eb472259d9c39bbbd11
2014-04-09 11:06:31 +02:00
Stephan Bergmann
2cc2a39a95
Clean up function declarations
...
Change-Id: I54f8a16cd64375d1398b6582175b0941ba68696e
2014-04-09 09:55:40 +02:00
Noel Grandin
8ab93ae45e
cppcanvas: sal_Bool->bool
...
Change-Id: I3dc076f3593d4d083d5e25e41e007eadc97d2978
2014-04-07 13:53:48 +02:00
Stephan Bergmann
8f6c55a839
Replace SV_DECL/IMPL_REF macros with SvRef template
...
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-07 12:38:27 +02:00
Stephan Bergmann
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
Stephan Bergmann
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Noel Grandin
86a32589e9
Find places where OUString and OString are passed by value.
...
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
Stephan Bergmann
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
8448d136ec
Remove visual noise from cppcanvas
...
Change-Id: I961e6a9e227962096b57569a8b8160841cacd950
2014-02-25 21:25:30 +01:00
Douglas Mencken
63de81621a
Update little-to-big endian GetSwapFloat functions
...
rSt >> pPtr[3] >> pPtr[2] >> pPtr[1] >> pPtr[0] results in error:
no match for 'operator>>' in 'rSt >> *(pPtr + 3u)'
Change-Id: I1820bac8c72f7633ab01a17bf5d073b988e1b58c
Reviewed-on: https://gerrit.libreoffice.org/8207
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-25 13:43:28 +00:00
Norbert Thiebaud
9aee4d1c9e
harmonize Tell() Seek() type.
...
Change-Id: I2e472aa0279d0763762d3c660207cd74da512626
2014-02-24 23:14:45 -06:00
Alexander Wilms
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
Stephan Bergmann
e8f8f24c84
vcl: sal_Bool -> bool
...
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
Caolán McNamara
cc74d3ce73
fix debug=2 build
...
Change-Id: Id7c6db5c6cbefef427d9c2cc4bd210811b5a7991
2014-02-17 09:51:39 +00:00
Noel Grandin
0c7f352775
remove SvStream::operator>> methods
...
in favour of ReadXXX methods.
Change-Id: Ic2c0a7b6b92ff4c236ae99b39d77f3d935b301e3
Reviewed-on: https://gerrit.libreoffice.org/7915
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-12 19:45:10 +00:00
Noel Grandin
15535e32dd
convert SvStream::operator>> methods to ReadXXX methods
...
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-02-12 15:31:40 +00:00
Noel Grandin
186b4ebc99
convert specialised SvStream::operator>> methods to ReadXXX methods
...
as preparation for converting the SvStream::operator>> methods on
primitive types
Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-02-04 22:50:39 +00:00
Andrzej Hunt
8d1ca883b1
EMF+: Only draw endcap outline if not filled, fix endcap scaling.
...
Change-Id: I4520eea08e43ccd657c1db03b258ef84612da971
Reviewed-on: https://gerrit.libreoffice.org/7726
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
Tested-by: Jan Holesovsky <kendy@collabora.com >
2014-01-30 11:24:47 +00:00
Stephan Bergmann
460c15be2e
Apparently broken bitmask operation
...
Change-Id: Id4dfa3d4676b50a86fd6044d501de15b122bb7f1
2014-01-28 20:24:36 +01:00
Caolán McNamara
766a512a88
coverity#1158489 Uninitialized scalar field
...
Change-Id: Ibe8600f8ad38859cd79d52528f970d99f0b8f536
2014-01-23 16:02:12 +00:00
Caolán McNamara
d113e328ef
longparas: remove now broken STRING_LEN uses
...
Change-Id: Ie2de4680e07e26416fc52d4c22b5bececb190cc1
2014-01-14 09:33:09 +00:00
Caolán McNamara
d4dd5c34db
longparas: convert ValidateKashidas to sal_Int32
...
we can use -1 as the failure return code as return value is always checked and
isolated from the rest of the code.
Change-Id: I87a743de82d681a7e4eabc61a576c4e50f1279a8
2014-01-13 20:35:21 +00:00
Andrzej Hunt
9b1ceabd5f
EMF+: actually use lineJoin attribute for polygons.
...
Change-Id: I5b369703333332598353d9817f0253bbe5fc3601
2014-01-01 17:40:16 +00:00
Andrzej Hunt
83f2b3c590
EMF+: mapping can rotate the width vector, so use resulting length.
...
Otherwise (i.e. with non-vertical lines) the width will be incorrect,
and can result in lines disappearing as the resulting X component
can be tiny/approaching zero.
Change-Id: Icf3b7c10c627594600b517b8ff445f8df87c56f8
2014-01-01 17:07:56 +00:00
Andrzej Hunt
793f14db15
EMF+: Add EMFPlusPointR detection to EMFPPath.
...
Change-Id: Iff1ae9806ee05654762b313ed00ada206e51337f
2013-12-27 11:30:36 +00:00
Andrzej Hunt
d8dedc775c
EMF+: Integer coordinate values are signed.
...
Change-Id: I5babcec50d48dc2a6288a01685db61fbb7058680
2013-12-26 20:26:12 +00:00
Norbert Thiebaud
4c539fac01
vcl get rid of xub_StrLen and STRING_LEN in outdev3
...
a new log section (sal.rtl.xub) is used to display alert in case of
suspicious len == 0xFFFF (aka STRING_LEN)
Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e
Reviewed-on: https://gerrit.libreoffice.org/7117
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2013-12-18 01:54:16 +00:00
Stephan Bergmann
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
Matúš Kukan
131f3230d9
EMF+: Fill line cap object if EmfPlusCustomLineCapDataFillPath is set.
...
Change-Id: I7b53a8f18e1fb24b1ae0322bdf0980e431a0725f
2013-12-06 15:04:11 +01:00
Jan Holesovsky
eb45c69b64
EMF+: Log the stride too.
...
Change-Id: I903d8e5629c578f292307bf3abdb2f58ef9dd92c
2013-12-05 09:08:09 +01:00
Matúš Kukan
f115ec6ce1
EMF+: Do not ignore source rectangle of the image to be rendered.
...
Change-Id: I4f861c7653c89d8f1ca73696e885f33f7bfc3b06
2013-12-04 17:46:41 +01:00
Thorsten Behrens
05d2994c13
Further XCanvas != XBitmapCanvas cleanup.
...
It seems I missed a few places in
21ec9beae2
, getting that straight
now hopefully.
Change-Id: I34fc8df2d1ee65bef0639b3de9487ff311bed89a
2013-11-29 18:26:48 +01:00
Thorsten Behrens
72aa51185f
Revert "Resolves: fdo#71527 make presenter console not crash/useless"
...
This reverts commit 639aa8e726
.
Change-Id: I0ac1a7ada530791e2d34d2f0802213c869ea48a1
2013-11-29 18:25:55 +01:00
Caolán McNamara
639aa8e726
Resolves: fdo#71527 make presenter console not crash/useless
...
Basically reverts the pieces of
21ec9beae2
to make XSpriteCanvas a
XBitmapCanvas again
Otherwise PresenterHelper::loadBitmap is not an XBitmapCanvas
and so VclFactory::createBitmap cannot succeed
Change-Id: I197adf98e915102f383ee050a8ea16d1e41cecf2
2013-11-28 17:02:53 +00:00
Jan Holesovsky
acd5edd3d4
EMF+: Line thickness has to be considered when drawing the caps.
...
Change-Id: I6043ee3c214f453afaef06125993c73be624c07e
2013-11-27 11:54:53 +01:00
Tor Lillqvist
b64d5dc6a4
WaE: potentially uninitialized local variable 'pPattern' used
...
Change-Id: Ic000edc60a9c5ae7d64fab9bf8b6c2a88bcec223
2013-11-26 10:04:09 +02:00
Stephan Bergmann
9abd09f04b
-Werror,-Wunused-const-variable
...
Change-Id: I25fa3ea9e0101de7b17c17ef44da6d7b26a46017
2013-11-26 09:02:05 +01:00
Jan Holesovsky
ad8875e2a0
EMF+: Set the stroke attributes on the custom line caps.
...
This finally makes the rendering of the custom line caps nice & complete.
Change-Id: If35ef1c44f34f5d5e6c50789c907105d03e96fca
2013-11-25 22:11:31 +01:00
Jan Holesovsky
ff98a070eb
EMF+: Render custom line cap data.
...
Change-Id: Ic5e2e2d105fb006503b63e4e162d4dc09dab9e68
2013-11-25 22:11:31 +01:00
Jan Holesovsky
20f9413f17
EMF+: Parse custom line cap data for start and end line caps.
...
Change-Id: I3a5f79e22500f53c3c61c173e0827c250b2a8fd0
2013-11-25 14:10:47 +01:00
Jan Holesovsky
172acd5bea
EMF+: Small cleanup & more logging in preparation for line starts & ends.
...
Change-Id: I584f8a1680c6aa7b51b948a00213c285387b77c3
2013-11-25 14:10:47 +01:00