Commit Graph

31 Commits

Author SHA1 Message Date
Gabor Kelemen
969b55d8da tdf#42949 Fix IWYU warnings in canvas/*/*cxx
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie1f6fe98f4e8bc792f5eae1ccdd697c997707004
Reviewed-on: https://gerrit.libreoffice.org/81930
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-06 14:23:21 +01:00
Gabor Kelemen
be27538c6a tdf#42949 Fix IWYU warnings in canvas/source/*/*hxx
Except directx/

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I4504e087edfd837a3a91df49e296bbf40778b030
Reviewed-on: https://gerrit.libreoffice.org/81586
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-30 10:35:10 +01:00
Stephan Bergmann
5926b22b5d The SystemEnvData passed into the canvas factories appears to be unused
It was passed in as aArg[1] ever since d551190e83
"INTEGRATION: CWS canvas05", but I can't find any current use of that specific
argument in canvas/source/ (assuming that all the factories are implemented
there), nor can I find any trace in the git history of it ever havig been used.

That means that Window::GetSystemDataAny is unused now and can be removed.

Change-Id: I16efe548afb5cc3e0606cffea135f7e6674d5def
Reviewed-on: https://gerrit.libreoffice.org/80295
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05 18:31:20 +02:00
Stephan Bergmann
6721d123fb Improved loplugin:stringconstant (now that GCC 7 supports it): canvas
Change-Id: Ia01e9c6a5a730e0efe97a9315810a5dfef5ec98f
Reviewed-on: https://gerrit.libreoffice.org/76693
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31 13:00:39 +02:00
Arkadiy Illarionov
c88f76035c Use hasElements to check Sequence emptiness in accessibility..canvas
Similar to clang-tidy readability-container-size-empty

Change-Id: I24c3f04b4eed3c1cd973166885660f113a26844f
Reviewed-on: https://gerrit.libreoffice.org/71805
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-11 20:24:40 +02:00
Gabor Kelemen
7af90cc93b Add missing sal/log.hxx headers
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84ade
to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from a* to configmgr

Change-Id: I6ea1a7f992b1f835f5bac7a725e1135abee3f85a
Reviewed-on: https://gerrit.libreoffice.org/57170
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-09 10:49:06 +02:00
Jochen Nitschke
35fc452721 remove unused vclunohelper.hxx includes
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22
Reviewed-on: https://gerrit.libreoffice.org/50393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27 15:00:06 +01:00
Tor Lillqvist
8e7897588d Rename the basegfx::tools namespace to basegfx::utils
Reduce potential confusion with the global tools namespace. Will
hopefully make it possible to remove the annoying initial :: when
referring to the global tools namespace. Unless we have even more
tools subnamespaces somewhere.

Thorsten said it was OK.

Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996
Reviewed-on: https://gerrit.libreoffice.org/42644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26 14:18:41 +02:00
Noel Grandin
fd00bd0f69 loplugin:unusedfields
make it a little smarter in dealing with fields that are smart pointers

Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11
Reviewed-on: https://gerrit.libreoffice.org/37751
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19 09:17:06 +02:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Noel Grandin
f3c1d240bd loplugin:constantparams
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361
Reviewed-on: https://gerrit.libreoffice.org/25769
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03 09:08:42 +00:00
Stephan Bergmann
c40c7a8c36 loplugin:nullptr (automatic rewrite)
Change-Id: I9e064592c4ee18a600aadfa20b3c89ecafc818d4
2015-11-10 10:31:18 +01:00
Michael Meeks
055f76b8f1 tdf#93870 - GL accel. via VCL canvas for presentations when GL enabled.
Change-Id: Ia31a88cb3d9e6baa987b22f77f407a3f592031f1
Reviewed-on: https://gerrit.libreoffice.org/18285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2015-09-03 09:37:33 +00:00
Norbert Thiebaud
e5ec630414 stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxx
also clean-up and 'standardize' the include sections of canvas' source code

Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73
Reviewed-on: https://gerrit.libreoffice.org/17633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11 03:57:18 +00:00
Norbert Thiebaud
326777b5d9 remove VERBOSE use from canva
in preparation to kill --enable-verbose in configure.ac
convert modules that use VERBOSE-YES/NO (uppercase) env variable
to do things differently at compile time
Convert canvas to use SAL_INFO/SAL_WARN mechanism instead of its
home-grown 'verbose logging'.

Change-Id: I2898d2309d421457839e3cd7078166c6da919882
Reviewed-on: https://gerrit.libreoffice.org/17619
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-10 17:14:18 +00:00
Stephan Bergmann
ad3f1321f9 More loplugin:simplifybool
Change-Id: I445a6edc0fc2c840cde777e8664bac3362c9b6e2
2015-04-27 15:30:52 +02:00
Caolán McNamara
e510a208b0 move cairo helpers to vcl and make per-plug
Change-Id: I4de4d5c3a191784598e93a8cf70e45a3f59ae857
Reviewed-on: https://gerrit.libreoffice.org/14907
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-23 11:42:28 +00:00
Caolán McNamara
34dc97c791 move IsCairoWorking to vclplug level and rename
Change-Id: Id31de932afa61df6933d61ddba971f5d7060f0c1
2015-03-18 12:32:30 +00:00
Noel Grandin
f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-29 09:01:40 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Ricardo Montania
50a7098b2e More ::rtl::OUString -> OUString in canvas
Change-Id: If99dfc98ace1bf62cd5ab05c596f4f6ffc5fbd2f
Reviewed-on: https://gerrit.libreoffice.org/1175
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-11-27 20:47:07 +00:00
Michael Meeks
60337134e4 re-base on ALv2 code. Includes:
linecap: Reintegrating finished LineCap feature
    Patch contributed by Regina Henschel
    http://svn.apache.org/viewvc?view=revision&revision=1232507

    disable extended linecap API for now.

    gnumake4 work primarily from Mathias Bauer
    http://svn.apache.org/viewvc?view=revision&revision=1394326

    misc. dead code cleanups
    Patch contributed by Ariel Constenla-Haile
    http://svn.apache.org/viewvc?view=revision&revision=1204995
    http://svn.apache.org/viewvc?view=revision&revision=1207270
2012-10-08 11:36:37 +01:00
Thorsten Behrens
eb4f96c988 Cleanup formatting in cairocanvas
White-space changes - code was in parts unreadable after tab/spaces
conversion. While at it, removed a few lines of commented-out code.
2012-03-16 17:02:23 +01:00
Norbert Thiebaud
24c0f87615 remove include of pch header in canvas 2011-11-27 12:57:22 -06:00
Thorsten Behrens
09b546cf9c Fix overloaded-virtual warning in canvas
With enabled -Woverloaded-virtual gcc warning (see
http://lists.freedesktop.org/archives/libreoffice/2011-March/009567.html),
canvas exposed a nasty clash between WeakComponentImplHelper::disposing
and XEventListener::disposing. Fixed by overriding *once* in baseclass,
and then calling disambiguated, renamed methods.
2011-04-08 16:47:25 +02:00
Fridrich Štrba
78d6b75c90 Wholesale prewin.h/postwin.h removal 2011-03-25 19:03:49 +01:00
Tor Lillqvist
b14f9301ef prewin.h already includes <windows.h> 2011-02-09 01:04:21 +02:00
Tor Lillqvist
f10a74f4fd Move prewin.h and postwin.h to solenv and adapt 2011-02-08 14:02:04 +02:00
Sebastian Spaeth
4905a19032 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-14 17:02:15 +02:00
Jens-Heiner Rechtien
8764506704 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Kurt Zenker
a76f8c8626 INTEGRATION: CWS canvas05 (1.1.2); FILE ADDED
2008/06/09 12:51:47 thb 1.1.2.9: #i88081# Join from CWS impress144 (fixing the dxcanvas crash), extended for the other canvas impls
2008/05/23 22:03:43 thb 1.1.2.8: Moving all remaining new files to LGPL 3
2008/05/13 14:51:47 thb 1.1.2.7: removed redundant extra surface from spritecanvas; removed silly conditional that always resolved to true from X11Surface ctor
2008/04/20 23:36:07 thb 1.1.2.6: Made canvasdemo work again on dev300; made sure GDIPlusUser is always destroyed _last_ (as it kills all other GDIPlus objects); made cairocanvas sensitive to outdev size
2008/04/16 13:47:38 thb 1.1.2.5: Made cairocanvas build on Win32 again
2008/04/04 22:08:33 thb 1.1.2.4: Fixed output of bezier polygons for cairo; fixed missing surfaces here and there; removed useless refcounted SurfaceProvider arguments (that lead to premature canvas death, as called during ctor)
2008/04/03 20:12:35 thb 1.1.2.3: Improved the system-dependent passing-around of the OS handles - now much more opaque
2008/04/02 22:56:26 thb 1.1.2.2: Reworked Surface class to abstract interface; changed all manual refcount handling to RAII
2008/03/28 23:38:45 thb 1.1.2.1: Backbuffer-less canvas implementation on top of cairo
2008-06-24 09:18:53 +00:00