mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
443,876 Commits 1 Branch 0 Tags
a322e61b51a04e189618e1d0c8c17f9c080a3d1d
Commit Graph

127 Commits

Author SHA1 Message Date
Noel Grandin
242e1c42d9 loplugin:referencecasting in comphelper..connectivity 
Change-Id: I21896885c29e9ab58ebab17b59f1480c6a06fb38
Reviewed-on: https://gerrit.libreoffice.org/75936
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-19 13:28:41 +02:00
Noel Grandin
22f2cf3ccc implement std::hash for css::uno::Reference and rtl::Reference 
The declaration in BarChart.cxx is particularly suspicious, because it
was using a < for the KeyEqual template parameter.
Been there since:
    commit b2c3233e5f
    Date:   Thu Dec 21 20:08:33 2017 +0900
    chart2: suspend/resume setting rects dirty for 3D shapes

comphelper::OInterfaceCompare is no longer necessary

Change-Id: I8278c4a3d9113a18570ca237cd05d553ec8f3975
Reviewed-on: https://gerrit.libreoffice.org/71537
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-30 08:43:04 +02:00
Gabor Kelemen
368f20001c tdf#42949 Fix IWYU warnings in comphelper 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Also re-evaluate some blacklisted headers and recheck include/comphelper/

Change-Id: Ib7eea5951e849c07cea2e2782be4e8945f71ad96
Reviewed-on: https://gerrit.libreoffice.org/70899
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-04-19 11:31:19 +02:00
Andrea Gelmini
b839763531 Fix typo 
Change-Id: Ia778edadc6ca4cf56868e250f0c29efeeef3ca9f
Reviewed-on: https://gerrit.libreoffice.org/70909
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-04-18 10:12:13 +02:00
Noel Grandin
eb7c9bcda2 tdf#117066 Saving ODT document with ~1500 bookmarks is slow, part 1 
Individually, these don't make much difference, but they add up
to a halving the time to save on my machine.

EmbeddedObjectContainer shows a lot of work in HasEmbeddedObject and
GetEmbeddedObjectName, so add a reverse map there.

Change-Id: Ib758668dbb045e6ceb2611bd86aa2af4fbfb9917
Reviewed-on: https://gerrit.libreoffice.org/70309
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-08 08:51:07 +02:00
Arkadiy Illarionov
95a538180f Simplify containers iterations in chart2, cli_ure, comphelper, configmgr 
Use range-based loop or replace with STL functions

Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76
Reviewed-on: https://gerrit.libreoffice.org/69010
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-03-12 16:10:01 +01:00
Noel Grandin
3b9dcfee64 loplugin:indentation in codemaker..comphelper 
Change-Id: I8dee6245cfa1f7998591b31a3752bbbae13f499d
Reviewed-on: https://gerrit.libreoffice.org/67527
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-08 10:01:40 +01:00
Noel Grandin
6f50961e69 remove more rtl::OUString and OString prefixes 
which seem to have snuck back in since the great rounds of removals.

Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1
Reviewed-on: https://gerrit.libreoffice.org/62229
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-24 14:43:34 +02:00
Noel Grandin
2c1b7e8d6a clang-tidy readability-container-size-empty 
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422
Reviewed-on: https://gerrit.libreoffice.org/61967
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-19 10:02:39 +02:00
Gabor Kelemen
8df9935dcb tdf#42949 Fix IWYU warnings in include/comphelper/[a-l]* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I22ba2c8aec235e34cd7835b8a0a716bf3057db7a
Reviewed-on: https://gerrit.libreoffice.org/60837
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-09-24 23:23:20 +02:00
Noel Grandin
d913b7d2d8 loplugin:unusedmethods 
Change-Id: I6f976ba8f792d2cee34859e9258798351eed8b1d
Reviewed-on: https://gerrit.libreoffice.org/52636
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-10 08:44:23 +02:00
Noel Grandin
0f28c8612f loplugin:unused-returns in basegfx..cppcanvas 
Change-Id: I32dc8c92871c8349651d2f4204a332d387e6e1b2
Reviewed-on: https://gerrit.libreoffice.org/48428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-25 13:51:24 +01:00
Noel Grandin
57c5f98083 loplugin:constmethod in comphelper,ucbhelper 
Change-Id: I27a860fbbedd2174c60c199af18cae76e02abc25
Reviewed-on: https://gerrit.libreoffice.org/43759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-25 08:32:27 +02:00
Noel Grandin
87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Noel Grandin
2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Noel Grandin
a394d67f37 use more OUString::operator== comphelper..cui 
Change-Id: Ib5f3037249152be2b66acf347d1a0c236dc7adfa
Reviewed-on: https://gerrit.libreoffice.org/39888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-13 11:03:14 +02:00
Noel Grandin
539c75b910 strip some linefeeds from the end of debug output 
Change-Id: I2821969d86b7f8cee53404e6a0acfbebbe53b3ac
Reviewed-on: https://gerrit.libreoffice.org/39824
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-12 08:43:14 +02:00
Stephan Bergmann
2b1c731f3c loplugin:casttovoid: comphelper 
Change-Id: I28752323d31320141a537c0e108c911cef09c10a
 2017-07-02 22:34:31 +02:00
Noel Grandin
8ed77fae3e loplugin:oncevar in codemaker..connectivity 
Change-Id: Ia479d9d3d459a699dfc5c1148d01c35e8bc973bd
Reviewed-on: https://gerrit.libreoffice.org/39000
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-20 11:54:20 +02:00
Noel Grandin
8c8f2a5285 remove unnecessary explicit linefeeds from end of SAL and OSL log calls 
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf
Reviewed-on: https://gerrit.libreoffice.org/36727
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-21 09:15:11 +02:00
Caolán McNamara
3f243471b5 ofz: segv on nullptr 
Change-Id: I5ec64411b101972ddd150a782b845d4f790ea873
 2017-03-19 21:34:58 +00:00
Tor Lillqvist
6de3688cc6 Drop :: prefix from std in c*/ 
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 23:01:23 +00:00
Stephan Bergmann
20d648625b Some simplifications, using UNO_QUERY_THROW 
Change-Id: I143ec0287421675fb13a03e8cf3c7054a17be37f
Reviewed-on: https://gerrit.libreoffice.org/34271
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-02-15 14:19:13 +00:00
Stephan Bergmann
6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Noel Grandin
8a16f665b1 makeAny->Any in canvas..configmgr 
Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e
Reviewed-on: https://gerrit.libreoffice.org/33869
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 10:44:01 +00:00
Huzaifa Iftikhar
5c983bc2ab tdf#70998 Change word "Graphic(s)" to "Image(s)" 
There was an error in the previous patch inside the file embeddedobjectcontainer.cxx
This is fixed in this patch.

Change-Id: I01c9e254e58e1683a8e6e9a0bcff3c4663bf32e0
Reviewed-on: https://gerrit.libreoffice.org/32353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-12-23 18:27:05 +00:00
Noel Grandin
d15b4e2045 teach sallogareas plugin to catch inconsistencies 
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-15 06:45:14 +00:00
Tor Lillqvist
714de95ec5 Remove nonsense comments: // bitfield 
Surely the actual bitfield syntax is enough to tell the code reader
that it is a bitfield.

Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
 2016-09-13 11:09:06 +03:00
Noel Grandin
127f70d66a new loplugin to check for static OUStrings 
that are better declared as OUStringLiteral

Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567
Reviewed-on: https://gerrit.libreoffice.org/27377
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-16 06:30:09 +00:00
nadith
efef273e2c tdf#100726: Improve readability of OUString concatenation 
this bug fixed in the modules between canvas - cppu

Change-Id: I2022b022897dafde20251352376e3facdb9b8d75
Reviewed-on: https://gerrit.libreoffice.org/27663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-01 06:12:30 +00:00
Xisco Fauli
e88107c055 tdf#89329: use unique_ptr for pImpl in embeddedobjectcontainer 
Change-Id: I679555e2eb51e2b9660bb035a08d8da8b1687cab
Reviewed-on: https://gerrit.libreoffice.org/25747
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-03 06:16:52 +00:00
Noel Grandin
74713b34a3 loplugin:unusedmethods 
Change-Id: Ib36bc0e87d00abb638cbfec511cd13b6179eabda
Reviewed-on: https://gerrit.libreoffice.org/25431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-26 07:50:33 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Noel Grandin
58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Seraphime Kirkovski
7739bd5f54 Iteration must not start at the end 
Change-Id: I2aebcc909aa9222fc1881e57bbc844025a154e84
Reviewed-on: https://gerrit.libreoffice.org/24497
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2016-04-29 18:42:16 +00:00
Stephan Bergmann
f555ab4e96 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Idb7e5ff0c73bbc2c462b92cd96444eb5d2d4194b
 2016-04-20 17:25:37 +02:00
Noel Grandin
b9372f0e90 loplugin:constantparam in comphelper 
Change-Id: I81e6af1ee869caa3b40d2d00604e8e22517d92d7
Reviewed-on: https://gerrit.libreoffice.org/23808
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-05 06:26:22 +00:00
Noel Grandin
337f517af6 loplugin:unuseddefaultparams comphelper 
Change-Id: I78280a13fc0d82fc87041b5dad0c3f2f7d462652
Reviewed-on: https://gerrit.libreoffice.org/22853
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-03 12:06:57 +00:00
Michael Stahl
bd58340058 tdf#97108: SwDocShell of clipboard document has no base URL 
... which triggers this assert; have to downgrade it to SAL_INFO.

The startsWith("0x") check is obsolete anyway since commit
0f02bc189b.

Change-Id: If47bc4496852ff85ba1bbeb4205ffc16be0782de
 2016-01-13 23:42:33 +01:00
Caolán McNamara
d9b589379c crashtesting: fdo85994-1.doc assert on reexport to doc 
try setting DefaultParentBaseURL based on the parent BaseURL
for objects created this way

Change-Id: I1a660ff6e4874321e0308d556c7ce0e10a2605fe
 2016-01-09 15:17:08 +00:00
Caolán McNamara
a4764cfa80 crashtesting: fdo73974-1.doc assert on reexport to doc 
try setting DefaultParentBaseURL based on the parent BaseURL
for objects created this way

Change-Id: Idfc44d90e4f73f23976e8648c504786955b4fce6
 2015-12-24 21:24:13 +00:00
Michael Stahl
e4a06fc983 sw: set a BaseURL when copying embedded objects 
Turns out that SfxObjectShell::CreateShellID() will produce the
SfxMedium's base URL if it exists, so
EmbeddedObjectContainer::CopyAndGetEmbeddedObject() already has
parameters, sw just needs to set them.

Change-Id: I36cedfde4e7c2e25c43c66a30d8ca572f099ad69
 2015-12-15 17:44:37 +01:00
Michael Stahl
b0fc09daf1 fix missing BaseURL when loading embedded objects 
When the object is edited in the UI, the m_xClient is set to a
SfxInPlaceClient and the DocumentBaseURL is retrieved from it.  But if
the object is not edited, it will be loaded during export via the API
and without a m_xClient; in this case the DocumentBaseURL must have been
set previously to be available during import.

There appears to be no way to get the URL of the document via the API
while it is being imported; SfxBaseModel's m_sURL is unfortunately only
initialized from SfxObjectShell::FinishedLoading().

During ODF import, the SvXMLEmbeddedObjectHelper creates the
embedded object, so let's make it pass in the parent's BaseURL.

The "DefaultParentBaseURL" parameter already exists but was unused
previously.

Change-Id: I3d1ed29b3a2c0e77ec606a1d09f7bc07e7860733
 2015-12-15 17:44:36 +01:00
Noel Grandin
fe3fd05966 add mapKeysToSequence/mapValuesToSequence methods to comphelper 
and use them

Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec
Reviewed-on: https://gerrit.libreoffice.org/20055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-20 08:14:13 +00:00
Stephan Bergmann
fb4ce444c2 loplugin:nullptr (automatic rewrite) 
Change-Id: Ibd0e6ae5e3243464b2484a009f2b4781bdaac471
 2015-11-10 10:31:19 +01:00
Noel Grandin
59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Noel Grandin
cb4fa1d1e2 use uno::Reference::set method instead of assignment 
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
 2015-10-30 11:08:36 +02:00
Andrea Gelmini
ce343470c3 Fix typos 
Change-Id: Iaff7e38dd5beac48e1643e369e4240aa736c35ea
Reviewed-on: https://gerrit.libreoffice.org/18941
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 06:00:18 +00:00
Daniel Robertson
96fa0df15b comphelper: replace for_each with range-based for 
Replace complex uses of ::std::for_each with a range-based for-loop.

Change-Id: I57d3d2e830e7700b793e1836777cbe72504c6825
Reviewed-on: https://gerrit.libreoffice.org/18817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-24 16:23:34 +00:00
Noel Grandin
d74436fb86 com::sun::star->css in comphelper 
Change-Id: I4aa0b2d15f2a06cbbbf63a363f403ca6435ffbcd
Reviewed-on: https://gerrit.libreoffice.org/17365
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-27 11:01:04 +00:00