Commit Graph

80 Commits

Author SHA1 Message Date
Lionel Elie Mamane
a55f22ef4c fixup startsWith vs == in string comparisons
probably left-over from OUString transition

Change-Id: I29f8f34ad44828608aa16b0b0a0759e887e280af
2016-03-04 13:16:40 +01:00
Lionel Elie Mamane
a70586d998 fixup tdf#92538
Change-Id: I57650fe955a31f433d611d9e74a0762d349bed64
2016-03-04 09:23:05 +01:00
Lionel Elie Mamane
280f234e5e fixup tdf#92538
Change-Id: I62fbead59ac83147da6da984f89b64b1d7e4f90d
2016-03-04 09:22:32 +01:00
Lionel Elie Mamane
ac2505632c tdf#92538 use proper schema name for type names
Change-Id: I7e428e4530765925bd35c7f4fcde7f95ceb12243
2016-03-03 19:45:24 +01:00
Noel Grandin
383e11040c sequence->vector in postgresql
Change-Id: I57bf8f4404df9f73d9a52c651c9f27784f10c937
2016-02-09 13:44:42 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Noel Grandin
98c343604d boost::hash->std::hash
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8
Reviewed-on: https://gerrit.libreoffice.org/21989
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02 09:20:47 +00:00
Noel Grandin
cb4fa1d1e2 use uno::Reference::set method instead of assignment
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
2015-10-30 11:08:36 +02:00
Stephan Bergmann
7bff36d45d loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I68b02ad101c4c2165b4618ed5d97cbffc2c43d2d
2015-08-31 08:04:12 +02:00
Noel Grandin
8601307838 loplugin: defaultparams
Change-Id: Id0a933d3507bc0f8145afa04effadf8475c8e210
2015-08-14 10:52:46 +02:00
Andrea Gelmini
87dc6c82d5 Fix typos
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875
Reviewed-on: https://gerrit.libreoffice.org/16706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-03 09:02:48 +00:00
Andrea Gelmini
8a2efbb717 Fix PostgreSQL function name
Change-Id: Ic089540c07c7fe7c85705fc3513411a7e2571a12
Reviewed-on: https://gerrit.libreoffice.org/16640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-07-02 13:40:06 +00:00
Stephan Bergmann
17e74bf1a0 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: Id2361bd7b50f4724211661b024583b8a3445500b
2015-04-01 08:36:20 +02:00
Noel Grandin
c7a50d072f new constantfunction loplugin
Change-Id: Ie9b7a0c41fc4dbd2560ceff6bae9ab85357f518b
2015-03-25 08:55:31 +02:00
Noel Grandin
3e8a7ce7df Revert "loplugin:constantfunction: connectivity"
it seems to be causing unit-test and build failures

This reverts commit 5cbb51c009.

Change-Id: Idc6372f98200b23828aa19b22a75b6b2b640d1ab
2015-03-23 11:02:11 +02:00
Noel Grandin
5cbb51c009 loplugin:constantfunction: connectivity
Change-Id: Ic1a71851a80ed2715969b0f00a0e59ab3a0593db
2015-03-23 09:42:23 +02:00
Noel Grandin
4a87597e42 remove unused struct
Change-Id: Icabf74fde82e917826f20ffdc8fcd71a26538bbe
2015-03-02 08:59:19 +02:00
Caolán McNamara
ca8787a981 boost::unordered_map->std::unordered_map
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
2015-01-04 12:51:09 +00:00
Stephan Bergmann
bca00da686 connectivity: Use appropriate OUString functions on string constants
Change-Id: I10b2ddf9dcc83219fea8eb55783507eed52702e8
2014-12-12 17:51:11 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Caolán McNamara
73d4d9a583 Related: #i124896# remove obsoleted pq_allocator.hxx
Change-Id: I8a2b54c97f20e581b9703bf33dbba537c2f603c2
2014-05-15 15:03:50 +01:00
Noel Grandin
199d333f13 connectivity: sal_Bool->bool
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
2014-04-16 11:51:51 +02:00
Thomas Arnhold
618a0f8c03 whitespace for include statements
Change-Id: I76bd0ef07a2fa134e948724cecdf539ffe6ccb8a
2014-04-15 13:43:13 +02:00
Thomas Arnhold
2805ac13dc typo: choosen -> chosen 2014-04-14 12:32:02 +02:00
Noel Grandin
358be80f65 comphelper,connectivity: prefer passing OUString by reference
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
Alexander Wilms
ac9212feed Remove visual noise from connectivity
Conflicts:
	connectivity/source/inc/odbc/OConnection.hxx

Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:54:35 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Caolán McNamara
61160e0454 add missing vim modelines
Change-Id: I72d565b77fad98e176e2f47368201ad1585aef3f
2014-02-18 15:18:09 +00:00
Stephan Bergmann
ead1525417 bool improvements
Change-Id: If35c939adede6a912dee14714a7ceeab84ac977e
2014-01-28 20:24:39 +01:00
Noel Grandin
f8b2265419 remove RTL_CONSTASCII_STRINGPARAM in OUString::matchAsciiL calls
Convert code like:
    defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) );
to:
    defaultValue.startsWith( "nextval(" );

Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
2013-11-20 13:56:09 +02:00
Noel Grandin
52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
Noel Grandin
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
Stephan Bergmann
7f02173bba -Werror,-Wunused-const-variable
Change-Id: Ic4edbbc0bf74887ab9624e4551b54ecbe3538108
2013-10-02 16:49:31 +02:00
Andras Timar
6ea6a422fb s/wiki.services.openoffice.org/wiki.openoffice.org/g
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-07 14:21:22 +02:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Michael Meeks
3e52762c5a Move to MPLv2 license headers, with ESC decision and author's permission.
Change-Id: I9f1102d4f0e189a048d8fccfe9cae246c0136311
2013-05-02 12:49:20 +01:00
Michael Meeks
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann
2d9ce9191d Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)
...which is a confusing overload with unexpectedly different semantics from the
one-parameter form.  In preparation of marking it as deprecated.

Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-20 13:05:35 +01:00
Stephan Bergmann
4c0c23af21 Simplify equalsIgnoreAsciiCaseAscii[L] calls
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19 11:32:20 +01:00
Thomas Arnhold
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
Lionel Elie Mamane
9953c1b5a6 pure comment: write down interesting idea gleaned at FOSDEM
Change-Id: I96685f405989fdd3b090b6a482edf8ad65bfd4e9
2013-02-19 12:35:01 +01:00
Jean-Noël Rouvignac
77fd448d09 Removed several useless macros: UNISTRING, USTR, USTR_ASCII, ASCII_STR, ASCII_STRING, CONST_ASCII, ASCSTR, ASCII, DEFINE_CONST_UNICODE, DEFINE_CONST_OUSTRING
Change-Id: I96d690bf9f9b319e9eeafcf218ec5ce87f21215f
Reviewed-on: https://gerrit.libreoffice.org/1954
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
2013-02-14 13:20:14 +00:00
Szabolcs Dezsi
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
Lionel Elie Mamane
fdd70e63ee fdo#46675: fixup 2012-02-27 13:48:50 +01:00
Lionel Elie Mamane
ee0cb9d05d fdo#46675: expand group memberships in get*Privileges 2012-02-27 13:14:02 +01:00
Takeshi Abe
03591233c1 Prefer equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("..."))
to equalsIgnoreAsciiCaseAscii("...")
2012-02-18 23:19:41 +09:00
Takeshi Abe
2b1758a2dc Prefer equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) to equalsAscii(...) 2012-02-10 23:01:07 +09:00
Lionel Elie Mamane
f21eaff8ea fdo#45249 declare support for Core SQL -> Base allows user aggregate functions 2012-02-09 18:35:13 +01:00