48 Commits

Author SHA1 Message Date
Noel Grandin
90305526ee loplugin:unusedenumconstants
Change-Id: I628a0114e56ec25926bd08d159c61cfecb719a1c
Reviewed-on: https://gerrit.libreoffice.org/35854
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-30 06:26:26 +00:00
Noel Grandin
a1b0d3ff53 remove unused enumerators from PrinterCapType
Change-Id: Id4f788dfae64e7a9bcde16af2db2ddeafaf6900e
Reviewed-on: https://gerrit.libreoffice.org/34468
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-20 12:24:14 +00:00
Noel Grandin
408c0a7693 convert StringType to scoped enum
and drop unused FormulaValue enumerator

Change-Id: Ide6026b841db224947d7d559c110dfc7da3cd975
Reviewed-on: https://gerrit.libreoffice.org/34467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-20 12:23:59 +00:00
Noel Grandin
d1eb3c86b0 remove unused ModalDialogue from WMWindowType enum
Change-Id: I22269d6d1868b744f48274ff53ca46fa93ce9fc1
Reviewed-on: https://gerrit.libreoffice.org/34455
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-20 08:45:24 +00:00
Noel Grandin
76f9e3b417 remove some unused enumerators
Change-Id: Idb9080f9c2edd838385d78b64e61ab49e93fe54b
Reviewed-on: https://gerrit.libreoffice.org/34373
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-20 05:56:44 +00:00
Noel Grandin
06f0d2d9f1 convert FormulaCompiler::SeparatorType to scoped enum
and drop unused COMMA_BASE enumerator

Change-Id: I5f35ba7453d5ca613ebd65d0853c7caaa210f3de
Reviewed-on: https://gerrit.libreoffice.org/34357
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-17 10:09:50 +00:00
Noel Grandin
be021ba04d convert StackMode to scoped enum
and drop unused AMBIGUOUS enumerator

Change-Id: I71954d75a64928061c0e520beb47f979c53ee5a8
2017-02-17 09:56:19 +02:00
Noel Grandin
1ac9f8ddd7 convert PropertyType to scoped enum
and drop unused enumerators

Change-Id: I61d2a46ed84ce4163757a2da58162c72b1b0950f
2017-02-17 09:56:19 +02:00
Noel Grandin
8fc4aecde3 convert ValueParser::State to scoped enum
Change-Id: I20c8217576fb6993107f1e45429adc5660d38da8
2017-02-17 09:56:19 +02:00
Noel Grandin
2c06083c75 remove unused NONE from TAscendingOrder enum
Change-Id: I31c793df40b2a687b4a6c84854f34aba72ac0494
2017-02-17 09:56:19 +02:00
Noel Grandin
f1421a3e12 convert SbxNameType to scoped enum
and drop unused enumerators

Change-Id: I2b47828b2146fcda335f1dc1c1f61a1139abbe19
2017-02-17 07:52:09 +02:00
Noel Grandin
fd2ffceefc convert EESpellState to scoped enum
and drop unused EE_SPELL_NOLANGUAGE enumerator

Change-Id: I74a5f89335883a13d77b39f78b7de55bddb1f107
2017-02-16 12:44:34 +02:00
Noel Grandin
1c3de19e98 remove unused NONE from ScrollRangeCheck enum
Change-Id: I9d83cc38a9fa477a61ec7e2ec3d9786318187085
2017-02-16 12:42:04 +02:00
Noel Grandin
ee36298909 convert resetType to scoped enum
Change-Id: Ie127b99949546b5303fd105c662b25c62d409941
2017-02-16 12:42:04 +02:00
Noel Grandin
ce3441c2d5 convert HelpProcessingErrorClass to scoped enum
and drop unused HELPPROCESSING_INTERNAL_ERROR enumerator

Change-Id: I0f2cf063a3f1472e1d52bab5039b1c3158d4865e
2017-02-16 08:17:34 +02:00
Noel Grandin
23ea9fb1dd remove unused enumerators from SymbolType enum
Change-Id: I63af4ab93dfd021f88f03fad2c065f5a0e9eeed9
2017-02-16 08:17:34 +02:00
Noel Grandin
4ca9e8fa3a remove unused Exist from oslCheckMode enum
Change-Id: I1ad187342444c5e92b61578d2a67cce2ae5ac428
2017-02-16 08:17:34 +02:00
Noel Grandin
04004cc259 convert FuncParamValidity to scoped enum
and drop unused NONE enumerator

Change-Id: Ibc77390efb195a9158ba809ad96aab4dcdbc09cb
2017-02-15 12:30:39 +02:00
Noel Grandin
3c96c22417 convert SylkVersion to scoped enum
Change-Id: Ib7e02fee748bd55be6d74d60bff3d8ed765ea225
2017-02-15 12:30:39 +02:00
Noel Grandin
d2871068d7 convert DoubledQuoteMode to scoped enum
and drop unused enumerators

Change-Id: I0dc45e2bec1a25357405ca0c0197632ee4806cb0
2017-02-15 12:30:39 +02:00
Noel Grandin
12b2803f19 drop unused PRESOBJ_IMAGE
Change-Id: I8fa011bea423e961a3ebe7cd8687e4bce7c4cd77
2017-02-15 09:36:42 +02:00
Noel Grandin
1342a8a4f2 drop unused SwChildWindowMailmerge from SfxShellFeature enum
Change-Id: Ica64d75986877bc0b2fc3bafb092457396fb8e27
2017-02-15 08:33:37 +02:00
Noel Grandin
dfd5510a7a convert SmBracketType to scoped enum
and drop unused enumerators

Change-Id: Icda3ff510331f9f0adb97d6dac56edf325d0d1a7
2017-02-15 08:33:37 +02:00
Noel Grandin
e48f0084df remove unused AccessibilityChanged from SfxHintId enum
Change-Id: Ic2d413002466e92d38a7a918b3f7e04d3c9eebf2
2017-02-15 08:33:37 +02:00
Noel Grandin
89c24a380a convert SvxIconChoiceCtrlPositionMode to scoped enum
and drop unused AutoAdjust enumerator

Change-Id: Ie900f89241947cb93a16f0223071846fecfef09c
2017-02-15 08:33:37 +02:00
Noel Grandin
923fd24972 convert svt::table::TableArea to scoped enum
and drop unused TableAreaDataArea enumerator

Change-Id: I00da558ab899dccbeaa9786c65f7a2831f323b25
2017-02-14 14:22:24 +02:00
Noel Grandin
7bd5d9c81b convert to EnumerationResult to scoped enum
and drop unused RUNNING constant

Change-Id: I498b8b47e172336775b38c953f867f2adc57603e
2017-02-14 14:22:24 +02:00
Noel Grandin
2b2cd4b06e convert SvxPrevLineSpace to scoped enum
Change-Id: I5903169e1d7728a2f1e547efdff82a75e8d7b6a7
2017-02-14 14:22:24 +02:00
Noel Grandin
b0a23c4c35 remove unused BreakedLine enumerator from SdrMeasureTextVPos
Change-Id: I28cf3d36c1427b382aea1925d2dd94ace0d2a443
Reviewed-on: https://gerrit.libreoffice.org/34204
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-14 08:09:24 +00:00
Noel Grandin
078ce1d597 convert SvxXMLTableImportContextEnum to scoped enum
and drop unused stice_unknown enumerator

Change-Id: Ia2d363c9e8d9e501bbfb6f9bb5838b109ce8593b
Reviewed-on: https://gerrit.libreoffice.org/34201
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-14 08:08:58 +00:00
Noel Grandin
251decd320 remove unused BrkAction enumerator from SdrEventKind
Change-Id: I46c50bbbad5d269b7f15e041db115fa7f37a8168
Reviewed-on: https://gerrit.libreoffice.org/34205
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-14 07:13:10 +00:00
Noel Grandin
d8499c45eb convert ShellModes to scoped enum
and drop read-only SHELL_MODE_DRAW_CTRL enumerator

Change-Id: I2ccaeb492912c876b89ff9b5dccaa99e28a268b7
2017-02-13 08:17:42 +02:00
Noel Grandin
f149f5abed convert eF_ResT to scoped enum
and drop read-only FLD_TAGTXT enumerator

Change-Id: I718529082ce540c0e3bca37d969917d3b3a67f5e
2017-02-13 08:17:42 +02:00
Noel Grandin
cdbe81f2ac convert SW_KeyState to scoped enum
and drop unused InsDel_* enumerators.
Also rename to SwKeyState to make it a little shorter and more
consistent with other naming.

Change-Id: I837ea8d64a0f26426567dcf78750939fc959a4a4
2017-02-13 08:17:42 +02:00
Noel Grandin
6e12729f71 remove unused enumerator from EncodedWordState
Change-Id: I793276d2b13bdb966e18acb8f13b4c7e77516898
2017-02-10 08:08:45 +02:00
Noel Grandin
3e33fbd269 restore constant to VerticalOrientation
Removed in commit f4826959c1a5b0e6d2849d4240668b2087582848
"new loplugin:unusedenumconstants".
And add a comment.

Change-Id: I63d6f46aa92e31db08e51e47a62104dc7d3d3359
Reviewed-on: https://gerrit.libreoffice.org/34057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 10:09:08 +00:00
Noel Grandin
bca47d830e remove ConnectionIdentifierType enum
since we only use the AsciiCString enumerator.
Consequently simplify the GetConnectionIdentifier method

Change-Id: I9e1a1318d2f12bfd18edeb8479e0e7171b22d0f1
Reviewed-on: https://gerrit.libreoffice.org/34026
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 09:51:05 +00:00
Noel Grandin
afc755fa61 loplugin:unusedenumconstants read-only constants in vcl (2)
Change-Id: Ia3da23e0ef2fa710403745bd11255ed001516da4
Reviewed-on: https://gerrit.libreoffice.org/34020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09 05:46:03 +00:00
Noel Grandin
65b7b6322b loplugin:unusedenumconstants read-only constants in vcl
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2
Reviewed-on: https://gerrit.libreoffice.org/34018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08 12:42:52 +00:00
Noel Grandin
25702ff6c9 loplugin:unusedenumconstants read-only constants in writerfilter
Change-Id: I3cc0d696059b130a8f1f1d8d3b1908d2e84d1a75
Reviewed-on: https://gerrit.libreoffice.org/34017
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08 11:00:32 +00:00
Noel Grandin
b2453d1f41 convert DEBUG_TIME to scoped enum
Change-Id: I91b286d8415ebc8c6675aca6ee143850c956c74b
Reviewed-on: https://gerrit.libreoffice.org/33986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 07:43:32 +00:00
Noel Grandin
c1380c0039 drop unused FONT_PROPTYPE_CELL constant
which makes this enum not necessary anymore

Change-Id: I0194634d357569aee502f1e8a7fd95c49e23040c
Reviewed-on: https://gerrit.libreoffice.org/33967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 06:01:50 +00:00
Noel Grandin
d91c81e433 convert GalleryBrowserTravel to scoped enum
and drop unused GALLERYBROWSERTRAVEL_CURRENT value

Change-Id: Id91824cbe024d4b5109ee0755b518164837bc6a6
Reviewed-on: https://gerrit.libreoffice.org/33965
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 06:01:27 +00:00
Noel Grandin
fde0b8df30 loplugin:unusedenumconstants in oox
Convert FragmentHandler2::MCE_STATE to scoped enum and drop MCE_UNUSED
constant

Change-Id: Id0b3a81e61d77af5d3837527b008e196835f57cd
Reviewed-on: https://gerrit.libreoffice.org/33954
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 11:36:17 +00:00
Noel Grandin
c9c3cb5446 loplugin:unusedenumconstants in connectivity..cui
Convert ExpressionFunct to scoped enum and drop FUNC_CONST value.
Convert MQueryExpressionBase::node_type to scoped enum and drop Unknown
value.
Dop PageType::Color value

Change-Id: Icb1f5503c230fb91329acc7d9e1da665fa28d95e
Reviewed-on: https://gerrit.libreoffice.org/33948
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 09:13:25 +00:00
Noel Grandin
bac9a5d634 loplugin:unusedenumconstants in framework
Convert EProtocol to scoped enum and drop E_UNKNOWN_PROTOCOL.
Convert ToggleButtonToolbarController::Style to scoped enum and drop
STYLE_TOGGLEBUTTON.
Convert TargetHelper::ESpecialTarget to scoped enum and drop
E_NOT_SPECIAL.

Change-Id: I412adacac15192cf6563ce4d5e5b74bfffff4737
Reviewed-on: https://gerrit.libreoffice.org/33949
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 07:57:28 +00:00
Noel Grandin
8b2ffb280b loplugin:unusedenumconstants in vcl
- drop TTCR_GLYPHSEQ
- drop ImageType::Invalid
- give preedit_data_t a default constructor, so my plugin spots that the
eState field is being initalised to DontKnow effectively by a memset
- document ToolbarIconSize::Small as unused, but can't remove since
it might be stored in a user-setting somewhere

Change-Id: I94b34bba83a04de16f95e4faec95b4bd29f3c652
Reviewed-on: https://gerrit.libreoffice.org/33887
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 05:48:02 +00:00
Noel Grandin
22326cb4f5 new loplugin unusedenumvalues
Change-Id: I03d684fc35238a45a6d99855e5ee6d3a5e33740d
2017-02-03 11:28:44 +02:00