Commit Graph

384479 Commits

Author SHA1 Message Date
Jan Holesovsky
0222608159 sc: Introduce Abstract Base Class for ScMatrix, for a future rework.
We want to introduce another type of ScMatrix that will directly contain
DoubleVectorRefToken and operate on that.  The idea is that it is pointless to
construct a ScMatrix via lots of copying around, when we already have a nice
array of doubles.

Change-Id: I3e5d7b9e2e0f9b9bf350336a8582cfd852586b3f
2015-11-24 17:41:30 +01:00
Stephan Bergmann
708ef6a08d '#pragma setlocale("C")' is probably no longer necessary
...as in both files the direct use of non-ASCII characters in ordinary string
literals has since been changed to use \xXX escapes instead

Change-Id: Ic3e17a9849288a02dc69d7702782fefccb7026ee
Reviewed-on: https://gerrit.libreoffice.org/20148
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-24 15:44:26 +00:00
Caolán McNamara
7acbf173fc crashtesting: ooo72999-1.ods NaNs found in light direction
and NaN != NaN so busted logic propogates, drop invalid directions
on initial read

Change-Id: Ic76c714666df14d37a4c68f43b817327675bd0e0
2015-11-24 15:19:02 +00:00
Michael Stahl
78407eea3d filter: fix DrMemory/valgrind warnings in PPT paragraph import
various uninitialized variables in CppunitTest_sd_filters_test hang-8.ppt

Change-Id: Id0b9f146a7ab8b5bb2b36a5c2a39d65ee52e122d
2015-11-24 16:04:56 +01:00
Miklos Vajna
de2a689787 sw lok comments: fix map mode state after changing zoom levels
Zoom level of SwEditWin is kept in sync with the client, so that the
pixel-based comment widgets can be positioned correctly. But that does
not mean in general the SwEditWin map mode should not be disabled: so
that we don't have to tweak the map mode for each and every
postMouseEvent() call and still be able to send them using logic
coordinates.

Change-Id: I6f686b93d2509d52fdd34e84a502cf04e1ce6e59
2015-11-24 15:53:45 +01:00
Miklos Vajna
7c654ee9d5 sw lok comments: avoid crash an exit after clicking the scrollbar
Without this, vcl::Window::ImplTrackTimerHdl() will be called on a
deleted vcl::Window.

Can be reproduced with a comment having a scrollbar in a LOK client,
then clicking on the down button of the scrollbar a number of times ->
crash on exit.

Change-Id: I5d67f96e8baa199f65ec5cf39cb5d39c8162ff33
2015-11-24 15:53:45 +01:00
Miklos Vajna
d562df0309 sw lok comments: implement drag of the scrollbar
With this, if a comment has a vertical scrollbar, then not only the
buttons of the scrollbar can be clicked on, but also the slider of the
scrollbar can be dragged.

Change-Id: I2e39e18bf60c42a878bb8bfd808f1d47be27eecb
2015-11-24 15:53:45 +01:00
Miklos Vajna
d7acb44b14 vcl lok: handle tracking coordinates which are in twips
This is similar to the mouse button down handling. When the map mode is
disabled and the map mode is in twips, then in general it's possible to
send mouse coordinates in twips. The scrollbar is usually in pixels, so
add extra code to still make this possible.

Change-Id: I0c7e404ecd7ac839e000266e396683bb7d15c505
2015-11-24 15:53:44 +01:00
David Tardon
b1e5983f04 fix c++ snafu with msvc
Change-Id: I493b79e70fb8003ce215e602f9b4ce92afa50150
2015-11-24 15:33:44 +01:00
Mike Kaganski
ae0e830f9a tdf#95970: Don't loose mirroring in SdrTextObj::TRSetBaseGeometry
Currently, negative scaling (mirroring) is lost in
SdrTextObj::NbcSetSnapRect, when rect is justified.
This patch cares for this.

Possibly it's better to make these changes directly in
SdrTextObj::NbcSetSnapRect?

Change-Id: I353ff01626e15b398de95e28eae78572991dfdc3
Reviewed-on: https://gerrit.libreoffice.org/20109
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-11-24 13:46:49 +00:00
Tor Lillqvist
ccd04a5f46 Bin old Windows-only MULTI_SL_DEBUG code of dubious usefulness
We have SAL_DEBUG and SAL_INFO.

Change-Id: I6dc12e2fc7a854d1cde6e455faabcebea4bc69ef
2015-11-24 15:37:24 +02:00
andreas kainz
17e4c758e6 Breeze Icons: change icons according to review from jay
Change-Id: Ib6614db33ede42e90a4706b3ccd7d3b8fb6be3e5
Reviewed-on: https://gerrit.libreoffice.org/20139
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-11-24 13:29:37 +00:00
Michael Meeks
d3cdd7efca vcl: scheduler - split timeout calculation from idle invocation.
This moves us towards unifying timeouts, events, idle handlers leaving
only the OS main-loop integration in the backends.

Change-Id: Iebfb0db21777d8018b33f216b13acb4ea2068659
2015-11-24 12:57:22 +00:00
Michael Meeks
5a08d3fa47 vcl: remove UpdateStack concept.
Change-Id: I6d9b7de7c57349bfb9c75a35e63bcf1eac172fd2
Reviewed-on: https://gerrit.libreoffice.org/20143
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-24 12:40:29 +00:00
Samuel Mehrbrodt
745751e32d Vcl Toolbox: Move Impl and local defines out of header files
This reverts part of 1e82a3e6e3

Change-Id: I683a855727c4a52d3ac6a7c5a1f104a6cf5b9ee2
2015-11-24 13:36:08 +01:00
Noel Grandin
60795a7fd1 loplugin:unusedfields in include/oox/
Change-Id: Ie7a53f3ecc05d1d4f6f71aa8165315f9155c60dc
2015-11-24 14:20:26 +02:00
Noel Grandin
73b7c5034f loplugin:unusedfields in include/framework/
Change-Id: I04603a3b78b0611fcca4974b00e2da06045308d1
2015-11-24 14:20:25 +02:00
Noel Grandin
6cd5d5f0a1 loplugin:unusedfields in include/filter/
Change-Id: Id79bc51ba273746873a1381243b2c1d32711bbb4
2015-11-24 14:20:25 +02:00
Noel Grandin
e78bb6d545 loplugin:unusedfields in include/comphelper,include/editeng
Change-Id: I619c2cf1765df97159fc52ee84e0e9e8d16a22fe
2015-11-24 14:20:25 +02:00
Tor Lillqvist
509907cea7 It's "incomplete", not "in complete"
Change-Id: Ib3960e8facc0104c4d19fc19ea587c138f998a42
2015-11-24 14:08:54 +02:00
Stephan Bergmann
295c7827e0 Translate Korean comments
...via translate.google.com, to make file plain ASCII

Change-Id: Icbf25074bd92eb1f0fb453f9887b1f1f1ca82b57
2015-11-24 13:05:52 +01:00
Eike Rathke
26a202a3e2 straighten out broken indentation
Change-Id: Ibb34f4a655cce13a24cc7ec22a29fa40e3a0286a
2015-11-24 13:03:19 +01:00
Stephan Bergmann
41dbbdcc8b Remove non-ASCII U+0086 PARAGRAPH SIGN from comment
Change-Id: Ifcbb2a61c662f135badc01b7beaef10fa3d75515
2015-11-24 13:02:40 +01:00
Stephan Bergmann
f42d03f3e9 Replace non-ASCII content in ordinary string literals with UTF-8 bytes
Change-Id: Ib92221527550beb35e2263b150a509b3ef68545f
2015-11-24 13:01:10 +01:00
Stephan Bergmann
5468446041 -Werror,-Wunused-private-field
Change-Id: I592db0524cb1d028e7dd3c3d49457f4a4038d5be
2015-11-24 13:01:10 +01:00
Noel Grandin
1f9264f9f8 com::sun::star->css in winaccessibility/
Change-Id: I644364fc6d8fc334044a3e53fcde24a6ef86c021
Reviewed-on: https://gerrit.libreoffice.org/20142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-24 11:42:48 +00:00
Miklos Vajna
55040ea134 sw lok comments: fix missing invalidations from the scrollbar
If a comment had a scrollbar, and the user clicked on the down arrow of
it, then the button remained in the "pushed" state, as the scrollbar
invalidations were not routed to the LOK client.

With this, the button gets back to its non-pushed state after the mouse
button is released.

Change-Id: Ie4ba5d0ec07229b0cfc08532e8e91ae25f7a4c9e
2015-11-24 12:22:49 +01:00
Miklos Vajna
fa377a0662 desktop: fix LOK_DEBUG rectangle painting
Change-Id: If023e409fad6fed8c0345a66ea48c1ed9924bff0
2015-11-24 12:22:49 +01:00
Tor Lillqvist
81d9f1cbd6 Bin outdated #if and unnecessary <config_mingw.h>
We don't support cross-compiling with MinGW currently, and in any case
if we ever attempt such again, in the meantime the free replacement
Win32 headers most likely have been updated to include the
SCRIPT_CONTROL::fMergeNeutralItems field, so no conditional
compilation is needed.

Change-Id: I38701d6c41c44952466c1ece7c8433abe67642be
2015-11-24 12:58:57 +02:00
David Ostrovsky
bbbef1568b Bump jpeg-turbo version to 1.4.2
Change-Id: Ie0d274423a66db49f58bf4de423ad7b0cc638d47
Reviewed-on: https://gerrit.libreoffice.org/20116
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-11-24 10:43:23 +00:00
Tor Lillqvist
ff66223fcb FONTFALLBACK_HOOKS_DISABLED is not defined
Change-Id: Icaecbfe4c53c6488fe8d9ed797251ac23985706f
2015-11-24 12:38:58 +02:00
Caolán McNamara
70b09d9322 cppcheck: noExplicitConstructor
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
2015-11-24 10:35:44 +00:00
Caolán McNamara
cbc5dc14d6 coverity#1326190 Explicit null dereferenced
set this back to its original code pre..

commit e5bc8b60ec
Date:   Tue Aug 5 12:18:20 2014 +0200

to silence coverity about it

Change-Id: I9d8f1bda1a32fbf97c0bdc73edfeab9f74d6443a
cids: 1326180<->1326190
2015-11-24 10:35:44 +00:00
Caolán McNamara
79391ca309 coverity#1326265 Explicit null dereferenced
Change-Id: I802e0f854cb5c560e7a860f2fcec0330e481da6c
2015-11-24 10:35:44 +00:00
Caolán McNamara
8540bcc810 coverity#1327143 UrF: Unread field
Change-Id: Iff1a546cca83fed6fc81836e447bc30d68969274
2015-11-24 10:35:44 +00:00
Caolán McNamara
606d0ef777 coverity#1326596 Useless call
Change-Id: I9aff17d367ba48609067abdb2a5fb5111daee38c
2015-11-24 10:35:43 +00:00
Caolán McNamara
ee283cd59f coverity#1326597 Useless call
Change-Id: I4f51d49a18adf76a741d55d67ed3ba2a7a2cc439
2015-11-24 10:35:43 +00:00
Caolán McNamara
61273b37ec coverity#1326892 FE: Test for floating point equality
Change-Id: I47b9ccf2685bd0f37ee2722e93fad9ed668c3b81
2015-11-24 10:35:43 +00:00
Caolán McNamara
6318552774 coverity#1326891 FE: Test for floating point equality
Change-Id: I5cf13dfb5e085684b333c47d6bee73f92b758e81
2015-11-24 10:35:43 +00:00
Caolán McNamara
7ab95e6fca coverity#1326890 FE: Test for floating point equality
Change-Id: I767df959a9b8d9845cb56a34538707c599f82849
2015-11-24 10:35:43 +00:00
Stephan Bergmann
827811ae7e -Werror,-Wunused-private-field
Change-Id: I595f0c2b05b96fbf2055a37e335f8c700044a699
2015-11-24 11:28:56 +01:00
Stephan Bergmann
97e24dc653 m_aCurrentRequest is not unused
...broken with dd351dd728 "loplugin:unusedfields
in vcl/"

Change-Id: I7e9cac85ab52e538c2ce3941c8eeffb73d3d387f
2015-11-24 10:51:43 +01:00
Philippe Jung
e4ec9232b6 Add sc version of toggletabbarvisibility icons
Change-Id: Ie6097aeb8847971e79b78e83a9522e49d7271652
Reviewed-on: https://gerrit.libreoffice.org/20141
Reviewed-by: Philippe Jung <phil.jung@free.fr>
Tested-by: Philippe Jung <phil.jung@free.fr>
2015-11-24 09:16:16 +00:00
Michael Meeks
e8a2170e18 vcl: fix for kde4.
Change-Id: If68e58a5b1d6dfe7d7851513eed73ec20d1cd912
2015-11-24 09:20:29 +00:00
Noel Grandin
f273676325 update unusedfields plugin to use new clang warn_unused attribute support
Change-Id: I7b84de29b672e40cbf3c3d340d235f334d2be8cb
2015-11-24 11:04:33 +02:00
Noel Grandin
c18c50cda3 add SAL_WARN_UNUSED to css::uno::WeakReference and SvCompatWeakRef
Change-Id: Idb784d398ed22f2291f1beaffb82f68642d68bcd
2015-11-24 11:04:33 +02:00
Michael Meeks
4bd8ffd27f Replace return boolean from DoYield with pleasant enumeration.
Change-Id: I1b1f885b4d7916a18dfb2457a8e9af9a5b4ae6e4
Reviewed-on: https://gerrit.libreoffice.org/20138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-24 09:02:31 +00:00
Miklos Vajna
37b5f1ed31 tdf#78902 VML import: workaround for extreme top margin
Regression from commit 2b78f2cd7b (rhbz#988516:
DOCX import: fix context stack when importing header/footer, 2014-03-05),
though that just made an existing Writer layout problem visible.

RTF/WW8/newer (drawingML) DOCX import doesn't have this problem, as those
import pictures as sw graphics, not draw ones.

<w10:wrap type="through"/> is normally mapped to our page wrap (as it uses
"through" in the "not only wrap around, but also in the holes of the shape, if
it has any" context, not in our "text should go through it, so no wrapping"
one), but for some reason in this case (most probably due to the extreme large
negative margins) Word handles the situation as our through, i.e. the text
should not go to the second page, as it would normally happen with a "Word
through" wrapping.

Work around the strange situation by ignoring the wrapping request for extreme
top margin values.

Change-Id: I20555b1fa7a769e20c40a3a5ff3873807403e937
2015-11-24 09:22:16 +01:00
Noel Grandin
dd351dd728 loplugin:unusedfields in vcl/
and remove the unused SALEVENT_MOUSEACTIVATE stuff

Change-Id: Ieb85872eca68621c6a7be47ff5dbea12f7690507
Reviewed-on: https://gerrit.libreoffice.org/20140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-24 08:17:55 +00:00
Noel Grandin
145a995411 loplugin:unusedfields in xmlsecurity/
Change-Id: I11bb62b0c90de361b7cd06608e77483786750ebb
2015-11-24 10:09:26 +02:00