mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
437,482 Commits 1 Branch 0 Tags
ada2b5be85f8c4d16c627a990e3f362ae0663d9f
Commit Graph

105 Commits

Author SHA1 Message Date
Jens Carl
9f71d0f3f9 tdf#68339 Other: BASIC Syntax error 
Allow expressions (operands) of comparison operators prefixed with the
Logical Operator "Not".

Change-Id: I1b070e2288dac26b1f1186d38cf5d2f4ad99a406
Reviewed-on: https://gerrit.libreoffice.org/71332
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2019-05-03 08:24:18 +02:00
Gabor Kelemen
e48e063254 o3tl::make_unique -> std::make_unique in basctl...bridges 
Since it is now possible to use C++14, it's time to replace
the temporary solution with the standard one

Change-Id: I9a20a58c68d12656359dcaa060d8ab41f621af32
Reviewed-on: https://gerrit.libreoffice.org/66262
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-01-16 07:20:49 +01:00
Doğa Deniz Arıcı
f0f462bfa5 tdf#112689: Replace chained O(U)StringBuffer::append() with operator+ 
Change-Id: Ieb5c1e13ae647b49fd563f1759d744bd5f008ce1
Reviewed-on: https://gerrit.libreoffice.org/65758
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-01-10 08:50:31 +01:00
Noel Grandin
bd26a8efd5 use unique_ptr in SbiExpression 
Change-Id: I8b44215c438b749afce4ad056cab2c2ac66d4bda
Reviewed-on: https://gerrit.libreoffice.org/65534
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-21 18:52:05 +01:00
Noel Grandin
a18a72ac1a loplugin:useuniqueptr in SbiExprNode 
Change-Id: I2025251e35a48f47a51f11d790c3a22e118f3c05
Reviewed-on: https://gerrit.libreoffice.org/59348
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-22 08:26:41 +02:00
Stephan Bergmann
6070aaa47d More loplugin:cstylecast: basic 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I20b38196ee1b6a34384dc46d9de1b6e1b44947ae
 2018-01-12 20:29:14 +01:00
Mike Kaganski
4e144751f1 loplugin:unusedindex 
Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146
Reviewed-on: https://gerrit.libreoffice.org/46652
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-18 07:36:32 +01:00
Mike Kaganski
daf7c3e732 basic: consistently use "" and <> in include directives 
Change-Id: I147c0e9b9b1e09af593f54799e45e1348cd40716
Reviewed-on: https://gerrit.libreoffice.org/43298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-10 07:43:46 +02:00
Tor Lillqvist
6978f506a4 Bin some noise comments and ASCII graphics 
Change-Id: Ib0e786b0e8401da3e3c93bf254727411774e8f43
 2017-09-20 09:47:38 +03:00
Stephan Bergmann
85d71244eb loplugin:oncevar: empty strings: basic 
Change-Id: I4edf130e526c4004aa8913e6aafdcd1e2f4ac1ef
 2017-07-13 11:47:27 +02:00
Noel Grandin
6ee9f2c188 loplugin:oncevar accessibility..basic 
Change-Id: I8fb41b658ef0f6ad1774ea897eace3dc9bb12de6
Reviewed-on: https://gerrit.libreoffice.org/38969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-20 07:50:06 +02:00
Chris Sherlock
da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Katarina Behrens
351dead74b tdf#106529: Revert "tdf#80731 Closing parenthesis is now detected" 
This reverts commit 65e294e221e0ad1d37c6667eecb995817ace870d, which
breaks several widely used Basic extensions and hundreds of anonymous
macros that miss closing parenthesis here and there

(cherry picked from commit 660e394b893a045a077ccded263f94a1be03fcf9)

Change-Id: I5d27e6d4e7c8aea3f0762c41ede46e35a5a24aaa
Reviewed-on: https://gerrit.libreoffice.org/35970
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-03-31 14:27:57 +00:00
Andrea Gelmini
5ad636acc6 Fix typos 
Change-Id: Idbf0aa261b829e83d4c08a2e989a4ced871dc6de
Reviewed-on: https://gerrit.libreoffice.org/35616
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-26 20:37:59 +00:00
Stephan Bergmann
73be3ce38a loplugin:subtlezeroinit: basic 
Change-Id: I3d5f157db315fce3492ff6ce88e8ded763af944e
 2017-02-21 07:35:12 +01:00
Noel Grandin
afabf409aa oops, wasn't supposed to commit that 
snuck in with commit 4d2c210c74
"use early return to simplify flow"

Change-Id: I2a5cbff01c5f40d879d320fd3934bc0856756d37
 2016-12-02 13:22:15 +02:00
Noel Grandin
4d2c210c74 use early return to simplify flow 
Change-Id: I98201eac2e038c152422bbc6380cfa321ba266df
Reviewed-on: https://gerrit.libreoffice.org/31534
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-02 11:17:12 +00:00
Pierre Lepage
379b7ffb68 tdf#80731 Closing parenthesis is now detected (Mid statement and functions). 
Change-Id: I5efdb6c3ce71148672a8b76d3f1cc87b0fe04994
Reviewed-on: https://gerrit.libreoffice.org/30593
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-30 06:42:48 +00:00
Noel Grandin
b1f8cf3782 loplugin:singlevalfields 
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76
Reviewed-on: https://gerrit.libreoffice.org/30476
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-02 13:06:37 +00:00
Arnaud Versini
c0d7dfa56c BASIC : Add SbModule::FindMethod 
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a
Reviewed-on: https://gerrit.libreoffice.org/24346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-12 07:43:03 +00:00
Noel Grandin
f107d45381 Convert SbxClassType to scoped enum 
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:49:32 +00:00
Caolán McNamara
a139320da2 deref of null 
regression from

commit f17a4694b0
Author: Arnaud Versini <arnaud.versini@gmail.com>
Date:   Sat Feb 13 20:17:41 2016 +0100

    BASIC : use std::unique_ptr for storing SbiExprList

    Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec
    Reviewed-on: https://gerrit.libreoffice.org/22345

because they have been moved into the container at this
point

Change-Id: If21e0321ffdce66aa9629637d0ff8c16efbbd25e
 2016-03-09 15:16:07 +00:00
Noel Grandin
2d0dab5b15 loplugin:commaoperator in basic/ 
Change-Id: I320a06e50d032a55d8d5e6354959c12327e319ee
 2016-02-22 16:55:11 +02:00
Arnaud Versini
f17a4694b0 BASIC : use std::unique_ptr for storing SbiExprList 
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec
Reviewed-on: https://gerrit.libreoffice.org/22345
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 07:08:59 +00:00
Arnaud Versini
6c6cb30bf4 BASIC : Use std::unique_ptr in SbiExpression and SbiExpList 
Change-Id: I6f09615d19560673319e103af36c40c94ea77f12
Reviewed-on: https://gerrit.libreoffice.org/22186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-02-08 20:32:15 +00:00
Arnaud Versini
c474e610e4 BASIC : Use vector in SbiExprList to avoid any dependencies 
Change-Id: I1ae88ae9c4276452a00aadaaadebf582e639b15a
Reviewed-on: https://gerrit.libreoffice.org/22174
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 06:06:40 +00:00
Arnaud Versini
4cac0c05c6 BASIC: SbiExpression::IsIntConstant has side effects. 
Also renames IsIntConstant to ConvertToIntConstIfPossible.

Change-Id: Ib4b465ac0d890762547fb2d83c26ad6be6ee75e8
Reviewed-on: https://gerrit.libreoffice.org/21746
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2016-01-27 15:36:52 +00:00
Arnaud Versini
7d0e520e22 BASIC : Remove class SbiDimList and SbiParameters 
Change-Id: I039bdc786a65ad534390e7138f584cdb470428af
Reviewed-on: https://gerrit.libreoffice.org/21734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-01-24 17:43:15 +00:00
Arnaud Versini
49b5eed56c BASIC : Remove SbiExprList::pParser 
Change-Id: Ib9386d97ddb12f148cf76dc71aa8c41003286f50
Reviewed-on: https://gerrit.libreoffice.org/21534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-24 06:48:45 +00:00
Stephan Bergmann
08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Stephan Bergmann
4d00131b67 Reduce variable scope 
Change-Id: I87850db982f413b328976e043d8386b7577ba17c
 2015-10-07 11:32:42 +02:00
Stephan Bergmann
1f6b082388 Fix previous commit 
...4b4a7c0d87eb580272aba0777c9021789025bdc0 "Revert a fix that can never have
worked in the first place?"---which presumably did work after all, as Noel
thankfully pointed out to me,
<http://lists.freedesktop.org/archives/libreoffice/2015-September/070193.html>
"Re: [Libreoffice-commits] core.git: basic/source 'Revert a fix that can never
have worked in the first place?'"

Change-Id: I411bfaacbfebf50589290c6a3040d0300c256439
 2015-09-09 10:54:03 +02:00
Stephan Bergmann
4b4a7c0d87 Revert a fix that can never have worked in the first place? 
clang-analyzer-deadcode.DeadStores finds that conditionally assigning

  eTok = SYMBOL

inside the "if( SbiTokenizer::IsKws( eTok ) )" block is useless, as the directly
following

  if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )

will unconditionally assign into eTok again, without intermediate use of the old
eTok value.

Now, the conditional "eTok = SYMBOL" assignment was added as
5d98ed5c6a "INTEGRATION: CWS ab12fixes: #118234#
SbiExpression::Term(): Allow Input as symbol for action option compatible,"
while the unconditional "eTok = eNextTok" assignment had followed that block
ever since c25ec0608a "initial import."

The referenced "#118234#" was a Sun-internal bug and is no longer available, but
it does very much look as if this alleged bugfix never worked in the first
place.  So revert the code back to what it looked before
5d98ed5c6a, for now.

Change-Id: I1fe1178d2c5b0c0372da32b8dd0f2dfbdb22a1ae
 2015-09-08 10:57:54 +02:00
Noel Grandin
b1c25a0d8f inline "old" SbERR constants 
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
 2015-07-28 08:35:34 +02:00
Arnaud Versini
fabe329412 BASIC : Remove SbCodeGen attribute from SbiExprNode and user std::unique_ptr. 
Change-Id: I9f44f6a4b61987de960b77f54bac8cf2c981bd2a
Reviewed-on: https://gerrit.libreoffice.org/16551
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
 2015-07-02 07:43:03 +00:00
Stephan Bergmann
761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00
Noel Grandin
539ba642d7 remove unnecessary header file 
Change-Id: I3b86a54a773341be7e7e69e88c59dc531ea49c5b
 2015-05-17 10:08:59 +02:00
Stephan Bergmann
39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00
Caolán McNamara
6b709b27b3 coverity#735399 Logically dead code 
we can only enter the bAssumeExprLParenMode controlled block once
because the block sets bAssumeExprLParenMode to false

bAssumeExprLParenMode is only true if the first token read in the
method is LPAREN

so we can only enter this block if the current token is LPAREN and
its the first token processed, so the token can't be BYVAL

Change-Id: I6e668fca4d127d7dbfe447e2d9f2231e05278a7d
 2014-11-17 14:53:24 +00:00
Stephan Bergmann
f8ef1fe95b loplugin:staticcall 
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
 2014-06-13 17:54:23 +02:00
Stephan Bergmann
f96f38f8f8 bool improvements 
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
 2014-01-28 20:26:30 +01:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Caolán McNamara
3c2983ded9 CID#707646 uninitialized member variables 
also CID#707647

Change-Id: I9962bd2417119944a243d8a92711866548248e36
 2013-10-07 11:46:58 +01:00
Takeshi Abe
ea1e3b77d4 sal_Bool to bool 
Change-Id: I16ddbcf100e21d6c05fccbe24faca2932a605902
 2013-10-02 10:00:44 +09:00
Markus Mohrhard
ead0a6038b coverity#705627: fix memory leak 
Change-Id: I4f73f77b27d2ed28a9f97757105c8a6cc5521b33
 2013-03-09 17:59:12 +01:00
Markus Mohrhard
1544c17ffd coverity#705626 and coverity#705627: fix memory leak 
Change-Id: I68f43d07798ccb3fc3a5ab438992ac74f4cd262a
 2013-02-28 06:29:35 +01:00
Norbert Thiebaud
27239ad230 basic: String -> OUString 
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
 2012-11-07 02:14:53 -06:00
Norbert Thiebaud
d92814f462 basic: preliminary cosmetic clean-up 
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
 2012-11-03 20:24:28 -05:00
Tor Lillqvist
38968e2963 WaE [loplugin]: statement alignment 
Change-Id: Ia09c74e02d261de5946e6d7e0530a7913e0bcb8d
 2012-10-10 14:59:24 +03:00
Takeshi Abe
1f224b02c8 sal_Bool to bool 
Change-Id: Idb5ef3cebdd45bd91f7c0ae34e422fd651d395c9
 2012-08-14 07:37:19 +09:00