mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
411,769 Commits 1 Branch 0 Tags
b45446fcb4958b13bc94e70e2d3d1940db3322e2
Commit Graph

203 Commits

Author SHA1 Message Date
Noel Grandin
3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Noel Grandin
c9253818ec loplugin:oncevar 
extend oncevar to any POD type

Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0
Reviewed-on: https://gerrit.libreoffice.org/40564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-31 08:25:07 +02:00
Noel Grandin
4250b25c6a teach unnecessaryparen loplugin about identifiers 
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b
Reviewed-on: https://gerrit.libreoffice.org/39737
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-10 09:57:24 +02:00
Noel Grandin
4b2262ab5b new loplugin unnecessaryparen 
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-05 11:08:48 +02:00
Noel Grandin
469076317d loplugin:unusedfields l10ntools..rsc 
Change-Id: I78785eeab436910c9e8733924a7c43fa998ba36f
Reviewed-on: https://gerrit.libreoffice.org/39491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-04 11:26:09 +02:00
Noel Grandin
93d42c1b23 loplugin:oncevar in l10ntools..mysqlc 
Change-Id: Ifd4826f8ba4e10f2e012172fa693794d68bb6b4d
Reviewed-on: https://gerrit.libreoffice.org/39188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-25 17:19:48 +02:00
Noel Grandin
cb37c5f0f3 loplugin:unusedfields in jvmfwk..mysqlc 
Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08
Reviewed-on: https://gerrit.libreoffice.org/39099
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 08:59:20 +02:00
Noel Grandin
2ccde70d60 teach redundantcast plugin about functional casts 
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-30 08:50:31 +02:00
Jochen Nitschke
959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Chris Sherlock
da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Stephan Bergmann
f6262b3dcb Remove redundant 'inline' keyword, Linux redux 
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
 2017-03-07 08:12:52 +01:00
Andrea Gelmini
5bea199bae Fix typos 
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b
Reviewed-on: https://gerrit.libreoffice.org/34803
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-02 12:39:35 +00:00
Stephan Bergmann
f89f9aa6ad With GCC -std=gnu++17, dynamic exception specifications cause an error 
...instead of a warning (as with Clang), so this follow-up to
e16644fa1c "external/mysqlcppconn: Silence
-Wdynamic-exception-spec errors" patches the (few) dynamic exception
specifications out of external/mysqlcppconn completely

Change-Id: I83a42f1c09e60c15fad1564cf7c42eb3370485da
 2017-02-23 12:20:49 +01:00
Stephan Bergmann
e16644fa1c external/mysqlcppconn: Silence -Wdynamic-exception-spec errors 
...with Clang in C++17 mode

Change-Id: If51c0788439688f6fbd77c1a05cb3295ac6e8cb4
 2017-02-16 18:11:24 +01:00
Noel Grandin
29337650a3 boost::scoped_ptr -> std::unique_ptr in mysqlc 
Change-Id: I4c8d25ed451ab03d2b5d0e9977ab74fd2ea1bb04
Reviewed-on: https://gerrit.libreoffice.org/33870
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 10:48:15 +00:00
Noel Grandin
f4826959c1 new loplugin:unusedenumconstants 
These are the simple removals, where it is obviously safe,
the more complex ones will come in separate commits

Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308
Reviewed-on: https://gerrit.libreoffice.org/33828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 08:59:39 +00:00
Stephan Bergmann
ccb1b1251c Work around GCC 7 -Werror=implicit-fallthrough= 
This is in !LIBO_INTERNAL_ONLY code, so cannot use SAL_FALLTHROUGH.  And even on
current <https://github.com/boostorg/config> master, BOOST_FALLTHROUGH does not
yet support [[fallthrough]] for GCC 7.

Change-Id: I5306c3949b13c517fe8ef643cf98c2021147617e
 2017-01-31 10:55:16 +01:00
Stephan Bergmann
f669813835 Silence GCC 7 warnings in cppconn/exception.h 
Change-Id: Ia924473d3dba11babee23f4137c645b9f8d86a8b
 2017-01-31 10:41:35 +01:00
Stephan Bergmann
b61214c91d Remove dynamic exception specifications from !LIBO_INTERNAL_ONLY 
...only odk/examples/ remains to be clean up

Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
 2017-01-27 10:40:41 +01:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox 
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:12:00 +00:00
Noel Grandin
a005fbeddc OSL_TRACE->SAL in framework..sal 
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9
Reviewed-on: https://gerrit.libreoffice.org/31903
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:10:04 +00:00
Noel Grandin
401d07f31f loplugin:datamembershadow 
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
 2016-11-17 11:19:55 +02:00
Noel Grandin
b1f8cf3782 loplugin:singlevalfields 
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76
Reviewed-on: https://gerrit.libreoffice.org/30476
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-02 13:06:37 +00:00
Stephan Bergmann
d4398c7767 Remove bogus comments about ~IPropertyArrayHelper not being virtual 
...which isn't true at least ever since b525a3115f
"initial import", but got copy/pasted all over the place

Change-Id: I47d3d8a594aef3ac3736d7176ae964a118821014
 2016-10-27 17:08:09 +02:00
Stephan Bergmann
07339d03af Remove obsolete workaround for SUNPRO 5 compiler 
...copy/pasted into three more places

Change-Id: I6661244d0248af509cd867fc3e8c451551068a78
 2016-09-20 07:55:10 +02:00
Noel Grandin
e592877844 loplugin:unusedenumvalues 
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b
Reviewed-on: https://gerrit.libreoffice.org/28942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-18 11:02:45 +00:00
Stephan Bergmann
8be8152bcb loplugin:unnecessaryoverride in mysqlc 
Change-Id: I7c8ecc8f675abf4495c991bdb680e31b59421e26
 2016-07-15 12:29:52 +02:00
Stephan Bergmann
a6060e02f7 Fix typo relase_ChildImpl -> release_ChildImpl 
Change-Id: I68faf8cfb8eb390e7970383b8a6596a9dd3f95f7
 2016-07-12 15:57:36 +02:00
Caolán McNamara
a7415828b8 Revert "tdf#88206 Change use of cppu::WeakImplHelper*" 
this doesn't build, I think mysqlc is considered !LIBO_INTERNAL_ONLY
seeing as its an extension

This reverts commit 2d2a33934e.

Change-Id: I600b986632b90e482475628e09256ca5c2b0a6cf
 2016-06-09 10:25:49 +01:00
krishna keshav
2d2a33934e tdf#88206 Change use of cppu::WeakImplHelper* 
removed <cppuhelper/implbase1.hxx>

Change-Id: I2888e42eec480f0940c3e4f9bcc000c150d1161b
Reviewed-on: https://gerrit.libreoffice.org/26076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-06-09 07:10:15 +00:00
Stephan Bergmann
336b62080b Missing include 
Change-Id: Id61e2de27ec307fa7773d3f0d5a0810005f1c364
 2016-05-30 13:33:37 +02:00
Stephan Bergmann
fcbd824f1b Use BOOST_FALLTHROUGH in external code 
...in preparation of enabling Clang's -Wimplicit-fallthrough

Change-Id: If64f9b18591b3cd2528adc6c2d6011d509d4afcd
 2016-05-10 15:25:12 +02:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Stephan Bergmann
235b1f3dfd Avoid reserved identifiers 
Change-Id: Id2ef8fb53207be64d0f7342734f0d9fab832b674
 2016-04-22 16:34:33 +02:00
Stephan Bergmann
227f6998d5 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Ie511eeb586e8c592bc255a09eff1bcf673a29ea9
 2016-04-20 17:25:45 +02:00
Jochen Nitschke
150ac9cf05 clean-up: unused using declarations and includes 
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:25:24 +00:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Stephan Bergmann
553f7e515d Revert "tdf#88206: use variadic variants for cppu helper" 
This reverts commit cf1ecad26d. Library_mysqlc is
external_code, so cannot use these LIBO_INTERNAL_ONLY features.
 2016-04-12 09:29:59 +02:00
Stefan Weiberg
cf1ecad26d tdf#88206: use variadic variants for cppu helper 
Change-Id: I58a00f721cbb37f97fdbc599d57c26b1e89f4c73
Reviewed-on: https://gerrit.libreoffice.org/23998
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2016-04-11 16:25:08 +00:00
Jochen Nitschke
f7a75a66fa cleanup: remove unused Reference.h(xx) includes 
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-02 19:01:24 +00:00
Noel Grandin
d298cfd986 loplugin:unuseddefaultparams in mysqlc 
Change-Id: I83e27ed242b6ec1fbd19e473a4d8c0f4588e6f86
 2016-03-03 08:13:14 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin
a7f6efc68b loplugin: unused return values 
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af
Reviewed-on: https://gerrit.libreoffice.org/21571
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-18 12:50:09 +00:00
Caolán McNamara
0aa5414015 cppcheck: noExplicitConstructor 
Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2
Reviewed-on: https://gerrit.libreoffice.org/21245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-01-08 17:15:04 +00:00
Noel Grandin
33fac48280 loplugin:unnecessaryvirtual 
and unwind some apparently now unused VCL OpenGL and GlyphCachePeer
stuff.

Change-Id: Ic85302d4e1ad4056dabc49c97a608891052e3167
Reviewed-on: https://gerrit.libreoffice.org/20920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-12-24 20:57:35 +00:00
Noel Grandin
1b80ad7246 loplugin:unusedfields in lingu,lotuswordpro,mysqlc 
Change-Id: I5866c8d95e04714e81a45e73bf00a430859a4327
 2015-12-22 10:16:36 +02:00
Noel Grandin
e18b08363a loplugin:unusedmethods 
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
 2015-12-21 10:20:31 +02:00
Stephan Bergmann
fb8a3fac5d loplugin:nullptr: More NULL -> nullptr automatic rewrite 
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
 2015-12-10 08:06:06 +01:00
Noel Grandin
ec3f724158 loplugin:unusedfields 
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
 2015-11-30 10:34:38 +02:00
Noel Grandin
1f86864e97 loplugin:unusedfields various 
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
 2015-11-25 13:57:29 +02:00