Commit Graph

37 Commits

Author SHA1 Message Date
Gabor Kelemen
5df31134f1 tdf#42949 Fix IWYU warnings in include/canvas/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I93d516146ba44d83f84cb245e712ef6d14634a18
Reviewed-on: https://gerrit.libreoffice.org/68035
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-25 14:17:32 +01:00
Gabor Kelemen
7af90cc93b Add missing sal/log.hxx headers
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84ade
to be able to remove those unneeded includes.

This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from a* to configmgr

Change-Id: I6ea1a7f992b1f835f5bac7a725e1135abee3f85a
Reviewed-on: https://gerrit.libreoffice.org/57170
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-09 10:49:06 +02:00
Tor Lillqvist
8e7897588d Rename the basegfx::tools namespace to basegfx::utils
Reduce potential confusion with the global tools namespace. Will
hopefully make it possible to remove the annoying initial :: when
referring to the global tools namespace. Unless we have even more
tools subnamespaces somewhere.

Thorsten said it was OK.

Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996
Reviewed-on: https://gerrit.libreoffice.org/42644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26 14:18:41 +02:00
Noel Grandin
fd00bd0f69 loplugin:unusedfields
make it a little smarter in dealing with fields that are smart pointers

Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11
Reviewed-on: https://gerrit.libreoffice.org/37751
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19 09:17:06 +02:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
aybuke
91c072b473 tdf#43157: Fix format string violations in OSL_TRACE etc.
Change-Id: Idffbfb78b2386020fd099077a67bf8a89917bdab
Reviewed-on: https://gerrit.libreoffice.org/21999
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02 06:10:21 +00:00
Mario J. Rugiero
ce69d6e9e1 boost::bind -> lambdas in canvas/source/vcl subtree
Change-Id: I2b2e746197b94222c73b78379d64086adfb5e693
Reviewed-on: https://gerrit.libreoffice.org/19712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01 11:31:21 +00:00
Norbert Thiebaud
e5ec630414 stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxx
also clean-up and 'standardize' the include sections of canvas' source code

Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73
Reviewed-on: https://gerrit.libreoffice.org/17633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11 03:57:18 +00:00
Norbert Thiebaud
326777b5d9 remove VERBOSE use from canva
in preparation to kill --enable-verbose in configure.ac
convert modules that use VERBOSE-YES/NO (uppercase) env variable
to do things differently at compile time
Convert canvas to use SAL_INFO/SAL_WARN mechanism instead of its
home-grown 'verbose logging'.

Change-Id: I2898d2309d421457839e3cd7078166c6da919882
Reviewed-on: https://gerrit.libreoffice.org/17619
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-10 17:14:18 +00:00
Noel Grandin
a60cc5d62a com::sun::star->css in canvas
Change-Id: I23c3f774834bb7e84e2f02fe05fa9d844adadc9d
Reviewed-on: https://gerrit.libreoffice.org/17259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22 09:04:57 +00:00
Michael Stahl
e8eb49995a canvas: remove boost::bind from headers
Change-Id: Ieaa8a74d59ee9c74fafe823e01db4a349c49821e
2015-07-09 10:18:05 +02:00
Christian Lohmaier
f96b38ddda tdf#91574 fix presenter console not displayed
The bool simplification from 3ac5138cfc
accidentally changed the logic of the return statement

Change-Id: Id6075356184e340dc970d2e59d1fb1d1a173d0a7
Reviewed-on: https://gerrit.libreoffice.org/16724
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-03 19:47:21 +00:00
Stephan Bergmann
3ac5138cfc loplugin:simplifybool
Change-Id: I8087e16e50c06534e7d9a08c3bc72ab53de9f126
2015-04-24 12:36:19 +02:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Chr. Rossmanith
58ae10ed58 RTL_CONSTASCII_(U)STRINGPARAM removed in canvas (WIP)
Change-Id: Id8db06826b77a2b59df51dc0829cd9e7539045fa
2013-01-07 19:42:36 +01:00
Michael Meeks
60337134e4 re-base on ALv2 code. Includes:
linecap: Reintegrating finished LineCap feature
    Patch contributed by Regina Henschel
    http://svn.apache.org/viewvc?view=revision&revision=1232507

    disable extended linecap API for now.

    gnumake4 work primarily from Mathias Bauer
    http://svn.apache.org/viewvc?view=revision&revision=1394326

    misc. dead code cleanups
    Patch contributed by Ariel Constenla-Haile
    http://svn.apache.org/viewvc?view=revision&revision=1204995
    http://svn.apache.org/viewvc?view=revision&revision=1207270
2012-10-08 11:36:37 +01:00
Norbert Thiebaud
24c0f87615 remove include of pch header in canvas 2011-11-27 12:57:22 -06:00
Thorsten Behrens
09b546cf9c Fix overloaded-virtual warning in canvas
With enabled -Woverloaded-virtual gcc warning (see
http://lists.freedesktop.org/archives/libreoffice/2011-March/009567.html),
canvas exposed a nasty clash between WeakComponentImplHelper::disposing
and XEventListener::disposing. Fixed by overriding *once* in baseclass,
and then calling disambiguated, renamed methods.
2011-04-08 16:47:25 +02:00
Norbert Thiebaud
5ef746c218 use SolarMutexGuard instead of LocalGuard in canvas
LocalGuard is a wrapper guard around the SolarMutex.
SolarMutexGuard already provide this function.
2010-10-25 19:55:37 -05:00
Sebastian Spaeth
4905a19032 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-14 17:02:15 +02:00
Jens-Heiner Rechtien
8764506704 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Kurt Zenker
b6a7c4da52 INTEGRATION: CWS canvas05 (1.13.56); FILE MERGED
2008/06/09 12:51:48 thb 1.13.56.7: #i88081# Join from CWS impress144 (fixing the dxcanvas crash), extended for the other canvas impls
2008/04/21 07:28:29 thb 1.13.56.6: RESYNC: (1.14-1.15); FILE MERGED
2008/04/09 14:33:12 thb 1.13.56.5: Gave back vclcanvas the window surface; made cairocanvas consistent with rest (regarding setWindow)
2008/04/09 09:35:12 thb 1.13.56.4: Improved log output, fixed wrong arg check for vclcanvas
2007/12/20 22:19:00 thb 1.13.56.3: #i81092# #i78888# #i78925# #i79258# #i79437# #i84784# Large canvas rework, completing various areas such as color spaces, bitmap data access, true sprite and non-sprite implementations, and upstreaming the canvas parts of rodos emf+ rendering
2007/11/06 12:37:01 thb 1.13.56.2: RESYNC: (1.13-1.14); FILE MERGED
2007/10/01 13:02:04 thb 1.13.56.1: #i78888# #i78925# #i79258# #i79437# Merge from CWS picom
2008-06-24 10:02:18 +00:00
Rüdiger Timm
7f367db507 INTEGRATION: CWS changefileheader (1.14.24); FILE MERGED
2008/03/28 16:35:17 rt 1.14.24.1: #i87441# Change license header to LPGL v3.
2008-04-11 08:58:23 +00:00
Jens-Heiner Rechtien
d03914c563 INTEGRATION: CWS thbpp9_SRC680 (1.13.58); FILE MERGED
2007/10/17 21:14:36 thb 1.13.58.1: #i82485# Carry clips along, also for XCachedPrimitive repaints
2007-11-01 13:43:00 +00:00
Kurt Zenker
d1ebdd0ed9 INTEGRATION: CWS presfixes09 (1.10.32); FILE MERGED
2006/10/20 11:40:39 thb 1.10.32.8: #i10000# Removed post-merge compiler warnings; removed spurious semicolon after macro
2006/10/18 14:04:51 thb 1.10.32.7: RESYNC: (1.11-1.12); FILE MERGED
2006/09/15 15:45:30 thb 1.10.32.6: RESYNC: (1.10-1.11); FILE MERGED
2006/04/25 12:53:53 thb 1.10.32.5: #i63943# Handling probe construction special
2006/04/21 12:44:22 thb 1.10.32.4: #i63088# Cloned Cyrille's patches accordingly
2006/03/13 12:38:01 thb 1.10.32.3: #i49357# Renamed macro
2006/03/08 18:00:04 thb 1.10.32.2: #i49357# Now also providing the C lib entry points again
2006/03/07 15:08:03 thb 1.10.32.1: #i49357# Adapted to recent XWindow vs. XWindowListener changes; using dbo's new ServiceDecl goodness
2006-12-13 13:48:40 +00:00
Oliver Bolte
0c58636064 INTEGRATION: CWS pchfix02 (1.11.20); FILE MERGED
2006/09/01 17:18:09 kaib 1.11.20.1: #i68856# Added header markers and pch files
2006-09-17 02:31:24 +00:00
Jens-Heiner Rechtien
10089cf771 INTEGRATION: CWS warnings01 (1.10.8); FILE MERGED
2006/06/14 09:33:36 pl 1.10.8.2: #i55991# cast was wrong and yielded a wild pointer
2006/02/22 22:27:26 thb 1.10.8.1: #i55991# Removed virtual derivations, where unnecessary; removed unused params; renamed vars which shadowed previous ones; put agg headers into sys header brackets
2006-06-20 01:20:57 +00:00
Kurt Zenker
aaf62231a7 INTEGRATION: CWS canvas02 (1.8.4); FILE MERGED
2005/10/19 13:47:18 thb 1.8.4.6: #i48939# Adapted to GraphicDeviceBase changes; add screen dump facility; now providing the sprite bounds debug feature as a public property
2005/10/08 12:56:52 thb 1.8.4.5: RESYNC: (1.8-1.9); FILE MERGED
2005/07/21 14:52:49 thb 1.8.4.4: #i48939# Factored out round up/down to integer; removed backend specific methods from base Sprite interface; removed updateScreen overwrite from SpriteCanvasBase (too much backend specifics need to be passed to HW canvases); now passing the target OutputDevice directly via Sprite::redraw() method in VCL canvas; made XFont -> impl font conversion dynamic cast, too; removed the getSpriteTargetSurface crap from SpriteCanvas
2005/07/03 20:25:18 thb 1.8.4.3: #i48939# Reworked ParametricPolyPolygon, to extract state in an atomic operation; added more state checking 'isXDirty()' methods to canvascustomspritehelper; added various comments and notes
2005/06/28 11:22:49 thb 1.8.4.2: #i48939# Removed refcounted reference to device in canvashelper (leads to circular references for SpriteCanvas); improved docs; added drawBezier() implementation
2005/06/17 23:49:52 thb 1.8.4.1: #i48939# Huge refactoring of canvas; as much functionality as possible is now common in a bunch of shared base classes (input checking, locking, sprite redraw, etc.); added scroll update optimization, transparently to all canvas implementations
2005-11-02 12:04:13 +00:00
Rüdiger Timm
120fb1216f INTEGRATION: CWS ooo19126 (1.8.18); FILE MERGED
2005/09/05 17:27:17 rt 1.8.18.1: #i54170# Change license header: remove SISSL
2005-09-07 22:23:21 +00:00
Oliver Bolte
3ce2b4373a INTEGRATION: CWS presfixes03 (1.7.2); FILE MERGED
2005/04/08 11:23:24 thb 1.7.2.2: #i36190# Sprite-transform support made it necessary to track update area also for moves (because the sprite size is no longer fixed, but can vary between the enqueuing of the sprite record and the actual repaint; slightly adapted getSpriteRect(), to match bounds actually attained during sprite transform
2005/04/05 15:24:06 thb 1.7.2.1: #i46666# Fixed resource leak (SpriteCanvas::dispose() did not dispose the member maCanvasHelper, which holds references to the backbuffer; fixed on/off problems for stroked lines, the stroke polygons generated by basegfx are not free of mutual intersections.
2005-04-18 08:12:38 +00:00
Rüdiger Timm
918d7bf7eb INTEGRATION: CWS presfixes02 (1.6.2); FILE MERGED
2005/03/14 16:03:09 thb 1.6.2.1: #i35136# #i36914# #i41113# #i44100# Merge from presfixes01 patches
2005-03-30 06:38:54 +00:00
Vladimir Glazounov
caad307691 INTEGRATION: CWS presfixes01 (1.5.10); FILE MERGED
2005/02/16 11:14:14 fs 1.5.10.1: #i42558# drafts.com.sun.star.drawing/rendering/geometry moved to com.sun.star.*
2005-03-10 11:00:56 +00:00
Thorsten Behrens
f49af82484 #i38282#, #i37796# Added XWindow interface to sprite canvas. Via this interface, the VCL window notifies dependent canvases about visibility/size changes, which makes the VCL canvas react properly on window resizes 2004-12-02 11:41:49 +00:00
Rüdiger Timm
92c9984f88 INTEGRATION: CWS presentationengine01 (1.2.2); FILE MERGED
2004/11/17 17:00:33 thb 1.2.2.13: #118514# Canvas module reorg
2004/09/29 23:36:05 thb 1.2.2.12: #110496# Making the new modules Wall clean
2004/09/29 08:31:23 thb 1.2.2.11: #110496# Removed extraneous trace outputs
2004/09/28 17:43:53 thb 1.2.2.10: #110496# Perform reinterpretative casting more carefully. The old version yielded wrong results for UltraSparc platform, possibly due to violated alignment requirements
2004/09/08 16:34:45 dbo 1.2.2.9: #110496# separate service names for all kinds of canvas implementations
Issue number:
Submitted by:
Reviewed by:
2004/08/27 18:46:18 thb 1.2.2.8: #110496# Adapted to recent canvas API changes (XSpriteCanvas::updateScreen and sprite clip semantics
2004/08/02 17:51:00 thb 1.2.2.7: #110496# Adapted to recent XCanvas API changes, streamlined and factored out common code with directxcanvas
2004/07/22 18:40:43 thb 1.2.2.6: #110496# Overhauled sprite redraw algo, to also respect overlapping sprites
2004/07/20 19:23:57 thb 1.2.2.5: #110496# Removed self-references to various interface implementations, along the lines, factored out common base implementation for all c++ canvases
2004/05/27 20:51:25 thb 1.2.2.4: #110496#
Added classification code to all TODO/HACK/FIXME comments.
There are four categories:
 - code quality (C)
 - performance (P)
 - missing functionality (F)
 - and missing/incomplete error handling (E)

Furthermore, every category has a severity number between
1 and 3 associated, where 1 is lowest and 3 highest
severity
2004/05/27 14:36:53 thb 1.2.2.3: #110496# verbose tracing is now guarded also with DBG_UTIL. Unified verbose trace output between directx and VCL canvas
2004/04/12 15:12:25 thb 1.2.2.2: #110496# Adaptions after canvas01 merge
2004/04/05 15:58:00 thb 1.2.2.1: Resync with canvas01 changes
2004-11-26 16:15:27 +00:00
Rüdiger Timm
356d12cb02 INTEGRATION: CWS ooo20040704 (1.2.14); FILE MERGED
2004/06/28 12:02:52 cmc 1.2.14.1: #i30801 no need to prepend external before boost
2004-09-08 15:26:10 +00:00
Thorsten Behrens
6e89341b50 #110496# Merge from cws_srx645_canvas01: first working version of XCanvas UNO components, for now consisting of javacanvas.uno.jar, vclcanvas.uno and directxcanvas.uno (windows only) 2004-03-18 09:38:44 +00:00