mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
365,666 Commits 1 Branch 0 Tags
b7430c4496b3485d5f0f284e3c27d4088c1f94fc
Commit Graph

749 Commits

Author SHA1 Message Date
Caolán McNamara
41029bcdd0 coverity#1242865 Untrusted value as argument 
Change-Id: Ie7a7a2e7894a204dd55833416b7cbc5b01826e64
 2014-11-14 12:02:48 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Caolán McNamara
1409c0bd88 coverity#1242865 Untrusted loop bound 
Change-Id: I9dc9cd98d0a02a2867d4c40c7afb7bf873513143
 2014-11-05 21:03:24 +00:00
Caolán McNamara
5b0c95d81e coverity#1242794 Untrusted loop bound 
Change-Id: I902a5bf989a8f385994a2f927cce4975b18f06d2
 2014-11-05 21:03:24 +00:00
Caolán McNamara
12bcfec04f markup with event type not checker type 
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
 2014-11-05 14:58:00 +00:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Caolán McNamara
cb0e009a9e document array_vs_singleton dismissals 
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
 2014-10-30 10:10:09 +00:00
Michael Stahl
a1fad26e04 fdo#84935: basic: DocBasicItem is a UNO service, lock SolarMutex in dtor 
Change-Id: Ia31d735ba54d18f406653debce04a07c077d09eb
 2014-10-23 15:38:20 +02:00
Caolán McNamara
0f6c6baf61 coverity#1242481 Dereference null return value 
Change-Id: I21e6bdd643d898a3515a96e4c9c17c2d6f98b0e4
 2014-10-03 16:30:32 +01:00
Noel Grandin
c625525ddc rename SvRef::AddRef to AddFirstRef 
to make it's intended purpose clearly distinguishable from AddNextRef

Change-Id: I5da780b48b19fd873667b648031bc394113f953b
Reviewed-on: https://gerrit.libreoffice.org/11763
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-03 05:25:41 +00:00
Noel Grandin
059f5a95b2 loplugin: cstylecast 
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
 2014-10-02 07:37:19 +02:00
Noel Grandin
5cefde06ea remove unnecessary casts in calls to SvStream.WriteUInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
 2014-09-26 15:27:17 +02:00
Noel Grandin
04fd62096f remove unnecessary casts in calls to SvStream.WriteInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
 2014-09-26 15:27:17 +02:00
Noel Grandin
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
 2014-09-26 15:26:48 +02:00
Noel Grandin
dedfa972bc remove unnecessary casts in calls to SvStream.WriteInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
 2014-09-26 15:26:48 +02:00
Noel Grandin
bec72dd34f remove unnecessary casts in calls to SvStream.WriteUChar 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
 2014-09-26 15:26:19 +02:00
Noel Grandin
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI 
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-09-06 15:47:44 -05:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Caolán McNamara
d21d5a7261 drop unnecessary shl.hxx includes 
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
 2014-08-18 12:59:49 +01:00
Caolán McNamara
d438c470d7 coverity#1231668 Unchecked return value 
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
 2014-08-17 16:39:21 +01:00
Tobias Lippert
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx 
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-07-17 08:47:58 +00:00
Takeshi Abe
d97b5e420f Avoid possible memory leaks in case of exceptions 
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
 2014-07-16 18:01:39 +09:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined 
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
 2014-07-11 14:12:25 +02:00
Norbert Thiebaud
42fcd888ae coverity#735397 dead code 
Change-Id: If8d82a39af7a506f42b6c13d8408ffc479b564e7
 2014-07-01 12:44:06 +02:00
Caolán McNamara
a7fcb3ed07 clang: Returning null reference 
Change-Id: I2cfc14e73696a027283dfa5eef98f784505dc5a3
 2014-06-26 16:29:13 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Stephan Bergmann
f8ef1fe95b loplugin:staticcall 
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
 2014-06-13 17:54:23 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Thomas Arnhold
dd8f095940 WaE: warning C4101: 'ex' : unreferenced local variable 
Change-Id: Ib8b71b50fe52a7cc4e261626549ac3e067851797
 2014-06-04 08:30:26 +02:00
Thomas Arnhold
3038794d2e basic: typo 
Change-Id: I10c9e480a94a966dac4f6c17fc69fa8892c56955
 2014-06-02 12:04:31 +02:00
Stephan Bergmann
6b4c596b01 Fix memory leak for BASIC sub (as well as void function) 
d88593af59 "INTEGRATION: CWS ab34: #i73457#
Prevent sub from beeing set as param 0 for return type void" to fix i#73457
"Memory Leak in all Basic type void Method calls" had made the PutDirect call
dependent on != SbxVOID only (which would cover void functions) but not also on
!= SbxEMPTY (which would apparently be required to also cover subs, as seen with
CppunitTest_basic_vba run under lsan).  Either this was an oversight with the
original fix, or subs have meanwhile changed from GetType() == SbxVOID to
SbxEMPTY?

Change-Id: I3e5dbf79bfd5eea3cfec8ed3fa984d13167aa501
 2014-06-02 11:12:11 +02:00
Kohei Yoshida
a916b6ff7f Detach all DocBasicItem objects upon process termination. 
To prevent rogue DocBasicItem objects (which are global objects) from
attempting to stop listening after the main app is dead.

Change-Id: I68a667137ca4e0eff18278f4d2d5dd67466eaf34
 2014-05-29 21:59:48 -04:00
Kohei Yoshida
5a827671d1 Avoid static local of a singleton. This crashed writer unit tests. 
Change-Id: I7c5f2d372676cdb317a8dad636bf1aab7dd5db37
 2014-05-29 21:59:42 -04:00
Takeshi Abe
a71ae24a23 Avoid possible memory leaks in case of exceptions 
Change-Id: Iac63a5d60478e5cd8e2b77c889c7b312d3d15f67
 2014-05-29 09:29:15 +09:00
Caolán McNamara
3d046b753d coverity#706235 Uncaught exception 
Change-Id: I06321ca2b686207a1d9bd698461aedf84daf31e1
 2014-05-28 13:49:50 +01:00
Caolán McNamara
9986fe77f4 coverity#706234 Uncaught exception 
Change-Id: I7542008369ed3433cd8bfce7702f036148195516
 2014-05-28 13:49:50 +01:00
Caolán McNamara
cf16d4eb9d coverity#706232 Uncaught exception 
Change-Id: I07e13af4f4578d5d6823b6d10aa9c37d04ecc395
 2014-05-28 13:49:49 +01:00
Caolán McNamara
1b48561586 coverity#706231 Uncaught exception 
Change-Id: I1f1acb91a97ff7c9fb50ad36eca7b91d361a1276
 2014-05-28 13:49:49 +01:00
Stephan Bergmann
a77a7f6083 Fix memory leak 
...by using css::uno::Type instead of a naked typelib_TypeDescription.

Change-Id: I387692265e9e032cb5ed6519739ebb3307db6f28
 2014-05-28 14:34:12 +02:00
Stephan Bergmann
b8a329989c Fix memory leak (missing typelib_TypeDescription_release) 
...by radically simplifying TypeToIdlClass().  It is unclear to me why this was
so complicated.  The only mildly plausible reaons would be that the old code
was careful to return null instead of throwing an exception for an unknown type,
but the TypeToIdlClass-call-sites either strongly expect a non-null return value
(by dereferencing it without any further checking) or use OSL_ASSERT or similar
to verify it.  So lets hope this is good.

Change-Id: I3e24eb6117e84c9d33f4c5f0e2fa88da4c4f2c30
 2014-05-28 14:34:12 +02:00
Thomas Arnhold
ea491d056d OSL_TRACE -> SAL_INFO 
Change-Id: Ib9e1ed6119b5286871ac10136f7fcbefffe7aebe
 2014-05-27 12:34:30 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Noel Grandin
c5d47c327a add default value for Context param in uno::Exception constructors 
and all it's subtypes, which is almost never used, so this allows us to
simplify lots of call sites.

Change-Id: I0b05793ea2bdd1027679f63252d42ce4af89433b
 2014-05-23 15:05:59 +02:00
Julien Nabet
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Julien Nabet
68741d0055 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part13 
Change-Id: Ieecfd7ccb10c75ac639d0ba8e7cb588607097c2a
 2014-05-15 22:52:22 +02:00
Julien Nabet
5ec7a589be Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8 
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
 2014-05-10 06:19:42 +02:00
Noel Grandin
78b9537b6a various: sal_Bool->bool 
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
 2014-05-08 11:48:14 +02:00
Thomas Arnhold
9e436082af dflt -> default 
Change-Id: I89f1f5771eb7d96da233a8c7386b906b2a3a9c3e
 2014-05-06 07:19:09 +02:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false" 
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
 2014-05-05 12:47:48 +02:00