Commit Graph

138 Commits

Author SHA1 Message Date
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Caolán McNamara
12bcfec04f markup with event type not checker type
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05 14:58:00 +00:00
Caolán McNamara
cb0e009a9e document array_vs_singleton dismissals
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
2014-10-30 10:10:09 +00:00
Noel Grandin
c625525ddc rename SvRef::AddRef to AddFirstRef
to make it's intended purpose clearly distinguishable from AddNextRef

Change-Id: I5da780b48b19fd873667b648031bc394113f953b
Reviewed-on: https://gerrit.libreoffice.org/11763
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-03 05:25:41 +00:00
Noel Grandin
fa537124ac loplugin: cstylecast
Change-Id: Ie3d13eccdf444d569cbe40befb45eb86941160b6
2014-10-01 13:08:41 +02:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-26 04:30:03 -05:00
Kohei Yoshida
e14abb13dc Use boost::optional to store alias name.
Change-Id: I809b21ea156061a265c0d83d58534df10bc273bc
2014-06-25 15:03:46 -04:00
Stephan Bergmann
f8ef1fe95b loplugin:staticcall
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
2014-06-13 17:54:23 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Takeshi Abe
6a53ea218c Avoid possible memory leaks in case of exceptions
Change-Id: Iad3de981a1c9660b1322315640e531c9891db0bf
2014-05-31 00:35:27 +09:00
Michaël Lefèvre
70e744b215 fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-12 11:32:38 +02:00
Thomas Arnhold
9e436082af dflt -> default
Change-Id: I89f1f5771eb7d96da233a8c7386b906b2a3a9c3e
2014-05-06 07:19:09 +02:00
Thomas Arnhold
d2f24e3a31 typo: beause -> because 2014-04-14 12:33:14 +02:00
Stephan Bergmann
cc725643fd Clean up function declarations and some unused functions
Change-Id: I63c4c61847fea4500b667a5ea9f2b32207692033
2014-04-09 10:12:02 +02:00
Noel Grandin
1eee88dd6b basic: sal_Bool->bool
Change-Id: I1c084ca86c0b1308eb2fc1451ba34d2e702c6a7f
2014-04-07 13:53:50 +02:00
Noel Grandin
f288d7dcbd basic: sal_Bool->bool
Change-Id: Id4952b6f97f9e8f917fea5651dee91499d109e48
2014-03-27 13:45:08 +02:00
Takeshi Abe
dd52330db6 Avoid possible resource leaks by boost::scoped_array
Change-Id: I14e1f7ef217eb5e8e9db9f8962af868ab0a4ab81
2014-03-25 20:08:26 +09:00
Alexander Wilms
6a38eace8c Remove visual noise from basic
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 21:09:17 +00:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Thomas Arnhold
326bec33e0 some more continuous corrections 2014-02-03 14:01:40 +01:00
Caolán McNamara
3848819cac coverity#707652 Uninitialized scalar field
Change-Id: I6d561955454b0619255296704812b41a10ffe962
2014-01-27 14:38:38 +00:00
Stephan Bergmann
0d29aab156 bool improvements
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
2014-01-14 18:11:10 +01:00
Norbert Thiebaud
8b308d510e basic: include <> for external includes
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
2013-11-11 22:37:24 -06:00
Noel Grandin
e9c4ee996d remove unnecessary use of OUString constructor in BASIC module
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
2013-11-11 11:21:25 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
Stephan Bergmann
458c5a0f47 Defer OUString -> OString conversion
...to avoid converting back OString -> OUString in SbiIoSystem::WriteCon.

Change-Id: I17024891d0babaa589f2c65f1123f1905c4338bb
2013-10-15 10:33:26 +02:00
Caolán McNamara
57482ed493 CID#707499 check for 0 nDims
Change-Id: I828339695db1b1880d7e884f8bf26911d04b8508
2013-09-12 13:09:04 +01:00
Noel Power
e70a436fe3 fix runtime error when using extended types
note: using VBA objects with the code completion is not possible at
the moment. Unfortunately there is some hard coded hacks for flattening
the namespace used by checkUnoObject.

Change-Id: Ic3a3149f41a6959943e71fa7ac22ff4dab7f30a1
2013-09-02 18:16:48 +02:00
Norbert Thiebaud
6a08067902 OUString convertion for unotools
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Reviewed-on: https://gerrit.libreoffice.org/4659
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-02 07:31:30 +00:00
Tor Lillqvist
d12a3e8b76 Combine fairly pointlessly split source code for SbiRuntime into one file
Insert basic/source/runtime/step[012].cxx into
basic/source/runtime/runtime.cxx.

Follow-up to https://gerrit.libreoffice.org/#/c/3373/ .

In many cases the sources for some class have been split up into several
source files, typically suffixed with a number 0, 1, 2 etc. Presumably this
has been done because some compiler years ago was not capable of compiling all
the source for that class at one time, or some other no longer relevant
reason.

It would be nice to get rid of this convention, so that clever compilers have
a better chance of noticing unused private fields in a class, for
instance. Just combining the source files in question into one source file and
removing the old source files from git leads to a discontinuity in version
control history. But the consensus seems to be that this is not such a big
deal.

I picked these sources just because they happened to be the first ones I came
across when looking for files called *0.cxx.

Change-Id: Ia7e8ece9a4374721bbcce6b0e2aba5721436faae
2013-04-24 11:07:15 +03:00
Eike Rathke
29bfb507b3 get rid of some Germanism (and some Windowsism)
Change-Id: I2ca1b34ff688a7d4fcf6c84c02035eda3ab0dee8
2013-04-18 23:43:18 +02:00
Eike Rathke
1ef2cce787 Revert "svformatter already accept OUString input", fdo#63306
This reverts commit c5e5699c80.

And adapts to OUString.

Conflicts:
	basic/source/runtime/runtime.cxx

Change-Id: Icd7c1e1e57162eefb1f3631aa5509fd3a09c9b08
2013-04-18 22:57:47 +02:00
Krisztian Pinter
cd49ebe1aa fdo#39445 writing out tools/fsys.hxx (basic)
removed unused include from runtime.cxx and step0.cxx
changed DirEntry::GetAccessDelimiter() to SAL_PATHDELIMITER in methods1.cxx
removed unused DirEntry declaration from methods1.cxx

Change-Id: I0d8c64b6498cf5b16757edaf13e1108f279934dd
Reviewed-on: https://gerrit.libreoffice.org/2848
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-03-19 17:23:43 +00:00
Thomas Arnhold
59b5ff7574 basic: translation of all debug messages
runtime.cxx: Added some output instead of nothing.

Change-Id: Ia25ae4b5fe8661a8a3ac317bc0562e1339640cd8
2013-03-11 21:36:43 +01:00
Noel Grandin
f95a7c2c6d fdo#46808, Convert SvNumberFormatter to use XComponentContext
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-28 08:25:24 +02:00
Radu Ioan
d4bca924dd fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
- Clean up OSL_
- Clean up DBG_
- Clean up OUString

Change-Id: I002d17ffbbd8371b0518ede34931b2eea30865a3
Reviewed-on: https://gerrit.libreoffice.org/1602
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-01-14 08:47:52 +00:00
Tor Lillqvist
6943c7b11c Sigh, my git grep regexps missed some cases
Change-Id: I085f14f40fb83cba171b35b14cf7c0d99091fc00
2012-12-27 14:03:18 +02:00
Eike Rathke
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
Norbert Thiebaud
cc63555fd0 PutEntry familly of functions use consistent pairing OUString/sal_Int32
Change-Id: I23ae9d3e8bf71ef9ece75ea013d18c36ab2e69d4
2012-11-18 19:57:23 -06:00
Norbert Thiebaud
27239ad230 basic: String -> OUString
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
2012-11-07 02:14:53 -06:00
Norbert Thiebaud
c5e5699c80 svformatter already accept OUString input
Change-Id: Icca8c40db4a4449876e115a0746319f3f893e846
2012-11-03 20:24:26 -05:00
Norbert Thiebaud
6f978fa977 basic: use OUString internaly for error messages
Change-Id: I9ea243f93b7477814037deca2f332c3359ce527d
2012-11-03 20:24:25 -05:00
Norbert Thiebaud
363d2c6f8b use OUString for intermediary result in PrepareNumberFormatter
Change-Id: I9435d926beb2fd7ebe350f61634673eed7228fbe
2012-11-03 20:24:25 -05:00
Norbert Thiebaud
de8d81b157 cosmetic clean-up
Change-Id: Ie9569fba8b03656b9a50e9add06c8e13d0026624
2012-11-03 20:24:25 -05:00
Noel Power
986a0f4eab fdo#54718 fix opcode detection in basic resulting in failed/unregcognized code
fix is followup to bf5b493104 which didn't adjust the runtime to
cater for the new enum layout

Change-Id: I6613fb8aacd8a70947c4fff556fb3e2d33c1113e
2012-09-10 11:15:22 +01:00
Takeshi Abe
969e6870e8 sal_Bool to bool
Change-Id: I86e5b49ccc9737517ecde17dbdaba44eeaee2371
2012-09-08 23:05:11 +09:00
Takeshi Abe
2efc59c9b6 sal_Bool to bool
Change-Id: I38141187c4f0809343a93c5765c0773d2321968a
2012-08-21 22:59:16 +09:00
Takeshi Abe
1817cf60d1 sal_Bool to bool
Change-Id: I61a6675df622232923a827fc20bf121dd03cd7da
2012-08-12 09:16:58 +09:00
Michael Stahl
6a94d7b5c9 basic, cui, extensions, filter, vcl: fix some warnings 2012-07-27 17:50:22 +02:00
Michael Meeks
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00