Commit Graph

343199 Commits

Author SHA1 Message Date
Jacobo Aragunde Pérez
007f260e0b ooxml: Preserve color transformations in shape style definitions
Color tags like <a:schemeClr> can have children tags that modify the
specified color. These modifications were applied on import time in
the Color object, but they were not preserved.

We added a member to Color object to preserve the unaltered list of
transformations. The method getTransformations() returns that member,
and the methods getColorTransformationName and
getColorTransformationToken were added to transform the tokens into
strings that can be added to an InteropGrabBag and viceversa.

The transformations are added to the Shape InteropGrabBag in the
method Shape::createAndInsert, and they are written back on export
time at DrawingML::WriteStyleProperties.

The data files for some /sd/qa/ unit tests were updated to reflect
the new properties inside the Shape InteropGrabBag.

Change-Id: Ieb164268c3b79f2d9b7ed3a4954b5de3b7a5811c
2014-01-28 11:00:37 +01:00
Miklos Vajna
f876c8a442 DOCX import: handle wp14:sizeRelV and wp14:pctHeight for Writer TextFrames
Change-Id: I1744cabf426af36483280df9ca5c09e7783fe210
2014-01-28 10:49:00 +01:00
Jacobo Aragunde Pérez
0583c889c3 sd/qa: Remove InteropGrabBag property from XML dumps
The InteropGrabBag property adds a lot of noise to this tests and it
doesn't actually have any purpose, because we are building their own
tests for InteropGrabBag-supported document attributes.

We have removed this property by default but we left a flag to enable
it when it's convenient for debugging.

Change-Id: I97cc7ba171783222a57ab5a96e5755070b949505
2014-01-28 10:36:11 +01:00
PriyankaGaikwad
d71d16958f fdo#73545 Shape position is wrong
Issue:
The <wp:align> is missing after roundtrip

XML Difference:
Original:
<wp:positionH relativeFrom="page">
 <wp:align>
 center
 </wp:align>
</wp:positionH>

Roundtrip:
<wp:positionH relativeFrom="page">
 <wp:posOffset>
 0
 </wp:posOffset>
</wp:positionH>

Conflicts:
	sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
	https://gerrit.libreoffice.org/7571

Change-Id: I3c8ef2f0ee3dd84a23fab197ab95f152b850067e
2014-01-28 09:47:52 +01:00
Sven Wehner
3fdbaaeebf fdo#39468 Translate German comments (sc/source/ui/pagedlg/tptable.cxx)
Also remove some ASCII art.

Change-Id: I8d440a05626c4db3ff63108a7e92ba54615ea24b
Reviewed-on: https://gerrit.libreoffice.org/7712
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-28 08:29:15 +00:00
Norbert Thiebaud
831c008880 Revert "Fix commit 4959f369d9bdcc"
This reverts commit d6d5f6803e.
2014-01-28 02:13:56 -06:00
Chris Sherlock
d6d5f6803e Fix commit 4959f369d9
Application::InitSettings should only assert when
pSVData->msAppData.mpSettings is already set. There is an errant not
symbol.

Change-Id: Id18848774f3f3a1b37969f057eaf8685231ad291
Reviewed-on: https://gerrit.libreoffice.org/7711
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-01-28 08:10:59 +00:00
Takeshi Abe
5b0fd61d69 Deleting NULL is safe
Change-Id: I673fd307d3f5f8c5c27b5dd6968775f81c0af8a0
2014-01-28 11:32:32 +09:00
Kohei Yoshida
3032d08226 fdo#74014: Broadcast cells on undoing of "cut".
Change-Id: I0fdf518078c86f259e72307f8011a988555a9235
2014-01-27 21:21:16 -05:00
Kohei Yoshida
fa11b0842a fdo#74014: Write unit test for this first.
Change-Id: I59fb04e2d7dc8148064564b900680e1b6e1b5e43
2014-01-27 21:21:10 -05:00
Kohei Yoshida
f571104ef3 fdo#69244: Avoid putting these cells in formula tree prematurely.
Marking the cell dirty alone appears to be sufficient to trigger resetting
of number format.  SetDirty() would mark it dirty *and* put the cell into
formula tree, which would prevent proper value propagation as seen in the
bug report.

Change-Id: Ie68f996112938fe286a9bd50c38404f9df6f4ca1
2014-01-27 19:11:55 -05:00
Kohei Yoshida
83f69e697a fdo#69244: Write unit test for this.
Change-Id: I5bfc8ad1566dbfc2813aadc8f08ba1eccca608ca
2014-01-27 19:11:55 -05:00
Katarina Behrens
c7b9d7d01f Converted Calc paste special dialog to .ui
Change-Id: Ibe782ed765a20adb34bb6ddd226c3d5ed328e810
2014-01-28 00:39:54 +01:00
Jan Holesovsky
cb64711136 Don't use OSL_LOG_PREFIX when throwing exceptions in non-debug builds.
Using OSL_LOG_PREFIX in the exceptions is not a good idea; it blows the size
of the string literals tremendously - full build path for every line that uses
that, including the line.

Let's not remove it for good, but hide it for non-debug builds
(OSL_DEBUG_LEVEL == 0) so that anybody who would like to use this during
debugging could still do (but I doubt it has any value for anybody).

Change-Id: Icc8db95ae0862671a206e681f92c60cdf51ffc32
2014-01-27 23:21:43 +01:00
Julien Nabet
c1503da35d Typo decendant => descendant in winaccessibility/MAccessible
Change-Id: I2e49ab149b2bbdad623f8694221b6169cdfd2d9a
2014-01-27 23:47:24 +01:00
Andras Timar
35782f89b6 fdo#74119 fix unlocalized redline menu
Change-Id: Ia4836a69ddd8bebe8cc21cea67be96b029388cb1
2014-01-27 22:30:11 +01:00
Jan Holesovsky
a0c2a6357c We want to read DOCX in TiledLibreOffice.
Change-Id: If1abbd654c407458a2a7947d6a2df07470417a38
2014-01-27 21:15:19 +01:00
Jan Holesovsky
3cf3700b7a fdo#74124: Scale the pictures before calling ImplDrawAlpha().
When the source and destination bitmap do not have the same size,
ImplDrawAlpha() does not use direct paint, but instead it gets the image from
the screen, blends it with the provided bitmap, and again draws it.

Unfortunately, the blending uses the most trivial (and ugly) way of scaling;
so to produce much better results, let's scale to the destination size before
even calling ImplDrawAlpha().

The sideeffect is that we use the direct paint in most cases now; so hopefully
it pays off to do the (a bit more expensive) scale first.

Change-Id: I3b6b275710220910709ae4345ad6be3d6e4bf79c
2014-01-27 20:17:01 +01:00
Kohei Yoshida
c0deb50f8f Handle note instances during copy-n-pasting of single cell.
Change-Id: Ib258556414fd94b5156b65777478a8fd37abfd9e
2014-01-27 14:47:04 -05:00
Miklos Vajna
1cfb281c2d remove script that parsed no longer available WRITERFILTERSTATUS comments
Change-Id: I137d2a9e4c0edda3e2509696ba4b0f5f4913bbc3
2014-01-27 20:19:15 +01:00
Miklos Vajna
4520e37785 filter: add sprmids header
This was generated previously in writerfilter, but keeping around an XML
file of 8000+ lines just to generate these constants is an overkill.

Additionally, these constants are hardwired in all available WW8 files,
so they won't change. By copying it here, it's possible to incrementally
remove what's still remaining from writerfilter's not used doctok.

Change-Id: I1d30da1f635946b15a37de68080fd9eebc2ad88e
2014-01-27 20:19:14 +01:00
Miklos Vajna
82d83af95a writerfilter: drop unused WW8TableHandler class
Change-Id: Ib74ac172088e7ad906fb3a28652948e2476a4cb2
2014-01-27 20:19:14 +01:00
Miklos Vajna
f9fef7e3ba writerfilter: drop unused WW8StreamHandler class
Change-Id: I79ea120223094f52996b52020fb86ddf9a919688
2014-01-27 20:19:13 +01:00
Miklos Vajna
44d08b67fe writerfilter: unused WW8PropertiesHandler class
Change-Id: Ie6a6d47241cdf0f4986aee9b2f30ecae55e6518c
2014-01-27 20:19:13 +01:00
Michael Meeks
7f2a2d2b05 fdo#73464 - get relation BSTR allocation right.
Change-Id: I270bc9c8e0507f44d2c27639e86002c60f4e2e6d
2014-01-27 18:01:05 +00:00
David Tardon
2dd8e2ce5c add test for structured content
Change-Id: I039e5ccfd6946f3f16505b6265e248fbead37a64
2014-01-27 18:14:05 +01:00
David Tardon
a6b0c67ee5 css::io::XInputStream _is_ allowed
Change-Id: Ib72c02a329bbc9a26390a16e115fd8ae94343263
2014-01-27 18:14:04 +01:00
Caolán McNamara
7e1f826822 coverity#704393 Logically dead code
Change-Id: Id46cdef80e3e8d4b56c22e8efc72aca885e0f406
2014-01-27 17:03:07 +00:00
Caolán McNamara
6e37a423fd coverity#1000521 Logically dead code
Change-Id: I9cf7d002de2bf8b33f17bd24403b8e77fe471a68
2014-01-27 17:03:07 +00:00
Caolán McNamara
df3c3ed1f0 coverity#738968 Unused pointer value
Change-Id: I0fabc525f5c052823946da93587ff1caaada9ab1
2014-01-27 17:03:07 +00:00
Caolán McNamara
06cfc634cd coverity#735559 Logically dead code
Change-Id: I75205d46243c18bbd63532aea1965a0e058ef739
2014-01-27 17:03:07 +00:00
Caolán McNamara
c9b41602a0 coverity#708315 Uninitialized scalar field
Change-Id: I1a93fcb6107bdce10b1f967337e75c525ab24640
2014-01-27 17:03:06 +00:00
Caolán McNamara
4a3c101276 coverity#708316 Uninitialized scalar field
Change-Id: I506ee57c59255494bbde91762da43c8b04b0f086
2014-01-27 17:03:06 +00:00
Caolán McNamara
463dbd42d1 coverity#440937 Logically dead code
Change-Id: If388006a7f53aee5ffe42a152ab917ca5aca2072
2014-01-27 17:03:06 +00:00
Caolán McNamara
d1c2f9849e coverity#707688 Uninitialized scalar field
Change-Id: If45153679e199eb749b8c877fc8593304ac35100
2014-01-27 17:03:06 +00:00
Caolán McNamara
6a3c12f303 coverity#707687 Uninitialized scalar field
Change-Id: I955a302418c56b6f34f89ff04b1e27c4d1b2722e
2014-01-27 17:03:05 +00:00
Caolán McNamara
3110ff212c coverity#707684 Uninitialized scalar field
Change-Id: I960aa77ce107c4f02f1e331cda07b75435beed5d
2014-01-27 17:03:05 +00:00
Caolán McNamara
e06b894af5 coverity#983618 Uncaught exception
Change-Id: I3abf410e7235b8dd1d126a3c8705e3ef9722e93b
2014-01-27 17:03:05 +00:00
Caolán McNamara
aece42b7b4 coverity#983617 Uncaught exception
Change-Id: I3f9c98d235d1bd5155653c6a56b757393bca2979
2014-01-27 17:03:05 +00:00
Caolán McNamara
773db5198e coverity#707681 Uninitialized scalar field
Change-Id: I88796c85447571d446c398439066029c3a200b4b
2014-01-27 17:03:04 +00:00
Caolán McNamara
8dec95f1d5 coverity#707680 Uninitialized scalar field
Change-Id: I763dc95a393bf296a7f3f5ce2a739f175fd528fb
2014-01-27 17:03:04 +00:00
Caolán McNamara
7cc3e9ca0c coverity#706277 Uncaught exception
Change-Id: I1941e0a3a662faaac1fb9374437f3984b3a5c6d8
2014-01-27 17:03:04 +00:00
Miklos Vajna
166af05c63 DOCX import: handle wp14:pctWidth for Writer TextFrames
Change-Id: I721a1ddd8299ff9639fd5fe4a25852e9418c00e2
2014-01-27 18:00:10 +01:00
Caolán McNamara
0535281003 coverity#707679 Uninitialized scalar field
Change-Id: I41c98456506a3ef843362b20c4db4a8d409319d6
2014-01-27 15:23:17 +00:00
Caolán McNamara
7677c52ae1 coverity#705787 Dereference before null check
Change-Id: I4d6e4ddaa104a025349c55ab75263004a6b2b6bf
2014-01-27 15:23:17 +00:00
Caolán McNamara
8bb41c67f0 coverity#1019407 Uninitialized scalar field
Change-Id: Icaa2062b00e0a68486bcbbc4a26b4089016bf2c8
2014-01-27 15:23:17 +00:00
Caolán McNamara
9f030d43ef coverity#1019406 Uninitialized scalar field
Change-Id: I9f5d48c5c5c0f76aa3386cfedcaf43ced162e4b0
2014-01-27 15:23:17 +00:00
Caolán McNamara
53c8030045 Resolves: fdo#74051 support 8430x11700 jpegs
Change-Id: I1ca95a496bca80e5e2787af2ccbf0f6cd42455a5
2014-01-27 15:23:16 +00:00
Jacobo Aragunde Pérez
5e2b865cf4 ooxml: fix import of custDash shape line attribute
A LineProperties object can contain some preset dash defined by the
shape style and some custom dash defined by the shape properties. In
that case, the custom dash must be used.

The existing code only used the custom dash if no preset dash was
present.

Change-Id: I6254d95184312360e8782dba7329d5ec2f5441fa
2014-01-27 15:52:14 +01:00
David Tardon
eb70c0993d fdo#73979 return 0 for unknown substreams
Change-Id: I8959891fc90544e2812651c0a2041f2760d90a83
2014-01-27 15:43:49 +01:00