Commit Graph

7326 Commits

Author SHA1 Message Date
Stephan Bergmann
ba15d30e8d loplugin:simplifybool
Change-Id: I4a7ba9192956941f05e68ae8df3263d609a7c4dc
2015-04-24 12:36:31 +02:00
Stephan Bergmann
2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs.
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
Thorsten Behrens
f3375fa07f Revert "-Werror,-Wunused-const-variable"
Actually used with follow-up commit
b94de8fa13

This reverts commit e24a02dc29.

Change-Id: I0f8226f756c7b3a813600351cc1be9bbbbcf67c2
2015-04-23 01:25:17 +02:00
Katarina Behrens
b94de8fa13 Related tdf#88056: Use correct service name
Now the page title field can finally be imported and displayed in
Impress \o/ It was a simple copy'n'pasta error, but damn, was it
hard to find ...

Change-Id: I04a3c71568960a66721269da3208208e168a99ac
2015-04-22 23:04:22 +02:00
Caolán McNamara
e24a02dc29 -Werror,-Wunused-const-variable
Change-Id: I2d150a8b387052e917f985907e2a7334682f1dc8
2015-04-22 15:47:33 +01:00
Katarina Behrens
57929ce5cc tdf#88056: Implement import of page title field from ODF
the field seems to get imported now, but still ain't displayed
in Impress *sigh*

Change-Id: I095b9a2c59145f984bc9db853cc22501ca103bb7
2015-04-22 15:21:38 +02:00
Caolán McNamara
bd75327c8b fix assert on export of ooo63141-1.doc to odt
if bAutoStyles is true then the mbDoSomething of the SvXMLElementExport is
false, and the ctor/dtor doesn't do anything so any attributes added to the
exporter are not cleared by the SvXMLElementExport dtor

so only add the attribute if bAutoStyles if false and might as well extend the
block to cover the use of SvXMLElementExport and use the other ctor which
defaults mbDoSomething on

Change-Id: If35cd35e902372562fd7e78b3f970d91fcec3c16
2015-04-22 14:17:02 +01:00
Michael Stahl
c13b80e202 tdf#90640: xmloff: ODF export: fix style:background-image attributes
... for Writer frames, which were missing the draw:opacity; turns out
this is because now the the default valued properties are not exported
any more, which causes them to be missing in the property array so the
hard-coded indexes in XMLTextExportPropertySetMapper::handleElementItem()
do not find them.

(regression from c3e49660e7)

Change-Id: I84b6c09b23a2275161135290f1b0ac9f52546a80
2015-04-21 15:43:14 +02:00
Katarina Behrens
d34f5fe5ef tdf88056: implement export of page title field to ODF
to loext namespace so far, since it isn't approved by ODF-TC yet

Change-Id: I1bb7723bdccec9b670630da5e4d56f47cd615e43
2015-04-21 11:52:26 +02:00
Tomaž Vajngerl
a88a8ca0d2 xmloff: cleanup StyleMap
Change-Id: I487ab62f412512b0437e6b46a01a3be7c88f5760
2015-04-18 11:39:30 +09:00
Markus Mohrhard
de4dd423b2 these two attributes are not part of ODF and unnecessary
Change-Id: I8eda0998f0bb9503cf7d6e89ace2fb1872273880
2015-04-18 00:33:06 +02:00
Markus Mohrhard
c172b75b8e add attribute mandated by ODF
Make sure that it does not confuse our importer by adding an attibute to
ignore it when the new elements have been added.

Change-Id: I15991be9dd993e2aeb18c440a14de3711f8001f4
2015-04-17 17:41:43 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Michael Stahl
ea8db4ad8e xmloff: add back the presumably accidentally removed "FootnoteLineStyle"
(regression from 7d9bb549d4)

Change-Id: I67ec4516ff431efd47451ff07fc261ba32e80385
2015-04-14 17:29:36 +02:00
Michael Stahl
e3efae3ebc xmloff: also print what is duplicate
Change-Id: I87b5122b8f1f4e26ba16ebc1228fb77f8b7800d9
2015-04-08 17:51:36 +02:00
Markus Mohrhard
6acc6c011d text:p is not allowed as child element of draw:frame
Regression from #i118485#.

Change-Id: Ib242ca1417f46b731d62d117132cbed6c02448fb
Reviewed-on: https://gerrit.libreoffice.org/15173
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-08 13:40:11 +00:00
Markus Mohrhard
204d1093d4 only try to export text:p for elements that really support it
Change-Id: Ie2c072c67ecaa0c0ec45c804ebbd4b3bcd631a13
Reviewed-on: https://gerrit.libreoffice.org/15172
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-08 13:39:50 +00:00
Markus Mohrhard
6864e3fc58 the attribute name is actually table:database-table-name
Change-Id: I9522529d918e143aafa6ea368fdb3fa55416d58b
Reviewed-on: https://gerrit.libreoffice.org/15176
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-08 13:38:49 +00:00
Michael Stahl
db1d278dcc tdf#89802: xmloff: fix ODF import of frame with empty style name ref
draw:fill-gradient-name="" in the graphic properties now causes
BaseFrameProperties_Impl::FillBaseProperties() to fail and prevent
insertion of the SwXTextFrame.

(regression from 6e61ecd096)

Change-Id: I9b4f3ddb0f0e1b3a80e86bbdc1af2dade1c8edf7
2015-04-07 22:55:26 +02:00
Noel Grandin
4906c24387 convert SvtModuleOptions::EFactory to enum class
and fix issues in iterating through o3tl::enumarray

Change-Id: Ia59ef9be44d8c92c2e406fa71aa92269578e26e3
2015-04-07 13:05:34 +02:00
Noel Grandin
d1b27a1d9a loplugin:staticmethods
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-07 10:24:54 +02:00
Stephan Bergmann
54e87df11f Change INetProtocol enumerators to CamelCase
...to avoid clashes with macros and poor warnings about hiding global FILE

Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
Stephan Bergmann
44b3e56bb4 Change INetProtocol to scoped enumeration
...and fix o3tl::enumarray::operator [] const overload

Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
Laurent Balland-Poirier
15d00363bb Engineering notation: Slight optimisation
Update of commit Ia18f9e150ca32aa9bbe133c082c3f9330e949f11

Change-Id: I5118619f2ab669f90e0377d9cabdba4778179581
Reviewed-on: https://gerrit.libreoffice.org/15100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-04-01 13:27:00 +00:00
Stephan Bergmann
2fc4a8c811 Add support for cppu::UnoType<void>
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-04-01 12:48:44 +02:00
Stephan Bergmann
a0c46d2f20 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: Ic3764caeeb2cdec397071706845bf8517c848917
2015-04-01 08:43:33 +02:00
Stephan Bergmann
c0755c8ee0 Reduce to static_cast any reinterpret_cast from void pointers
Change-Id: Ie25a2b8a84a146a5b988c6ef77127896d126e488
2015-03-31 13:17:54 +02:00
Stephan Bergmann
a52cf476e7 Clean up template-parameter-dependent C-style casts
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
2015-03-29 15:13:45 +02:00
Stephan Bergmann
0bd502af47 Clean up remaining C-style casts among void pointers
Change-Id: I1b49c020d597b569e330482f4dbf20c15ccdae3f
2015-03-29 09:17:47 +02:00
Stephan Bergmann
44b9b27b1a Clean up C-style casts from pointers to void
Change-Id: I962bd44f2ef6204ed2ea51f79b752bd948f67209
2015-03-28 19:09:29 +01:00
Stephan Bergmann
f701cce539 const_cast: convert some C-style casts and remove some redundant ones
Change-Id: Ib054b36c87c87ae2189b5456bc9b12d7b76c49e7
2015-03-26 15:33:41 +01:00
Markus Mohrhard
849c1b64de also import and export to ODF the new databar property
Change-Id: Ib29a0d5c9fefe15fbd0f08a5cf9600eff58cd030
2015-03-24 16:01:58 +01:00
Noel Grandin
4d4022fef2 loplugin:constantfunction: xmloff
Change-Id: I0ddcaada71eaa53cd7e6320c6ccaa8d8971f6df0
2015-03-24 10:31:17 +02:00
Julien Nabet
41c99ab630 Typos
Change-Id: Ie08a26a569b83bfe3ef4351dbb7b6e928745b95d
2015-03-23 20:08:36 +01:00
Eike Rathke
7b7f5c70c6 use ODFSaneDefaultVersion to determine if and how to store exponent-interval
Change-Id: I58d4c75806d656cb3f8bf971efecba6f775e05a9
2015-03-22 19:29:41 +00:00
Eike Rathke
de6f165132 introduce SvXMLExport::getSaneDefaultVersion()
Change-Id: I1b73b4850e78f4ec0823894b93b8bc1cbadf0d0d
2015-03-22 19:29:40 +00:00
Eike Rathke
48b1d2b120 use SvXMLExport::getDefaultVersion()
... instead of SvtSaveOptions().GetODFDefaultVersion()

Change-Id: Ib94fa3edc395f6ef39f3be33c5cdf4f4e2da32b4
2015-03-22 17:53:41 +00:00
Eike Rathke
ee7e182591 write exponent-interval only for 1.2+ and later, tdf#30716 follow-up
... and prepare for distinguishing between 1.2+ and 1.3

Change-Id: I8d491be4b0ff5f65fc1506145f460f07e8371a73
2015-03-22 16:52:47 +00:00
Eike Rathke
bff1b48899 read both, XML_NAMESPACE_LO_EXT and XML_NAMESPACE_NUMBER, tdf#30716 follow-up
Change-Id: I3058c3249e7ae1f43c8e21972adf0fa7826d21a9
2015-03-22 15:48:30 +00:00
Laurent Balland-Poirier
fdf8e5aaee tdf#30716 start Engineering notation: implement exponent-interval
ODF1.3 implement a new attribute for engineering notation
https://issues.oasis-open.org/browse/OFFICE-1828
This commit only add this attribute to ODF import/export.
Engineering notation is not yet available.

Treat also thousand separator with exponent-interval
Change XML_NAMESPACE_NUMBER to XML_NAMESPACE_LO_EXT for
exponent-interval

Change-Id: Ia18f9e150ca32aa9bbe133c082c3f9330e949f11
Reviewed-on: https://gerrit.libreoffice.org/14875
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-03-22 15:44:55 +00:00
Zolnai Tamás
f880962f5b Char highlight: ODT filters
Export merges the two background attribute.

Change-Id: I882321fbd5a7d24991fb01b8dc9d2cc0bd294051
2015-03-21 16:19:08 +01:00
Julien Nabet
61a3ace9f4 Related tdf#50133: Wrong underlining in Reports
By running some tests, I noticed double wave didn't appear when opening report in non edit mode.
First you must know that to indicate "double wave", xml contains these 2 information:
style:text-underline-style="wave" style:text-underline-type="double"

The problem is the reading order of the parser doesn't seem the same each time.
So if it reads style then type, it's ok thanks to this part:
    132             case awt::FontUnderline::DOUBLE:
    133                 // A double line style has priority over a bold line style,
    134                 // but not over the line style itself.
    135                 switch( eUnderline )
    136                 {
    137                 case awt::FontUnderline::SINGLE:
    138                 case awt::FontUnderline::BOLD:
    139                     break;
    140                 case awt::FontUnderline::WAVE:
    141                 case awt::FontUnderline::BOLDWAVE:
    142                     eNewUnderline = awt::FontUnderline::DOUBLEWAVE;
    143                     break;

but if the parser read type in the first place then style, the case FontUnderline "DOUBLEWAVE" wasn't managed

Change-Id: Ie090507898e537827eebaae157dfac248baa43f1
Reviewed-on: https://gerrit.libreoffice.org/14801
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-19 13:08:18 +00:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Julien Nabet
84ec8274fa Typo: elemet->element
Change-Id: I204c49239faf3574b72530ba1118defb1ae31ff3
2015-03-13 19:53:39 +01:00
Michael Stahl
0777231112 V803 decreased performance postfix increment
These are pretty silly anyway, but apparently it complains even about
integer variables which make this rather a waste of time.

Change-Id: I15e847d33d5decd2adcab04e4f1567d3997d28a2
2015-03-13 16:23:26 +01:00
Deena Francis
7b355da685 Enhancement tdf#87972 : Cannot repeat items labels on a pivot table
Change-Id: I44b2521ea548b51a1b3e9b42cfa64c5f50d7798a
Reviewed-on: https://gerrit.libreoffice.org/14504
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2015-03-12 01:18:06 +00:00
Caolán McNamara
556373c41f V668 no sense in testing the result of new against null
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
Caolán McNamara
5a308b1239 V801: Decreased performance
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
Julien Nabet
27bc6714df tdf#50133: Wrong underlining in Reports
Change-Id: Ia1d37d150c2186f014733cd87179445722b54346
Reviewed-on: https://gerrit.libreoffice.org/14789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-03-08 02:45:07 +00:00
Caolán McNamara
32f95a3551 V813: Decreased performance
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-04 13:07:40 +00:00