Stephan Bergmann
9f23260105
SvStream: WriteUChar -> WriteBool
...
Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
2015-04-17 15:20:43 +02:00
Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Noel Grandin
ee094bd46f
loplugin:staticmethods
...
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-04-13 09:37:12 +02:00
Arnaud Versini
4e0d2fcdda
BASIC: Merge BasicLibs with BasicManagerImpl and use boost::ptr_vector.
...
Change-Id: I36fc3ce26b129b11fc2d6d2829a146b3fa57b783
Reviewed-on: https://gerrit.libreoffice.org/15267
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-04-13 06:19:23 +00:00
Stephan Bergmann
9222f5d065
A UNO Any can't contain an Any
...
...and css::uno::makeAny<css::uno::Any>() was never meant to be used. Introduce
css::uno::toAny for the (template-code) cases that shall return an Any for both
Any and non-Any inputs.
Change-Id: Ifa977d73f1da71b2fedde7e8140b19497c4a0257
2015-04-08 17:45:08 +02:00
Stephan Bergmann
5ba54aacd5
Remove dead INetProtocol::Vim
...
...which removes the need to abstract over the standard URI '%' escape prefix
vs. the silly vim '=' special case invention.
Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
2015-04-07 20:21:21 +02:00
Stephan Bergmann
54e87df11f
Change INetProtocol enumerators to CamelCase
...
...to avoid clashes with macros and poor warnings about hiding global FILE
Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
Stephan Bergmann
44b3e56bb4
Change INetProtocol to scoped enumeration
...
...and fix o3tl::enumarray::operator [] const overload
Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
Stephan Bergmann
2fc4a8c811
Add support for cppu::UnoType<void>
...
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-04-01 12:48:44 +02:00
Stephan Bergmann
4f2a236da4
Replace remaining getCppuType et al with cppu::UnoType
...
Change-Id: I69cac41fd3db1e99ecb55e23ac81c67046f81cb4
2015-04-01 08:35:28 +02:00
Stephan Bergmann
a52cf476e7
Clean up template-parameter-dependent C-style casts
...
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
2015-03-29 15:13:45 +02:00
Stephan Bergmann
0bd502af47
Clean up remaining C-style casts among void pointers
...
Change-Id: I1b49c020d597b569e330482f4dbf20c15ccdae3f
2015-03-29 09:17:47 +02:00
Stephan Bergmann
c3fb36ed26
Clean up C-style casts from pointers to void
...
Change-Id: I6dd7c7fbaf0d4b22abba0a7b1f5e37f0a46d0747
2015-03-28 19:09:17 +01:00
Stephan Bergmann
0511c86791
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: If774a3b4e2e993d26dd9b5777a55665a330b2abe
2015-03-26 15:33:28 +01:00
Julien Nabet
b33788cb6b
Typos
...
Change-Id: I665a56fcad10e136e949a10497f6ab8813af9968
2015-03-25 21:19:59 +01:00
Arnaud Versini
8414d8434b
Basic: scanner should'nt use 0xFF mask on characters
...
Change-Id: I2fd3f70c3d8e411430f84c7383da7ab8700513bd
Reviewed-on: https://gerrit.libreoffice.org/14682
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org >
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2015-03-25 13:41:25 +00:00
Noel Grandin
b2d2d72a7e
loplugin:constantfunction: basic
...
Change-Id: I1c9a33cefb68bec978b2a922c2c3ef00f2a7a1b4
2015-03-24 10:31:17 +02:00
Stephan Bergmann
d1c9e5ee53
tdf#43157: Fix format string violations in OSL_TRACE etc.
...
...for a 32-bit build, similar to what ee11e221d2
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build
Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-13 18:21:36 +01:00
Michaël Lefèvre
c3cd100556
CppCheck cleanlyness : reduce variable's scope
...
Change-Id: I5bd18b1a93f7197121eb42f6b82d2d8d87e7671f
Reviewed-on: https://gerrit.libreoffice.org/14843
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-03-12 22:28:38 +00:00
Caolán McNamara
556373c41f
V668 no sense in testing the result of new against null
...
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
Caolán McNamara
34d6ec2c6e
cppcheck: variableScope
...
Change-Id: Ie77a988956927475ea384c36664ca7c3dd00b2a7
2015-03-09 16:27:47 +00:00
Caolán McNamara
5a308b1239
V801: Decreased performance
...
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
Julien Nabet
5f6fcb4e7c
Typos
...
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
2015-03-08 16:45:30 +01:00
LeMoyne Castle
3b585737ff
convert error number to string
...
BASIC error type was printing as "Error "+ odd char
instead of "Error " + error number
Change-Id: I7407833626d6117f932cc29c6dab1a8a64c50b5a
Reviewed-on: https://gerrit.libreoffice.org/14776
Reviewed-by: Tor Lillqvist <tml@collabora.com >
Tested-by: Tor Lillqvist <tml@collabora.com >
2015-03-07 05:57:20 +00:00
Caolán McNamara
32f95a3551
V813: Decreased performance
...
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-04 13:07:40 +00:00
Tor Lillqvist
6c7291141c
WaE: implicit conversion from bool to 'int'
...
Change-Id: I40782009fb8d73f827c82c298586a7d4542561c9
2015-03-02 09:39:55 +02:00
Noel Grandin
e9beb26470
convert SBI_ constants to enum class
...
Change-Id: I65e706f4e1adfe242808293d9514c9db8d22cc12
2015-03-02 08:59:18 +02:00
David Tardon
04814fcc3b
likely intent
...
Change-Id: I2372ddec8e82eb99206661469843d7837d2bf6d1
2015-03-01 17:33:58 +01:00
Stephan Bergmann
164276a0d2
Clean up previous commit
...
Change-Id: Iddade9d297be8f4a4e69b3bec5ab7588bf68c112
2015-02-26 15:34:57 +01:00
Chris Sherlock
a45a5501cc
basic: convert sb.component to constructor usage
...
Change-Id: I45ddf460fa7d673c5210f9415b2a8015988a643e
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2015-02-26 15:05:23 +01:00
Noel Grandin
2f928b2d09
remove NUMBERFORMAT_ constants
...
.. in favour of just using the underlying constants from
css::util::NumberFormat
Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-02-25 10:34:27 +02:00
Noel Grandin
9473ba2469
fix marking of free slots in array
...
Change-Id: I5170b9bbc4a3acab8307f7ad5ebc5e4ba9d58352
2015-02-24 10:36:51 +02:00
Stephan Bergmann
3b513aefa4
tdf#86543: reinterpret_cast -1 of appropriate width as special marker
...
Change-Id: Idf0d2a77a78e0e8fcbf435984b9b8f4393e4c207
2015-02-23 13:13:39 +01:00
Radu Ioan
a8e6f0bea0
tdf#39440 - cppcheck cleanliness
...
Fixed some cppcheck defects
Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb
Reviewed-on: https://gerrit.libreoffice.org/14487
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-02-17 06:15:54 +00:00
Caolán McNamara
a1ceacc17e
boost::foo_ptr->std::foo_ptr
...
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16 12:54:44 +00:00
Arnaud Versini
78f25d565e
Basic : Partially rewrite hex and octal constant reading.
...
Change-Id: I42f72e7b1ca897aba71950841f90b501cf3b6dc2
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2015-02-09 13:18:31 +01:00
Arnaud Versini
96520ae764
Basic : Small OString usage simplification
...
Change-Id: I6d6032b3075e98abb38859207e4a25e1a2e13e98
Reviewed-on: https://gerrit.libreoffice.org/14351
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-02-08 06:54:45 +00:00
Stephan Bergmann
d93bcf7790
loplugin:deletedspecial
...
Change-Id: Iabc7b3fe295743db014e0bce78f9dc65e069d848
2015-02-07 12:35:56 +01:00
Stephan Bergmann
0f86834bd5
Remove redundant explicit up-casts
...
Change-Id: I58fd91354fe41673216674f5ae9c11c17cb3f29d
2015-02-05 12:47:23 +01:00
Juan Picca
6e1d28efb3
fdo#39440: replace C-style cast's
...
* Add get() method to tools::SvRef
Change-Id: I3825852176c9c37f3ee21f4fd57328b1c7451951
Reviewed-on: https://gerrit.libreoffice.org/14268
Tested-by: Michael Stahl <mstahl@redhat.com >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-02-05 07:24:30 +00:00
Caolán McNamara
d41b8ac9e5
callcatcher: shave off a few more
...
Change-Id: Ie48cf7f89c8c826e56409c2493e1e1250086f10a
2015-02-02 21:07:54 +00:00
Arnaud Versini
4b9a9ce8a0
Use rtl/character.hxx in basic module when possible
...
Change-Id: I1296541ac1a6a65a613818a1264c2b7482915e64
Reviewed-on: https://gerrit.libreoffice.org/14170
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org >
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2015-01-31 09:48:27 +00:00
Caolán McNamara
bf7b702814
coverity#1267698 Uninitialized scalar field
...
Change-Id: I79974d276a8f7f856dbf09b14b06ce3b1bb418f0
2015-01-30 20:52:52 +00:00
Caolán McNamara
309574394b
callcatcher: large newly detected unused methods post de-virtualization
...
i.e lots now able to be detected after...
commit b44cbb26ef
Author: Noel Grandin <noel@peralex.com >
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29 23:42:26 +00:00
Michael Stahl
a4faad707c
tdf#76174: basic: lock SolarMutex in BasicScriptListener_Impl
...
... before calling into BASIC.
Change-Id: I51a59fe5ca9b15ff7ec509c052964523d87a9790
2015-01-29 21:48:12 +01:00
Noel Grandin
fe480d8136
remove unused typedefs
...
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-01-28 06:19:49 +00:00
Eike Rathke
cd528c3099
implement css::i18n::XCalendar4 and LocaleCalendar2 service, tdf#63230
...
Implementation only, new local date/time routines not used yet from the
outside in this step.
2015-01-26 18:12:10 +01:00
Noel Grandin
b44cbb26ef
new loplugin: change virtual methods to non-virtual
...
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Caolán McNamara
818c2021d1
coverity#1266457 Identical code for different branches
...
Change-Id: I809ad43ad4541e4dcd5c245b469d30605f9f0d27
2015-01-25 20:46:39 +00:00
Tor Lillqvist
b5938bf4b3
WaE: rewrite call of rtl::OUString::operator= ...
...
... with empty string constant argument as call of rtl::OUString::clear
[loplugin:stringconstant].
Actually, no need to clear the string here as it already is empty, surely?
Change-Id: Ib4b1a6e1b0c0f59c1c964fe58d26058b492c3821
2015-01-24 08:10:50 +02:00