mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
372,268 Commits 1 Branch 0 Tags
c110559268461dd3b7b8e28d24e36fdbcc25bb17
Commit Graph

452 Commits

Author SHA1 Message Date
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Noel Grandin
ee094bd46f loplugin:staticmethods 
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
 2015-04-13 09:37:12 +02:00
Stephan Bergmann
0511c86791 const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: If774a3b4e2e993d26dd9b5777a55665a330b2abe
 2015-03-26 15:33:28 +01:00
Caolán McNamara
5a308b1239 V801: Decreased performance 
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
 2015-03-09 12:41:09 +00:00
Caolán McNamara
32f95a3551 V813: Decreased performance 
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
 2015-03-04 13:07:40 +00:00
Noel Grandin
e9beb26470 convert SBI_ constants to enum class 
Change-Id: I65e706f4e1adfe242808293d9514c9db8d22cc12
 2015-03-02 08:59:18 +02:00
Stephan Bergmann
164276a0d2 Clean up previous commit 
Change-Id: Iddade9d297be8f4a4e69b3bec5ab7588bf68c112
 2015-02-26 15:34:57 +01:00
Chris Sherlock
a45a5501cc basic: convert sb.component to constructor usage 
Change-Id: I45ddf460fa7d673c5210f9415b2a8015988a643e
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2015-02-26 15:05:23 +01:00
Stephan Bergmann
d93bcf7790 loplugin:deletedspecial 
Change-Id: Iabc7b3fe295743db014e0bce78f9dc65e069d848
 2015-02-07 12:35:56 +01:00
Arnaud Versini
4b9a9ce8a0 Use rtl/character.hxx in basic module when possible 
Change-Id: I1296541ac1a6a65a613818a1264c2b7482915e64
Reviewed-on: https://gerrit.libreoffice.org/14170
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-01-31 09:48:27 +00:00
Noel Grandin
fe480d8136 remove unused typedefs 
found with some minor modifications to find/find-unused-defines.sh

Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-01-28 06:19:49 +00:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load 
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
 2015-01-09 00:00:47 +01:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants. 
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
 2015-01-08 10:39:36 +02:00
Noel Grandin
7f8f277b94 fdo#84938: convert STREAM_ #defines to 'enum class' 
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
 2015-01-07 11:20:44 +02:00
Caolán McNamara
7f476fea47 boost::unordered_map -> c++11 std::unordered_map 
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
 2014-12-27 23:00:45 +00:00
Stephan Bergmann
179810cdf2 Further clean-up 
Change-Id: I20049b482c831e4ac2221fddfe80deb9847e72c3
 2014-12-03 20:30:18 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin
fbf3aa391b spelling: instanciated -> instantiated 
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
 2014-10-08 11:02:55 +02:00
Caolán McNamara
d438c470d7 coverity#1231668 Unchecked return value 
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
 2014-08-17 16:39:21 +01:00
Takeshi Abe
50725318e4 Drop an unused function 
Change-Id: I59eb46f9d57e9fd72ed86c972685be93d154e3c7
 2014-07-18 23:24:58 +09:00
Takeshi Abe
fffc9b2f26 fdo#75757: remove inheritance to std::vector 
... which was introduced at 2110397670.

Change-Id: If0f634b29e1891574267edf8cc07b24d07a9406c
Reviewed-on: https://gerrit.libreoffice.org/10363
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2014-07-17 21:29:50 +00:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined 
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
 2014-07-11 14:12:25 +02:00
Caolán McNamara
c80be30203 coverity#706241 Uncaught exception 
we've already checked to see if the element exists, so
we know that its not there.

Change-Id: I538c0d48a883d478e4c748d222b21958d083c049
 2014-07-03 08:29:41 +01:00
Stephan Bergmann
e48a233960 loplugin:unreffun: also warn about redundant redeclarations 
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
 2014-06-27 15:27:39 +02:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Stephan Bergmann
a77a7f6083 Fix memory leak 
...by using css::uno::Type instead of a naked typelib_TypeDescription.

Change-Id: I387692265e9e032cb5ed6519739ebb3307db6f28
 2014-05-28 14:34:12 +02:00
Michael Stahl
5246fa2624 fdo#68983: basic: if the library is not loaded fully, copy source storage 
Also fixes fdo#42899 and fdo#67685 in a different way; the previous fix
for fdo#42899 caused the problem with password-protected libraries for
which the password is not known: only the binary representation of the
BAISC module was stored, not the source code; by simply copying from the
source storage the problem can be avoided.

It would be possible to ask for the password when storing, but that
would not work when non-interactive (called via API).

An alternative fix would be to pass in the
SfxObjectShell::IsSetModifyEnabled() flag and actually reset the BASIC
library's modify flag correctly, but that requires adding a
parameter to XStorageBasedLibraryContainer::storeLibrariesToStorage().

(regression from af34774d26 )

Change-Id: I4701401f35171139fc2fe8d225d13d4e533091a0
 2014-05-22 13:12:55 +02:00
Thomas Arnhold
b4285a90d8 fixincludeguards.sh: basic 2014-04-19 11:10:08 +02:00
Stephan Bergmann
cc725643fd Clean up function declarations and some unused functions 
Change-Id: I63c4c61847fea4500b667a5ea9f2b32207692033
 2014-04-09 10:12:02 +02:00
Noel Grandin
1eee88dd6b basic: sal_Bool->bool 
Change-Id: I1c084ca86c0b1308eb2fc1451ba34d2e702c6a7f
 2014-04-07 13:53:50 +02:00
Stephan Bergmann
8f6c55a839 Replace SV_DECL/IMPL_REF macros with SvRef template 
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
 2014-04-07 12:38:27 +02:00
Caolán McNamara
675194c83d coverity#706238 Uncaught exception 
Change-Id: I10bd34115be12dc752987ddbe5d93862aa072e72
 2014-04-04 09:35:19 +01:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Stephan Bergmann
0015c9807f Remove unused BASIC CaptureAssertions functionality 
...that had originally been introduced to catch DBG_ASSERTs during smoketest,
but since made effectively unused when basing DBG_ASSERT on the sal/log.hxx
functionality, and obsoleted by the ongoing clean-up of using true assert where
appliable.

Change-Id: I2fb4f5d0873d29595b178057f83c1404c0085575
 2014-03-31 11:23:24 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Noel Grandin
f288d7dcbd basic: sal_Bool->bool 
Change-Id: Id4952b6f97f9e8f917fea5651dee91499d109e48
 2014-03-27 13:45:08 +02:00
Noel Grandin
d7c5d9e385 basic: sal_Bool->bool 
Change-Id: Idfe18863b2c6f60da5192d661f66e85a2bac09e5
 2014-03-27 13:45:08 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann
5fb78604c1 Split TYPEINFO into plain and TYPEINFO_OVERRIDE 
...where the latter contains SAL_OVERRIDE annotations

Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
 2014-03-26 11:54:55 +01:00
Noel Grandin
39c7532933 basic: prefer passing OUString and OString by reference 
Change-Id: I8121204cdb37d4e1d8967397f3e45bdab6aaddad
 2014-03-13 08:39:26 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
6a38eace8c Remove visual noise from basic 
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-25 21:09:17 +00:00
Alexandre Vicenzi
25d089e09d fdo#63154 Removed unused solar.h ref. in basic, cui, forms and writerfilter. 
Change-Id: I09cca73d8d77af259965e74e1b29a88aa5c315ab
Reviewed-on: https://gerrit.libreoffice.org/7731
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-30 10:48:40 +00:00
Caolán McNamara
81926e66d1 coverity#707650 Uninitialized pointer field 
Change-Id: I6843ce28f3e1395a2ab3c5515f393cce5096674b
 2014-01-27 14:38:38 +00:00
Herbert Dürr
9e77ddcd19 Resolves: #i123817# prepare codebase for updating to boost 1.55 
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)

Conflicts:
	basic/source/comp/parser.cxx
	basic/source/comp/token.cxx
	dbaccess/source/ui/dlg/generalpage.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	vcl/quartz/salbmp.cxx

Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
 2014-01-06 16:32:20 +00:00
Norbert Thiebaud
8b308d510e basic: include <> for external includes 
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
 2013-11-11 22:37:24 -06:00
Thomas Arnhold
4adf622925 fixincludeguards.sh: basic 
Change-Id: Id797a8969e42876092da347d8e1bba6195b697dc
 2013-10-28 15:16:20 +01:00
Thomas Arnhold
8fc6905674 fdo#68849 add some header guards 
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f
Reviewed-on: https://gerrit.libreoffice.org/6364
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-10-21 09:15:59 +00:00