mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
372,268 Commits 1 Branch 0 Tags
c110559268461dd3b7b8e28d24e36fdbcc25bb17
Commit Graph

94 Commits

Author SHA1 Message Date
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Caolán McNamara
5a308b1239 V801: Decreased performance 
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
 2015-03-09 12:41:09 +00:00
Caolán McNamara
32f95a3551 V813: Decreased performance 
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
 2015-03-04 13:07:40 +00:00
Stephan Bergmann
164276a0d2 Clean up previous commit 
Change-Id: Iddade9d297be8f4a4e69b3bec5ab7588bf68c112
 2015-02-26 15:34:57 +01:00
Chris Sherlock
a45a5501cc basic: convert sb.component to constructor usage 
Change-Id: I45ddf460fa7d673c5210f9415b2a8015988a643e
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2015-02-26 15:05:23 +01:00
Stephan Bergmann
39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00
Takeshi Abe
6a53ea218c Avoid possible memory leaks in case of exceptions 
Change-Id: Iad3de981a1c9660b1322315640e531c9891db0bf
 2014-05-31 00:35:27 +09:00
Michael Stahl
5246fa2624 fdo#68983: basic: if the library is not loaded fully, copy source storage 
Also fixes fdo#42899 and fdo#67685 in a different way; the previous fix
for fdo#42899 caused the problem with password-protected libraries for
which the password is not known: only the binary representation of the
BAISC module was stored, not the source code; by simply copying from the
source storage the problem can be avoided.

It would be possible to ask for the password when storing, but that
would not work when non-interactive (called via API).

An alternative fix would be to pass in the
SfxObjectShell::IsSetModifyEnabled() flag and actually reset the BASIC
library's modify flag correctly, but that requires adding a
parameter to XStorageBasedLibraryContainer::storeLibrariesToStorage().

(regression from af34774d26 )

Change-Id: I4701401f35171139fc2fe8d225d13d4e533091a0
 2014-05-22 13:12:55 +02:00
Julien Nabet
5ec7a589be Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8 
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
 2014-05-10 06:19:42 +02:00
Stephan Bergmann
cc725643fd Clean up function declarations and some unused functions 
Change-Id: I63c4c61847fea4500b667a5ea9f2b32207692033
 2014-04-09 10:12:02 +02:00
Noel Grandin
1eee88dd6b basic: sal_Bool->bool 
Change-Id: I1c084ca86c0b1308eb2fc1451ba34d2e702c6a7f
 2014-04-07 13:53:50 +02:00
Valentin Kettner
061130bd6d fdo#75280 Started cleaning up of sal_uIntPtr usage. 
Converted wrong usage of sal_uIntPtr to appropriate other types in basic
module.

The bug is not fully fixed with this since many other occurences of sal_uIntPtr remain.

Update due to code review comments:
Fixed forgetting to change some declarations in iosys.cxx.
Cleaned up the one remaining sal_uIntPtr in iosys.cxx
Fixed adding a sal_uInt64 to a Date (uses long now instead) in methods.cxx
Fixed the VarDecFromUI4 call in sbxdec.cxx from sal_uLong to ULONG .

Conflicts:
	basic/source/runtime/iosys.cxx

Change-Id: Ia6460be04967deb68b92eb62d945da8814fae605
 2014-03-28 20:08:46 +01:00
Noel Grandin
f288d7dcbd basic: sal_Bool->bool 
Change-Id: Id4952b6f97f9e8f917fea5651dee91499d109e48
 2014-03-27 13:45:08 +02:00
Noel Grandin
d7c5d9e385 basic: sal_Bool->bool 
Change-Id: Idfe18863b2c6f60da5192d661f66e85a2bac09e5
 2014-03-27 13:45:08 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
6a38eace8c Remove visual noise from basic 
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-25 21:09:17 +00:00
Norbert Thiebaud
295bc8703f basic: remove use of sal_uIntptr in favor of more appropriate type 
Change-Id: Ie878f43c7245838519fe7477b039827b079dde63
Reviewed-on: https://gerrit.libreoffice.org/8214
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-02-25 00:26:43 +00:00
Andras Timar
ac6e8ac7e4 typo fixes in comments 
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
 2014-02-06 23:22:30 +01:00
Julien Nabet
527eb5ae5c Typo: applictaion -> application 
Change-Id: I2d578cb417bb1e814dcf3007f500fe8ff77510f7
 2014-02-06 21:51:36 +01:00
Stephan Bergmann
f96f38f8f8 bool improvements 
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
 2014-01-28 20:26:30 +01:00
Norbert Thiebaud
8b308d510e basic: include <> for external includes 
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
 2013-11-11 22:37:24 -06:00
Noel Grandin
e9c4ee996d remove unnecessary use of OUString constructor in BASIC module 
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
 2013-11-11 11:21:25 +02:00
Stephan Bergmann
f58ee783ee Improve ErrorCodeIOException messages 
...and clean up some includes.

Change-Id: Ia5843cd38f967722d7173a6c87fba26064e3ffd6
 2013-10-09 21:02:11 +02:00
Takeshi Abe
d57010faf1 sal_Bool to bool 
Change-Id: Ie8e35c4342db6e2dc35fca33cee7b4d71cfcb732
 2013-10-07 17:08:18 +09:00
Caolán McNamara
ed0f0fa730 XubString->OUString 
Change-Id: I5424a148c7173409e6e56f9483fcc769696707bc
 2013-09-02 12:22:34 +01:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Noel Grandin
dcbaf7c253 remove unused componentcontext.hxx includes 
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
 2013-06-05 08:13:21 +02:00
Noel Grandin
4460f213df fdo#46808, use XComponentContext in SfxLibraryContainer 
Change-Id: I6f66fc69a40e2cd2ef2372e0413ff95b6202c5c5
 2013-05-14 08:08:27 +02:00
Noel Grandin
67042f1f03 fdo#46808, replace XMultiServiceFactory with XComponentContext is SfxLibrary 
Change-Id: I150d86b4ae4004e7c39ec6a3ed7fba31029f8ab1
 2013-05-14 08:08:26 +02:00
Luboš Luňák
9c06700874 fix build 
Change-Id: I2588b69280abbc510ee2fdc9845df56616db8b95
 2013-01-03 19:06:15 +01:00
Marcos Paulo de Souza
695f4a18e6 fdo#57950: Fix some chained appends in basic 
Change-Id: Icac8ec992d993748a063aa95cc6f58c24fa87444
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1515
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
 2013-01-03 17:07:41 +00:00
Marcos Paulo de Souza
c40cd8a4f2 Remove all occurences of RTL_* and ::rtl prefix from basic 
This is a big commit, so thanks for your time reviewing this :)

Conflicts:
	basic/source/sbx/sbxscan.cxx

Change-Id: Ib9bc710b87475b5695764557321e5dcef25e5933
Signed-off-by: Miklos Vajna <vmiklos@suse.cz>
 2013-01-03 10:07:39 +01:00
Noel Grandin
5837402fb1 fdo#46808, use service constructor for ucb::SimpleFileAccess 
I upgraded the service to return XSimpleFileAccess3, since it
already implemented that interface, and it's backwards
compatible.

Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
 2012-11-15 08:28:44 +01:00
Norbert Thiebaud
27239ad230 basic: String -> OUString 
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
 2012-11-07 02:14:53 -06:00
Norbert Thiebaud
d92814f462 basic: preliminary cosmetic clean-up 
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
 2012-11-03 20:24:28 -05:00
Norbert Thiebaud
bbf1bcd9ad basic: String -> OUString in basicmanager 
Change-Id: I6607bfe8b6bf4d29ffd01cd88a19af5e53d616b5
 2012-11-03 20:24:26 -05:00
Noel Grandin
fb741b5e1e fdo#46808, Adapt xml::sax::XWriter UNO service to new style 
Create a merged XWriter interface for the service.
The xml.sax.Writer service already existed, it just did not have
an IDL file.

Change-Id: I4e6d3f3c68f9282a55fc7aa19778f97632fd8ad5
 2012-10-22 17:01:11 +02:00
Noel Grandin
a20f9a410f fdo#46808, Adapt xml::sax::XParser UNO service to new style 
The xml.sax.Parser service already existed, it just did not have
a new-style service to create it.

Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
 2012-10-04 16:29:53 +02:00
Arnaud Versini
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h 
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2012-10-01 18:48:05 +00:00
Takeshi Abe
2efc59c9b6 sal_Bool to bool 
Change-Id: I38141187c4f0809343a93c5765c0773d2321968a
 2012-08-21 22:59:16 +09:00
Takeshi Abe
38f3fe0432 sal_Bool to bool 
Change-Id: I6206ee7e17e12388ea644123e180842df3e3a7ee
 2012-08-19 17:55:27 +09:00
Michael Meeks
63c508e3e8 re-base on ALv2 code. Includes: 
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
 2012-07-18 09:29:19 +01:00
Caolán McNamara
2c757293b8 reduce static_initialization_and_destruction chain 
Change-Id: I0c1b2f2d908c31d1510662880c13504d81445a6a
 2012-06-25 14:19:03 +01:00
Caolán McNamara
c3f2401d49 reduce scope and replace some String::CreateFromAscii 
Change-Id: I8c375e3bfbcd3d7046a8bdb1968934b7d7ca96f8
 2012-06-21 15:07:52 +01:00
Noel Grandin
d08578912f fdo#46808, Adapt UNO services to new style, Part 7, updating ::create 
Update calls to factories to use new SimpleFileAccess::create method

Change-Id: Ie5b0696fe2228a9033b19969245a53c21a61aa14
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, added some tweaks.
 2012-06-06 10:01:22 +02:00
Norbert Thiebaud
aca9239724 targeted string re-work 
Change-Id: Ia651a93951da514105183775a5f49d031a192937
 2012-06-02 17:57:17 -05:00
Szabolcs Dezsi
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
Olivier Hallot
9201704ede Fix for fdo43460 Part IV getLength to isEmpty 
Part IV
Module
basic (small fix per demand from Ivan Timofeev)
binaryurp
bridges
 2011-12-13 00:11:25 +04:00
Olivier Hallot
91d4fe75ee Fix for fdo43460 Part III getLength to isEmpty 
Part III
Module
basic
 2011-12-10 21:13:58 +04:00
Takeshi Abe
3c795a953f removed dead code 2011-11-29 10:07:04 +09:00