mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
372,268 Commits 1 Branch 0 Tags
c110559268461dd3b7b8e28d24e36fdbcc25bb17
Commit Graph

52 Commits

Author SHA1 Message Date
Noel Grandin
0339e648a8 loplugin:constantfunction: chart2 
Change-Id: I2ec1eaf9faa23779fbdf53771dbba1936c6aa3f9
 2015-03-23 09:42:23 +02:00
Noel Grandin
cb414252b8 loplugin: cstylecast 
Change-Id: I4aafc170895d8bab47206c7b07b4f1f6105d42d3
 2014-10-23 12:36:14 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Stephan Bergmann
ea733ab5b6 Turn SfxItemState into a C++11 scoped enumeration 
...to gain further confidence in the claim "that none of the existing
code tries to uses combinations of these enum values"
(d92602c5b1 "more fixes for SfxItemState")

Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13
Reviewed-on: https://gerrit.libreoffice.org/11384
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2014-09-12 06:08:32 +00:00
Noel Grandin
d92602c5b1 more fixes for SfxItemState 
In commit 88a874fc "convert SfxItemState constants to a proper enum"
I made some mistakes in converting bitwise logic to boolean logic.

I fixed one of those places in commit 7ad83656 "fix bitwise->logic
conversion in SfxItemState commit"

This commit fixes the other places where I converted bitwise to normal
boolean logic. I also validated that none of the existing code tries to
uses combinations of these enum values.

This commit also introduces an exception-throwing check in the one place
where the enum is explicitly cast to make sure that no combinations
sneak in.

Change-Id: I545f7d17b76c4fd999078867caec314e83ffe165
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-09-10 17:54:35 +02:00
Noel Grandin
7ad8365648 fix bitwise->logic conversion in SfxItemState commit 
88a874fc "convert SfxItemState constants to a proper enum"

Change-Id: I979d5a859f0bbfd8797bfc5ba4ce5497eb777fe7
 2014-09-09 13:31:17 +02:00
Stephan Bergmann
f9857727c6 EE_PARA_WRITINGDIR should presumably use an SvxFrameDirectionItem 
...rather than an SfxInt32Item, just as it does everywhere else outside chart2.
At least, running CppunitTest_chart2_export under -fsanitize=undefined
complained about an invalid cast to SvxFrameDirectionItem.

Change-Id: Ia7ea43a00d659de9642f801f390f45b9239d9c32
 2014-08-28 15:53:13 +02:00
Thomas Arnhold
8f2990517f directly include ResourceIds.hrc header 
Change-Id: Iaef6876ac2838f8727fea21c03a4cdc50683e675
 2014-08-09 18:12:06 +02:00
Noel Grandin
88a874fcb3 convert SfxItemState constants to a proper enum 
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants

Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
 2014-07-23 13:26:19 +02:00
Markus Mohrhard
3575dba98d remove whitespaces 
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
 2014-07-02 23:03:07 +02:00
Stephan Bergmann
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer 
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
 2014-06-11 14:39:04 +02:00
Stephan Bergmann
a92e973b6d Change SfxTabPage::Reset param from ref to pointer 
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)

Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
 2014-06-11 10:39:03 +02:00
Stephan Bergmann
4dbeadb9c1 Change SfxTabPage::FillItemSet param from ref to pointer 
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)

Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
 2014-06-10 17:25:23 +02:00
Thomas Arnhold
97a5ba4a71 remove comments why a file gets included 
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
 2014-04-21 18:08:28 +02:00
Noel Grandin
329332ba52 chart2: sal_Bool->bool 
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
 2014-04-15 15:23:29 +02:00
Noel Grandin
34002c4e5c sfx2: sal_Bool->bool 
Change-Id: I1fd02cc148fd9a54d2092dad1e548f51a0813a14
 2014-03-27 13:45:09 +02:00
Stephan Bergmann
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState 
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
 2014-02-24 12:27:32 +01:00
Stephan Bergmann
e8f8f24c84 vcl: sal_Bool -> bool 
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
 2014-02-21 12:53:51 +01:00
Stephan Bergmann
12f1faf7bf svl: sal_Bool -> bool 
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
 2014-02-20 08:17:00 +01:00
Stephan Bergmann
d5d2e280bd bool improvements 
Change-Id: I4fb554a0b703b29cb2dc70fc11111a4f2fa9af8e
 2014-01-28 20:26:30 +01:00
Thomas Arnhold
54a17dd246 windows: warning 4355 is disabled globally in com_MSC_defs.mk 
So there is no need to do this locally, too.

Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
 2013-10-28 01:02:13 +01:00
Manal Alhassoun
07aade88b0 tp_axisLabel.ui widgets 
Change-Id: I279d2989e6a3a8f0aa279c5aa8eb13251a6052da
Reviewed-on: https://gerrit.libreoffice.org/5801
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-09-04 08:56:47 +00:00
Jelle van der Waa
dd9c97d587 fdo#62475 removed pointless comments 
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
 2013-07-29 11:34:33 +00:00
Julien Nabet
3e49d72847 Some cppcheck cleaning in chart2/ 
Change-Id: I1f8fcdd78029344c735cd4364c8b081d692e2f4e
 2012-12-15 18:28:02 +01:00
Michael Meeks
63c508e3e8 re-base on ALv2 code. Includes: 
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
 2012-07-18 09:29:19 +01:00
Stephan Bergmann
bd205223ec New IMPL_LINK_NOARG to work around SAL_UNUSED_PARAMETER problem 
...see ebe26f72e9 "WaE: 'unused' attribute ignored when parsing type"
for the problem.
 2012-03-01 18:00:32 +01:00
Norbert Thiebaud
6da8379e14 remove include of pch header in chart2 2011-11-27 12:59:19 -06:00
Kohei Yoshida
12343c1556 Merge commit 'ooo/DEV300_m101' into integration/dev300_m101 2011-03-10 20:21:13 -05:00
Carsten Driesner
24684974fe removetooltypes01: Fix build problems after rebase to DEV300m99 in basctl, cui, reportdesign, sw 2011-02-08 11:05:35 +01:00
Mikhail Voytenko
981b1b3d5a removetooltypes01: #i112600# adjust rebase in chart2, starmath, sc, sd 2011-02-07 18:01:48 +01:00
Carsten Driesner
e1d7ba2932 removetooltypes01: Rebase to DEV300m99 2011-02-07 13:06:08 +01:00
Ingrid Halama [iha]
770837b8b4 chart46: merge with dev300m98 2011-01-28 17:43:26 +01:00
Carsten Driesner
d672102cc7 removetooltypes01: Rebase to DEV300m98 2011-01-21 17:18:37 +01:00
Mikhail Voytenko
3d6a5a98cd removetooltypes01: #i112600# remove tooltypes from chart2 2011-01-14 15:18:08 +01:00
Ingrid Halama [iha]
edaa216847 chart46: #i25706# implement date axis 2010-11-30 01:45:03 +01:00
Thomas Benisch
b9fd0c3f31 chartextensibility: #i115276# improve layout of hierarchical axis labels in chart 2010-11-05 13:25:12 +01:00
Sebastian Spaeth
63bb42ab7d Add vim/emacs modelines to all source files 
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
 2010-10-13 10:57:18 +02:00
Vladimir Glazunov
22e99ad710 CWS-TOOLING: integrate CWS changefileheader2 2010-02-17 10:32:35 +01:00
Jens-Heiner Rechtien
4573ccfffd changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Mathias Bauer
bf5462ddf6 #i107450#: build all other modules with new editeng lib 2010-01-08 18:32:51 +01:00
Mathias Bauer
a293d0a7b1 #i103496#: split svtools; improve ConfitItems 2009-10-16 00:05:16 +02:00
Vladimir Glazounov
811e7a83cb CWS-TOOLING: integrate CWS rtlchart01 2008-11-26 15:19:48 +00:00
Rüdiger Timm
ca11276334 INTEGRATION: CWS changefileheader (1.9.94); FILE MERGED 
2008/04/01 15:04:03 thb 1.9.94.2: #i85898# Stripping all external header guards
2008/03/28 16:43:30 rt 1.9.94.1: #i87441# Change license header to LPGL v3.
 2008-04-10 19:14:09 +00:00
Rüdiger Timm
78677c20c8 INTEGRATION: CWS chart07 (1.8.12); FILE MERGED 
2007/07/10 11:57:29 bm 1.8.12.1: #i69281# warnings removed
 2007-07-25 07:37:32 +00:00
Vladimir Glazounov
d417fbbf07 INTEGRATION: CWS chart2mst3 (1.2.4); FILE MERGED 
2007/05/14 20:03:10 bm 1.2.4.7: RESYNC: (1.6-1.7); FILE MERGED
2006/10/18 17:04:28 bm 1.2.4.6: RESYNC: (1.5-1.6); FILE MERGED
2006/02/20 14:45:45 iha 1.2.4.5: move SchItemPool from controller to view lib -> ChartItemPool
2005/10/07 11:18:15 bm 1.2.4.4: RESYNC: (1.4-1.5); FILE MERGED
2004/08/30 22:35:30 bm 1.2.4.3: RESYNC: (1.2-1.4); FILE MERGED
2004/06/01 18:54:07 iha 1.2.4.2: no warnings
2004/03/04 12:25:25 iha 1.2.4.1: cleanup
 2007-05-22 16:43:33 +00:00
Kurt Zenker
9847fb6984 INTEGRATION: CWS pchfix04 (1.6.22); FILE MERGED 
2007/02/05 08:38:58 os 1.6.22.1: #i73604# usage of ITEMID_* removed
 2007-05-10 15:32:05 +00:00
Oliver Bolte
ff68d1cd69 INTEGRATION: CWS pchfix02 (1.5.80); FILE MERGED 
2006/09/01 17:18:35 kaib 1.5.80.1: #i68856# Added header markers and pch files
 2006-09-17 11:58:36 +00:00
Rüdiger Timm
3a6a45ea57 INTEGRATION: CWS ooo19126 (1.4.58); FILE MERGED 
2005/09/05 18:42:25 rt 1.4.58.1: #i54170# Change license header: remove SISSL
 2005-09-07 23:13:39 +00:00
Rüdiger Timm
de77a60aff INTEGRATION: CWS sch03 (1.3.2); FILE MERGED 
2004/08/18 09:33:43 dr 1.3.2.2: #i32576# missing item set handling
2004/08/17 09:15:46 dr 1.3.2.1: #i32576# new svx controls added in CWS dr14
 2004-08-20 07:46:38 +00:00
Daniel Rentz
83af2e60e3 #i10000# changes from CWS dr14 2004-08-04 13:33:25 +00:00