Commit Graph

51 Commits

Author SHA1 Message Date
Noel Grandin
fcaad6576d fix shadow error
introduced by my commit 216fdcbdb4
"convert RECALCMODE_ constants to scoped enum"

Change-Id: Ie7db053741205faeac70e3d21757774567f43ce0
2015-04-08 11:40:16 +02:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Caolán McNamara
567f511924 V801: Decreased performance
Change-Id: I97c7977fdfea57b5d1c45ce0c5902b74cc719db9
2015-03-06 17:08:55 +00:00
Caolán McNamara
c622304965 V813: Decreased performance
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-03-04 00:51:57 +00:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Noel Grandin
8044acf2db convert SFX_CALLMODE constants to SfxCallMode enum class
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident

Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:52 +00:00
Noel Grandin
71540e1e47 cid#1244949 Uncaught exception
Change-Id: Ic33d60a435ee875e8e342420046aae436739c123
2014-10-10 10:14:17 +02:00
Stephan Bergmann
0b23ac2c9d vbahelper: std::auto_ptr -> std::unique_ptr
Change-Id: Ic1b28e7f79cc7dad6a045eb64e5191991533990d
2014-09-29 18:37:51 +02:00
Stephan Bergmann
40036fc228 scripting: sal_Bool -> bool
Change-Id: I3b2d410dfdd9bc779e7f1f1674fb6fc8b74a42c2
2014-09-15 15:41:18 +02:00
Stephan Bergmann
9deb4ff124 Mark template member fns that are supposed to override as SAL_OVERRIDE
Change-Id: I712f352635a2e258bfaf60dc30ed764666a51f15
2014-09-15 13:56:02 +02:00
Stephan Bergmann
a8c8f92d3d Mark template member fns that are supposed to override as SAL_OVERRIDE
Change-Id: Ifb5798a9f01961dd916857a0dca44a3fd8587ec4
2014-09-15 12:13:47 +02:00
Caolán McNamara
c1dd91a93c callcatcher: update unused code
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-22 09:54:38 +01:00
Caolán McNamara
7f55c89470 some other coverity foo
Change-Id: Ide5a10d7f9c45970c3cc5c78213c151c85ff4570
2014-07-18 15:36:20 +01:00
Caolán McNamara
e0ec561059 coverity#707480 Uncaught exception
Change-Id: I27732316c42face6750ffb7eccc238f66519e4e6
2014-07-10 13:39:18 +01:00
Caolán McNamara
92fe8838f7 coverity#707382 Uncaught exception
and

coverity#707383 Uncaught exception
coverity#707384 Uncaught exception
coverity#707385 Uncaught exception
coverity#707386 Uncaught exception
coverity#707387 Uncaught exception
coverity#707388 Uncaught exception
coverity#707389 Uncaught exception
coverity#707390 Uncaught exception
coverity#707391 Uncaught exception
coverity#707409 Uncaught exception
coverity#707411 Uncaught exception
coverity#707413 Uncaught exception
coverity#707414 Uncaught exception
coverity#706919 Uncaught exception
coverity#706920 Uncaught exception
coverity#706933 Uncaught exception
coverity#706935 Uncaught exception
coverity#706968 Uncaught exception
coverity#706970 Uncaught exception
coverity#706973 Uncaught exception
coverity#706974 Uncaught exception
coverity#707032 Uncaught exception
coverity#707044 Uncaught exception
coverity#738455 Uncaught exception
coverity#738456 Uncaught exception

Change-Id: Ifd4c0a2b6b4ddcb5df01a951b8d56435ee32d754
2014-07-09 09:59:02 +01:00
Caolán McNamara
6fb1f934d7 coverity#707193 Uncaught exception
Change-Id: Ie3e6bc593365311bfe80972b26d1189acbb6afcb
2014-07-03 12:49:39 +01:00
Thomas Arnhold
c2034f3993 fixincludeguards: fix include guards
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06 19:16:40 +00:00
Noel Grandin
adc20c3937 compareToAscii -> equalsAscii
convert places using compareToAscii that should be using equalsAscii

Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
2014-06-04 11:52:31 +02:00
Caolán McNamara
09188ebfc4 coverity#706959 Uncaught exception
Change-Id: I6b18bd2df7ef190b39ceacd625bf2b62a53892fa
2014-06-02 17:00:00 +01:00
Noel Grandin
9116edcfa7 cid#706953 Uncaught exception
Change-Id: I4c46e98a8382ac39786ffb6607bd3ecdb57b3914
2014-05-28 10:00:54 +02:00
Noel Grandin
437a1f3925 cid#707192 Uncaught exception
Change-Id: Ibf6f8a4a405d089eb8bbdcf46269f2f78b2222a9
2014-05-27 10:50:03 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Thomas Arnhold
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
Caolán McNamara
833067c870 coverity#707469 Uncaught exception
Change-Id: I93bb55b339dcc6a177d7403760703a895cebc805
2014-04-24 17:16:36 +01:00
Caolán McNamara
d8fa21bd11 hmm, need a rethink on these exceptions
Change-Id: I0d91e142d719b946f65ed704b06371d00534ad78
2014-04-24 13:26:57 +01:00
Caolán McNamara
cf058da1e5 coverity#707475 Uncaught exception
Change-Id: I4c9da1bb21e55578fc81e4c5b3133cbd639711cc
2014-04-24 11:10:00 +01:00
Caolán McNamara
6b260f17e9 coverity#707476 Uncaught exception
Change-Id: I667867d0333d9d82db3218e2645741a2327cd8fe
2014-04-24 11:10:00 +01:00
Caolán McNamara
4d225d3e7f coverity#707477 Uncaught exception
Change-Id: Ie91515b0cd0fcf5a1b3bc7b2d394927dafa851ea
2014-04-24 11:10:00 +01:00
Caolán McNamara
b6804259c5 coverity#707478 Uncaught exception
Change-Id: Ib967053b7d306d18c69843da39646d69540f081f
2014-04-24 11:10:00 +01:00
Caolán McNamara
cc44da64b1 coverity#707479 Uncaught exception
Change-Id: I4a1c43dab2814ed66f1785b91ead76407e32de46
2014-04-24 11:09:59 +01:00
Thomas Arnhold
2346c010ea fix mac build
Change-Id: I3f29b389543d23bb230964d81ed9a6a946a4414d
2014-04-14 12:45:51 +02:00
Thomas Arnhold
60c8df4326 remove static strings 2014-04-14 12:31:55 +02:00
Caolán McNamara
7969655b95 coverity#707406 Uncaught exception
Change-Id: I5fc9d24390d0a90f89c3e71e87bf37ddd9c2fe67
2014-04-05 20:53:15 +01:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
Noel Grandin
ba73873ea7 vbahelper: sal_Bool->bool
Change-Id: Ic4bcc2fa02426e1995d08a6992cc5b35777c1c9a
2014-04-03 09:17:51 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
Noel Grandin
fddde2b74a xmloff,vbahelper: prefer passing OUString and OString by reference
Change-Id: I8b7e4284c122549c03edaa7f3963cbfb2024b3fc
2014-03-13 15:05:31 +02:00
Alexander Wilms
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Stephan Bergmann
3ca9c83610 bool improvements
Change-Id: I1a88cdb87767d029868b855eac09c016e1bca82e
2014-01-22 08:22:34 +01:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
Norbert Thiebaud
65d9783d8b fdo#65108 inter-module includes <> include/vbahelper
Change-Id: I3f18707dae67118fd20036e7c9cb4e98bf8ef642
2013-11-09 18:48:46 -06:00
Thomas Arnhold
1130a359cb fixincludeguards.sh: include - the rest
Change-Id: If1ee11da444a7f96f2d8668b277540da0bb4dbe9
2013-10-23 23:22:31 +02:00
Noel Grandin
9f4c18e64c convert remains of String to vbahelper module to OUString
Change-Id: Ibbecdd1c28ba078e1031ec6185beaff05b6d8b6e
2013-10-01 10:08:44 +02:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
Noel Power
b2d1526203 Parse workbook name correctly, don't fall over spaces etc.
Change-Id: I26213e4202ea2f2d15014ca722ab7878aa09cbf1
2013-05-09 14:11:20 +01:00
Noel Power
a7cc0faeff support Shape.Alternative
Change-Id: I6d822ef0d06e222f454c1279be16e33bcaae0037
2013-05-09 14:11:19 +01:00
Noel Power
04eb03cc0b handle various ReturnXXXX types for forms
Change-Id: Idcbfbebafb02c734b42428c5b1d6df8d0d4a23d6
2013-05-09 14:11:14 +01:00