Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
David Tardon
8840fd3226
tdf#82695 allow to build with system collada2gltf
...
Change-Id: I1179e20fd5fbdecd198633d5440621ed08a0465b
2015-04-13 16:43:35 +02:00
Noel Grandin
ee094bd46f
loplugin:staticmethods
...
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-04-13 09:37:12 +02:00
Julien Nabet
65c3f29a96
Typo: wheter->whether
...
Change-Id: Iab5e7de499452924b4ac0d34cc604ee38395c813
2015-04-01 21:14:43 +02:00
Stephan Bergmann
1140d4c950
Reduce to static_cast any reinterpret_cast from void pointers
...
Change-Id: I443d86e9805dd994006d8bde6dabd72e14a2cff5
2015-03-31 13:16:31 +02:00
Stephan Bergmann
9e53fbd9a6
loplugin:cstylecast
...
Change-Id: I8bb20f4ce9c8cca3b70057cd8c4fb23819fa3b23
2015-03-29 22:26:59 +02:00
Stephan Bergmann
84676d50ca
Clean up C-style casts from pointers to void
...
Change-Id: Iaae87d77ea48207c3277e7107b339296f6a99772
2015-03-28 19:09:25 +01:00
Pedro Giffuni
09f83e1f40
Small fix for BSD.
...
Part of Code Review:
https://reviews.freebsd.org/D2055
Author: Don Lewis (truckman at FreeBSD)
(cherry picked from commit ecebe457c968bfd30a99a435210b0bdbb117faef)
2015-03-27 15:42:01 +00:00
Stephan Bergmann
b549220522
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: I84b3843b32bbec6dfe5a9c627927b04122d50abd
2015-03-26 15:33:36 +01:00
Julien Nabet
25d3c618d8
Typo: formated->formatted
...
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
2015-03-25 21:12:16 +01:00
Phillip Sz
3f6bfb4c0d
remove exit 0 at the end of a shell script
...
Change-Id: I6f9b6aa7abba6eadf4db93506bdd9a822afdf2fb
Reviewed-on: https://gerrit.libreoffice.org/14884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-03-25 06:50:53 +00:00
Stephan Bergmann
c6dcd7b7f3
Fix various Windows-only XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ibc5bb0575f3869317e4d14614cf1dad0af728ddc
2015-03-24 18:08:39 +01:00
Stephan Bergmann
3099c70b11
Fix various XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Caolán McNamara
6617505ee1
V512: we want the number of wide-chars here, not the number of bytes
...
Change-Id: I121cdfd586562b9ce298448f51d0b2e3b2a52c39
2015-03-11 17:14:13 +00:00
Caolán McNamara
3aebfbc299
leak on short read
...
Change-Id: I5da7ec2992f9f0b20aa075ee33d0b882cdf91901
2015-03-11 14:08:36 +00:00
Caolán McNamara
556373c41f
V668 no sense in testing the result of new against null
...
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
Caolán McNamara
d22519f62b
V801: Decreased performance
...
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-09 22:04:31 +00:00
Michael Stahl
19bfe765a5
shell: warning C4996 function call with parameters that may be unsafe
...
Change-Id: Id70289b0c88dd203cac6301303fe7452088f60f9
2015-03-05 15:36:48 +01:00
Caolán McNamara
32f95a3551
V813: Decreased performance
...
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-04 13:07:40 +00:00
Markus Mohrhard
ff8b9c4e59
unnecessary wstring -> char* -> wstring conversion
...
Change-Id: I21e6036a5156ed62f2c7bff6439c64d0178c96e4
2015-03-01 18:58:43 +01:00
Noel Grandin
ba233e87ef
remove unnecessary parenthesis in return statements
...
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
Jan-Marek Glogowski
f7db246129
Add kde4-open-url script
...
Adds a KDE4 specific URL processing script.
Change-Id: I0116fa95f076a5772e88c616e93de542fe4fe4e4
2015-02-16 21:30:32 +01:00
Stephan Bergmann
fe5644984a
loplugin:deletedspecial
...
Change-Id: I2a3d9deb9c71bb4dfe3ad9076d7202636001e0bb
2015-02-07 12:36:02 +01:00
Aron Budea
7ce1e0e1ec
fdo#43368 Remove MapiLogon/Logoff calls so simplemail works with WLM
...
Signed-off-by: Michael Stahl <mstahl@redhat.com >
Conflicts:
shell/source/win32/simplemail/senddoc.cxx
Change-Id: I31cac063ffb4afbfde068558ebcf5f66ea34d1a8
2015-02-07 00:54:19 +01:00
Noel Grandin
fe480d8136
remove unused typedefs
...
found with some minor modifications to find/find-unused-defines.sh
Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-01-28 06:19:49 +00:00
Michael Stahl
ba68436e3f
Win SDK 8.1: apparently VersionHelpers.h needs to be included explicitly
...
http://ci.libreoffice.org/job/lo_gerrit_master/495/Gerrit=Gerrit,Platform=Windows/console
Change-Id: I0104d448906bd17857b3716856c544e632c1662c
2015-01-23 14:04:24 +01:00
Stephan Bergmann
dcfb17b805
Some more loplugin:cstylecast: shell
...
Change-Id: I8d9846dcfd8b0f686f7321a3e7b7b0d70428723d
2015-01-20 09:06:51 +01:00
Michael Stahl
4500afcc1b
try to fix GetVersionEx deprecation warnings from Windows SDK 8.1
...
Apparently GetVersionEx() is deprecated now, but the replacement header
"versionhelpers.h" does not exist in older SDKs (at least not in 8.0),
so try to determine the used SDK version by checking if the Windows 8.1
version constant _WIN32_WINNT_WINBLUE (0x0602) exists.
http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972%28v=vs.85%29.aspx
Change-Id: Ia9224a8c76823ada7cb294a600046c6a0fc843ad
Reviewed-on: https://gerrit.libreoffice.org/14020
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-01-19 20:31:38 +00:00
Noel Grandin
54942f0d09
spelling: attachement -> attachment
...
Change-Id: I1bb1ad04adec864b594d96711f85b8fcdc1d1ef2
2015-01-05 12:57:18 +02:00
Michael Weghorn
ea644f0e90
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5
Reviewed-on: https://gerrit.libreoffice.org/13608
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-23 05:53:41 +00:00
Stephan Bergmann
7f09f384b2
shell: Use appropriate OUString functions on string constants
...
Change-Id: I3b2c0a4200fa953162f40eff49289052962e73d2
2014-12-18 14:12:32 +01:00
Stephan Bergmann
4888f82557
shell: Use appropriate OUString functions on string constants
...
Change-Id: I2647295383085abf8f217693531ef82632eb4c52
2014-12-15 10:17:33 +01:00
Michael Stahl
15b4ab8d19
cppuhelper: clean up public headers with include-what-you-use
...
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Caolán McNamara
357f9d22a0
give all the open-url scripts the same starting permissions
...
Change-Id: I35fcb2d73accf20baa96b62d99be6d0a3ebb3ba2
2014-11-17 14:53:23 +00:00
Caolán McNamara
20dab428f8
drop gnome-open-url binary
...
we don't really need it anymore, fallback to our own open-url
if there is nothing else to take it
Change-Id: I7a4e841a53bda30e29d48b9c34d24af085f1b4b5
Related: coverity#706194 Use of untrusted string value
2014-11-17 14:53:22 +00:00
Michael Stahl
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Andrea Gelmini
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
Richard PALO
88a40e70fe
O_RDWR and O_CREAT are defined in fcntl.h
...
Change-Id: I568ee2c3f103777720f6c39340a5915b10aeebb4
Signed-off-by: Michael Stahl <mstahl@redhat.com >
2014-11-11 19:44:57 +01:00
Markus Mohrhard
89c47e4a3d
that stuff seems to be totally unused
...
Change-Id: Ice7bc99fc5f3d26ced1b7cd5a1dbf29b0e635471
2014-11-10 07:58:34 +01:00
Stephan Bergmann
fc0d57b7af
Revert "use the new OUString::fromUtf8 method"
...
This reverts commit 05050cdb23
,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23
use the new OUString::fromUtf8 method
...
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
Andrea Gelmini
c70f1545e2
Removed duplicated includes
...
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-10-31 16:18:30 +00:00
Noel Grandin
0371a63365
remove unnecessary 'using namespace rtl' declarations
...
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-29 11:28:54 +00:00
Eike Rathke
04a810cee4
back out more wrong and confusing tools::Time comment changes
...
Apparently fc04f76336
used some sed script
to change all ...
Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-08 14:24:21 +02:00
Stephan Bergmann
36d24bced0
shell (Windows): std::auto_ptr -> std::unique_ptr
...
Change-Id: I44c843c028c2dfcfcea9f6a2196440ca700fc3a8
2014-10-02 15:20:54 +02:00
Stephan Bergmann
5b401a06a6
shell: std::auto_ptr -> std::unique_ptr
...
Change-Id: I6fc7ef7438e1b999b3b65e4e661b9e787a66cf47
2014-10-01 17:35:09 +02:00
Noel Grandin
fc04f76336
fdo#82577: Handle Time
...
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-01 07:34:23 +00:00
Andras Timar
ae4c836b49
bnc#887307 ODF files not showing up on Windows search
...
Under Windows 7, ODF and OpenOffice.org 1.1 files were not found,
when the folder containing them was not indexed, and full text
search was switched on. The problem did not occur under Windows 8.
Apparently there is a bug in Windows 7, reading beyond the end of a
BufferStream resulted in 0 bytes read. So we take care not to read
beyond the end of stream.
Change-Id: Id01b08922121dabbb7b49c54f8ef11cb0e4ac413
2014-09-18 00:57:21 +02:00
Stephan Bergmann
8405ee507e
shell: sal_Bool -> bool
...
Change-Id: Ie4fedd95752aa1212481bff0cda7c0045956b361
2014-09-11 16:34:50 +02:00
Julien Nabet
037d03b9fa
Typo: (N|n)ormaly->(N|n)ormally
...
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-10 22:35:39 +02:00