mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
372,268 Commits 1 Branch 0 Tags
c110559268461dd3b7b8e28d24e36fdbcc25bb17
Commit Graph

332 Commits

Author SHA1 Message Date
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
9e53fbd9a6 loplugin:cstylecast 
Change-Id: I8bb20f4ce9c8cca3b70057cd8c4fb23819fa3b23
 2015-03-29 22:26:59 +02:00
Stephan Bergmann
84676d50ca Clean up C-style casts from pointers to void 
Change-Id: Iaae87d77ea48207c3277e7107b339296f6a99772
 2015-03-28 19:09:25 +01:00
Stephan Bergmann
dcfb17b805 Some more loplugin:cstylecast: shell 
Change-Id: I8d9846dcfd8b0f686f7321a3e7b7b0d70428723d
 2015-01-20 09:06:51 +01:00
Michael Weghorn
ea644f0e90 fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5
Reviewed-on: https://gerrit.libreoffice.org/13608
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-23 05:53:41 +00:00
Stephan Bergmann
7f09f384b2 shell: Use appropriate OUString functions on string constants 
Change-Id: I3b2c0a4200fa953162f40eff49289052962e73d2
 2014-12-18 14:12:32 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Markus Mohrhard
89c47e4a3d that stuff seems to be totally unused 
Change-Id: Ice7bc99fc5f3d26ced1b7cd5a1dbf29b0e635471
 2014-11-10 07:58:34 +01:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method" 
This reverts commit 05050cdb23,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
 2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method 
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
 2014-11-06 13:51:10 +02:00
Andrea Gelmini
c70f1545e2 Removed duplicated includes 
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-10-31 16:18:30 +00:00
Stephan Bergmann
8405ee507e shell: sal_Bool -> bool 
Change-Id: Ie4fedd95752aa1212481bff0cda7c0045956b361
 2014-09-11 16:34:50 +02:00
Noel Grandin
f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception 
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
 2014-05-29 09:01:40 +02:00
Thomas Arnhold
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left 
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-15 12:50:46 +00:00
Noel Grandin
177d32b6b8 shell: sal_Bool->bool 
Change-Id: I4313819fa40885a3cfa4a137888ae457d8d839a8
 2014-04-30 08:43:41 +02:00
Stephan Bergmann
6a3b0b7cc4 Explicitly mark overriding destructors as "virtual," Mac OS X redux 
Change-Id: Ib7ab02bc3cdadbdfe0e0787560d1dd562eb85be9
 2014-04-01 21:30:38 +02:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Stephan Bergmann
5eb733cf67 loplugin:saloverride 
Change-Id: I028d6da250bad64cca2d85c8bbf4a3b5a1300f1b
 2014-03-30 21:55:17 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann
72ef2d526b std::exception retrofit sequel 
Change-Id: I7461c320e98b9a3605db26f4d58200789e1477df
 2014-02-27 08:39:31 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Maxim Monastirsky
e44a7eefb7 KDE: don't throw on TemplatePathVariable 
This is required after commit
838b77f5f3.

Actual functionality is still missing.

Change-Id: Ib94d8a982609de730d9c61bf7bf9886093c51f5b
Reviewed-on: https://gerrit.libreoffice.org/8367
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 09:09:40 -06:00
Alexander Wilms
d18a2753d5 Remove visual noise from shell 
Change-Id: I1857fd7a9aeda38cb8ef2a0eda7783203b7658ed
Reviewed-on: https://gerrit.libreoffice.org/8311
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 07:55:24 -06:00
Caolán McNamara
838b77f5f3 Resolves: rhbz#1065807 use xdg ~/Templates for default Template location 
(if it exists)

Change-Id: I98fc9fd54d1f56c8bed24ce4d2ebf53756ded2cc
 2014-02-25 10:45:27 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Stephan Bergmann
a83b2af9ab Clean-up uno/lbnames.h 
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
 2013-12-16 21:43:12 +01:00
Noel Grandin
73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM 
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
 2013-11-22 08:07:19 +02:00
Thomas Arnhold
f01580ce9c Windows: Require at least Windows XP SP2 
* Windows XP SP2 is 0x0502, see
  http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
  this is done module wide now. So the overall behavior
  is as before. This seems to be the best compromise for
  now.
* We need at least SP2 because of the bluetooth stuff
  used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
  has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
  project specific precompiled header files.
* All local definitions of WINVER are removed, because
  the global WINVER setting makes them obsolete now.

To the relation of the three macros:

Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.

WINVER and NTDDI_VERSION can be set idenpendently each
for itself.

Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
 2013-11-20 07:15:16 -06:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Thomas Arnhold
48dd3571f8 fixincludeguards.sh: shell 
Change-Id: I987c54b15c271fc80b7efd25933e13950f974423
 2013-11-05 09:28:53 +01:00
Marcos Paulo de Souza
704f95e525 fdo#54938: More uses of cppu::supportsService 
Change-Id: I90a7a07a43559b8d7e1d4b886b2624255200d46b
Reviewed-on: https://gerrit.libreoffice.org/6406
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-25 08:19:58 +00:00
Luboš Luňák
ee149fdbcb valueOf is deprecated 
Change-Id: I89b06a077eaceee7d06c7372dd596840e979e697
 2013-08-21 16:42:05 +02:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf() 
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
 2013-08-21 15:10:35 +02:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Ivan Timofeev
9dd52eb86a use GLIB_CHECK_VERSION instead of GLIB_VERSION_X_XX 
Michael Meeks pointed out that the latter can cause problems.

Change-Id: I68e7f8c6dcfae52305738b2a8cdee72e9c2c7f93
 2013-04-19 17:46:28 +04:00
Ivan Timofeev
025857d81d WaE: g_type_init has been deprecated since GLib 2.36 
Change-Id: Ied9b2c2424d780d589cb1b07df0ec38107d49829
Reviewed-on: https://gerrit.libreoffice.org/3434
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-04-18 09:19:46 +00:00
Luboš Luňák
ba044b1e96 remove needless forward rtl::OUString declarations 
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
 2013-04-07 14:23:12 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Stephan Bergmann
aa753f01ba -Wunused-macros 
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
 2013-03-27 09:36:53 +01:00
Thomas Arnhold
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations 
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 10:48:30 +00:00
Thomas Arnhold
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings 
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 09:00:26 +00:00
Thomas Arnhold
a2454a42ad fdo#43460: use isEmpty() 
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
 2013-03-09 20:32:39 +01:00
Krisztian Pinter
895898596c WIP: fdo#47011 autosave feature 
Change-Id: Ib2cbcc33e6188c60c183b5f47e9ae9c9d4c91b95
 2013-03-07 10:11:47 +01:00
Thomas Arnhold
26e37ca4c7 doubled includes 
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
 2013-03-04 13:58:40 +01:00
Marcos Paulo de Souza
e9aff4b508 fdo#57950: Remove some chained appends in shell 
And remove some *STRINGPARAM macros.

Change-Id: Idebee475e4b383f5f390040515bdfa7c49a24c1d
Reviewed-on: https://gerrit.libreoffice.org/1682
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
 2013-01-15 18:17:17 +00:00
Stephan Bergmann
30c77b4c3f -Werror,-Wunused-result 
Change-Id: I25cf94e9abaf976df9a8a0b8ee5f9955d623b006
 2012-12-05 17:29:50 +01:00
Thorsten Behrens
66a175834c c++ API: use css alias in generated headers, adds global css decl 
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
 2012-11-30 14:36:36 +01:00
Michael Meeks
c4008ef546 re-base on ALv2 code. Includes: 
tkr41: #117828# office crash fixed . (null pointer) + add unit test
    Patch contributed by Tobias Krause
    http://svn.apache.org/viewvc?view=revision&revision=1172105

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

    remove the OutDev::GetKernPair* stubs completely
    Patch contributed by Herbert Duerr
    http://svn.apache.org/viewvc?view=revision&revision=1179221

    reverting un-necessary OS/2 conditionals.
 2012-10-03 16:56:06 +01:00
Tor Lillqvist
565acfef76 Use prefix 
Change-Id: Ife93e37f8b24f3ce96b55c5a221f0f929b789f60
 2012-10-02 12:07:06 +03:00