Commit Graph

119 Commits

Author SHA1 Message Date
Michael Stahl
64644e0d92 svx: hack around LogicToPixel assert in SvxRuler::UpdateTabs
Somehow this gets called in a different order than in 4.3; with the
bugdoc from tdf#89478 i get this assert on master because of the
uninitizlized / LONG_MAX.

Change-Id: Iacce21571246c96276bd3c126f982282df7fc491
2015-04-14 17:29:35 +02:00
Noel Grandin
e9cb5577f4 loplugin:staticmethods
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2015-04-02 09:38:29 +02:00
Caolán McNamara
a1ceacc17e boost::foo_ptr->std::foo_ptr
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16 12:54:44 +00:00
dbeurle
8748ae646b HiDPI changes to ruler to respect screen DPI
Change-Id: I4cbb303b395ad60d4935bff55fbaea08f13334a0
Reviewed-on: https://gerrit.libreoffice.org/13867
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-14 12:49:50 +00:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
Noel Grandin
8044acf2db convert SFX_CALLMODE constants to SfxCallMode enum class
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident

Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 15:14:52 +00:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
Noel Grandin
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06 15:47:44 -05:00
Chris Laplante
7b33dbb253 svx: Cleanup ASCII art and useless comments
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71
Reviewed-on: https://gerrit.libreoffice.org/11011
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-19 01:28:24 -05:00
Caolán McNamara
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
Stephan Bergmann
6b8440134f loplugin:staticcall
Change-Id: I41ecb2b80251f56823f6b59c0746ff50531e6c84
2014-06-13 17:54:34 +02:00
Caolán McNamara
83f760d566 coverity#705258 Missing break in switch
Change-Id: I96dbefbc5ecc006b4ec456290cabed5026c18b03
2014-05-26 10:18:25 +01:00
Noel Grandin
be88947bac svx: sal_Bool->bool
Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e
2014-04-15 09:02:33 +02:00
Noel Grandin
aaee84c4c8 svx: sal_Bool->bool
Change-Id: I26a7bded5138d646c67ae396690659ee13ba9f36
2014-03-11 08:18:20 +02:00
Michael Stahl
958616a323 rhbz#1072607: (hopefully) fix crash in SvxRuler::MouseMove()
Not sure why mpParaItem is 0 here, add a check like in every other
SvxRuler method.

(regression from 47a77d7dbc)

Change-Id: Ic11a4d0c9b6ca217cd59d1d3f6789592996d2c1d
2014-03-07 00:27:02 +01:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Herbert Dürr
9e77ddcd19 Resolves: #i123817# prepare codebase for updating to boost 1.55
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)

Conflicts:
	basic/source/comp/parser.cxx
	basic/source/comp/token.cxx
	dbaccess/source/ui/dlg/generalpage.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	vcl/quartz/salbmp.cxx

Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
2014-01-06 16:32:20 +00:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Tomaž Vajngerl
fcc436bc62 use rtl::math::round for rounding, std:round is C++11
Change-Id: Ibba1a3e712de56844be454a87a0bb65c26ae4fe1
2013-09-15 16:19:04 +02:00
Tomaž Vajngerl
b0c3f45bec include cmath
Change-Id: I34fd87a7599884340adbf6e3ae7df321cfc85e23
2013-09-15 16:10:39 +02:00
Tomaž Vajngerl
e0a43dff64 Use vector instead of scoped_array to hold ruler items
Change-Id: I51f8d1d22da5f869e9937813de9649fddae1ffda
2013-09-15 15:34:16 +02:00
Tomaž Vajngerl
b46079bb41 Fix ruler margin dragging in vertical mode
Change-Id: I4727bbb304059859f3f5b4a96f834b41191c0bab
2013-09-15 15:34:15 +02:00
Tomaž Vajngerl
681f432745 ruler: RTL fixes for indents in tables and columns
Change-Id: I6c0a819e4a294fcf50c96a51bb9eea3ddef84c57
2013-09-15 15:34:15 +02:00
Tomaž Vajngerl
47a77d7dbc Ruler: disable snapping, tooltips
It is now possible to disable snapping of the ruler at dragging
with holding the ALT key and coarse snapping with ALT+SHIFT key.

Tooltips are shown when hovering over indents and borders.

Change-Id: Ib1e9639e1e2824f2a75b5abd35765bbbd02c87f7
2013-09-15 15:34:15 +02:00
Noel Grandin
ef84ce9cec convert svx/source/dialog/*.cxx from String to OUString
Change-Id: Icba1afdaf0d6ec16d2d09788ed3346160cb7564d
2013-09-05 08:55:12 +02:00
Tomaž Vajngerl
dda8877b98 Ruler: minimal unit 1/16 inch, 1/10 cm, dynamic tick draw, various
- minimal unit for inch is 1/16 and for cm 1/10 (1mm)
- additional tick level (now 4 in total)
- top and bottom tick in addition to the number (highes tick level)
- dynamically draw tick levels depending on the tick gap (should be
  at least 6 pixel wide)

Change-Id: I0598b16e32d19eb1294a2358eacbeb19a70966a2
2013-09-03 07:46:44 +02:00
Tomaž Vajngerl
0e0078468a Convert more instance vars to scoped_ptr and scoped_array in ruler
Change-Id: I8f6f0800af814e08a38e09136c4e26cb1b9c7902
2013-08-29 18:40:01 +02:00
Tomaž Vajngerl
99bbef59ae fdo#67033 fix default tab drawing on ruler
Change-Id: I471920e26a8e336cde795360945b5a843fe8f9c8
2013-08-29 18:40:01 +02:00
Tomaž Vajngerl
14451e36c8 Remove paragraph border drawing in ruler as it is not useful.
Change-Id: I8fbe294722b448aaa08b5f14d9902bdbfe9f8f25
2013-08-29 18:40:00 +02:00
Tomaž Vajngerl
6a55ef189d Use scoped_ptr for items in svxruler and clean-up code.
Change-Id: Ia461bdf633364fdc379a8180998452ef08a58316
2013-08-29 18:40:00 +02:00
Tomaž Vajngerl
8c8b165f54 fdo#38144 more stable ruler actions on tables
Change-Id: I38b16153df1d801b81a753449e202d962ce5f38e
2013-08-29 18:40:00 +02:00
Tomaž Vajngerl
c968afcdf5 SvxRuler: remove debug output methods and cleanup code
Debug output was bit rotten and was of very little value. Debug
window was still left in however.

Change-Id: I6e9542a081312b7cc82c2e70d5d2c06ea60907c7
2013-08-29 18:39:59 +02:00
Caolán McNamara
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
Tomaž Vajngerl
fbd059fb60 fdo#38144 Fix calculation of tick size in snapping to frame margin
Change-Id: I36aa24880f28cb011e0b48e3b817c97a28475119
2013-07-28 11:49:53 +02:00
Tomaž Vajngerl
bfa3f8584b fdo#38144 Enhance snapping to markers, also snap to frame margins
Change-Id: I5de4f8bafecabf84224a0518d9515295d23d7321
2013-07-26 00:05:03 +02:00
Tomaž Vajngerl
0153ea7e11 Fix compiler errors and warnings..
Change-Id: Id35cdec02c7a5175e1b429b723679541292ddfb3
2013-07-23 23:00:48 +02:00
Tomaž Vajngerl
98608e57f2 fdo#38144 In ruler snap to markers for tab stops, margins, etc.
Change-Id: Ie7f829b0ec36af79a2a97d9de7b6e37034c22e61
2013-07-23 20:52:46 +02:00
Tomaž Vajngerl
06c416be33 Cleanup strangely formatted code in SvxRuler.
Change-Id: I69b87dd737ac6a1195cbd023398179580fa0fd24
2013-07-23 20:52:45 +02:00
Caolán McNamara
491bb212fa allow changing the fill color user for tab previews
Change-Id: Ie20e900fe9e1f9bfdcd5784b380aa4574d52c001
2013-07-03 12:48:21 +01:00
Marcos Paulo de Souza
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
Rodolfo Ribeiro Gomes
e047a967b0 fdo#38246 Comment control on Writer ruler feature
It follows the directions from design team available at
https://wiki.documentfoundation.org/Design/Whiteboards/Comments_Ruler_Control.
It misses some fancy stuff though (like animated/delayed highlight and fading border).
Some work should be done with (svtools) Ruler also for a cleaner implementation.

Change-Id: Ib065043d05fe56fbfe6d00e0bb654966f046129b
Signed-off-by: Rodolfo Ribeiro Gomes <rodolforg@gmail.com>
2013-03-11 10:08:30 +01:00
Ricardo Montania
0db25d61bc String::CreateFromAscii removal
Change-Id: I86a33ef14b2bcdea1655db410f36d799689a1377
Reviewed-on: https://gerrit.libreoffice.org/2402
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-02-26 10:38:09 +00:00
Jean-Noël Rouvignac
6119e15c8b fdo#38838 search replace for String::CreateFromInt32().
I ran the following code replace:
    s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/

Change-Id: I7c047cf1c90632bddc23ed49f9455d745ac8688e
Reviewed-on: https://gerrit.libreoffice.org/2282
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-22 17:23:19 +00:00
Michael Meeks
0a063f3a36 re-base on ALv2 code. Includes:
Patch contributed by Christian Lippka
    impress212: #i113063# patch: dubios self assign in svx/source/dialog/framelink.cxx
    http://svn.apache.org/viewvc?view=revision&revision=1167619

    Patches contributed by Mathias Bauer
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117712#: fix several resource errors introduced by
    IAccessible2 implementation
    http://svn.apache.org/viewvc?view=revision&revision=1172343
    cws mba34issues01: #i117719#: use correct resource ID
    http://svn.apache.org/viewvc?view=revision&revision=1172351

    Patch contributed by Andre Fischer
    Do not add targets for junit tests when junit is disabled.
    http://svn.apache.org/viewvc?view=revision&revision=1241508

    Patches contributed by Armin Le-Grand
    #118804# corrected GraphicExporter behaviour on shortcut when pixel graphic is requested
    http://svn.apache.org/viewvc?view=revision&revision=1240195
    fix for #118525#: Using primitives for chart sub-geometry visualisation
    http://svn.apache.org/viewvc?view=revision&revision=1226879
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118524: apply patch, followup fixes to 118485
    http://svn.apache.org/viewvc?view=revision&revision=1186077 13f79535-47bb-0310-9956-ffa450edef68

    Patch contributed by Regina Henschel
    linecap: Reintegrating finished LineCap feature
    http://svn.apache.org/viewvc?view=revision&revision=1232507

    Patch contributed by Wang Lei (leiw)
    #i118760# split the first table cell vertically, then undo&redo,
    the Presentation app will crash
    http://svn.apache.org/viewvc?view=revision&revision=1301361

cleanup globlmn hacks, undo dependent fixmes.
2012-11-27 12:55:10 +00:00
jailletc36
e609841e8f cppCheck: remove dead assignment and dead variables
Change-Id: I3f0eae93be7f362ff70f8a544c46cd500d2ca50c
Signed-off-by: jailletc36 <christophe.jaillet@wanadoo.fr>
Reviewed-on: https://gerrit.libreoffice.org/1153
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2012-11-25 12:19:22 +00:00
Thomas Arnhold
d8afc8e5e9 Remove superfluous include comments
Change-Id: Ie5792855761b9be209bf3fa2cba9e6998523c982
2012-06-09 04:39:01 +02:00
Takeshi Abe
c4f2c60c08 removed duplicate includes in svx 2012-04-02 17:17:22 +09:00
Thomas Arnhold
ef026f3359 unusedcode.easy: remove some more 2012-02-22 00:52:32 +01:00
August Sodora
bd7f838011 Remove oooimprovement 2011-12-07 21:59:28 -05:00
Norbert Thiebaud
2fcfed5785 remove include of pch header from svx 2011-11-27 13:24:50 -06:00