mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
391,857 Commits 1 Branch 0 Tags
c2f912b51efa458ba9bd1601a8676ab119aca1bd
Commit Graph

391857 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Caolán McNamara
c880eb6b69 tweak assert and switch to squeak by NDEBUG and nonNDEBUG 
Change-Id: I996d69d83acb77e96cb105f65a0243bd5fe80295
 2016-05-12 12:32:56 +01:00
Tor Lillqvist
43c95611d2 tdf#99369: Try harder to bail out for non-horizontal text 
Look not only for fonts with rotated glyphs (where the first character
of the face name is '@') but also for font objects with non-zero
orientation or escapement in general.

Change-Id: Ia88d38010e52ada8193f2b8057d9f3250108e9f1
 2016-05-12 14:26:37 +03:00
Caolán McNamara
92c4c76f55 fall-through->SAL_FALLTHROUGH 
Change-Id: I91ed1614162f3b7de13a0fe4ce1af689dce21510
 2016-05-12 12:22:16 +01:00
Caolán McNamara
eacea16a6c have a stab at fixing the -Wimplicit-fallthrough in json_parser 
Change-Id: I2e6909cd804159a3540de4eb8ddecc1bd9131457
 2016-05-12 11:36:31 +01:00
Caolán McNamara
3beb77bb67 Resolves: tdf#99464 don't allow a menu as a dialog parent 
which is an issue since...

commit dd46727b99
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Apr 5 15:27:38 2016 +0100

    Resolves; tdf#87120 no keyboard navigation inside floating windows

    lets try and treat these the same as we do normal toplevels
    like dialogs if they popup with GrabFocus.

    This way focus can be set on widgets inside the floating windows, and
    so keyboard traversal of widgets etc all works.

which allows keyboard focus inside floatinging windows to allow
a11y keyboard navigation inside them without jumping through difficult hoops.

Its typically better to explicitly set the parent of the dialog rather
than depend no the auto-search stuff

Change-Id: I869f3ef6c86d32dd9a1f5b53a2677be9f16a1598
 2016-05-12 11:32:30 +01:00
Caolán McNamara
9226f602ba rejig for legibility, no logic change 
Change-Id: I73418e29dd85488613ea5c54ca8d505715ed3cbf
 2016-05-12 11:32:30 +01:00
Stephan Bergmann
11ef5ee940 in non-debug build, leave sPath empty 
(avoid -Wimplicit-fallthrough with NDEBUG)

Change-Id: I60332c4b05c805a7972189774283cdd518f77af0
 2016-05-12 11:53:28 +02:00
Stephan Bergmann
94b361b005 loplugin:stringconstant 
Change-Id: I5515f35871b23b67564d5eda52bf3323e7e047bb
 2016-05-12 11:44:12 +02:00
Stephan Bergmann
3eaf7ae663 Massage code to avoid warnings 
Change-Id: I847e1a109bd20e64161a7735ee30b2fe1ca507b0
 2016-05-12 11:33:18 +02:00
Caolán McNamara
89f22051f2 WaE: -Werror=logical-op dynamic_cast dbg test is on the result not input 
Change-Id: Ib3750fe1d2ce480beb5b4c512ed74701f29eecfc
 2016-05-12 10:29:26 +01:00
Stephan Bergmann
c1b6d15472 Massage code to avoid warnings 
Change-Id: Id86085e60c588d80ae50e8e5af07f2065b89048c
 2016-05-12 11:26:13 +02:00
Stephan Bergmann
81ad706b95 Replace comment with SAL_FALLTHROUGH 
Change-Id: I9ccba0369453af3b4b3328b9fca94429369c6524
 2016-05-12 11:20:14 +02:00
Stephan Bergmann
1859d3881a Replace comment with SAL_FALLTHROUGH 
Change-Id: Ibc5937b852ee8220d5d347e18a824df4c97ade40
 2016-05-12 11:17:50 +02:00
Michael Stahl
c567c0cf44 dbaccess: replace boost::bind with C++11 lambdas 
Change-Id: I468f9c7af9c8c8189c51790e0301dd8c60a9f83c
 2016-05-12 11:08:25 +02:00
Michael Stahl
28159e91ba sdext: replace boost::bind with C++11 lambdas, part 2 
Change-Id: Ife5fbf7a7a41182de00dca339cba160e3bb0062f
 2016-05-12 11:08:24 +02:00
Caolán McNamara
0b8a989ace warn to info for something that isn't a surprise 
Change-Id: I7427d2970d81d700f1ecc3e48c33ffb5a8045f2c
 2016-05-12 10:09:26 +01:00
Caolán McNamara
71c4a2b761 mpDefDialogParent is not used since 2002 
i.e.

commit c0ae87cb5f
Author: Stephan Schäfer <ssa@openoffice.org>
Date:   Tue Oct 22 08:39:05 2002 +0000

    #103442# choose DefDialogParent on-the-fly

and so calling SetDefDialogParent doesn't achieve anything

Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
 2016-05-12 10:09:26 +01:00
Stephan Bergmann
533fd775d5 Massage code to avoid warnings 
Change-Id: Iec529b4750770c52aa0a746390ba272ce6390fb5
 2016-05-12 11:08:37 +02:00
Stephan Bergmann
a966293cad Replace comment with SAL_FALLTHROUGH 
Change-Id: Iff490d06eaf73e0b55bfb7aa6c41b5fd3851ea44
 2016-05-12 11:04:24 +02:00
Stephan Bergmann
8d711b2dfd Missing SAL_FALLTHROUGH (see comment above) 
Change-Id: I25d7c76462699e0f206e622841744fef9527108b
 2016-05-12 10:38:58 +02:00
Noel Grandin
899e8cedd7 simplify SalGraphics::copyArea flags argument 
Change-Id: Iaaef4d90d7fe817a32cd51652d41c2e49c8909a4
Reviewed-on: https://gerrit.libreoffice.org/24832
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 07:13:45 +00:00
Noel Grandin
b415494bf0 clang-tidy modernize-loop-convert in sw 
Change-Id: I1f4a0ad6658bd3154c48940296aa8edc1ea1612c
Reviewed-on: https://gerrit.libreoffice.org/24876
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 07:12:44 +00:00
Noel Grandin
875984617c clang-tidy modernize-loop-convert in svx 
Change-Id: I09e5243e5dff46ceccef1a707e648ee9cb0c37c5
Reviewed-on: https://gerrit.libreoffice.org/24875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 07:12:21 +00:00
Noel Grandin
6bc3c2bdc5 Convert SFX_EXTRA to scoped enum 
Change-Id: I57fa684d91d10a132c718152ca646edd1c7bd189
Reviewed-on: https://gerrit.libreoffice.org/24882
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 06:57:49 +00:00
Noel Grandin
1342818790 convert SFXWB file dialog flags to scoped enum 
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b
Reviewed-on: https://gerrit.libreoffice.org/24881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 06:57:19 +00:00
Noel Grandin
0f4ac20e04 Convert RulerType to scoped enum 
Change-Id: I2233b70e5413bfa3156011e1b3306d539003795b
Reviewed-on: https://gerrit.libreoffice.org/24879
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 06:57:04 +00:00
Tor Lillqvist
e1efe3359c loplugin:stringconstant 
Change-Id: I9eed9713a0d208e7aa4cdddc0cedb97edf831239
 2016-05-12 08:48:57 +03:00
Tor Lillqvist
f1fa4a58fc loplugin:defaultparams 
Change-Id: I4905e4c1dd72dabe2229d99742ee0012295a9742
 2016-05-12 08:48:56 +03:00
Tor Lillqvist
1275d96147 -Werror,-Wimplicit-fallthrough 
Fix "fallthrough annotation in unreachable code". Clang is clever
enough to know that code after assert(false) is unreachable in a
non-NDEBUG build.

Seriously, micro-optimisation of the case that should never be
reached?

Change-Id: I10d7ae60895437be52c27aa93539d17e0f091ac4
 2016-05-12 08:47:32 +03:00
Julien Nabet
7d3b676ce1 Silence bogus GCC 5.3 -Werror=strict-overflow 
Thank you Stephan for the hint!

Change-Id: I22b5a9c9e65297cba5a2894e46d2fee59825a045
Reviewed-on: https://gerrit.libreoffice.org/24900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-05-12 05:03:38 +00:00
Takeshi Abe
cc63036369 Convert FLG_* to scoped enum 
Change-Id: If767fff10a0bb28735578b4ec3dcf7b9e2d326a2
Reviewed-on: https://gerrit.libreoffice.org/24872
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2016-05-12 00:38:42 +00:00
Michael Stahl
4517ac3741 sal: -Werror,-Wimplicit-fallthrough 
Change-Id: Id8262e735b9f95d8b476a4939c362648e2a4328a
 2016-05-11 23:14:45 +02:00
Julien Nabet
842970f846 -Werror=unused-variable for non debug build 
Change-Id: I110ae4973e98b0fa3c8c5273e778eab9ddcd7476
Reviewed-on: https://gerrit.libreoffice.org/24899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-05-11 20:46:10 +00:00
Caolán McNamara
a7a96078ff Resolves: tdf#99464 set what parent the dialogs are dialogs for 
With nullptr a parent is searched for and assigned (unless NoParent is
set which means no parent)

since...

commit dd46727b99
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Apr 5 15:27:38 2016 +0100

    Resolves; tdf#87120 no keyboard navigation inside floating windows

    lets try and treat these the same as we do normal toplevels
    like dialogs if they popup with GrabFocus.

    This way focus can be set on widgets inside the floating windows, and
    so keyboard traversal of widgets etc all works.

I believe an active menu is allowed as a parent (which I'll investigate and see
if we can fix or revert that if necessary), but its good practice to explicitly
set the right parent rather than depending on what happens to be on top anyway.

Change-Id: I744f6d9bc133058a4a9db94d6c27d2e36e22179e
 2016-05-11 21:19:46 +01:00
Michael Stahl
58a64174a8 slideshow: tweak ListenerOperations<std::weak_ptr<ListenerTargetT>> 
Pretty sure FuncT(...value_type) is wrong since value_type is
std::weak_ptr which does not implicitly convert to a callable pointer;
this caused build failure on Mac OS X with clang/libc++.

Change-Id: Id9de4a7825347a84cce2aab5367a457a003bb352
 2016-05-11 21:37:48 +02:00
Michael Stahl
7ac1062c66 slideshow: replace boost::mem_fn with C++11 lambdas 
A bit more verbose but we have less than 10 mem_fn now so better
elimintate them all so hopefully we can get rid of the corresponding
boost warning patches.

Change-Id: I79e2f9994841125916d92bdce9973d956f2a68ce
 2016-05-11 21:37:47 +02:00
Michael Stahl
148da261c8 sd: replace boost::mem_fn with C++11 lambda 
Change-Id: I5502730d042d385033f34ae888835637376ffb44
Reviewed-on: https://gerrit.libreoffice.org/24887
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-05-11 19:25:54 +00:00
Michael Stahl
c7325f3903 sdext: replace boost::bind with C++11 lambdas 
Change-Id: I2a30e764b96530e21d5ff201b18f98d1cd334a6d
Reviewed-on: https://gerrit.libreoffice.org/24888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-05-11 19:21:49 +00:00
Pranav Kant
a5a71cea62 sc: Add new param, DontTerminateEdit, to .uno:Save 
... which determines if current editing mode before save should
be terminated with save or not.

Change-Id: I49318013f1244eb8681a19ed3da50fbecd336a3d
 2016-05-11 21:33:14 +05:30
Pranav Kant
0241896fad lokdocview: Add debug info; paintTile rendering time 
Change-Id: Icdb14e9a5fedb3dcfbad502e323b333c3dbcc534
 2016-05-11 21:33:06 +05:30
Juergen Funk
0761614ccf tdf#98924 In windows, change the keyboard layout per application 
reint the key maps when in windows change the language for the
application

Change-Id: I71045386b4fe4d6db5572effa07a2f01ce79e74f
Reviewed-on: https://gerrit.libreoffice.org/23556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2016-05-11 15:43:04 +00:00
Stephan Bergmann
812e640561 Enable Clang -Wimplicit-fallthrough 
...now that all intended ones are marked as SAL_FALLTHROUGH.

Change-Id: Ibc76299cdac0d33285a47b106e7a548a5efffcbd
 2016-05-11 17:11:50 +02:00
Stephan Bergmann
01f787a21a Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???" 
Would be great if people knowing about the respective code areas could look into
these, and either change them into plain "SAL_FALLTHROUGH;" or "break;".

Change-Id: I6bd5e04bbb84452bea57d10946522b456c2ad5f0
 2016-05-11 17:09:13 +02:00
Stephan Bergmann
6356b33747 Add SAL_FALLTHROUGH, where apparently appropriate 
Change-Id: I4394a2e54da7c8a0e998db818211b0935b4cb1cd
 2016-05-11 17:08:36 +02:00
Stephan Bergmann
0a5f9d7806 SAL_FALLTHROUGH is intended here 
...given 8100100298 "fdo#80167 RTF export: don't
loose page breaks" (and confirmed by Miklos on IRC)

Change-Id: Ib70df00c565c5ec163fb13ead501d2100743d2dc
 2016-05-11 16:58:33 +02:00
Oliver Specht
b22ce32946 set parent window of windows system file picker on save(as) 
If no parent is provided the Windows system file picker uses either the current
foreground window or the desktop. The decision depends on the thread id of
the foreground window. To make sure the document window is used as parent this
is now also sent to the system file picker as it was already done for the
internal file picker.

Change-Id: Id589cbc1f91db30e065175aaea42ef1512ffb1b9
Reviewed-on: https://gerrit.libreoffice.org/24635
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2016-05-11 14:40:23 +00:00
Stephan Bergmann
315aebd970 Looks like SAL_FALLTHROUGH is intended here 
...given 3006acbabc "New: Vertical flag"

Change-Id: I99c89017f43aeb6f7cf2808dffc498b99d8765fc
 2016-05-11 16:39:03 +02:00
Oliver Specht
c4af075904 tdf#98981 added initialization of e-Mail configuration QueryBox 
Change-Id: I96a742439825ae422bc345294c2964159d168d3f
Reviewed-on: https://gerrit.libreoffice.org/24650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2016-05-11 14:29:55 +00:00
Samuel Mehrbrodt
f1242573ee Fix horrible codestyle 
Change-Id: I3bbeb625abd9ba130fc6fea97689ead682fa074b
Reviewed-on: https://gerrit.libreoffice.org/24893
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-05-11 14:18:27 +00:00
Stephan Bergmann
838994da2a Missing break in switch 
caused by c2ea2e6ca9 "coverity#704901 Dereference
after null check"

Change-Id: I7e53493bcb2857ccc840429cd2fd2e802180aa19
 2016-05-11 16:14:24 +02:00