mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
414,416 Commits 1 Branch 0 Tags
cb151051d79a7ec176e769a33a56e7d906fc1425
Commit Graph

2602 Commits

Author SHA1 Message Date
Stephan Bergmann
a2d814ac1d loplugin:implicitboolconversion 
("explicit conversion (NoOp) from 'const bool' to 'bool' implicitly cast back to
'const bool'", seen now with a recent trunk Clang 6, and with experimentally
enabling -std=gnu++17 for the LO build; not sure what caused this to be
triggered only now for me)

Change-Id: I5310961b1d50870d3ae06554e4cb37e12ac68151
 2017-10-24 20:48:35 +02:00
Stephan Bergmann
38ef960bf7 loplugin:includeform: editeng 
Change-Id: If2aa2cbbfabe164ccf0f68522fa18fa3bae2225d
 2017-10-23 22:46:09 +02:00
Tomaž Vajngerl
fbc44fe63b tscp: advanced classification dialog for impress 
Change-Id: I76c81e6f84de8160c20f1614d7676f2f2c3fb155
Reviewed-on: https://gerrit.libreoffice.org/43361
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2017-10-23 12:04:43 +02:00
Noel Grandin
87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Noel Grandin
856df6d406 use std::unique_ptr in TrieNode 
Change-Id: I1482f846370e0b8e6f76d46fc5020e2dcb152223
Reviewed-on: https://gerrit.libreoffice.org/43495
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-19 09:05:05 +02:00
Armin Le Grand
8fa7d052e7 EditEngine: Enhance visualization of URLs 
When URLs get layouted Multi-Lined from the EditEngine,
a rough 'guess' how many chars per line should be used
was in place up to now. This could lead to lines being
too short or being longer than the available space, also
looked ugly. Layouting now using the needed space properly.
Also adapted vertical (for horizontal text) space usage,
with multiple lines the space was 'compressed' and wrong
calculated.

Change-Id: I7255e3e65c85a3a50497b771ed2ca1ef5d97c0dd
Reviewed-on: https://gerrit.libreoffice.org/43464
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
 2017-10-17 18:45:29 +02:00
Stephan Bergmann
141873715b Move editeng/source/editeng include files to common include directory 
...that are included from various source directories.  Change done in
preparation of loplugin:includeform.

Change-Id: I4c2160d1c682b37e93e1161796c67097866bf659
 2017-10-16 17:22:21 +02:00
Tomaž Vajngerl
92fad9596e editeng: add function to insert parargaph break to the EditView 
Change-Id: I06ab56967f25e6f9170cfbeb391110b55ddb18f6
Reviewed-on: https://gerrit.libreoffice.org/43359
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2017-10-16 15:22:40 +02:00
Henry Castro
59e9d16334 sd lok: fix spell checking languages in Impress 
Change-Id: I133c9b91521fa7f2b5f7e3a47396f7efa31e1a86
Reviewed-on: https://gerrit.libreoffice.org/43382
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
 2017-10-14 13:39:05 +02:00
Michael Stahl
34f4446b0a editeng: fix assert about wrong EE_PARA_OUTLLEVEL item 
It's a SfxInt16Item in DefItems::DefItems().

Change-Id: I01644b0b9d689d4d8756c52f1c2868f03b3037a5
 2017-10-05 22:48:21 +02:00
Michael Stahl
03041e0f8d tdf#112817 editeng,svx: fix SvxUnderlineItem/SvxOverlineItem SDI 
This was asserting because the superclass SvxTextLineItem
was instantiated instead of the specific subclasses.

Change-Id: If26847b8fa96dbf00062ba8372fe58e58c786782
 2017-10-05 17:21:14 +02:00
Noel Grandin
2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Noel Grandin
d3971ec256 new loplugin:blockblock 
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd
Reviewed-on: https://gerrit.libreoffice.org/43025
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-03 08:41:11 +02:00
Noel Grandin
2149bbfd27 rename SvxTabStop::IsEqual to operator== 
Change-Id: I98f8db6e80d6a5dc30826ec755deb9432f809e92
Reviewed-on: https://gerrit.libreoffice.org/42907
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-29 08:53:20 +02:00
Noel Grandin
8a8864aeb7 convert IsEqual/etc methods on ESelection to operators 
Change-Id: Ia8424e701b6f22d0536ee7f3bdb0ecaaed94a3b9
Reviewed-on: https://gerrit.libreoffice.org/42904
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-29 08:53:03 +02:00
Tor Lillqvist
8e7897588d Rename the basegfx::tools namespace to basegfx::utils 
Reduce potential confusion with the global tools namespace. Will
hopefully make it possible to remove the annoying initial :: when
referring to the global tools namespace. Unless we have even more
tools subnamespaces somewhere.

Thorsten said it was OK.

Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996
Reviewed-on: https://gerrit.libreoffice.org/42644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-09-26 14:18:41 +02:00
Jan Holesovsky
551e639f46 lok: Don't freeze the LibreOfficeKit via the spell-checking popup menu. 
Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0
Reviewed-on: https://gerrit.libreoffice.org/42608
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/42627
Tested-by: Jenkins <ci@libreoffice.org>
 2017-09-22 12:24:31 +02:00
Caolán McNamara
442df6cf83 ofz: don't leak in face of exceptions 
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2
Reviewed-on: https://gerrit.libreoffice.org/42587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-09-22 11:01:53 +02:00
Noel Grandin
3a481dde03 loplugin:flatten in editeng..extensions 
Change-Id: I2b68f5640471ea827c09af1b5a319fb526a53b4b
Reviewed-on: https://gerrit.libreoffice.org/42579
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-21 15:29:20 +02:00
Noel Grandin
71d48c3d5c unused xForbiddenCharsTable in ImpEditEngine 
since as far back as I can see

Change-Id: I828d527e91479f40d0186b09043de4841d735e84
 2017-09-19 09:31:43 +02:00
Noel Grandin
2b5cb7c6b1 unused m_xAccInfo in AccessibleEditableTextPara 
since

    commit c23ab5eaed
    Date:   Tue Nov 26 14:25:22 2013 +0000
    Integrate branch of IAccessible2

Change-Id: Id068fb0a49f5a1e79ca17fe66885cda558abe275
 2017-09-18 13:47:29 +02:00
Noel Grandin
b3c77e46e5 remove unused aLocale from SvxNumRule 
and fix usage site, regression from

    commit 41956321ce
    Date:   Sat Nov 24 18:54:09 2012 +0100
    get rid of Svx...Locale...() double conversion nonsense

Change-Id: Ic70abf5f52dce1db9cffd9c819e57f1a6c2a3df3
 2017-09-18 13:47:29 +02:00
Noel Grandin
7d14555ef7 convert SvxDateFormat to scoped enum 
And simplify the code in sd/headerfooterdlg, no
need for the complex encoding of date and time when we
can just index into a static array.

Change-Id: I677400bf1f956c81eba665b71dbda9183b63f55c
Reviewed-on: https://gerrit.libreoffice.org/42346
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-18 13:16:23 +02:00
Noel Grandin
f66661c166 convert SvxTimeFormat to scoped enum 
and make the numerators look more like our internal formatting codes

Change-Id: I3b3d448cec913e72c7ffb6cc3e7754241af36d93
Reviewed-on: https://gerrit.libreoffice.org/42345
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-16 14:44:19 +02:00
Noel Grandin
2ba9f793c7 convert SvxTimeType to scoped enum 
Change-Id: Ic5ca8c50ccd74837cd0521a13e1f5eaa8e326ff3
Reviewed-on: https://gerrit.libreoffice.org/42344
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-16 14:43:25 +02:00
Noel Grandin
70e5520653 convert SvxURLFormat to scoped enum 
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000
Reviewed-on: https://gerrit.libreoffice.org/42343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-16 14:43:04 +02:00
Noel Grandin
e45f61a590 convert SvxFileType to scoped enum 
Change-Id: Iec1c67f7f0f9b2244b1d6ef52921ddd09f944fbb
Reviewed-on: https://gerrit.libreoffice.org/42314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-15 12:05:23 +02:00
Noel Grandin
2b825fe7f5 convert SvxFileFormat to scoped enum 
Change-Id: Ia75c86a89c89bb22759e1d588ce603701cb7fad5
Reviewed-on: https://gerrit.libreoffice.org/42313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-15 12:05:07 +02:00
Noel Grandin
359201c9b4 convert SvxAuthorType to scoped enum 
Change-Id: I990eb35c883ddd417751487435556f584e956374
Reviewed-on: https://gerrit.libreoffice.org/42312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-15 11:27:50 +02:00
Noel Grandin
4da85bf822 convert SvxAuthorFormat to scoped enum 
Change-Id: I5553ea640a4483c98ec5f5240594e30a72c968f8
Reviewed-on: https://gerrit.libreoffice.org/42311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-15 10:38:11 +02:00
Noel Grandin
fda59e9768 convert SdrMeasureFieldKind to scoped enum 
Change-Id: I8896d46623843d3fe341c057d7ee0376a99f4741
Reviewed-on: https://gerrit.libreoffice.org/42310
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-15 10:21:09 +02:00
Noel Grandin
54e608c660 convert SvxCellVerJustify to scoped enum 
Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4
Reviewed-on: https://gerrit.libreoffice.org/42276
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-15 07:58:45 +02:00
Noel Grandin
5685ee25aa improve redundantcast loplugin 
to find c-style casts where the expression is a templated method

Change-Id: Ifbd1e2cdc72d906fc95a7ec0f9408c3f6d2a836b
Reviewed-on: https://gerrit.libreoffice.org/42275
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-14 14:43:43 +02:00
Noel Grandin
9c5c905680 clang-tidy modernize-use-emplace in editeng..framework 
Change-Id: I7739c4f77c856d34f8484754244df13d8fef840e
Reviewed-on: https://gerrit.libreoffice.org/42151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-11 09:42:55 +02:00
Noel Grandin
2e0a25ce2b loplugin:constantparam 
Change-Id: Ic87f0cc863490858b7cc7e74a7f90ec31992dd53
Reviewed-on: https://gerrit.libreoffice.org/42089
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-08 09:19:32 +02:00
Noel Grandin
7aa7f4d9e4 loplugin:unnecessaryparen include c++ casts 
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb
Reviewed-on: https://gerrit.libreoffice.org/41874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-04 10:52:41 +02:00
Matteo Casalin
9786bc48e3 OUString: reduce temporaries and constify 
Change-Id: Ic4d5e26b16414625dfb507ecf37d87efe171ceab
 2017-08-27 14:10:52 +02:00
Noel Grandin
4d41b2e42f loplugin:unusedfields 
Change-Id: I81bcf4f56599146536ba8d66cc86fa5a08737298
Reviewed-on: https://gerrit.libreoffice.org/41556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-25 13:10:03 +02:00
Noel Grandin
1b694dad64 loplugin:unusedmethods 
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f
Reviewed-on: https://gerrit.libreoffice.org/41539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-25 09:04:26 +02:00
Eike Rathke
311be7d701 Related: tdf#108795 never use an unresolved LANGUAGE_SYSTEM in SvxAutoCorrect 
Substitute with the current work locale, using MsLangId::getSystemLanguage()
instead was also wrong.

Change-Id: I55db3bc1f76329320afc1f366d7426a8c2f66fb2
Reviewed-on: https://gerrit.libreoffice.org/41476
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-08-24 00:30:55 +02:00
Eike Rathke
06d14411a4 Related: tdf#108795 a shared SvxAutoCorrect instance can not be stateful 
An SvxAutoCorrect instance is shared via SvxAutoCorrCfg::Get().GetAutoCorrect().
Since commit 284eb10676 and following the
SvxAutoCorrect::bRunNext/HasRunNext() introduced a state whether a previously
inserted NO-BREAK SPACE should be removed again, depending on the next
character input. That does not work, for example, if
SvxAutoCorrect::DoAutoCorrect() is called from two different EditEngine
instances, like it is the case in the Calc input line and cell which are
synchronized; or any other two or more instances for that matter. The caller
has to pass and remember a flag that is maintained by SvxAutoCorrect.

Change-Id: I79a26d2ba44cc40771979a78b686c89f0c80b412
Reviewed-on: https://gerrit.libreoffice.org/41475
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-08-24 00:30:37 +02:00
Michael Stahl
f53c9922c6 editeng: warning C4701 potentially uninitialized local var 
Change-Id: I611f0b5652722f0de38dfb82440823b832a6029c
 2017-08-22 22:52:58 +02:00
Michael Stahl
2f2a56f91e editeng: avoid infinite loop in SvxBoxItem::Create 
Apparently a sw unit test randomly read a partially written autotbl.fmt
and the stream has m_isEof = true.

Change-Id: Iacfbc42e83be6320d4aa695a5df4264f1db0b021
 2017-08-22 21:54:19 +02:00
Jochen Nitschke
728e42a9da drop unused SvxScriptTypeItem 
apparently there was never a user for this item since initial commit
in the year 2000. SvxScriptSetItem gets the ScriptType by parameter
see GetItemOfScript and PutItemForScriptType.

remove SID_ATTR_CHAR_SCRIPTTYPE and don't put the item in any set.
keep the gap in the ID range because it's not part of any range
and there are already other gaps.

Change-Id: Iee24f13b329593af2dc5548d8b6bc2282c2dc5b3
Reviewed-on: https://gerrit.libreoffice.org/41423
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-22 20:55:54 +02:00
Jochen Nitschke
1e3bd9bd15 drop unused SfxSpellCheckItem 
last getter went with
commit 215207f480
Date:   Thu Mar 6 16:42:24 2014 +0000
    coverity#708784 Unused pointer value

don't put the item in any item sets anymore.
delete SID_ATTR_SPELL and adjust SfxItemSet ranges.
narrow ranges in OfaTreeOptionsDialog::CreateItemSet to actually
used items.

Change-Id: Ia5cc91fc62a0fccf87b2fd380e6bb2bef1f6f3e7
Reviewed-on: https://gerrit.libreoffice.org/41335
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-20 07:56:27 +02:00
Noel Grandin
eea6d3951b loplugin:unnecessaryparen 
look for  statements like

    return (function());

Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3
Reviewed-on: https://gerrit.libreoffice.org/41260
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-18 08:49:37 +02:00
Andrea Gelmini
64a3124d92 Fix typos 
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3
Reviewed-on: https://gerrit.libreoffice.org/41194
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2017-08-17 21:53:28 +02:00
Noel Grandin
9881bea8d4 remove unnecessary use of OUString::getStr 
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4
Reviewed-on: https://gerrit.libreoffice.org/38114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 11:55:13 +02:00
Noel Grandin
2e8acde112 remove UL/L suffixes from integer constants on the RHS of expressions 
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5
Reviewed-on: https://gerrit.libreoffice.org/41237
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 11:25:21 +02:00
Varun Dhall
006a7b5054 Removing unused serialisation code 
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8
Reviewed-on: https://gerrit.libreoffice.org/41233
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-08-17 10:54:59 +02:00