mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
414,416 Commits 1 Branch 0 Tags
cb151051d79a7ec176e769a33a56e7d906fc1425
Commit Graph

50 Commits

Author SHA1 Message Date
Jochen Nitschke
594331cc81 remove default-able copy ctors and copy operators 
The implicit defined ctors and operators will copy all members
(and bases).
Since C++11 implicit copy is depreciated if there is a non-default
dtor, keep such copies.

This commit includes only types that had either copy ctor or
copy operator and were found by cppcheck.

Change-Id: I93ee687fb3b3c5884f475a2c6054955cdde57ed7
Reviewed-on: https://gerrit.libreoffice.org/39351
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-28 14:20:44 +02:00
Stephan Bergmann
6cb9e6dad7 Remove redundant 'inline' keyword 
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-03-03 20:55:50 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Noel Grandin
70fed865df new loplugin: useuniqueptr: forms..framework 
Change-Id: I4300a13f455148b7156ac3f444c7102d63ae6db3
Reviewed-on: https://gerrit.libreoffice.org/33164
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-17 11:31:40 +00:00
Noel Grandin
bb674aa550 loplugin:unusedfields 
Change-Id: Id2dbbf384637223db3d334d95332251832918003
Reviewed-on: https://gerrit.libreoffice.org/30927
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-17 13:10:42 +00:00
Noel Grandin
c123c528bf loplugin:unnecessaryvirtual in comphelper..forms 
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-08 06:57:57 +00:00
Noel Grandin
0aa24916cb loplugin:expandablemethodds in filter..forms 
Change-Id: Ic1f64f804acc10b1a48d82de9fc6a2b39af465a0
Reviewed-on: https://gerrit.libreoffice.org/30014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-19 06:32:58 +00:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Andrea Gelmini
506c929a0a Fix typos 
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0
Reviewed-on: https://gerrit.libreoffice.org/24536
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-05-01 09:51:41 +00:00
Noel Grandin
62633dfe02 clang-tidy performance-unnecessary-value-param in various 
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-14 11:37:19 +00:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Chris Sherlock
a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin
aa4dc89352 loplugin:unusedmethods unused return value in forms 
Change-Id: I9da3e72ca12e040e7fb5bea7ccaa071edfd34f27
 2016-01-11 13:14:08 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Caolán McNamara
7ba7a974f6 cppcheck: noExplicitConstructor 
Change-Id: I32c6728ce7423fd997cdbec66feb8a6ba39948d2
 2015-10-07 15:11:03 +01:00
Noel Grandin
de020fc9c3 com::sun::star->css in forms/ 
Change-Id: I1c09e88f839bdf11c6ff809ec95769e8f729c7cd
 2015-10-02 08:20:11 +02:00
Takeshi Abe
14bead7f42 forms: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: Ia4f56692c9beddda13ee948ab8bbc1ee95098fbf
Reviewed-on: https://gerrit.libreoffice.org/17648
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-11 13:30:17 +00:00
Noel Grandin
2886f830a9 idl,framework,forms: inline some use-once typedefs 
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
 2015-08-04 08:55:56 +02:00
Noel Grandin
771d9ef3f6 loplugin:unusedmethods forms 
Change-Id: I6b7938e948fb1422f83e2175fee5fcabe0a0b83f
 2015-07-17 11:07:13 +02:00
Philipp Weissenbacher
0f8ed32913 fdo#39468 Translate German comments, clean some ws 
Conflicts:
	forms/source/component/FormComponent.cxx
	forms/source/component/FormattedField.cxx

Change-Id: I76dacfff3aa6f5680a1e81c97281c4f744ec1ceb
Reviewed-on: https://gerrit.libreoffice.org/11622
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-09-25 08:49:03 +00:00
Chris Laplante
04f31d13c5 Remove ASCII art, useless comments and whitespace from forms module 
Change-Id: Ib6157a493092a137a6b0bf5b96d0e760d307f9da
Reviewed-on: https://gerrit.libreoffice.org/9472
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-05-25 14:35:17 -05:00
Noel Grandin
c0d037a6ec forms: sal_Bool->bool 
Change-Id: Ifa15f4ed3107b1075b504f09d2cae69ee38d347a
 2014-05-06 12:38:16 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Alexander Wilms
bed18b128f Remove visual noise from forms 
Conflicts:
	forms/source/component/DatabaseForm.cxx

Change-Id: I4005fe65e89794bd92191c37221c252a3e964917
Reviewed-on: https://gerrit.libreoffice.org/8262
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 14:54:56 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Arnaud Versini
5a73cceee5 FORMS : Remove usage of DBG_CTOR and DBG_DTOR. 
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 16:26:50 +00:00
Stephan Bergmann
07ab0d43b5 Get rid of DECLARE_STL_VECTOR 
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
 2013-12-06 08:04:23 +01:00
Stephan Bergmann
4a8175ebeb Get rid of DECLARE_STL_USTRINGACCESS_MAP 
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
 2013-12-06 08:04:22 +01:00
Thomas Arnhold
bdf7b2715e fixincludeguards.sh: forms 
Change-Id: I634371fcd867f20e20384f75d613dab5f69a246c
 2013-11-05 09:28:53 +01:00
Tor Lillqvist
e036d4b706 Spell "indices" correctly 
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
 2013-10-02 21:57:42 +03:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Michael Meeks
0a063f3a36 re-base on ALv2 code. Includes: 
Patch contributed by Christian Lippka
    impress212: #i113063# patch: dubios self assign in svx/source/dialog/framelink.cxx
    http://svn.apache.org/viewvc?view=revision&revision=1167619

    Patches contributed by Mathias Bauer
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117712#: fix several resource errors introduced by
    IAccessible2 implementation
    http://svn.apache.org/viewvc?view=revision&revision=1172343
    cws mba34issues01: #i117719#: use correct resource ID
    http://svn.apache.org/viewvc?view=revision&revision=1172351

    Patch contributed by Andre Fischer
    Do not add targets for junit tests when junit is disabled.
    http://svn.apache.org/viewvc?view=revision&revision=1241508

    Patches contributed by Armin Le-Grand
    #118804# corrected GraphicExporter behaviour on shortcut when pixel graphic is requested
    http://svn.apache.org/viewvc?view=revision&revision=1240195
    fix for #118525#: Using primitives for chart sub-geometry visualisation
    http://svn.apache.org/viewvc?view=revision&revision=1226879
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118524: apply patch, followup fixes to 118485
    http://svn.apache.org/viewvc?view=revision&revision=1186077 13f79535-47bb-0310-9956-ffa450edef68

    Patch contributed by Regina Henschel
    linecap: Reintegrating finished LineCap feature
    http://svn.apache.org/viewvc?view=revision&revision=1232507

    Patch contributed by Wang Lei (leiw)
    #i118760# split the first table cell vertically, then undo&redo,
    the Presentation app will crash
    http://svn.apache.org/viewvc?view=revision&revision=1301361

cleanup globlmn hacks, undo dependent fixmes.
 2012-11-27 12:55:10 +00:00
Thomas Arnhold
86f964d438 Remove doubled headers. 2011-01-21 18:32:36 +01:00
Caolán McNamara
eec16c4640 include algorithm for std::lower_bound 2010-10-28 20:18:06 +01:00
Caolán McNamara
b77940e5af add modelines to .hxx files as well 2010-10-28 15:48:02 +01:00
Jesús Corrius
6a6190a7bb Make some stl functions less ambiguous (fixes VC++ 10 compilation) 2010-10-28 13:55:00 +02:00
Noel Power
e31e563d72 initial commit for vba blob ( not including container_control stuff ) 2010-10-06 10:16:13 +01:00
Jens-Heiner Rechtien
36de66bdf0 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm
96ed7ffe93 INTEGRATION: CWS changefileheader (1.11.126); FILE MERGED 
2008/04/01 15:16:31 thb 1.11.126.3: #i85898# Stripping all external header guards
2008/04/01 12:30:23 thb 1.11.126.2: #i85898# Stripping all external header guards
2008/03/31 13:11:33 rt 1.11.126.1: #i87441# Change license header to LPGL v3.
 2008-04-11 07:15:27 +00:00
Oliver Bolte
06d17456e4 INTEGRATION: CWS sb59 (1.10.114); FILE MERGED 
2006/08/29 16:10:59 sb 1.10.114.1: #i67487# Made code warning-free (wntmsci10).
 2006-10-12 10:12:12 +00:00
Rüdiger Timm
ae697f1783 INTEGRATION: CWS ooo19126 (1.9.110); FILE MERGED 
2005/09/05 13:50:22 rt 1.9.110.1: #i54170# Change license header: remove SISSL
 2005-09-08 21:43:17 +00:00
Kurt Zenker
1c92523766 INTEGRATION: CWS gcc340fixes01 (1.8.38); FILE MERGED 
2004/07/16 12:37:49 cmc 1.8.38.1: #i31586# trivial namespace mod for gcc34
 2004-07-30 14:05:02 +00:00
Jens-Heiner Rechtien
f594965bb2 INTEGRATION: CWS ooo20031216 (1.7.82); FILE MERGED 
2003/12/13 13:14:28 waratah 1.7.82.1: #i1858# implement typename where they are needed
 2004-02-04 11:34:57 +00:00
Jens-Heiner Rechtien
5c44484b92 MWS_SRX644: migrate branch mws_srx644 -> HEAD 2003-03-25 17:05:07 +00:00
Vladimir Glazounov
6e46a20762 #92075# exception specification 2001-09-12 11:13:09 +00:00
Frank Schönheit
bd4fbd779f #86416# in the DBG_UTIL version, implement the copy ctor to allow correct instance counting (DBG_CTOR) 2001-04-27 11:08:20 +00:00
Frank Schönheit
ed2279051a #75916# OGroupManager knows it's container to check for the correct disposing call 2001-01-05 17:00:35 +00:00
Ocke Janssen
6722dc0da7 namespace changes 2000-11-23 08:05:32 +00:00
Frank Schönheit
cdbcbba768 migrated from unotools to comphelper 2000-10-19 10:52:20 +00:00
Jens-Heiner Rechtien
bf4154eb53 initial import 2000-09-18 15:33:13 +00:00