Commit Graph

45 Commits

Author SHA1 Message Date
Stephan Bergmann
3f9e9940a5 loplugin:includeform: fpicker
Change-Id: Icf2531ca9dea11bf25a8bbe5815e5b37b933553d
2017-10-23 22:46:07 +02:00
Caolán McNamara
182a74d937 de-hrc various things
e.g.  helpid[s].hrc -> helpids.h
and insert include guards where missing

move "ordinary" defines into .hxx files

remove .hrc entries that are used as arguments to dialog factory
when a dedicated method can be added instead

Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21 08:20:51 +01:00
Caolán McNamara
00657aef09 migrate to boost::gettext
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl
* all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string")
* ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching
  MODULE .mo files
* UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui
  goes from l10n target to normal one, so the res/lang.zips of UI files go away
* translation via Translation::get(hrc-define-key, imbued-std::locale)
* python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there
  to keep finding the .hrc file uniform) so magic numbers can go away there
* java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation
  mechanism
* en-US res files go away, their strings are now the .hrc keys in the source code
* remaining .res files are replaced by .mo files
* in .res/.ui-lang-zip files, the old scheme missing translations of strings
  results in inserting the english original so something can be found, now the
  standard fallback of using the english original from the source key is used, so
  partial translations shrink dramatically in size
* extract .hrc strings with hrcex which backs onto
   xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap
* extract .ui strings with uiex which backs onto
   xgettext --add-comments --no-wrap
* qtz for gettext translations is generated at runtime as ascii-ified crc32 of
   content + "|" + msgid
* [API CHANGE] remove deprecated binary .res resouce loader related uno apis
      com::sun::resource::OfficeResourceLoader
      com::sun::resource::XResourceBundleLoader
      com::sun::resource::XResourceBundle
    when translating strings via uno apis
      com.sun.star.resource.StringResourceWithLocation
    can continue to be used

Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-21 08:20:50 +01:00
Noel Grandin
6bbda13286 loplugin:unusedfields in forms..idlc
Change-Id: If250ff47c1f375fe24c61b5bf271da9a9c330822
Reviewed-on: https://gerrit.libreoffice.org/39133
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23 08:59:56 +02:00
Chris Sherlock
3b85b72d64 errinf.hxx moved out of tools and into vcl module
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more
appropriate to have it reside in the VCL module.

Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650
Reviewed-on: https://gerrit.libreoffice.org/36839
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25 10:55:17 +02:00
Caolán McNamara
b80dc58271 unwind fpicker RID_FILEPICKER_IMAGES imagelist
Change-Id: I1b55e4581c7fcbdf228c3b903269e28d37e53297
2016-12-06 10:12:32 +00:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin
938821fb08 new loplugin overrideparam
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25 06:09:17 +00:00
Noel Grandin
aa0d0536a4 tdf#97527 - vcl: reference-count Menu
some places are marked with "dodgy"- need to check those to see
what is going on, because they are leaving dangling pointers behind
in the Menu class

Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b
Reviewed-on: https://gerrit.libreoffice.org/26516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23 06:28:00 +00:00
Noel Grandin
c2f912b51e convert FilePicker flags to scoped enum
and merged into the other flags variable.

Change-Id: I23ed21936b9de1537a06168de04530b9fb6bcff1
Reviewed-on: https://gerrit.libreoffice.org/24889
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13 06:29:04 +00:00
Szymon Kłos
5813660e7b icon view for RemoteFilesDialog
New view type can be accessed in:

Start Center > Remote Files > Icon View

Cloud service for testing purposes:

1. Start Center > Remote Files > Add service
2. Set type to: Alfresco 4
3. Set host to: http://cmis.alfresco.com/cmisatom
4. Click refresh icon and enter login:admin pass:admin
5. Click OK and open this service

Change-Id: I3d4674bb84d1df1b678111adffe2f835d2bb2356
Reviewed-on: https://gerrit.libreoffice.org/22437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-09 16:42:54 +00:00
Noel Grandin
d9e6270392 loplugin:unnecessaryvirtual
update the plugin with lessons learned from the mergeclasses plugin and
re-run it

Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711
Reviewed-on: https://gerrit.libreoffice.org/20015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17 12:26:32 +00:00
Noel Grandin
a673713bb3 more removal of com::sun::star typedefs
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21 15:10:24 +02:00
Noel Grandin
6f1313b3d4 convert Link<> to typed
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-16 09:11:29 +00:00
Noel Grandin
ba974ccc8c com::sun::star->css in fpicker/
Change-Id: I211687bfeaf456e0f9639567bff401083011cd74
Reviewed-on: https://gerrit.libreoffice.org/19353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-14 06:36:34 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Noel Grandin
3c99f8500f convert Link<> to typed
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12 10:48:13 +00:00
Noel Grandin
e85b2333bc convert Link<> to typed
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-24 16:19:37 +00:00
Noel Grandin
55cdab3b8b convert Link<> to typed
Change-Id: I057969beed6402b2125f4dc719570d324c1df4fc
2015-09-15 09:37:31 +02:00
Noel Grandin
cf0c04a428 convert Link<> to typed
Change-Id: I85658fa35b9b85106a3b9c8ef303584cad6f39b0
2015-09-11 08:48:54 +02:00
Noel Grandin
61623d5b90 convert Link<> to typed
Change-Id: I365a81a0a960f5da736c9a97aa056da16c99452f
2015-09-08 08:16:46 +02:00
Noel Grandin
411e32244c convert Link<> to typed
Change-Id: Ic15d0539aa00b46694a1715b6dda9d78bb1c00d8
Reviewed-on: https://gerrit.libreoffice.org/18269
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03 07:21:26 +00:00
Szymon Kłos
51c3a6421e remember password for all types of service
Change-Id: I8620332ac5228eee1d7c16d0b0ff7920031be331
2015-08-29 12:33:20 +02:00
Szymon Kłos
6bf5bc9873 Remember window size
Change-Id: I4e9bd5e2516b66f47b560a388237b75059a7f142
2015-08-29 12:33:17 +02:00
Szymon Kłos
495285ee3a RemoteFilesDialog: file name autocompletion
Change-Id: Iab051ccaf075cc91acce67e01863e8d7ecac820c
2015-08-29 12:33:09 +02:00
Noel Grandin
167bc621ef Convert vcl Button Link<> click handler to typed Link<Button*,void>
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-26 11:15:35 +02:00
Noel Grandin
979b460faf make Link<> typed
Change-Id: Iffa4bbb58931075679a60132d90c3b8be6a76cc2
2015-08-17 09:59:59 +02:00
Szymon Kłos
a38e2ff720 store password for service if filled
Change-Id: I99ce30516a3d8859c060c8e85f8f8ea5e5217d61
2015-08-14 08:45:49 +02:00
Szymon Kłos
b5be942585 use shared context
Change-Id: I513a07e8e8d361b8f9c9695ddc8d283ee62b565d
2015-08-14 08:45:49 +02:00
Szymon Kłos
bb924a8176 shared PasswordContainer
Change-Id: I73d4532cd9e6f811e32d46738808c81a03c2e895
2015-08-14 08:45:47 +02:00
Szymon Kłos
0ab1f6a024 added change password entry in the split button menu
Change-Id: I68e76e346ec6d704c27fe6f4031453dd44dbc983
2015-08-14 08:45:42 +02:00
Szymon Kłos
41102d9fcd added New Folder button
Change-Id: I4b1ef03e707fdfb3d1968dca9f48c548f872612c
2015-08-14 08:45:40 +02:00
Szymon Kłos
7e33e62e87 Breadcrumb: changed first entry label ('Root')
Change-Id: Id15bc1ef92fdab22ba3332dc9b42fb9c785298b4
2015-08-14 08:45:25 +02:00
Szymon Kłos
7278462e12 remember user settings
Change-Id: I69c4672646365ca4cbeb04d6956741ffe365ad35
2015-08-14 08:45:23 +02:00
Szymon Kłos
5667079ae0 save mode improvements
Change-Id: I14953eafb3fbd840df5f9c890b55855e14a1fd9a
2015-08-14 08:45:19 +02:00
Noel Grandin
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
Szymon Kłos
2c6ffb2c75 don't show edit/delete menu when there is no service
Change-Id: Ia53c9e3f6a4bcaab5e68fbbff6d2ec8cfe5cd702
2015-07-24 12:29:11 +02:00
Szymon Kłos
3eee31157a RemoteFilesDialog integration with AsyncPickerAction
Change-Id: If6ded1c2f2b056ce864589649b08ed19a73dc5dd
2015-07-24 12:29:08 +02:00
Szymon Kłos
8f79782454 show error when directory doesn't exist
Change-Id: I1c8ca1a509c9187687079d86f0e637b26490a7a3
2015-07-24 12:29:05 +02:00
Szymon Kłos
37e184911e Show 'Add service' dialog when there is no service added yet
Change-Id: I72d294e9c09b0d02b829b91fb188c1c7965d1d45
2015-07-24 12:28:48 +02:00
Stephan Bergmann
53bf91d66e loplugin:passstuffbyref
Change-Id: I37c254bd1fdb3cfb05d513f87fa4f4a468466bb0
2015-07-16 10:29:45 +02:00
Stephan Bergmann
5e090212b1 -Werror,-Winconsistent-missing-override
Change-Id: I5f7ab4c7eb106fc7bc0d93abc78ab9168c6867a6
2015-07-16 10:29:45 +02:00
Szymon Kłos
84d266fa83 RemoteFilesDialog: remember last used service
Change-Id: I494b1d43d28d8e6c37ce9d391b37580be6a9be31
2015-07-16 09:53:55 +02:00
Szymon Kłos
2239b486bf RemoteFilesDialog moved to fpicker
Change-Id: I8e978d40ee022d15f482aec4567c3171b75b9720
2015-07-16 09:53:52 +02:00