Andrea Gelmini
e07606fdd0
Fix typos
...
Change-Id: Ia30f466d08a9366b527225bbc0965f85881c7431
Reviewed-on: https://gerrit.libreoffice.org/43714
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2017-10-23 15:17:01 +02:00
Noel Grandin
f2964b9cdb
convert SfxGroupId to scoped enum
...
in the process I had to teach the idl compiler to cope with identifiers
like SfxGroupID::Math, which has the side effect of requiring a space
before a ':' in some of the .sdi files.
Change-Id: If256599cb8aa1dfc0a33642c5070c5560702f3ba
Reviewed-on: https://gerrit.libreoffice.org/40441
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-26 11:42:49 +02:00
Noel Grandin
41dc56df37
loplugin:constparams codemaker,idl,idlc
...
Change-Id: Ic72b7525cfbfbd3c5afb12fe9ea814176e6c8c9d
Reviewed-on: https://gerrit.libreoffice.org/40126
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-18 13:27:45 +02:00
Noel Grandin
8c77b5670e
use OString::operator== in preference to ::equals
...
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf
Reviewed-on: https://gerrit.libreoffice.org/39646
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-06 20:23:09 +02:00
Johnny_M
c6f4fd1942
tdf#39468 Translate German comments and dbg strings (leftovers in h.. to i..)
...
Translates all (leftovers) found using a custom regex, in directories not shown by
/bin/find-german-comments and beginning with "h" to "i".
Additionally:
- Fixed a few spellings
Change-Id: I54ea06f8e0cf1bd4bd6c84b171bec1bd342a8df8
Reviewed-on: https://gerrit.libreoffice.org/38390
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2017-06-06 13:51:55 +02:00
Noel Grandin
ef513fd4b0
remove unnecessary use of OString::getStr
...
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-28 19:44:08 +02:00
Caolán McNamara
fd24dd469d
coverity#1403731 Explicit null dereferenced
...
Change-Id: Ia8d183fbf1c80964eabc10f1e363333133a4181c
2017-05-12 09:28:12 +01:00
Jochen Nitschke
959496794c
cleanup osl/diagnose.h includes
...
with command
> git grep -l osl/diagnose.h *.cxx |
xargs grep -L -w 'OSL_\w*' |
xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'
headers need more work
Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-05-09 15:41:46 +02:00
Jochen Nitschke
b3eb843766
cleanup tools/debug.hxx includes
...
with command
> git grep -l tools/debug.hxx |
xargs grep -L DBG_ |
xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'
don't change files in includes/ and */pch
Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-08 08:33:01 +02:00
Noel Grandin
a12dfa3531
create SfxGroupId based on o3tl::strong_int
...
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71
Reviewed-on: https://gerrit.libreoffice.org/37108
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-02 08:18:14 +02:00
Maxim Monastirsky
c2f7c567b7
svidl: Adapt to SlotType removal
...
No diff in workdir/SdiTarget.
BEWARE: If you're going to revert this for whatever
reason, you should also revert the previous commit
that removed the SlotType property from sdi files!
Change-Id: I78cc391a6b47f4672157926eba1b55e786f48f2d
2017-05-01 01:30:44 +03:00
Maxim Monastirsky
20f33eb7c5
svidl: Remove nested method support
...
No diff in workdir/SdiTarget.
Change-Id: I53e974c8ccafbbc3675f67b87a0e1b8ff19b6790
2017-05-01 01:28:02 +03:00
Noel Grandin
3a36cf434f
loplugin:checkunusedparams in configmgr and vcl
...
Change-Id: I7226d01f38e6edaf3868d7267d9b02dbdbc9e5ba
Reviewed-on: https://gerrit.libreoffice.org/36975
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-28 08:32:56 +02:00
Caolán McNamara
aa434253d2
coverity#1403731 Explicit null dereferenced
...
Change-Id: I6025e6d4307aa8a6e4b6338d62bc597dace0ac9e
2017-04-03 10:18:44 +01:00
Caolán McNamara
da1d5307c3
use weak attribute for Linux too
...
Change-Id: If6bad5be57c984930061629077b07eee287202f0
2017-04-01 14:54:22 +01:00
Jens Carl
ad3681df0a
tdf#39468 Translate German comments
...
Translate German comments and terms in dbaccess/, forms/, fpicker/, framework/,
and idl/
Change-Id: I08b3db9492f16fc1c457e8f5eff838c13561c945
Reviewed-on: https://gerrit.libreoffice.org/35888
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-30 10:27:35 +00:00
Noel Grandin
7097037d5a
remove enum slot code from sfx2
...
since we only used it for the pseudo-slot stuff, which is now gone
Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a
Reviewed-on: https://gerrit.libreoffice.org/35759
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-28 08:25:18 +00:00
Noel Grandin
71403558cb
remove PseudoSlot support from idl compiler
...
Since we have removed the last usage with
commit 12c6caa84a
"Kill remaining PseudoSlots usage"
And remove corresponding support from the list-dispatch-commands script.
Also remove the now unused SFX_NEW_SLOT_ENUM macro
Change-Id: Id07c431de4404acf61a8bdd3507e390e5249879a
Reviewed-on: https://gerrit.libreoffice.org/35754
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-28 08:24:51 +00:00
Noel Grandin
2fc5ef74c5
remove unhandled SID commands from sfx2
...
Change-Id: I5473dbb1fdc2c3779892610ab4ea5f6146291921
Reviewed-on: https://gerrit.libreoffice.org/35742
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-28 06:41:25 +00:00
Stephan Bergmann
6291574d94
Remove unused #include <ctype.h>
...
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23 17:55:31 +01:00
Stephan Bergmann
254c13265f
Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)
...
Change-Id: I94b4cd3860b1b8740965373ee0b254a0415c8b4c
2017-03-23 07:35:01 +01:00
Noel Grandin
e9c7d259e8
create SfxDisableFlags enum
...
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f
Reviewed-on: https://gerrit.libreoffice.org/35514
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-22 06:46:10 +00:00
Noel Grandin
4978328534
convert method names in tools::SvRef to be more like our other..
...
reference classes, uno::Reference and rtl::Reference.
Specifically rename Is()->is() and Clear()->clear().
Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae
Reviewed-on: https://gerrit.libreoffice.org/33576
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-02-02 08:02:54 +00:00
Noel Grandin
1a743fd8a2
loplugin:expandablemethods in hwpfilter..linguistic
...
Change-Id: I62ae20ab4a47b3b7e2b0d503cedcad3319cc9c85
Reviewed-on: https://gerrit.libreoffice.org/30683
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-08 08:41:38 +00:00
Noel Grandin
88ec5de1c9
expand SvMetaType::ReadNamesSvIdl
...
it just forwards to ReadNameSvIdl
Change-Id: I803edb7a5977cf309e2cedaa3b4764bcbd933597
2016-10-26 11:56:21 +02:00
Noel Grandin
877774c057
loplugin:expandablemethodds in hwpfilter..linguistic
...
Change-Id: If20fd4a6cf8a8e005804dbb7caf41cce73d587a5
Reviewed-on: https://gerrit.libreoffice.org/30016
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-19 08:07:18 +00:00
Noel Grandin
62223f9a8a
loplugin:unnecessaryoverride
...
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-13 06:47:44 +00:00
Jacek Fraczek
f004aa9951
tdf#89307: Removed SvRef::operator T*()
...
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.
SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.
Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-10-10 08:48:30 +00:00
Noel Grandin
4d87443bf5
loplugin:constantparam
...
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c
Reviewed-on: https://gerrit.libreoffice.org/29321
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-09-30 06:57:26 +00:00
Caolán McNamara
bcf8f87889
remove IMAGEROTATION and IMAGEREFLECTION SfxSlotMode enums...
...
unused since...
commit 7affe26a12
Author: Maxim Monastirsky <momonasmon@gmail.com >
Date: Mon Feb 22 18:47:15 2016 +0200
Kill sfx2 menu support
Change-Id: I902957b8379be7c314f5357750aeba5a2fcc0a00
Reviewed-on: https://gerrit.libreoffice.org/28749
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2016-09-08 21:01:31 +00:00
Noel Grandin
3e53c6ba93
move the attribute parsing code to SvParser
...
and simplify considerably
Change-Id: I2a4af15e77904b62abc81dad78a2990e2eab05f0
2016-06-22 09:27:15 +02:00
Noel Grandin
f3c1d240bd
loplugin:constantparams
...
Change-Id: Ib162ba9297b9d900ea42c7e5216e152d3e58a361
Reviewed-on: https://gerrit.libreoffice.org/25769
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-03 09:08:42 +00:00
Noel Grandin
43b4903db3
teach stylepolice plugin about ref-counted-pointer naming
...
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752
Reviewed-on: https://gerrit.libreoffice.org/24459
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-28 09:31:16 +00:00
Noel Grandin
5b79f5a4e5
loplugin:constantparam in idl
...
Change-Id: I2fa4c74c9709d3a8495341f00d974ba960c18deb
2016-03-23 10:19:43 +02:00
Julien Nabet
33b2d58895
Remove some unused include stdio
...
Change-Id: Ifdb9d133237eecd3132dffb0f85c005beac169d2
Reviewed-on: https://gerrit.libreoffice.org/23174
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-12 14:43:17 +00:00
Noel Grandin
20276795b7
small cleanups in .SDI parser
...
Change-Id: Ic7122e3ecfe2914e27945fd508199f7ec1d6bdab
2016-02-23 10:07:09 +02:00
Noel Grandin
c45d3badc9
new loplugin: commaoperator
...
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-23 08:08:56 +02:00
Noel Grandin
314cb543fe
parse shell/interface entries in SvIdlParser
...
Change-Id: Ief68b26be0a0890ffdfa02a5904ba9d2cb364c65
2016-02-16 11:59:05 +02:00
Noel Grandin
f7520bbc80
move interface/shell parsing to SvIdlParser
...
Change-Id: I95cce21c6c9beb5637dd4f4a769f455eaacbec2b
2016-02-15 15:47:30 +02:00
Noel Grandin
ac43283932
move item and struct parsing into SvIdlParser
...
Change-Id: I1ba88bca82b5b251ed34330ab5e0cb8bd88a5815
2016-02-15 15:47:30 +02:00
Noel Grandin
b27dcabad3
move parsing of enum into SvIdlParser
...
Change-Id: I89eef20d62f92f7345750c48c34c9f3b7bca287e
2016-02-12 09:13:43 +02:00
Noel Grandin
f3f533f0c6
move module parsing into SvIdlParser class
...
Change-Id: I99937935a1d41fa5b0ff6c2f5e92bde3b4847e9f
2016-02-12 09:13:43 +02:00
Noel Grandin
62225eeb98
bIsModified in SvMetaModule is unused
...
Change-Id: Idc6effddce9923f0d48a111b2a04458efc11ebf9
2016-02-12 09:13:43 +02:00
Noel Grandin
0c6d6aa47e
rename Read()->ReadIf() and ReadDelimiter()->ReadIfDelimiter()
...
Change-Id: I589dc0280c5bb587aa024b0f1dcf0b623d719aa4
2016-02-12 09:13:43 +02:00
Noel Grandin
8db11c9056
fix dead code warning on Windows
...
Change-Id: I7b23442b34c7f2dcc2c44c33613fb66e6eb1b14b
2016-02-11 15:27:09 +02:00
Noel Grandin
4e13a69112
use exceptions for error handling in .SDI parsing
...
to simplify the normal control flow
Change-Id: If325ec0507a51d8e2d3340fc5b628bb75a078a44
2016-02-11 14:47:01 +02:00
Noel Grandin
09d58f7be8
GetToken never returns null, so use a reference
...
Change-Id: I0164e546b0ee0b40acc7b9253d3c0ecded97280c
2016-02-11 14:47:01 +02:00
Noel Grandin
cf6c21e7f1
ReadDelemiter->ReadDelimiter
...
Change-Id: I311eb27e3d287f3ef409cb54f19a152793f940d9
2016-02-11 10:03:18 +02:00
Noel Grandin
d542cf3e63
spelling
...
Change-Id: Ic6464cd4d2c4fdb302f6337719ad937c0d3f8135
2016-02-11 10:01:46 +02:00
Noel Grandin
81372804ae
simplify some OStringBuffer code
...
Change-Id: Ic1b0e13a8d77154fa780f6804ee36b5a5d9c7334
2016-02-11 10:01:45 +02:00