Commit Graph

132 Commits

Author SHA1 Message Date
Stephan Bergmann
0a938e7859 loplugin:includeform: jvmfwk
Change-Id: I7292ced23647692fdc85a3c234fb1469a91ad0ea
2017-10-23 22:46:03 +02:00
Julien Nabet
2ea531c057 Use loop ranges in jvmfwk
to simplify and avoid all the typedefs

Change-Id: Ia14337dd71b55fc24f162b5436af76aeeb8d2575
Reviewed-on: https://gerrit.libreoffice.org/43346
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-13 00:19:34 +02:00
Noel Grandin
7ca4ea54b4 clang-tidy modernize-use-emplace in hwpfilter..lotuswordpro
Change-Id: Ic11634ca28396fd156390c511087bae03bd5fb70
Reviewed-on: https://gerrit.libreoffice.org/42156
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-11 13:50:50 +02:00
Noel Grandin
8c77b5670e use OString::operator== in preference to ::equals
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf
Reviewed-on: https://gerrit.libreoffice.org/39646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06 20:23:09 +02:00
Noel Grandin
4d162d8222 cleanup some OString stuff in jvmfwk
Change-Id: I80d221a348c4bd5fcec82cafc455a051237ae95d
Reviewed-on: https://gerrit.libreoffice.org/38131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30 08:56:39 +02:00
Chris Sherlock
97eb00c75e revert OSL_ASSERT changes
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07 17:03:35 +10:00
Chris Sherlock
3cf126d701 tdf#43157: convert jvmfwk from OSL_ASSERT to assert
Change-Id: Ie06633dd6a49ed9fc51dfb5e6066529020dcf268
2017-05-07 08:18:25 +10:00
Stephan Bergmann
f276171835 Use std::unique_ptr<JavaInfo> in jfw_plugin_getAllJavaInfos
Change-Id: I2beb95c42c666a788a87a45f59bc15ccfcf25aa6
2017-04-13 17:32:44 +02:00
Stephan Bergmann
8d475bb13f Use std::unique_ptr<JavaInfo> in jfw_plugin_getJavaInfoByPath
Change-Id: I3511eaa12bb689a374a775204a3480d7c667a915
2017-04-13 17:32:43 +02:00
Stephan Bergmann
74315cbccf Use std::unique_ptr<JavaInfo> in jfw_plugin_getJavaInfoFromJavaHome
Change-Id: I8be48d1eec799f347a5edaa67837cf1bbf4d2cc3
2017-04-13 17:32:43 +02:00
Stephan Bergmann
626dec44e3 Use std::unique_ptr<JavaInfo> in jfw_plugin_getJavaInfosFromPath
...thereby fixing a memory leak

Change-Id: I1aa91eeb407987abcdaa5221f4abd447f881c5d2
2017-04-13 17:32:43 +02:00
Stephan Bergmann
6925007c2a Simplify jfw_findAllJREs
...dropping remaining uses of CJavaInfo

Change-Id: I76afd5af927233712181f58b14fe6f4c1a9c15c2
2017-04-13 17:32:43 +02:00
Stephan Bergmann
77e5a6d857 Replace a use of CJavaInfo with std::unique_ptr<JavaInfo>
Change-Id: Ib659d6edf362901a95cfb50ac008520805ad0fb0
2017-04-13 17:32:43 +02:00
Stephan Bergmann
2767dcc7b2 Replace a use of CJavaInfo with std::unique_ptr<JavaInfo>
Change-Id: I89cb19969285200a61c47d29e819a50845fa692b
2017-04-13 17:32:43 +02:00
Stephan Bergmann
41a20d3b37 More std::unique_ptr<JavaInfo> lifecycle management
Change-Id: If53347633ec4b2f8c2b221ba2057e0c38fa97b67
2017-04-13 17:32:42 +02:00
Stephan Bergmann
1a2afa01c9 Simplify passing options to jfw_startVM
Change-Id: Idac31e282fe4df69449298a03d491473e460c742
Reviewed-on: https://gerrit.libreoffice.org/36495
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13 07:47:48 +02:00
Andrea Gelmini
3c3f7d784e Removed duplicated includes
No automatic tools. Manual checked and tested.

Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754
Reviewed-on: https://gerrit.libreoffice.org/36371
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-13 07:46:16 +02:00
Stephan Bergmann
9b157d37f1 Remove unused jfw::VendorSettings instantiations
Change-Id: I0af90fbb9eb77e5e65b29a79cc3b37af8cfc75e6
2017-04-12 09:36:20 +02:00
Stephan Bergmann
598f788116 Remove unnecessary copy
Change-Id: Ib350999ddf3ed2753b9e615a07b963c459dc714b
2017-04-12 09:36:20 +02:00
Stephan Bergmann
f1bbafc584 Convert rtl_uString -> OUString in jfw_get/setVMParameters
Change-Id: I55f96873661f686cd9625d69523718ccb54659dc
2017-04-12 09:36:20 +02:00
Stephan Bergmann
61f43d0327 Simplify jfw::VersionInfo
Change-Id: I2cc1071bbaf9c68fbd621d6c0c6953b7646b1a62
2017-04-12 09:36:20 +02:00
Stephan Bergmann
346b5cfd90 Convert some rtl_uString -> OUString in jvmfwk
Change-Id: I08de5cab29dabc6fd824d5df8bac12c8520a05ae
2017-04-12 09:36:20 +02:00
Stephan Bergmann
59fddf430f Calls to jvmfwk/framework.hxx must not pass in null, drop JFW_E_INVALID_ARG
Change-Id: Iff4b8ccc79e194f645791ac73818e3b677ae32a6
2017-04-11 19:10:48 +02:00
Stephan Bergmann
40677a2909 Fix missing deref
...lacking since recent f0454e72c1 "Use
std::unique_ptr<JavaInfo> for lifecycle management in jvmfwk/framework.hxx"

Change-Id: Ied39be52ccc8cbef48cdfb4933e4ac1914fd0fd3
2017-04-11 18:59:13 +02:00
Stephan Bergmann
7635e0c1c7 sal_Bool -> bool
Change-Id: If632eb547aa5082ad13eac8c2ad39a1742309fc7
2017-04-11 18:38:51 +02:00
Stephan Bergmann
33cf2b6613 Let jfw_isVMRunning return the result; there are no error conditions
Change-Id: I004b3d6f6b7b32d1bb41072d7fdd4a66f944d992
2017-04-11 18:33:31 +02:00
Stephan Bergmann
16f29aa720 sal_Bool -> bool
Change-Id: Iec70d6726e36af607a0a5b5a0f6dc86d05322435
2017-04-11 18:28:43 +02:00
Stephan Bergmann
15c98f1740 jfw_existJRE requires non-null args, never returns JFW_E_INVALID_ARG
Change-Id: I2067b77393427a5a6a4273c2f609ff8d335f436a
2017-04-11 18:25:04 +02:00
Stephan Bergmann
583508ced2 sal_Bool -> bool
Change-Id: I8df49f349308cc17d684d5c0e8215aa628dfaeda
2017-04-11 18:18:42 +02:00
Stephan Bergmann
f0454e72c1 Use std::unique_ptr<JavaInfo> for lifecycle management in jvmfwk/framework.hxx
Change-Id: Ie604c75e92c407ff3118aaa58155648d956c91fb
2017-04-11 18:04:54 +02:00
Stephan Bergmann
a730dc1b56 Remove unnecessary jfw::CJavaInfo::cloneJavaInfo
Change-Id: Ia9e807c0d1e5b0664d711c551a5e70afccbcc564
2017-04-11 15:07:42 +02:00
Samuel Mehrbrodt
64a50fc271 Typo: requirments -> requirements
Change-Id: I02c5846eb51071e1a958c3d65e150fb7cbc7d58a
Reviewed-on: https://gerrit.libreoffice.org/34873
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-03 16:43:59 +00:00
Stephan Bergmann
36c8fd8995 Clean up jfw_findAllJREs return value computation
Change-Id: Iace2281ec4b5cfaa6e1de44b58a6705ca3a18c58
2016-11-16 23:47:09 +01:00
Stephan Bergmann
1ccc7c425b clang-cl loplugin: jvmfwk
Change-Id: I4ae0795469e70d6be3d2052d96a2f0dad3920d8b
Reviewed-on: https://gerrit.libreoffice.org/29860
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-16 14:18:35 +00:00
Noel Grandin
57ef4457be Convert javaPluginError to scoped enum
Change-Id: Ib3a32227d50fa9e0f9cc4106ce40a4c3e840f8c7
Reviewed-on: https://gerrit.libreoffice.org/25206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22 17:52:41 +00:00
Stephan Bergmann
f43b89b7ed loplugin:salbool: Automatic rewrite of sal_False/True
Change-Id: I65fdd933e2a3973053359024d8d9c733f79a6477
2016-04-20 17:25:43 +02:00
Stephan Bergmann
8e9a7cac42 No more need for jfw_freeJavaInfo
Change-Id: I2426a76936b4099a243ce8c102da867e7868aac3
2016-03-10 21:42:31 +01:00
Stephan Bergmann
8546831b3b Turn JavaInfo sal_Sequence* member into rtl::ByteSequence
Change-Id: Iecd476970b0b7a46afe223f71e95b0010048d7b1
2016-03-10 21:41:24 +01:00
Stephan Bergmann
5dcdb35ab1 Turn JavaInfo rtl_uString* members into OUString
Change-Id: Ieb23b0c36ef56a4793a56cdb450df34e4d9bce1d
2016-03-10 21:41:24 +01:00
Stephan Bergmann
81dd7115e8 Manage JavaInfo instances via new/delete
Change-Id: I10a113718e525b646c51aa8a19f9f2b75a36714a
2016-03-10 21:41:23 +01:00
Stephan Bergmann
bf6c5c9b0f No need to repeat SAL_CALL in definitions
Change-Id: Ief75af9d08d9b7e31d821773db2363fa201f3038
2016-03-10 21:41:23 +01:00
Stephan Bergmann
8471ba7b97 No need for extern "C" here
...and fix resulting loplugin:salbool fallout

Change-Id: I5ae1497608d31c20b0d10676450a7673dee1c651
2016-03-10 21:41:22 +01:00
Stephan Bergmann
220d9c24d0 include/jvmfwk/*.h -> .hxx (only ever included from C++ code)
Change-Id: Ia912e937d5a48afb6f8f5345b20bb7bd517fc4f1
2016-03-09 19:08:29 +01:00
Noel Grandin
2087484c65 use consistent #define checks for the Windows platform
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17 11:33:57 +00:00
Stephan Bergmann
8980565881 loplugin:nullptr (automatic rewrite)
Change-Id: I9dfcec9488b2a25e32d3934766d6d4b208a8c2dc
2015-11-10 10:31:30 +01:00
Noel Grandin
644487a115 loplugin:unusedmethods
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861
Reviewed-on: https://gerrit.libreoffice.org/19231
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27 08:20:43 +00:00
Stephan Bergmann
a52ad6b1cc loplugin:simplifybool
Change-Id: Iaa3c04ba936512f511de238f5a3ca5b0f9afc06d
2015-07-16 14:00:18 +02:00
Takeshi Abe
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]>
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17 15:50:45 +00:00
Stephan Bergmann
62ee548b8c loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I62a6714749eba8226ba3a5416ee81f2d76cf0afc
2015-06-08 16:25:58 +02:00
Stephan Bergmann
863bfb2811 loplugin:cstylecast: deal with those that are (technically) const_cast
Change-Id: Ie8e3bde0eeeec6cd35a7f73f9a29c28cdd03ad02
2015-06-02 11:27:11 +02:00