Commit Graph

146 Commits

Author SHA1 Message Date
Julien Nabet
092adc4991 Typos
Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5
Reviewed-on: https://gerrit.libreoffice.org/33904
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-03 21:55:50 +00:00
Laurent Balland-Poirier
0412d863d1 tdf#104268 NLPSolver: Improve display of solution
Format "%.2f" is not optimal for large or small values.
Format "%g" should be prefered.

Change-Id: I92899d80564b9000b1f3e049221c456f8e1176a9
Reviewed-on: https://gerrit.libreoffice.org/31445
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12 12:26:35 +00:00
Stanislav Horacek
2536bd8b26 tdf#103622 do not use arrow as separator of menu commands
Change-Id: I15f1cb699107dc7e24d6ebef2e8f4d8f38dcd596
Reviewed-on: https://gerrit.libreoffice.org/30573
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-11-06 08:55:47 +00:00
Caolán McNamara
4d95bd6261 coverity#1326449 Dereference null return value
and

coverity#1326448 Dereference null return value

Change-Id: I8e26c9c57264b654a5a7c3dc56c658f23291e357
2016-01-21 15:15:52 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Caolán McNamara
612acf5400 coverity#1327027 SIC: Inner class could be made static
Change-Id: I9c36aa362e58de724c63b9d23334eabfc973ee42
2015-11-04 13:55:53 +00:00
Stephan Bergmann
115fa590dc More plausible fix
...for 7c465e7f9e "coverity#1326260 Explicit null
dereferenced"

Change-Id: I3b7fb8195c29b7e447fbe31f823cd00d7a820e95
2015-10-21 10:57:59 +02:00
Caolán McNamara
7c465e7f9e coverity#1326260 Explicit null dereferenced
Change-Id: I75b9cb661a7a45304bf32395ad980f83621f4612
2015-10-15 14:26:07 +01:00
Noel Grandin
a1624a8ecd cid#1327023 to cid#1327077 SIC: Inner class could be made static
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-15 09:23:16 +02:00
Noel Grandin
afe95a1d7a cid#1326608,cid#1326609 CN: Bad implementation of cloneable idiom
Change-Id: Iac74be96b47720ab105f862e7d1a69f909214294
2015-10-14 09:55:13 +02:00
Andrea Gelmini
5e985c2f34 Fix typos
Change-Id: I4452d4a4a4a61f39cd9c2b5a441c6c2017f15ce8
Reviewed-on: https://gerrit.libreoffice.org/19073
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-01 14:04:14 +00:00
Andrea Gelmini
ecf5384f75 Fix typos
Change-Id: I04d1bc3a9f38ff7871d3192563cd1f649fdc6cea
Reviewed-on: https://gerrit.libreoffice.org/18960
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-01 11:37:50 +00:00
Andrea Gelmini
ac22644352 Fix typos
Change-Id: I021589aeca9ef6bceb1c828c2197f5ff58f85b09
Reviewed-on: https://gerrit.libreoffice.org/18707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-09-18 22:06:21 +00:00
Andrea Gelmini
1a8915ef83 Fix typos
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30 15:57:12 +00:00
Noel Grandin
efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Noel Grandin
ba233e87ef remove unnecessary parenthesis in return statements
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
LeMoyne Castle
c290998df6 tdf#87074 null-ref error from NLPSolver in Basic
Initialize java class member objects exposed as
XSolver properties: no default construction in java.
Fixes issue for both DEPS and SCO solvers.
Also removed info level console prints.

Change-Id: I6762c5cca978072ce20b1f69a6b523f53364107d
Reviewed-on: https://gerrit.libreoffice.org/14499
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-17 06:21:19 +00:00
Noel Grandin
43cc8ad33e java: remove dead code
found by UCDetector

Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
Noel Grandin
126eea88e6 java: nlpsolver: getPropertyByName was checking the wrong datastructure
Found by PMD

Change-Id: I76d38d71a3379416fe7e5078ef8b121915b26b6b
2014-12-19 10:41:55 +02:00
Noel Grandin
7557f23b31 java: reduce visibility of fields and methods
found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11 06:09:03 +00:00
Noel Grandin
c199b76d88 java: remove some unused local variables
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05 11:15:57 +02:00
Noel Grandin
db203e59d6 java: remove some unused fields
Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
2014-12-05 11:15:56 +02:00
Noel Grandin
58eab57648 java: final fields that can be static
found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25 06:06:48 +00:00
Noel Grandin
0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
Noel Grandin
79c6aff069 java: fix some javadoc errors
Eclipse was flagging this text as "invalid javadoc tags"

Change-Id: I09e090c6cc49366191f96d34bd51f6ba68cf18aa
Reviewed-on: https://gerrit.libreoffice.org/12524
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18 08:07:14 +00:00
Noel Grandin
bb437029c1 java: convert fields to local variables where possible
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:03:29 +00:00
Noel Grandin
36ff1527c9 java: reduce excessive code indentation levels
by using early return in some methods

Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7
Reviewed-on: https://gerrit.libreoffice.org/12374
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 08:01:55 +00:00
Noel Grandin
03c7c26cbe java: final fields that can be static
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
Noel Grandin
fa22664be2 java: always use braces for while loops
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16 08:15:52 +02:00
Robert Antoni Buj i Gelonch
88bfc90de9 nlpsolver: ensure that the stream is cleaned up before the method returns
Change-Id: I081194d802bd835285bdc37fbef55f229f1185dc
Reviewed-on: https://gerrit.libreoffice.org/11940
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13 06:56:56 +00:00
rbuj
bc796af285 nlpsolver: fix javadoc error: bad use of '>'
Change-Id: Ibfaeef155982ce6eeefe8ef51eea9c2bddb12c46
Reviewed-on: https://gerrit.libreoffice.org/11244
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:17:16 -05:00
Noel Grandin
0ce1267ae2 remove more unnecessary constructor declarations
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20 12:12:43 +02:00
Noel Grandin
c0415d5f1e java: remove unnecessary constructor declarations
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
Noel Grandin
8c9fdc4a96 java: remove modifiers implied by the context
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
Noel Grandin
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
Noel Grandin
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
Noel Grandin
3a8d351988 java: remove unused methods
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
Noel Grandin
0d916bb240 java: remove unused imports
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
Noel Grandin
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
Noel Grandin
5ce80c9728 remove dead java constants
found by UCDetector

Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
2014-08-13 13:34:43 +02:00
Noel Grandin
5ca7fa8db2 make some java fields private
found by UCDetector

Change-Id: Ib4cf18be134c3177cb123191e963bb43b7e6de93
2014-08-13 13:34:42 +02:00
Noel Grandin
34bcf9b498 java: remove dead methods
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
Noel Grandin
b20a5c7be0 fix makefile
after my commit  cc6bd12  "java: remove unused enum values"

Change-Id: I9f2f151c0c9a40f39fc235fa65b8324b9cb40027
2014-08-13 09:44:18 +02:00
Noel Grandin
cc6bd12542 java: remove unused enum values
found by UCDetector

Change-Id: Ic07be7e34204b5d838a722e1ce6038506a771144
2014-08-13 08:49:24 +02:00
Noel Grandin
8583da1e93 java: remove unused fields
found by UCDetector

Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13 08:49:24 +02:00
Noel Grandin
68cd011c90 java: reduce scope, make some methods private
found by UCDetector

Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
Noel Grandin
70f56bc22f java: reduce scope, make member classes private
found by UCDetector

Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
Noel Grandin
da677dfd59 java: reduce scope, make fields private
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
Noel Grandin
14d1a11ec4 java: reduce scope, make constructors private
found by UCDetector

Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
Noel Grandin
e701b3f732 java: reduce scope, make constants private
found by UCDetector

Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12 12:16:37 +02:00