mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
414,416 Commits 1 Branch 0 Tags
cb151051d79a7ec176e769a33a56e7d906fc1425
Commit Graph

299 Commits

Author SHA1 Message Date
Stephan Bergmann
426a2527e7 loplugin:includeform: svgio 
Change-Id: I5832529b0200295cc54a85dff42bf5692bd59ab5
 2017-10-23 22:45:51 +02:00
Noel Grandin
87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Noel Grandin
2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Tor Lillqvist
8e7897588d Rename the basegfx::tools namespace to basegfx::utils 
Reduce potential confusion with the global tools namespace. Will
hopefully make it possible to remove the annoying initial :: when
referring to the global tools namespace. Unless we have even more
tools subnamespaces somewhere.

Thorsten said it was OK.

Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996
Reviewed-on: https://gerrit.libreoffice.org/42644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-09-26 14:18:41 +02:00
Mike Kaganski
cf48347e7a Fresh run of bin/update_pch.sh 
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06
Reviewed-on: https://gerrit.libreoffice.org/42565
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-09-22 21:01:49 +02:00
Noel Grandin
48b200a0a2 clang-tidy modernize-use-emplace in svgio..svtools 
Change-Id: I4f3b0762e197d5397e723aba1dc43e3c857be145
Reviewed-on: https://gerrit.libreoffice.org/42193
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-12 13:15:40 +02:00
Stephan Bergmann
66604baf08 Consistently use OUString in test::Directories 
Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2
Reviewed-on: https://gerrit.libreoffice.org/41466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-08-24 09:28:32 +02:00
Noel Grandin
ff1f6a5fc2 remove UL/L suffixes from integer constants in initialiser/call expressions 
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300
Reviewed-on: https://gerrit.libreoffice.org/41214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 08:14:31 +02:00
Noel Grandin
65c69af584 loplugin:constparams in svgio 
Change-Id: I35dd8b1373ce3c46a10b1da1ddc6dc3722ffa760
Reviewed-on: https://gerrit.libreoffice.org/40245
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-21 08:37:21 +02:00
Noel Grandin
db3860062e extend loplugin useuniqueptr to OUString pointers 
Change-Id: Ieb5bab3895e1edaff497c4a1a88303ccac097edc
Reviewed-on: https://gerrit.libreoffice.org/39948
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-17 07:23:22 +02:00
Armin Le Grand
83535a28c5 emfplus: create a wmf/emf/emf+ primitive based importer 
First steps to organize an importer that can read/interpret
wmf/emf/emf+ and deliver a primitive representation for
the content by parsing it. Use the same mechanisms as
already applied for Svg, so to reuse abilities to keep
original binary data to allow save again and embedding in
files and have an implemented replacement bitmap based
representation. For this, unify the used helper classes
to handle more than just Svg. For 1st try, add test code
and static bool switches

Change-Id: I6e0a82943541d811a8f8d65a84115569fcd8cee7
 2017-07-15 11:01:29 +02:00
Noel Grandin
6af025501d use more OUString::operator== in sfx2..svtools 
Change-Id: I859b77319f551eabd19dae54bd69c212221112a8
Reviewed-on: https://gerrit.libreoffice.org/39938
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-14 10:19:27 +02:00
Noel Grandin
8e39ef6692 extend loplugin useuniqueptr to POD types 
Change-Id: I6ff24f048bd8f75bf87a78b718f37b57855d4781
Reviewed-on: https://gerrit.libreoffice.org/39932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-14 10:13:46 +02:00
Caolán McNamara
5ef84bde43 bah, wrong reset 
Change-Id: Iaee7f4f038000c7009c9c74b822b7599559f09ca
 2017-07-13 16:53:04 +01:00
Caolán McNamara
304b16c3bf Resolves: tdf#108903 avoid recurse to death 
Change-Id: Iadde719a024c5fce97aa0f4c58947a5012639a84
Reviewed-on: https://gerrit.libreoffice.org/39918
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-07-13 17:30:58 +02:00
Noel Grandin
8dca2d5ac7 loplugin:oncevar in starmath..svl 
Change-Id: I20e3796407c7e429a88d2811673929ac1141a41c
Reviewed-on: https://gerrit.libreoffice.org/39280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-27 08:42:53 +02:00
Noel Grandin
18f5131454 loplugin:unusedfields store..svl 
Change-Id: I6070a683e5128271b84a10caccb548d07c950927
Reviewed-on: https://gerrit.libreoffice.org/39021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-21 08:43:05 +02:00
Noel Grandin
e4e4d5713e clang-tidy readability-delete-null-pointer 
which in turn triggered some loplugin:useuniqueptr

Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64
Reviewed-on: https://gerrit.libreoffice.org/38281
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-12 08:43:48 +02:00
Jochen Nitschke
16ce815df3 cppcheck: knownConditionTrueFalse 
Change-Id: I231113eaf3117e13ed18de906e3787643abe9335
Reviewed-on: https://gerrit.libreoffice.org/38423
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-06 08:25:21 +02:00
Noel Grandin
0265bdb92e convert GRFILTER constants to ERRCODE_GRFILTER_ 
since various code mixes these constants in with ErrCode values from
other code, let us just make it into real ErrCode values.

Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95
Reviewed-on: https://gerrit.libreoffice.org/38313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-02 09:00:13 +02:00
Noel Grandin
ef513fd4b0 remove unnecessary use of OString::getStr 
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-28 19:44:08 +02:00
Noel Grandin
44752e2627 loplugin:checkunusedparams in svgio 
Change-Id: I2e05fc51715902737ead6e57d0fbe167d715b822
Reviewed-on: https://gerrit.libreoffice.org/37194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-04 08:42:40 +02:00
Jochen Nitschke
58ac61478a remove empty namespaces 
Change-Id: I3eae0ecc1ffc5500d3c55abc6554822f5432a50a
Reviewed-on: https://gerrit.libreoffice.org/37173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-03 09:10:21 +02:00
Stephan Bergmann
c22ecc1867 loplugin:salunicodeliteral: svgio 
Change-Id: I98461a30c14d3939e8fd5313a49aa478b39df1c3
 2017-04-28 18:26:56 +02:00
Noel Grandin
9348b322a5 clang-tidy readability-simplify-boolean-expr 
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a
Reviewed-on: https://gerrit.libreoffice.org/36450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-28 11:23:34 +02:00
David Ostrovsky
de030cd7a2 gbuild: Remove MSVC 2013 legacy code 
Uwinapi is discontinued.

Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01
Reviewed-on: https://gerrit.libreoffice.org/23198
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
 2017-04-21 18:18:44 +02:00
Andrea Gelmini
3ffc206a4b Fix typos 
Change-Id: Ib25dadb25d8c2df1361de194f74cf3ddd459650d
Reviewed-on: https://gerrit.libreoffice.org/34783
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-03 06:54:05 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Noel Grandin
2da34e265d new loplugin: useuniqueptr: svgio 
Change-Id: I645ac954ac519fe713f4347cdf69780b0f8070e4
Reviewed-on: https://gerrit.libreoffice.org/33252
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-19 05:40:55 +00:00
Xisco Fauli
5903235d57 tdf#104339 Partially revert d5649ae7b7 
Change-Id: I5160c6efe7cf58351955d9d1d3066e3b33bdfe20
Reviewed-on: https://gerrit.libreoffice.org/32082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
 2016-12-19 00:10:09 +00:00
Noel Grandin
bfde4866e0 convert DecodeMechanism to scoped enum 
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
 2016-12-05 12:49:02 +02:00
Stephan Bergmann
b610d25131 loplugin:unnecessaryoverride (dtors) in svgio 
Change-Id: Icff1b3d5072c9a854de7ae12141131b0a9650b91
 2016-12-02 11:15:42 +01:00
Noel Grandin
3a54589302 convert Primitive2DContainer to std::deque 
since we only care about appending to this container, and then
traversing it (normally once). So reduce the re-allocations that
std::vector requires

Change-Id: I206a7b82d9eefc1fa3762c4a03e7b5e21136951f
Reviewed-on: https://gerrit.libreoffice.org/30706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-09 08:54:01 +00:00
Noel Grandin
9bdec0831a loplugin:oncevar in sd..svgio 
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c
Reviewed-on: https://gerrit.libreoffice.org/30459
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-01 13:25:08 +00:00
Noel Grandin
c19d2b276b loplugin:expandablemethods in stoc..svl 
Change-Id: I7dd701ef07a14f70589b87154bfeeda7530b628f
Reviewed-on: https://gerrit.libreoffice.org/30316
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-27 10:16:08 +00:00
Noel Grandin
58072c5a7f loplugin:expandablemethodds in svgio 
Change-Id: Iac2aa6dae56d96819589d198be5875ecfe14f26f
Reviewed-on: https://gerrit.libreoffice.org/30056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-20 06:14:11 +00:00
Noel Grandin
62223f9a8a loplugin:unnecessaryoverride 
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-13 06:47:44 +00:00
Noel Grandin
e592877844 loplugin:unusedenumvalues 
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b
Reviewed-on: https://gerrit.libreoffice.org/28942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-18 11:02:45 +00:00
Michael Stahl
b647996a9b replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos) 
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.

Change-Id: I8344453780689f5120ba0870e44965b6d292450c
 2016-09-15 12:01:11 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Tor Lillqvist
714de95ec5 Remove nonsense comments: // bitfield 
Surely the actual bitfield syntax is enough to tell the code reader
that it is a bitfield.

Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
 2016-09-13 11:09:06 +03:00
Xisco Fauli
75003438e4 tdf#101237 SVGIO: Use black as default when parents' fill... 
...attributes are empty or none and there's a reference
to a clip-path present.

Change-Id: I4dc4e3bcaac43a007fbdb8a1d006cbd39c737396
Reviewed-on: https://gerrit.libreoffice.org/28500
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <anistenis@gmail.com>
 2016-08-30 20:41:07 +00:00
Jochen Nitschke
33b38082ca put StreamMode masks in scope of enum class 
Change-Id: I77682f7e289a59b986bb84edf014029a20266470
Reviewed-on: https://gerrit.libreoffice.org/28420
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-27 12:06:15 +00:00
Noel Grandin
a402785625 loplugin:countusersofdefaultparams in sfx2..svgio 
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0
Reviewed-on: https://gerrit.libreoffice.org/27903
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-05 11:56:06 +00:00
Noel Grandin
27319418ed loplugin:countusersofdefaultparams in store..svtools 
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6
Reviewed-on: https://gerrit.libreoffice.org/27580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-29 07:07:13 +00:00
Julien Nabet
b7a18f18ef tdf#101070: svg/insert, avoid infinite recursive loop when referencing oneself 
See bt https://bugs.documentfoundation.org/attachment.cgi?id=126377

Change-Id: I3c6546a5449fc42613e30a7f45f31862752b7187
Reviewed-on: https://gerrit.libreoffice.org/27468
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-07-24 14:20:15 +00:00
Xisco Fauli
ecb34112cc SVGIO: use clamp on strokeOpacity in case it's negative 
testcase: painting-stroke-08-t.svg

Change-Id: Ia09a4581e5189cbb88aca4391474ada89e7af042
testcase: painting-stroke-08-t.svg
Reviewed-on: https://gerrit.libreoffice.org/27326
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <anistenis@gmail.com>
 2016-07-20 08:53:39 +00:00
Noel Grandin
6e72f0251b new loplugin unnecessary override 
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-15 14:05:41 +00:00
Armin Le Grand
5046ebd813 tdf#82214 optimize PatternFillPrimitive and SVG 
Use buffering in the drawinglayer, and don't do slow stuff in the
windows gdi renderer.

Conflicts:
	svgio/source/svgreader/svgstyleattributes.cxx

Change-Id: Id955ee6a3b03e568c2678f02d77af35d2e5ba1d4
 2016-07-07 22:32:39 +02:00
Otto Kekäläinen
428e23f4f7 Fix some spelling errors in comments and strings 
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-07-04 06:11:36 +00:00