Commit Graph

1082 Commits

Author SHA1 Message Date
Noel Grandin
0ac9a10d31 fdo#46808, Deprecate configuration::ConfigurationProvider old-style service
...in favor of existing new-style configuration::theDefaultProvider singleton.

Theoretically, ConfigurationProvider instances can be created with specific
Locale and EnableAsync arguments, but this is hardly used in practice, and thus
effectively all uses of the ConfigurationProvider service use the
theDefaultProvider instance, anyway.

theDefaultProvider is restricted to the XMultiServiceFactory interface, while
ConfigurationProvider also makes available XComponent.  However, dispose must
not be called manually on theDefaultProvider singleton anyway, and calls to
add-/removeEventListener are so few (and in dubious code that should better be
cleaned up) that requiring an explicit queryInterface does not really hurt
there.

This commit originated as a patch by Noel Grandin to "Adapt
configuration::ConfigurationProvider UNO service to new style [by creating] a
merged XConfigurationProvider interface for this service to implement."  It was
then modified by Stephan Bergmann by deprecating ConfigurationProvider instead
of adding XConfigurationProvider and by replacing calls to
ConfigurationProvider::create with calls to theDefaultProvider::get.

Change-Id: I9c16700afe0faff1ef6f20338a66bd7a9af990bd
2012-10-31 15:31:36 +01:00
Noel Grandin
8fff6bf6bd fdo#46808, Adapt i18n::LocaleCalendar UNO service to new style
Did not need to create a new interface, because XCalendar3
already covers the whole service interface.

Change-Id: Iaf094014c16e872d2003ca6e8e7588abd081d882
2012-10-29 17:32:57 +01:00
Noel Grandin
e8aa70b5d4 fdo#46808, convert comphelper::ConfigurationHelper to XComponentContext
Convert the helper methods to take an XComponentContext parameter,
instead of XMultiServiceFactory.

Change-Id: I9f0098af37b91f107d8799f14caa04756eac82b1
2012-10-24 11:29:53 +02:00
Noel Grandin
fb741b5e1e fdo#46808, Adapt xml::sax::XWriter UNO service to new style
Create a merged XWriter interface for the service.
The xml.sax.Writer service already existed, it just did not have
an IDL file.

Change-Id: I4e6d3f3c68f9282a55fc7aa19778f97632fd8ad5
2012-10-22 17:01:11 +02:00
Caolán McNamara
9d2cfee5e9 some more clang warnings
Change-Id: I4359784279875dc9dac99bc4d2db95dccf094b20
2012-10-22 09:11:40 +01:00
Norbert Thiebaud
8eb5db8997 replace sxub_Unicode by sal_Unicode
Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831
Reviewed-on: https://gerrit.libreoffice.org/887
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-19 10:55:56 +00:00
Markus Mohrhard
ac60fba3b5 delegating a constructor can't work like this, fdo#55033
Change-Id: I6b057ad68054fe5806daec722b3bfe4e33bc3602
2012-10-19 10:44:59 +02:00
Markus Mohrhard
1c0f4d8ca7 don't catch this exception, we want to crash if this fails and fix it
Change-Id: I6aa0e1ba94b1702a54c7520a5093e6d0ba75a0d9
2012-10-19 10:37:23 +02:00
Luboš Luňák
83154f9234 mark lcl_ functions static or rename them if they are not local at all
http://lists.freedesktop.org/archives/libreoffice/2012-October/039639.html

Change-Id: I37b2c7b7acd31437f4be74b0163f4dac2279655b
2012-10-12 13:34:48 +02:00
Stephan Bergmann
9db74c6133 fdo#46071: Do not hide windows based on nil "Visible" property
This appears to be messy:  The /org.openoffice.Office.Views/WindowType
configuration group template has both a nilable bool "Visible" property and a
UserData/Data string property that encodes various things like geometry---but
also visibility---in a string.

Now, likely due to the problem that has meanwhile been fixed through
f3f79cc9e6 "Resolves fdo#46074: Fix
Partial::contains for paths that go past a leaf node," some
registrymodification.xcu files in the wild contain such WindowType entries in
"default" state, without a UserData/Data string and with a nil "Visible"
property.

The way SfxChildWindow::InitializeChildWinFactory_Impl and
SvtViewOptions::IsVisible are implemented, they will always lead to an invisible
window for such broken registrymodification.xcu data (as IsVisible unhelpfully
returns false for a nil value, and InitializeChildWinFactory_Impl uses that
value when there is no UserData/Data string).

For the Math formula editor window (ID 30378) this means that it can disappear
from the UI completely, as there appears to be no UI trigger for the user to
show it in case it is hidden.

The fix is to introdue SvtViewOptions::HasVisible (which only returns true if
the property is not nil) and change InitializeChidlWinFactory_Impl to only use
the value of IsVisible() if HasVisible() returns true.  This makes the code even
more baroque, but this is a rather central, generic piece of code for all sorts
of windows, so I do not want to break any other uses by e.g. changing IsVisible
to return true for a nil property.

Change-Id: Iae40075a7116a8aabd2d25aa9334709522e23d8f
2012-10-05 15:19:05 +02:00
Noel Grandin
a20f9a410f fdo#46808, Adapt xml::sax::XParser UNO service to new style
The xml.sax.Parser service already existed, it just did not have
a new-style service to create it.

Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
2012-10-04 16:29:53 +02:00
Caolán McNamara
b243afd875 callcatcher: update unused code list
and remove code freshly unused post widget layout introduction

Change-Id: Ifa244391f7f2b565dec10314ca3fd2958dfd87a9
2012-10-04 12:49:27 +01:00
Arnaud Versini
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
Marcos Paulo de Souza
053b68a0c7 Unused code cleanup.
Change-Id: Iad4d1f6cdd9ad03c5ccc02c57acef5b9bbb47d35
2012-10-01 20:28:10 +02:00
Stephan Bergmann
c2ca6fabd1 Use comphelper::getComponentContext
...and some further clean up.

Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-29 18:18:28 +02:00
Stephan Bergmann
b0c9f3b5f6 fdo#55019: Cope with empty TrustedAuthor entries
Change-Id: I9c01c1c718897a4be992150170a6ed9b5bd8a0a0
2012-09-25 15:41:42 +02:00
Julien Nabet
906b3f43c5 Bin other unused methods
Change-Id: Ib3a7a90174b14c77d01285430151098142815867
2012-09-20 22:01:27 +02:00
Julien Nabet
855454e18d Dump some newly unused methods
Change-Id: I3c2fd7eb1ccf445f7f389f7400784748a80aa929
2012-09-20 21:45:18 +02:00
Stephan Bergmann
03a9f139bd ComponentContext::getUnoContext -> getComponentContext simplification
...and some further clean-up.

Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-19 13:16:38 +02:00
Norbert Thiebaud
b854de954f deprecate oustringostreaminserter.hxx
the intent of this header has canged over time. now it is already
systematically included with ustring.hxx and the operator overload it
provide fit nicely there...

Just to be safe, since that include as been added to the api during the
3.5 timeframe and therefore is already in 'production'
the header remain and simply attempt to include ustring.hxx
but a warning is issued indicating that this header should not be used
anymore... in a couple of major release we will thenr emove it completely

All internal users of that header are converted.

Change-Id: I8934c55f089e29d78c0f5649b7c87b2ecf024bad
Reviewed-on: https://gerrit.libreoffice.org/634
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-18 10:10:06 +00:00
Stephan Bergmann
e3c05e34fd Improvement on previous commit
Change-Id: I609961ece562b7e02c542cfeb23d7c584a9663d9
2012-09-17 14:28:21 +02:00
Noel Grandin
369e3fdcda fdo#46808, Adapt i18n::LocaleData UNO service to new style
The implementation of the LocaleData implements the optional XLocaleData4,
so rather than creating a new interface for the new-style service, we simply
make the service implement XLocaleData4, which in turn implements
XLocaleData3, XLocaleData2, XLocaleData.

Change-Id: I3e9a48b031be6b2aa5e04b376b3940b942add85a
2012-09-17 14:28:21 +02:00
Caolán McNamara
d5e15c6355 update unused code list
Change-Id: I4d6ad11fbe68420931e88defa20afbef290d4d24
2012-09-17 10:46:27 +01:00
Stephan Bergmann
9ac86f484b Improvement on previous commit, UCB clean up
* As UCB is only ever initialized with "Local"/"Office", remove this
  configuration vector completely.  The "create" ctor creates an instance
  internally initialized with those "Local"/"Office" keys.  Special (test) code
  can still instantiate an uninitialized one via plain createInstance.  And for
  backwards compatilibity process startup still ensures to create an initialized
  instance early, in case there is still code out there (in extensions) that
  later calls plain createInstance and expects to get the already-initialized
  (single) instance.

* XInitialization is an "implementation detail" of the UniversalContentBroker
  service, do not expose in XUniversalContentBroker.

* ucbhelper/configurationkeys.hxx is no longer needed and is removed.

* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
  requires ucbhelper::Content constructors to take explicit XComponentContext
  arguments now.

* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
  Android-only InitUCBHelper.  Is that relevant still?

Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-14 18:24:49 +02:00
Norbert Thiebaud
b42094b2b0 remove use of SAL_MIN() macro
Change-Id: Ia91118388240c9a54d010b94aef34ad528ce5761
2012-09-14 03:49:21 -05:00
Matúš Kukan
b4f030f0e3 hide duplication into anonymous namespace
Change-Id: Ie9a810f59d08d79636a0ad4b56adedb87479706e
2012-09-01 21:06:12 +02:00
Caolán McNamara
f59733d45f fix build
Change-Id: I3616e62689246a091d9f26d69105a27f64553d48
2012-08-29 23:57:35 +01:00
Uray M. János
030df631a8 Cleanup in Tools > Options > User Data
Change-Id: I4f0a0304d7dd23ed8ce011e6f8f90e170bfbe5df

Cleanup in Tools > Options > User Data

Change-Id: If89f19e22b6efeb0fdd811ff8afe2cb6c0b0bf4e
Reviewed-on: https://gerrit.libreoffice.org/500
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2012-08-29 20:56:58 +00:00
Eike Rathke
cda1562570 resolved fdo#52240 fdo#52137 fdo#52288 user editable date patterns
Implemented user editable date acceptance patterns.

The introduction of strict date parsing using locale dependent date
acceptance patterns in 3.6.0 wasn't always welcomed. Besides that not
every locale had patterns for incomplete (only day and month) date
input, users also complained about not being able to key in dates on
numeric keypads if the locale's date separator wasn't '/' or '-'

This commit implements a "Date acceptance patterns" edit field under
Tools->Options->LanguageSettings->Languages that follows the selected
locale and enables the user to add patterns.

Example de-DE locale:
* default patterns: D.M.Y;D.M.
* to enable additional input on numeric keypad: D.M.Y;D.M.;D-M-Y;D-M
  * if 3-4 shall not result in a date, D-M- could be used instead of D-M
  * note that to enter an ISO 8601 Y-M-D date with a D-M-Y pattern
    active one needs to enter a year >31 or with at least 3 digits, e.g.
    011

Change-Id: I9e20fcb168578b02d0f0248a0e209942e0f27113
2012-08-29 21:17:46 +02:00
Noel Grandin
206c70eef3 fdo#46808, Adapt TempFile UNO service to new style
Change-Id: Ia448d6d74201e2be487c6d8317f94be3745808aa
2012-08-27 15:40:08 +02:00
Stephan Bergmann
27c7682e5e fdo#46249: UCBContentHelper::GetTitle must not fail for void property
This was a regression introduced with 2af9040d38
"Cleaned up utl::UCBContentHelper."  GetSize exhibited the same problem and has
also been fixed.  IsYounger exhibits a similar problem, but has not been
addressed, as it is unclear what to return in case no dates can be compared; it
is only used in one place (handling SID_EDITDOC in
SfxViewFrame::ExecReload_Impl, sfx2/source/view/viewfrm.cxx) where, it appears,
only contents for which DateModified /does/ yield a non-void value are relevant.

Change-Id: Iff9f5e1ed6f45eede117713d64a265b98f6862b1
2012-08-22 09:11:23 +02:00
Norbert Thiebaud
aa767cc265 WaE parameter shadow member
Change-Id: I231e41771e81f7e6f2939468e6b2175f2bc10101
2012-08-18 22:31:19 -05:00
Norbert Thiebaud
c6189b43f3 WAE parameter shadow member
Change-Id: Icf41caa23ce9a548223da4613a199116641e7fe5
2012-08-18 15:10:41 -05:00
Stephan Bergmann
0e10d1627d -Werror,-Wunused-private-field (Clang towards 3.2)
Change-Id: Id5343222eea264c956ed0a6b545c59125352e110
2012-08-14 10:39:12 +02:00
Oliver Günther
be88027c32 fdo#39468: Translate German comments in toolkit,unotools, & xmloff
Also checked the following with bin/find-german-comments (all
false positives):
- sysui
- xml2cmp
- udm
- ucb

Change-Id: I2c72f973f5cecf56d70b5419e56338170dd55a2e
2012-08-10 21:57:26 +02:00
Thomas Arnhold
2beba8f93e reduce ascii noise and useless comments
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
2012-08-08 13:53:54 +02:00
Thomas Arnhold
49ad17e2b1 remove include comments and boxes
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-08-08 13:53:53 +02:00
Thomas Arnhold
548a2ffe3a remove bogus date information
Change-Id: I2789153ee35f4ec10e760f9412eb7d379de031bf
2012-08-07 18:08:30 +02:00
Thomas Arnhold
87f242e036 remove empty ascii boxes and stuff III
Change-Id: I8b54e8518c219a7edd7e29173a1099611a7e0dbb
2012-08-07 18:08:29 +02:00
Stephan Bergmann
889de665ec Typo ressource -> resource
Change-Id: Id13e7acfbe34eca5e124c9032d36d6f158bfb831
2012-07-30 09:26:00 +02:00
Sören Möller
c5653e812e Replaced deprecated tools/String with OUString in sc/../chgviset
Added new TextSearch::SearchForward mirroring TextSearch::SearchFrwrd using OUString and sal_Int32 to make it possible to replace all uses of tools/String

Change-Id: I260d8d3a23d634eab37f28a5ceaf61ace5040540
2012-07-11 23:54:33 +02:00
Michael Meeks
535e83550e re-base on ALv2 code. Includes:
Avoid some uses of non portable #!/bin/bash in shell scripts.
    Patch contributed by Pedro Giffuni
    http://svn.apache.org/viewvc?view=revision&revision=1235297
    remove redundant namespace, patch contributed Mathias Bauer
    http://svn.apache.org/viewvc?view=revision&revision=1162610
    removal of OS/2 port changes, and preferring our similiar
    tools/inc/tools/solar.h DLLPOSTFIX cleanup.
    i118595 - Removal of the use of getopt() from rscdep.
    Patch contributed by Andre Fische
    http://svn.apache.org/viewvc?view=revision&revision=1202270
2012-07-11 18:12:35 +01:00
Caolán McNamara
bccf34c19a ditch String::CreateFromAscii
Change-Id: I2b482bd323ac510629c5ee31868010b7cd6ce691
2012-07-03 21:24:35 +01:00
Thomas Arnhold
57154616f0 Remove UNO includes comments
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
2012-06-29 09:25:09 +02:00
Caolán McNamara
d9a00ace2c tidy some resource strings
Change-Id: I611a276d048121084ec842d062129e042f3baea5
2012-06-26 13:34:03 +01:00
Caolán McNamara
2c757293b8 reduce static_initialization_and_destruction chain
Change-Id: I0c1b2f2d908c31d1510662880c13504d81445a6a
2012-06-25 14:19:03 +01:00
Caolán McNamara
4ce70ccc2d TODO: get rid of this in another incompatible build with SW project
Change-Id: Ic3fb0c8eb37317d55bcdc6abc7ff9843ba11fac6
2012-06-25 14:19:02 +01:00
Caolán McNamara
8eabfaa990 unnecessary use of UniString::GetBuffer
Change-Id: If7d31a649a058a30196e1ed4be28b5c6c42640a0
2012-06-25 14:19:01 +01:00
Michael Meeks
ec5fa0164b replace all but one .hdl include with equivalent .hpp includes.
Change-Id: I15e94f112144549692d0c2babeb48c77adcb93a9
2012-06-21 19:28:47 +01:00
Michael Meeks
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00